211240 2020-04-30 10:51:51 -0700 WebCore::systemHasBattery() is unnecessarily expensive on iOS 2020-04-30 12:43:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ggaren pvollan webkit-bug-importer oldest_to_newest 1647414 0 cdumez 2020-04-30 10:51:51 -0700 WebCore::systemHasBattery() is unnecessarily expensive on iOS since iOS devices always have a battery. 1647415 1 cdumez 2020-04-30 10:52:01 -0700 <rdar://problem/62619971> 1647417 2 398066 cdumez 2020-04-30 10:53:43 -0700 Created attachment 398066 Patch 1647419 3 398066 ggaren 2020-04-30 11:01:35 -0700 Comment on attachment 398066 Patch I look forward to finding this code ten years from now, to fix a new hardware bug. 😬 1647504 4 ews-feeder 2020-04-30 12:43:19 -0700 Committed r260960: <https://trac.webkit.org/changeset/260960> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398066. 398066 2020-04-30 10:53:43 -0700 2020-04-30 12:43:19 -0700 Patch bug-211240-20200430105342.patch text/plain 1868 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmE0MzhhNjIzZTFlNTNh NmFjMGI5NGY5MzIxMGM3Y2VhZmQxZjRiMS4uMmMzNGFlMDE2ZGEyNzAxZTljNzc2NWFlMjU5YWRl ZTRjMjIyOTgzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA0LTMwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29yZTo6c3lzdGVtSGFz QmF0dGVyeSgpIGlzIHVubmVjZXNzYXJpbHkgZXhwZW5zaXZlIG9uIGlPUworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMjQwCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS82MjYxOTk3MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgV2ViQ29yZTo6c3lzdGVtSGFzQmF0dGVyeSgpIHRvIHJldHVy biB0cnVlIHVuY29uZGl0aW9uYWxseSBvbgorICAgICAgICBQTEFURk9STShJT1MpIGFuZCBQTEFU Rk9STShXQVRDSE9TKSBzaW5jZSBpT1MgZGV2aWNlcyBhbHdheXMgaGF2ZSBhCisgICAgICAgIGJh dHRlcnkuIEFsc28gcmV0dXJuIGZhbHNlIHVuY29uZGl0aW9uYWxseSBmb3IgUExBVEZPUk0oQVBQ TEVUVikuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9TeXN0ZW1CYXR0ZXJ5Lm1tOgorICAg ICAgICAoV2ViQ29yZTo6c3lzdGVtSGFzQmF0dGVyeSk6CisKIDIwMjAtMDQtMzAgIENoYXJsaWUg VHVybmVyICA8Y3R1cm5lckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjbGFuZyAxMV0gZml4IGJ1 aWxkIGVycm9ycyBkdWUgdG8gLVdXYysrMTEtbmFycm93aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9TeXN0ZW1CYXR0ZXJ5Lm1tIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY29jb2EvU3lzdGVtQmF0dGVyeS5tbQppbmRleCBlZmQ0MzlkNGI2NDdmYjE5YzBk NWQyYjZmM2I5MGM3NDk0M2Q1MjA1Li42YzEzZTVlYjcwZDhlNTE0M2VkZDI4ODFkZDI5ZTEwNzUz MGI1OWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9TeXN0ZW1C YXR0ZXJ5Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1N5c3RlbUJhdHRl cnkubW0KQEAgLTQxLDYgKzQxLDEyIEBAIGJvb2wgc3lzdGVtSGFzQmF0dGVyeSgpCiB7CiAgICAg aWYgKCFoYXNCYXR0ZXJ5Lmhhc1ZhbHVlKCkpIHsKICAgICAgICAgaGFzQmF0dGVyeSA9IFtdIHsK KyNpZiBQTEFURk9STShJT1MpIHx8IFBMQVRGT1JNKFdBVENIT1MpCisgICAgICAgICAgICAvLyBE ZXZpY2VzIHJ1bm5pbmcgaU9TIC8gV2F0Y2hPUyBhbHdheXMgaGF2ZSBhIGJhdHRlcnkuCisgICAg ICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbGlmIFBMQVRGT1JNKEFQUExFVFYpCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisjZWxzZQogICAgICAgICAgICAgUmV0YWluUHRyPENGVHlwZVJlZj4g cG93ZXJTb3VyY2VzSW5mbyA9IGFkb3B0Q0YoSU9QU0NvcHlQb3dlclNvdXJjZXNJbmZvKCkpOwog ICAgICAgICAgICAgaWYgKCFwb3dlclNvdXJjZXNJbmZvKQogICAgICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKQEAgLTU0LDYgKzYwLDcgQEAgYm9vbCBzeXN0ZW1IYXNCYXR0ZXJ5KCkKICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CisjZW5kaWYKICAgICAgICAgfSgpOwogICAgIH0KIAo=