211231 2020-04-30 06:32:24 -0700 [GTK4] Add navigation and reload buttons to MiniBrowser 2020-04-30 07:04:55 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 csaavedra csaavedra aperez bugs-noreply oldest_to_newest 1647351 0 csaavedra 2020-04-30 06:32:24 -0700 [GTK4] Add navigation and reload buttons to MiniBrowser 1647352 1 398052 csaavedra 2020-04-30 06:35:09 -0700 Created attachment 398052 Patch 1647359 2 ews-feeder 2020-04-30 07:04:55 -0700 Committed r260949: <https://trac.webkit.org/changeset/260949> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398052. 398052 2020-04-30 06:35:09 -0700 2020-04-30 07:04:55 -0700 Patch bug-211231-20200430163507.patch text/plain 4938 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2VlYzA4ZDM5YWY2MTZkNjU5MWM3YTkxMGJhY2JjNzlm OWFhZjlkNi4uNjM2MTdiZjc0OWJlZTczNzMyOWYwMDc4OWNjYzZmNzdhMWQ3M2U1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTA0LTMwICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUSzRdIEFkZCBuYXZpZ2F0aW9uIGFuZCByZWxvYWQgYnV0dG9ucyB0byBN aW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjExMjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jOgorICAgICAgICAoYnJvd3Nlcldp bmRvd1VwZGF0ZU5hdmlnYXRpb25NZW51KToKKyAgICAgICAgKHdlYlZpZXdJc0xvYWRpbmdDaGFu Z2VkKToKKyAgICAgICAgKGJyb3dzZXJXaW5kb3dTZXR1cFRvb2xiYXJJdGVtKToKKyAgICAgICAg KGJyb3dzZXJfd2luZG93X2luaXQpOgorCiAyMDIwLTA0LTMwICBBbmRyZXMgR29uemFsZXogIDxh bmRyZXNnXzIyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggZm9yIGNyYXNoZXMgaW4gYWNjZXNz aWJpbGl0eS9hY2Nlc3NpYmlsaXR5LW5vZGUtbWVtb3J5LW1hbmFnZW1lbnQuaHRtbCBpbiBpc29s YXRlZCB0cmVlIG1vZGUuCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3Nl cldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwppbmRleCAw ZWIxMzZkMDc5YzliNDJkZWQ1ZDcxZTI4Yzg2ZDExMDc0NmE4NTU1Li43OTg2YmRjOTE3MDYyOWYx NTAxODMyOWQ5ZDNiNTFmYTAyZTFjY2Q3IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9n dGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2lu ZG93LmMKQEAgLTExOCw3ICsxMTgsNiBAQCBzdGF0aWMgdm9pZCBhY3RpdmF0ZVVyaUVudHJ5Q2Fs bGJhY2soQnJvd3NlcldpbmRvdyAqd2luZG93KQogICAgICk7CiB9CiAKLSNpZiAhR1RLX0NIRUNL X1ZFUlNJT04oMywgOTgsIDApCiBzdGF0aWMgdm9pZCByZWxvYWRPclN0b3BDYWxsYmFjayhCcm93 c2VyV2luZG93ICp3aW5kb3cpCiB7CiAgICAgV2ViS2l0V2ViVmlldyAqd2ViVmlldyA9IGJyb3dz ZXJfdGFiX2dldF93ZWJfdmlldyh3aW5kb3ctPmFjdGl2ZVRhYik7CkBAIC0xNDAsNiArMTM5LDcg QEAgc3RhdGljIHZvaWQgZ29Gb3J3YXJkQ2FsbGJhY2soQnJvd3NlcldpbmRvdyAqd2luZG93KQog ICAgIHdlYmtpdF93ZWJfdmlld19nb19mb3J3YXJkKHdlYlZpZXcpOwogfQogCisjaWYgIUdUS19D SEVDS19WRVJTSU9OKDMsIDk4LCAwKQogc3RhdGljIHZvaWQgc2V0dGluZ3NDYWxsYmFjayhCcm93 c2VyV2luZG93ICp3aW5kb3cpCiB7CiAgICAgaWYgKHdpbmRvdy0+c2V0dGluZ3NEaWFsb2cpIHsK QEAgLTI2MywxMSArMjYzLDExIEBAIHN0YXRpYyBHdGtXaWRnZXQgKmJyb3dzZXJXaW5kb3dDcmVh dGVCYWNrRm9yd2FyZE1lbnUoQnJvd3NlcldpbmRvdyAqd2luZG93LCBHTGlzCiAKIHN0YXRpYyB2 b2lkIGJyb3dzZXJXaW5kb3dVcGRhdGVOYXZpZ2F0aW9uTWVudShCcm93c2VyV2luZG93ICp3aW5k b3csIFdlYktpdEJhY2tGb3J3YXJkTGlzdCAqYmFja0ZvcndhcmRsaXN0KQogewotI2lmICFHVEtf Q0hFQ0tfVkVSU0lPTigzLCA5OCwgMCkKICAgICBXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3ID0gYnJv d3Nlcl90YWJfZ2V0X3dlYl92aWV3KHdpbmRvdy0+YWN0aXZlVGFiKTsKICAgICBndGtfd2lkZ2V0 X3NldF9zZW5zaXRpdmUod2luZG93LT5iYWNrSXRlbSwgd2Via2l0X3dlYl92aWV3X2Nhbl9nb19i YWNrKHdlYlZpZXcpKTsKICAgICBndGtfd2lkZ2V0X3NldF9zZW5zaXRpdmUod2luZG93LT5mb3J3 YXJkSXRlbSwgd2Via2l0X3dlYl92aWV3X2Nhbl9nb19mb3J3YXJkKHdlYlZpZXcpKTsKIAorI2lm ICFHVEtfQ0hFQ0tfVkVSU0lPTigzLCA5OCwgMCkKICAgICBHTGlzdCAqbGlzdCA9IGdfbGlzdF9y ZXZlcnNlKHdlYmtpdF9iYWNrX2ZvcndhcmRfbGlzdF9nZXRfYmFja19saXN0X3dpdGhfbGltaXQo YmFja0ZvcndhcmRsaXN0LCAxMCkpOwogICAgIGd0a19tZW51X3Rvb2xfYnV0dG9uX3NldF9tZW51 KEdUS19NRU5VX1RPT0xfQlVUVE9OKHdpbmRvdy0+YmFja0l0ZW0pLAogICAgICAgICBicm93c2Vy V2luZG93Q3JlYXRlQmFja0ZvcndhcmRNZW51KHdpbmRvdywgbGlzdCkpOwpAQCAtNTM3LDExICs1 MzcsOCBAQCBzdGF0aWMgdm9pZCBmYXZpY29uQ2hhbmdlZChXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3 LCBHUGFyYW1TcGVjICpwYXJhbVNwZWMsIEJyb3dzZQogCiBzdGF0aWMgdm9pZCB3ZWJWaWV3SXNM b2FkaW5nQ2hhbmdlZChXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCBHUGFyYW1TcGVjICpwYXJhbVNw ZWMsIEJyb3dzZXJXaW5kb3cgKndpbmRvdykKIHsKLSNpZiAhR1RLX0NIRUNLX1ZFUlNJT04oMywg OTgsIDApCiAgICAgZ2Jvb2xlYW4gaXNMb2FkaW5nID0gd2Via2l0X3dlYl92aWV3X2lzX2xvYWRp bmcod2ViVmlldyk7Ci0gICAgZ3RrX3Rvb2xfYnV0dG9uX3NldF9sYWJlbChHVEtfVE9PTF9CVVRU T04od2luZG93LT5yZWxvYWRPclN0b3BCdXR0b24pLCBpc0xvYWRpbmcgPyAiU3RvcCIgOiAiUmVs b2FkIik7Ci0gICAgZ3RrX3Rvb2xfYnV0dG9uX3NldF9pY29uX25hbWUoR1RLX1RPT0xfQlVUVE9O KHdpbmRvdy0+cmVsb2FkT3JTdG9wQnV0dG9uKSwgaXNMb2FkaW5nID8gInByb2Nlc3Mtc3RvcCIg OiAidmlldy1yZWZyZXNoIik7Ci0jZW5kaWYKKyAgICBnX29iamVjdF9zZXQoR19PQkpFQ1Qod2lu ZG93LT5yZWxvYWRPclN0b3BCdXR0b24pLCAibGFiZWwiLCBpc0xvYWRpbmcgPyAiU3RvcCIgOiAi UmVsb2FkIiwgImljb24tbmFtZSIsIGlzTG9hZGluZyA/ICJwcm9jZXNzLXN0b3AiIDogInZpZXct cmVmcmVzaCIsIE5VTEwpOwogfQogCiAjaWYgIUdUS19DSEVDS19WRVJTSU9OKDMsIDk4LCAwKQpA QCAtOTQ2LDcgKzk0MywxNyBAQCBzdGF0aWMgdm9pZCBicm93c2VyV2luZG93VGFiQWRkZWRPclJl bW92ZWQoR3RrTm90ZWJvb2sgKm5vdGVib29rLCBCcm93c2VyVGFiICp0YQogICAgIGd0a19ub3Rl Ym9va19zZXRfc2hvd190YWJzKEdUS19OT1RFQk9PSyh3aW5kb3ctPm5vdGVib29rKSwgZ3RrX25v dGVib29rX2dldF9uX3BhZ2VzKG5vdGVib29rKSA+IDEpOwogfQogCi0jaWYgIUdUS19DSEVDS19W RVJTSU9OKDMsIDk4LCAwKQorI2lmIEdUS19DSEVDS19WRVJTSU9OKDMsIDk4LCAwKQorc3RhdGlj IEd0a1dpZGdldCogYnJvd3NlcldpbmRvd1NldHVwVG9vbGJhckl0ZW0oQnJvd3NlcldpbmRvdyog d2luZG93LCBHdGtDb250YWluZXIqIGNvbnRhaW5lciwgY29uc3QgY2hhciogbmFtZWRJY29uLCBH Q2FsbGJhY2sgY2FsbGJhY2spCit7CisgICAgR3RrV2lkZ2V0ICpidXR0b24gPSBndGtfYnV0dG9u X25ld19mcm9tX2ljb25fbmFtZShuYW1lZEljb24pOworICAgIGd0a19idXR0b25fc2V0X2hhc19m cmFtZShHVEtfQlVUVE9OKGJ1dHRvbiksIEZBTFNFKTsKKyAgICBndGtfY29udGFpbmVyX2FkZChj b250YWluZXIsIGJ1dHRvbik7CisgICAgZ19zaWduYWxfY29ubmVjdF9zd2FwcGVkKGJ1dHRvbiwg ImNsaWNrZWQiLCBjYWxsYmFjaywgKGdwb2ludGVyKXdpbmRvdyk7CisKKyAgICByZXR1cm4gYnV0 dG9uOworfQorI2Vsc2UKIHN0YXRpYyBHdGtXaWRnZXQqIGJyb3dzZXJXaW5kb3dTZXR1cFRvb2xi YXJJdGVtKEJyb3dzZXJXaW5kb3cqIHdpbmRvdywgR3RrV2lkZ2V0KiB0b29sYmFyLCBHVHlwZSB0 eXBlLCBjb25zdCBjaGFyKiBsYWJlbCwgY29uc3QgY2hhciogbmFtZWRJY29uLCBHQ2FsbGJhY2sg Y2FsbGJhY2spCiB7CiAgICAgR3RrV2lkZ2V0ICppdGVtID0gZ19vYmplY3RfbmV3KHR5cGUsICJp Y29uLW5hbWUiLCBuYW1lZEljb24sIE5VTEwpOwpAQCAtMTA1MCw2ICsxMDU3LDEyIEBAIHN0YXRp YyB2b2lkIGJyb3dzZXJfd2luZG93X2luaXQoQnJvd3NlcldpbmRvdyAqd2luZG93KQogICAgIHdp bmRvdy0+dG9vbGJhciA9IHRvb2xiYXI7CiAgICAgZ3RrX3dpZGdldF9zZXRfaGV4cGFuZCh3aW5k b3ctPnVyaUVudHJ5LCBUUlVFKTsKICAgICBndGtfY2VudGVyX2JveF9zZXRfY2VudGVyX3dpZGdl dChHVEtfQ0VOVEVSX0JPWCh0b29sYmFyKSwgd2luZG93LT51cmlFbnRyeSk7CisKKyAgICBHdGtX aWRnZXQgKmJveCA9IGd0a19ib3hfbmV3KEdUS19PUklFTlRBVElPTl9IT1JJWk9OVEFMLCAwKTsK KyAgICB3aW5kb3ctPmJhY2tJdGVtID0gYnJvd3NlcldpbmRvd1NldHVwVG9vbGJhckl0ZW0od2lu ZG93LCBHVEtfQ09OVEFJTkVSKGJveCksICJnby1wcmV2aW91cyIsIEdfQ0FMTEJBQ0soZ29CYWNr Q2FsbGJhY2spKTsKKyAgICB3aW5kb3ctPmZvcndhcmRJdGVtID0gYnJvd3NlcldpbmRvd1NldHVw VG9vbGJhckl0ZW0od2luZG93LCBHVEtfQ09OVEFJTkVSKGJveCksICJnby1uZXh0IiwgR19DQUxM QkFDSyhnb0ZvcndhcmRDYWxsYmFjaykpOworICAgIHdpbmRvdy0+cmVsb2FkT3JTdG9wQnV0dG9u ID0gYnJvd3NlcldpbmRvd1NldHVwVG9vbGJhckl0ZW0od2luZG93LCBHVEtfQ09OVEFJTkVSKGJv eCksICJ2aWV3LXJlZnJlc2giLCBHX0NBTExCQUNLKHJlbG9hZE9yU3RvcENhbGxiYWNrKSk7Cisg ICAgZ3RrX2NlbnRlcl9ib3hfc2V0X3N0YXJ0X3dpZGdldChHVEtfQ0VOVEVSX0JPWCh0b29sYmFy KSwgYm94KTsKICNlbHNlCiAgICAgR3RrV2lkZ2V0ICp0b29sYmFyID0gZ3RrX3Rvb2xiYXJfbmV3 KCk7CiAgICAgd2luZG93LT50b29sYmFyID0gdG9vbGJhcjsK