211229 2020-04-30 06:13:34 -0700 Disable low latency encoder on iOS 2020-04-30 11:54:53 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf darin eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1647345 0 youennf 2020-04-30 06:13:34 -0700 Disable VCP on iOS until ready 1647346 1 398050 youennf 2020-04-30 06:15:33 -0700 Created attachment 398050 Patch 1647444 2 ews-feeder 2020-04-30 11:36:43 -0700 Committed r260956: <https://trac.webkit.org/changeset/260956> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398050. 1647445 3 webkit-bug-importer 2020-04-30 11:38:04 -0700 <rdar://problem/62662886> 1647462 4 darin 2020-04-30 11:54:53 -0700 When possible we should try to make more careful use of HAVE vs. USE and Platform headers vs. SPI headers vs. SoftLink headers. It’s a little peculiar to define a HAVE in an SPI header. Seems even more peculiar to have it in a SoftLink header. Our decision here seems to be about whether to *use* something, not whether it’s present, so that sounds like USE instead of HAVE. In this situation, I might have changed the conditionals in the code to USE instead of HAVE, and turned it off that way. And moved the HAVE to a PlatformHave header, out of the SoftLink header. And defined USE to a PlatformUse header with a default of 0. There may be arguments agains this such as: - This small change is effective and low risk; doing a bigger change instead is messy and risky. - It’s nice to concentrate information about whether the platform has something with the header for that thing, so annoying that the HAVE macro is supposed to go in one of the PlatformHave headers. - For something that’s not ready at all yet, seems unnecessary to have it in a PlatformUse header. But I also think it’s valuable to separate HAVE and USE, and separate configuration and platform capability information from the headers with specific classes and functions. I suggest that when we bring this macro back we do it in the platform machinery, not by adding it back to the SoftLink header. 398050 2020-04-30 06:15:33 -0700 2020-04-30 11:36:44 -0700 Patch bug-211229-20200430151531.patch text/plain 1773 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA0ODhiYTcwNjVlYWI0MGM1OTlhMDY1NTBlMGIyYzFlNDVhMzg4OThhLi45YzM0 Zjc4MjQwZGM5OTM1MzcxNmYwZTNiNmUxZmVlN2M3MTY4NTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNC0zMCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBsb3cgbGF0ZW5jeSBl bmNvZGVyIG9uIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjExMjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvVmlkZW9Qcm9jZXNzaW5nU29mdExpbmsu aDoKKyAgICAgICAgVGhpcyBpcyBub3QgeWV0IGZ1bGx5IHJlYWR5LgorCiAyMDIwLTA0LTE1ICBK ZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIGlzTnVsbEZ1bmN0aW9u UG9pbnRlcigpIGNhbiBmYWlsIGZvciBzeW1ib2xzIG5vdCBleHBsaWNpdGx5IG1hcmtlZCBhcyB3 ZWFrbHkgbGlua2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1Nv dXJjZS93ZWJydGMvc2RrL1dlYktpdC9WaWRlb1Byb2Nlc3NpbmdTb2Z0TGluay5oIGIvU291cmNl L1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL1dlYktpdC9WaWRlb1Byb2Nl c3NpbmdTb2Z0TGluay5oCmluZGV4IDFkYmVjMzdjY2EzYzJjZTYyYmZhMmM3MzE3OTVmMTRmNDUz MTlhZjIuLjMzNTJiNTBkZWNkYWY4MzBhNmI1MmU1YWFhYmIwNDJjNTFmYTA4ZTcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQv VmlkZW9Qcm9jZXNzaW5nU29mdExpbmsuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJy dGMvU291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1ZpZGVvUHJvY2Vzc2luZ1NvZnRMaW5rLmgKQEAg LTM5LDcgKzM5LDYgQEAKICNlbGlmIChkZWZpbmVkKFRBUkdFVF9PU19JUEhPTkUpICYmIFRBUkdF VF9PU19JUEhPTkUpCiAjZGVmaW5lIEVOQUJMRV9WQ1BfRU5DT0RFUiBfX0lQSE9ORV9PU19WRVJT SU9OX01JTl9SRVFVSVJFRCA8IDE0MDAwMAogI2RlZmluZSBFTkFCTEVfVkNQX1ZUQl9FTkNPREVS IF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDAwMCAmJiBfX0lQSE9ORV9P U19WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDE0MDAwMAotI2RlZmluZSBIQVZFX1ZUQl9SRVFVSVJF RExPV0xBVEVOQ1kgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTQwMDAwCiAj ZWxpZiAoZGVmaW5lZChUQVJHRVRfT1NfTUFDKSAmJiBUQVJHRVRfT1NfTUFDKQogI2RlZmluZSBF TkFCTEVfVkNQX0VOQ09ERVIgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTYw MAogI2RlZmluZSBFTkFCTEVfVkNQX1ZUQl9FTkNPREVSIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTAxNTAwICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAx MDE2MDAK