211210 2020-04-29 15:37:23 -0700 EWS should skip Apple Win build and tests for patches that only change WebKit2 sources 2022-01-05 17:55:32 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210115 https://bugs.webkit.org/show_bug.cgi?id=234911 InRadar P2 Normal --- 1 ddkilzer aakash_jain aakash_jain ap bfulgham don.olmstead fujii jbedard pvollan ryanhaddad webkit-bug-importer oldest_to_newest 1647185 0 ddkilzer 2020-04-29 15:37:23 -0700 EWS should skip Apple Win build and tests for patches that only change WebKit2 sources. See also: Bug 210115: EWS should skip mac-wk1 and mac-debug-wk1 tests for patches that only change WebKit2 sources 1648332 1 aakash_jain 2020-05-03 05:29:01 -0700 Is this applicable to WinCairo as well? (wincairo ews doesn't run tests, only builds) 1648587 2 398383 aakash_jain 2020-05-04 10:05:02 -0700 Created attachment 398383 Patch 1648613 3 pvollan 2020-05-04 10:36:08 -0700 (In reply to Aakash Jain from comment #1) > Is this applicable to WinCairo as well? (wincairo ews doesn't run tests, > only builds) I don't think this is applicable to WinCairo. 1649166 4 aakash_jain 2020-05-05 06:16:21 -0700 (In reply to Per Arne Vollan from comment #3) > I don't think this is applicable to WinCairo. ok. the attached patch is only for Apple Windows platform. 1649291 5 ews-feeder 2020-05-05 11:34:25 -0700 Committed r261184: <https://trac.webkit.org/changeset/261184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398383. 1649292 6 webkit-bug-importer 2020-05-05 11:35:14 -0700 <rdar://problem/62896445> 1650108 7 aakash_jain 2020-05-07 08:31:23 -0700 Deployed on server yesterday. Seems to be working fine. e.g.: https://ews-build.webkit.org/#/builders/10/builds/17575 https://ews-build.webkit.org/#/builders/10/builds/17563 1828479 8 398383 fujii 2022-01-05 17:55:32 -0800 Comment on attachment 398383 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398383&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:307 > + 'windows': wk1_paths, This code has a problem. Filed: Bug 234911 – AppleWin EWS check-patch-relevance skips a patch for Source/cmake/*.cmake 398383 2020-05-04 10:05:02 -0700 2020-05-05 11:34:26 -0700 Patch bug-211210-20200504130501.patch text/plain 5426 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MTA4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIwLTA1LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1Mgc2hvdWxkIHNraXAgQXBwbGUgV2luIGJ1aWxkIGFuZCB0ZXN0cyBm b3IgcGF0Y2hlcyB0aGF0IG9ubHkgY2hhbmdlIFdlYktpdDIgc291cmNlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMjEwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvZmFjdG9yaWVzLnB5OgorICAgICAgICAoV2luZG93c0ZhY3RvcnkuX19pbml0X18p OiBlbmFibGVkIHJlbGV2YW5jZSBjaGVja2luZyBmb3Igd2luZG93cyBld3MuCisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllc191bml0dGVzdC5weTogVXBkYXRl ZCB1bml0LXRlc3QuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5OgorICAgICAgICAoQ2hlY2tQYXRjaFJlbGV2YW5jZSk6IERlZmluZWQgcmVsZXZhbmNlIGlu Zm8gZm9yIHdpbmRvd3MgZXdzLiAKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHk6CisgICAgICAgIChUZXN0Q2hlY2tQYXRjaFJlbGV2YW5jZS50 ZXN0X3JlbGV2YW50X3dpbmRvd3Nfd2sxX3BhdGNoKTogQWRkZWQgdW5pdCB0ZXN0LgorICAgICAg ICAoVGVzdENoZWNrUGF0Y2hSZWxldmFuY2UudGVzdF9xdWV1ZXNfd2l0aG91dF9yZWxldmFuY2Vf aW5mbyk6IEZpeGVkIHVuaXQtdGVzdC4KKwogMjAyMC0wNS0wNCAgTWljaGFlbCBDYXRhbnphcm8g IDxtY2F0YW56YXJvQGdub21lLm9yZz4KIAogICAgICAgICBbV1BFXVtHVEtdIFNob3VsZCBpbnN0 YWxsIHB5dGhvbjMtc2VjcmV0c3RvcmFnZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyNjEwODcpCisrKyBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0xNzEsNyArMTcxLDcgQEAgY2xhc3MgbWFjT1NXSzJGYWN0b3J5KFRlc3RGYWN0b3J5KToKIAog Y2xhc3MgV2luZG93c0ZhY3RvcnkoRmFjdG9yeSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBs YXRmb3JtLCBjb25maWd1cmF0aW9uPU5vbmUsIGFyY2hpdGVjdHVyZXM9Tm9uZSwgdHJpZ2dlcnM9 Tm9uZSwgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCAqKmt3YXJncyk6Ci0gICAgICAgIEZhY3Rv cnkuX19pbml0X18oc2VsZiwgcGxhdGZvcm09cGxhdGZvcm0sIGNvbmZpZ3VyYXRpb249Y29uZmln dXJhdGlvbiwgYXJjaGl0ZWN0dXJlcz1hcmNoaXRlY3R1cmVzLCBidWlsZE9ubHk9RmFsc2UsIHRy aWdnZXJzPXRyaWdnZXJzLCBhZGRpdGlvbmFsQXJndW1lbnRzPWFkZGl0aW9uYWxBcmd1bWVudHMp CisgICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxhdGZvcm09cGxhdGZvcm0sIGNvbmZp Z3VyYXRpb249Y29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcz1hcmNoaXRlY3R1cmVzLCBidWls ZE9ubHk9RmFsc2UsIHRyaWdnZXJzPXRyaWdnZXJzLCBhZGRpdGlvbmFsQXJndW1lbnRzPWFkZGl0 aW9uYWxBcmd1bWVudHMsIGNoZWNrUmVsZXZhbmNlPVRydWUpCiAgICAgICAgIHNlbGYuYWRkU3Rl cChLaWxsT2xkUHJvY2Vzc2VzKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChDb21waWxlV2ViS2l0 KHNraXBVcGxvYWQ9VHJ1ZSkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChWYWxpZGF0ZVBhdGNoKHZl cmlmeUJ1Z0Nsb3NlZD1GYWxzZSwgYWRkVVJMcz1GYWxzZSkpCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXNfdW5pdHRlc3QucHkJ KHJldmlzaW9uIDI2MTA4NykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9m YWN0b3JpZXNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE2MSw2ICsxNjEsNyBAQCBj bGFzcyBUZXN0QnVpbGRBbmRUZXN0c0ZhY3RvcnkoVGVzdENhc2UpCiAgICAgICAgIGZhY3Rvcnkg PSBmYWN0b3JpZXMuV2luZG93c0ZhY3RvcnkocGxhdGZvcm09J3dpbicsIGNvbmZpZ3VyYXRpb249 J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVzPVsieDg2XzY0Il0pCiAgICAgICAgIHNlbGYuYXNzZXJ0 QnVpbGRTdGVwcyhmYWN0b3J5LnN0ZXBzLCBbCiAgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9y eShzdGVwcy5Db25maWd1cmVCdWlsZCwgcGxhdGZvcm09J3dpbicsIGNvbmZpZ3VyYXRpb249J3Jl bGVhc2UnLCBhcmNoaXRlY3R1cmVzPVsieDg2XzY0Il0sIGJ1aWxkT25seT1GYWxzZSwgdHJpZ2dl cnM9Tm9uZSwgcmVtb3Rlcz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUpLAorICAgICAg ICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ2hlY2tQYXRjaFJlbGV2YW5jZSksCiAgICAg ICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5WYWxpZGF0ZVBhdGNoKSwKICAgICAgICAg ICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlByaW50Q29uZmlndXJhdGlvbiksCiAgICAgICAg ICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5DaGVja091dFNvdXJjZSksCkluZGV4OiBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNjEwODcp CisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcg Y29weSkKQEAgLTMwNCw2ICszMDQsNyBAQCBjbGFzcyBDaGVja1BhdGNoUmVsZXZhbmNlKGJ1aWxk c3RlcC5CdWlsCiAgICAgICAgICdqc2MnOiBqc2NfcGF0aHMsCiAgICAgICAgICd3ZWJraXRweSc6 IHdlYmtpdHB5X3BhdGhzLAogICAgICAgICAnd2sxLXRlc3RzJzogd2sxX3BhdGhzLAorICAgICAg ICAnd2luZG93cyc6IHdrMV9wYXRocywKICAgICB9CiAKICAgICBkZWYgX3BhdGNoX2lzX3JlbGV2 YW50KHNlbGYsIHBhdGNoLCBidWlsZGVyTmFtZSk6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNjEw ODcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3Qu cHkJKHdvcmtpbmcgY29weSkKQEAgLTIyMTYsMTcgKzIyMTYsMjUgQEAgY2xhc3MgVGVzdENoZWNr UGF0Y2hSZWxldmFuY2UoQnVpbGRTdGVwTQogICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVz dWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nUGF0Y2ggY29udGFpbnMgcmVsZXZhbnQgY2hhbmdl cycpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCisgICAgZGVmIHRlc3RfcmVsZXZh bnRfd2luZG93c193azFfcGF0Y2goc2VsZik6CisgICAgICAgIENoZWNrUGF0Y2hSZWxldmFuY2Uu X2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2FtcGxlIHBhdGNoOyBmaWxlOiBTb3VyY2UvV2ViS2l0 TGVnYWN5JworICAgICAgICBzZWxmLnNldHVwU3RlcChDaGVja1BhdGNoUmVsZXZhbmNlKCkpCisg ICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJ1dpbmRvd3MtRVdTJykKKyAg ICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1Bh dGNoIGNvbnRhaW5zIHJlbGV2YW50IGNoYW5nZXMnKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5T dGVwKCkKKwogICAgIGRlZiB0ZXN0X3F1ZXVlc193aXRob3V0X3JlbGV2YW5jZV9pbmZvKHNlbGYp OgogICAgICAgICBDaGVja1BhdGNoUmVsZXZhbmNlLl9nZXRfcGF0Y2ggPSBsYW1iZGEgeDogJ1Nh bXBsZSBwYXRjaCcKICAgICAgICAgcXVldWVzID0gWydDb21taXQtUXVldWUnLCAnU3R5bGUtRVdT JywgJ0FwcGx5LVdhdGNoTGlzdC1FV1MnLCAnR1RLLUJ1aWxkLUVXUycsICdHVEstV0syLVRlc3Rz LUVXUycsCiAgICAgICAgICAgICAgICAgICAnaU9TLTEzLUJ1aWxkLUVXUycsICdpT1MtMTMtU2lt dWxhdG9yLUJ1aWxkLUVXUycsICdpT1MtMTMtU2ltdWxhdG9yLVdLMi1UZXN0cy1FV1MnLAogICAg ICAgICAgICAgICAgICAgJ21hY09TLU1vamF2ZS1SZWxlYXNlLUJ1aWxkLUVXUycsICdtYWNPUy1N b2phdmUtUmVsZWFzZS1XSzItVGVzdHMtRVdTJywgJ21hY09TLU1vamF2ZS1EZWJ1Zy1CdWlsZC1F V1MnLAotICAgICAgICAgICAgICAgICAgJ1dpbmRvd3MtRVdTJywgJ1dpbkNhaXJvLUVXUycsICdX UEUtRVdTJywgJ1dlYktpdFBlcmwtVGVzdHMtRVdTJ10KKyAgICAgICAgICAgICAgICAgICdXaW5D YWlyby1FV1MnLCAnV1BFLUVXUycsICdXZWJLaXRQZXJsLVRlc3RzLUVXUyddCiAgICAgICAgIGZv ciBxdWV1ZSBpbiBxdWV1ZXM6CiAgICAgICAgICAgICBzZWxmLnNldHVwU3RlcChDaGVja1BhdGNo UmVsZXZhbmNlKCkpCiAgICAgICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScs IHF1ZXVlKQogICAgICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBz dGF0ZV9zdHJpbmc9J1BhdGNoIGNvbnRhaW5zIHJlbGV2YW50IGNoYW5nZXMnKQotICAgICAgICBy ZXR1cm4gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgICAgIHJjID0gc2VsZi5ydW5TdGVwKCkKKyAg ICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgdGVzdF9ub25fcmVsZXZhbnRfcGF0Y2goc2VsZik6 CiAgICAgICAgIENoZWNrUGF0Y2hSZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2Ft cGxlIHBhdGNoJwo=