211209 2020-04-29 15:07:46 -0700 Change default of "inAppBrowserPrivacyQuirks" testing toggle to use it for tests only 2020-04-30 14:39:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham webkit-bug-importer wilander oldest_to_newest 1647173 0 katherine_cheney 2020-04-29 15:07:46 -0700 This was used to test certain In-App Browser Privacy quirks. It is no longer needed, so we can delete it. 1647174 1 webkit-bug-importer 2020-04-29 15:08:08 -0700 <rdar://problem/62619659> 1647203 2 katherine_cheney 2020-04-29 16:24:17 -0700 (In reply to katherine_cheney from comment #0) > This was used to test certain In-App Browser Privacy quirks. It is no longer > needed, so we can delete it. After a bit of thinking, this flag is actually still needed for tests. We can change the default value and set it manually in tests which need it for script evaluation purposes. 1647206 3 398008 katherine_cheney 2020-04-29 16:37:16 -0700 Created attachment 398008 Patch 1647535 4 398008 bfulgham 2020-04-30 14:09:27 -0700 Comment on attachment 398008 Patch Looks good. r=me. 1647560 5 ews-feeder 2020-04-30 14:39:11 -0700 Committed r260968: <https://trac.webkit.org/changeset/260968> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398008. 398008 2020-04-29 16:37:16 -0700 2020-04-30 14:39:11 -0700 Patch bug-211209-20200429163715.patch text/plain 5776 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFlZmFhMTMxNDljODJmODY0 YmQzOWI3NTI5ZTUyM2VlNDgxNWQ1MGYuLjdhYTU1MjQxN2QzNjkwNjE0YzViNzg2OWNhYTk2MjYz YjIyOGE3N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMjkgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIGRlZmF1 bHQgb2YgImluQXBwQnJvd3NlclByaXZhY3lRdWlya3MiIHRlc3RpbmcgdG9nZ2xlIHRvIHVzZSBp dCBmb3IgdGVzdHMgb25seQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjExMjA5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjYxOTY1OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IGJlaGF2aW9yIGNvbmZpcm1lZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIFNoYXJl ZC9XZWJQcmVmZXJlbmNlcy55YW1sOgorCiAyMDIwLTA0LTI5ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFdLTmF2aWdhdGlvbkRlbGVn YXRlIEFQSSBzaG91bGRBbGxvd0RlcHJlY2F0ZWRUTFMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQ cmVmZXJlbmNlcy55YW1sCmluZGV4IGE2ODEzOWMzOTI5ZjY3ZTExY2YzYzA5ZjYxNDU0N2FmOTFm OTEzOWEuLjg3NWMwNDQ1ZjU2ZDczNmY4YTY5NDhhZDdjODIwMmU3Y2EyNDNhYmIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKKysrIGIvU291cmNl L1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAtMTI3NSw3ICsxMjc1LDcgQEAg SXNJbkFwcEJyb3dzZXJQcml2YWN5RW5hYmxlZDoKIAogTmVlZHNJbkFwcEJyb3dzZXJQcml2YWN5 UXVpcmtzOgogICAgIHR5cGU6IGJvb2wKLSAgICBkZWZhdWx0VmFsdWU6IHRydWUKKyAgICBkZWZh dWx0VmFsdWU6IGZhbHNlCiAgICAgaHVtYW5SZWFkYWJsZU5hbWU6ICJOZWVkcyBJbi1BcHAgQnJv d3NlciBQcml2YWN5IFF1aXJrcyIKICAgICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246ICJFbmFi bGUgcXVpcmtzIG5lZWRlZCB0byBzdXBwb3J0IEluLUFwcCBCcm93c2VyIHByaXZhY3kiCiAgICAg d2ViY29yZUJpbmRpbmc6IFJ1bnRpbWVFbmFibGVkRmVhdHVyZXMKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMWE5YTIzYWQ1NzcwYTk5N2IwNzc4 OTIxNTI3MjcyMzFlZmUwMzk2Li4yNzQ5OWZmYWU2MDA3ODQ4YmRjYzY2MDYxYzE0ZTYzNTI2OGVj Zjc4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMjAtMDQtMjkgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5l eUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIGRlZmF1bHQgb2YgImluQXBwQnJvd3NlclBy aXZhY3lRdWlya3MiIHRlc3RpbmcgdG9nZ2xlIHRvIHVzZSBpdCBmb3IgdGVzdHMgb25seQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMjA5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82MjYxOTY1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNYW51YWxseSBlbmFibGUgaW5BcHBCcm93c2VyUHJpdmFj eVF1aXJrcyBmb3IgY2VydGFpbiB0ZXN0cyB3aGljaAorICAgICAgICBuZWVkIHNjcmlwdCBldmFs dWF0aW9uIHRvIHRlc3Qgb3RoZXIgYXNwZWN0cyBvZiBJbi1BcHAgQnJvd3NlciBQcml2YWN5Lgor CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9JbkFwcEJyb3dzZXJQ cml2YWN5Lm1tOgorICAgICAgICAoVEVTVCk6CisKIDIwMjAtMDQtMjkgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgV0tOYXZpZ2F0aW9u RGVsZWdhdGUgQVBJIHNob3VsZEFsbG93RGVwcmVjYXRlZFRMUwpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9JbkFwcEJyb3dzZXJQcml2YWN5Lm1tIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9JbkFwcEJyb3dzZXJQcml2YWN5 Lm1tCmluZGV4IGRiZjU4MzJhNmM4NjE0MmEzNTM0MDRiMmMzODQ2YjgxNjg1ZjRiNDMuLjFmNGI2 MDc0ZDFiZjA1MWZmNWNkNDBjOTZjYjQ5MTMxZTFmNzBiODQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvSW5BcHBCcm93c2VyUHJpdmFjeS5tbQorKysg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0luQXBwQnJvd3NlclByaXZh Y3kubW0KQEAgLTMzMCw2ICszMzAsNyBAQCBURVNUKEluQXBwQnJvd3NlclByaXZhY3ksIE5vbkFw cEJvdW5kVXNlclN0eWxlU2hlZXRGb3JTcGVjaWZpY1dlYlZpZXdGYWlscykKICAgICBhdXRvIHNj aGVtZUhhbmRsZXIgPSBhZG9wdE5TKFtbSW5BcHBCcm93c2VyU2NoZW1lSGFuZGxlciBhbGxvY10g aW5pdF0pOwogICAgIFtjb25maWd1cmF0aW9uIHNldFVSTFNjaGVtZUhhbmRsZXI6c2NoZW1lSGFu ZGxlci5nZXQoKSBmb3JVUkxTY2hlbWU6QCJpbi1hcHAtYnJvd3NlciJdOwogICAgIFtbY29uZmln dXJhdGlvbiBwcmVmZXJlbmNlc10gX3NldEluQXBwQnJvd3NlclByaXZhY3lFbmFibGVkOllFU107 CisgICAgW1tjb25maWd1cmF0aW9uIHByZWZlcmVuY2VzXSBfc2V0TmVlZHNJbkFwcEJyb3dzZXJQ cml2YWN5UXVpcmtzOllFU107CiAKICAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdL V2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpDR1JlY3RaZXJvIGNvbmZpZ3VyYXRpb246Y29u ZmlndXJhdGlvbi5nZXQoKV0pOwogICAgIE5TVVJMUmVxdWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJl cXVlc3QgcmVxdWVzdFdpdGhVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJpbi1hcHAtYnJvd3Nl cjovLy9pbi1hcHAtYnJvd3Nlci1wcml2YWN5LXRlc3QtdXNlci1zdHlsZS1zaGVldHMiXV07CkBA IC0zNTMsNiArMzU0LDcgQEAgVEVTVChJbkFwcEJyb3dzZXJQcml2YWN5LCBOb25BcHBCb3VuZFVz ZXJTdHlsZVNoZWV0Rm9yQWxsV2ViVmlld3NGYWlscykKICAgICBhdXRvIHNjaGVtZUhhbmRsZXIg PSBhZG9wdE5TKFtbSW5BcHBCcm93c2VyU2NoZW1lSGFuZGxlciBhbGxvY10gaW5pdF0pOwogICAg IFtjb25maWd1cmF0aW9uIHNldFVSTFNjaGVtZUhhbmRsZXI6c2NoZW1lSGFuZGxlci5nZXQoKSBm b3JVUkxTY2hlbWU6QCJpbi1hcHAtYnJvd3NlciJdOwogICAgIFtbY29uZmlndXJhdGlvbiBwcmVm ZXJlbmNlc10gX3NldEluQXBwQnJvd3NlclByaXZhY3lFbmFibGVkOllFU107CisgICAgW1tjb25m aWd1cmF0aW9uIHByZWZlcmVuY2VzXSBfc2V0TmVlZHNJbkFwcEJyb3dzZXJQcml2YWN5UXVpcmtz OllFU107CiAKICAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxv Y10gaW5pdFdpdGhGcmFtZTpDR1JlY3RaZXJvIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5n ZXQoKV0pOwogICAgIE5TVVJMUmVxdWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJlcXVlc3QgcmVxdWVz dFdpdGhVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJpbi1hcHAtYnJvd3NlcjovLy9pbi1hcHAt YnJvd3Nlci1wcml2YWN5LXRlc3QtdXNlci1zdHlsZS1zaGVldHMiXV07CkBAIC0zNzUsNiArMzc3 LDcgQEAgVEVTVChJbkFwcEJyb3dzZXJQcml2YWN5LCBOb25BcHBCb3VuZFVzZXJTdHlsZVNoZWV0 QWZmZWN0aW5nQWxsRnJhbWVzRmFpbHMpCiAgICAgYXV0byBzY2hlbWVIYW5kbGVyID0gYWRvcHRO UyhbW0luQXBwQnJvd3NlclNjaGVtZUhhbmRsZXIgYWxsb2NdIGluaXRdKTsKICAgICBbY29uZmln dXJhdGlvbiBzZXRVUkxTY2hlbWVIYW5kbGVyOnNjaGVtZUhhbmRsZXIuZ2V0KCkgZm9yVVJMU2No ZW1lOkAiaW4tYXBwLWJyb3dzZXIiXTsKICAgICBbW2NvbmZpZ3VyYXRpb24gcHJlZmVyZW5jZXNd IF9zZXRJbkFwcEJyb3dzZXJQcml2YWN5RW5hYmxlZDpZRVNdOworICAgIFtbY29uZmlndXJhdGlv biBwcmVmZXJlbmNlc10gX3NldE5lZWRzSW5BcHBCcm93c2VyUHJpdmFjeVF1aXJrczpZRVNdOwog CiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRX aXRoRnJhbWU6Q0dSZWN0WmVybyBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCldKTsK ICAgICBOU1VSTFJlcXVlc3QgKnJlcXVlc3QgPSBbTlNVUkxSZXF1ZXN0IHJlcXVlc3RXaXRoVVJM OltOU1VSTCBVUkxXaXRoU3RyaW5nOkAiaW4tYXBwLWJyb3dzZXI6Ly8vaW4tYXBwLWJyb3dzZXIt cHJpdmFjeS10ZXN0LXVzZXItc3R5bGUtc2hlZXRzLWlmcmFtZSJdXTsKQEAgLTQwMiw2ICs0MDUs NyBAQCBURVNUKEluQXBwQnJvd3NlclByaXZhY3ksIE5vbkFwcEJvdW5kRG9tYWluQ2Fubm90QWNj ZXNzTWVzc2FnZUhhbmRsZXJzKQogICAgIGF1dG8gc2NoZW1lSGFuZGxlciA9IGFkb3B0TlMoW1tJ bkFwcEJyb3dzZXJTY2hlbWVIYW5kbGVyIGFsbG9jXSBpbml0XSk7CiAgICAgW2NvbmZpZ3VyYXRp b24gc2V0VVJMU2NoZW1lSGFuZGxlcjpzY2hlbWVIYW5kbGVyLmdldCgpIGZvclVSTFNjaGVtZTpA ImluLWFwcC1icm93c2VyIl07CiAgICAgW1tjb25maWd1cmF0aW9uIHByZWZlcmVuY2VzXSBfc2V0 SW5BcHBCcm93c2VyUHJpdmFjeUVuYWJsZWQ6WUVTXTsKKyAgICBbW2NvbmZpZ3VyYXRpb24gcHJl ZmVyZW5jZXNdIF9zZXROZWVkc0luQXBwQnJvd3NlclByaXZhY3lRdWlya3M6WUVTXTsKIAogICAg IGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZy YW1lOkNHUmVjdFplcm8gY29uZmlndXJhdGlvbjpjb25maWd1cmF0aW9uLmdldCgpXSk7CiAKQEAg LTk4Nyw3ICs5OTEsOSBAQCBURVNUKEluQXBwQnJvd3NlclByaXZhY3ksIFdlYlZpZXdXaXRob3V0 QXBwQm91bmRGbGFnQ2FuRnJlZWx5TmF2aWdhdGUpCiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6 cnVuKCZpc0RvbmUpOwogCiAgICAgLy8gTmF2aWdhdGlvbiBzaG91bGQgYmUgc3VjY2Vzc2Z1bCwg YnV0IHRoaXMgV2ViVmlldyBzaG91bGQgbm90IGdldCBhcHAtYm91bmQgZG9tYWluCi0gICAgLy8g cHJpdmlsZWdlcyBsaWtlIHVzZXIgc3R5bGUgc2hlZXRzLgorICAgIC8vIHByaXZpbGVnZXMgbGlr ZSB1c2VyIHN0eWxlIHNoZWV0cy4gU2V0IHF1aXJrcyB0byB0cnVlIHNvIHdlIGNhbiBldmFsdWF0 ZSBzY3JpcHQKKyAgICAvLyB0byBjaGVjay4KKyAgICBbW1t3ZWJWaWV3IGNvbmZpZ3VyYXRpb25d IHByZWZlcmVuY2VzXSBfc2V0TmVlZHNJbkFwcEJyb3dzZXJQcml2YWN5UXVpcmtzOllFU107CiAg ICAgZXhwZWN0U2NyaXB0RXZhbHVhdGVzVG9Db2xvcih3ZWJWaWV3LmdldCgpLCBiYWNrZ3JvdW5k Q29sb3JTY3JpcHQsIGJsYWNrSW5SR0IpOwogICAgIGNsZWFuVXBJbkFwcEJyb3dzZXJQcml2YWN5 VGVzdFNldHRpbmdzKCk7CiB9Cg==