211204 2020-04-29 13:56:09 -0700 build-jsc should quote the value of compile flags it forwards 2020-04-29 14:58:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1647148 0 saam 2020-04-29 13:56:09 -0700 For example, we do the wrong thing now with make when doing $ build-jsc --release ARCHS="x86_64 i386" We invoke make as $ make release ARCHS=x86_64 i386 instead of $ make release ARCHS="x86_64 i386" 1647153 1 397997 saam 2020-04-29 14:16:45 -0700 Created attachment 397997 patch 1647158 2 397997 mark.lam 2020-04-29 14:25:00 -0700 Comment on attachment 397997 patch rs=me 1647167 3 ews-feeder 2020-04-29 14:57:46 -0700 Committed r260917: <https://trac.webkit.org/changeset/260917> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397997. 1647168 4 webkit-bug-importer 2020-04-29 14:58:14 -0700 <rdar://problem/62619195> 397997 2020-04-29 14:16:45 -0700 2020-04-29 14:57:47 -0700 patch b-backup.diff text/plain 1969 saam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MDkxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDIwLTA0LTI5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor CisgICAgICAgIGJ1aWxkLWpzYyBzaG91bGQgcXVvdGUgdGhlIHZhbHVlIG9mIGNvbXBpbGUgZmxh Z3MgaXQgZm9yd2FyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMTIwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIHNob3VsZCBxdW90ZSBvdXRnb2luZyBjb21waWxlIGZsYWdzIHRoYXQgaGF2ZSBh biBlcXVhbCBpbiB0aGVtLiBCZWZvcmUsCisgICAgICAgIGlmIGJ1aWxkLWpzYyB3ZXJlIGludm9r ZWQgbGlrZToKKyAgICAgICAgJCBidWlsZC1qc2MgLS1yZWxlYXNlIEFSQ0hTPSJ4ODZfNjQgaTM4 NiIKKyAgICAgICAgSXQnZCBpbnZva2UgbWFrZSBsaWtlOgorICAgICAgICAkIG1ha2UgcmVsZWFz ZSBBUkNIUz14ODZfNjQgaTM4NgorICAgICAgICBsZWFkaW5nIHVzIHRvIHRyeSB0byBidWlsZCB0 aGUgImkzODYiIHRhcmdldCwgd2hpY2ggZG9lc24ndCBleGlzdC4KKyAgICAgICAgCisgICAgICAg IFRoaXMgcGF0Y2ggbWFrZXMgdXMgaW52b2tlIG1ha2UgbGlrZSBzbzoKKyAgICAgICAgJCBtYWtl IHJlbGVhc2UgQVJDSFM9Ing4Nl82NCBpMzg2IgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC1q c2M6CisgICAgICAgIChidWlsZE15UHJvamVjdCk6CisKIDIwMjAtMDQtMjkgIEthdGUgQ2hlbmV5 ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgbGF5b3V0 IHRlc3RzIGFmdGVyIHVwZGF0ZXMgdG8gSW4tQXBwIEJyb3dzZXIgUHJpdmFjeQpJbmRleDogVG9v bHMvU2NyaXB0cy9idWlsZC1qc2MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9idWlsZC1q c2MJKHJldmlzaW9uIDI2MDkxMykKKysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtanNjCSh3b3JraW5n IGNvcHkpCkBAIC0yMTQsNyArMjE0LDE5IEBAIHN1YiBidWlsZE15UHJvamVjdAogICAgICAgICB9 CiAgICAgICAgICRjb21waWxlckZsYWdzIC49ICciJzsKIAotICAgICAgICBteSAkY29tbWFuZCA9 ICJtYWtlICIgLiAobGMgY29uZmlndXJhdGlvbigpKSAuICIgIiAuICRjb21waWxlckZsYWdzIC4g IiAiIC4gam9pbigiICIsIEBBUkdWKTsKKyAgICAgICAgbXkgJGV4dHJhQ29tbWFuZHMgPSAiIjsK KyAgICAgICAgZm9yZWFjaCAoQEFSR1YpIHsKKyAgICAgICAgICAgICMgRW5zdXJlIHRoYXQgaWYg c29tZWJvZHkgcGFzc2VzIGluIGEgZmxhZyBsaWtlIGBBUkNIUz0iaTM4NiB4ODZfNjQiYCB3ZQor ICAgICAgICAgICAgIyBtYWludGFpbiB0aGUgcXVvdGVzIGFyb3VuZCAiaTM4NiB4ODZfNjQiLgor ICAgICAgICAgICAgbXkgJGFyZyA9ICRfOworICAgICAgICAgICAgaWYgKCRhcmcgPX4gbS89Lykg eworICAgICAgICAgICAgICAgICRhcmcgPX4gcy89Lz0iLzsKKyAgICAgICAgICAgICAgICAkYXJn ID0gJGFyZyAuICJcIiI7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAkZXh0cmFDb21tYW5k cyAuPSAiICIgLiAkYXJnOworICAgICAgICB9CisKKyAgICAgICAgbXkgJGNvbW1hbmQgPSAibWFr ZSAiIC4gKGxjIGNvbmZpZ3VyYXRpb24oKSkgLiAiICIgLiAkY29tcGlsZXJGbGFncyAuICIgIiAu ICRleHRyYUNvbW1hbmRzOwogCiAgICAgICAgIHByaW50ICJcbiI7CiAgICAgICAgIHByaW50ICJi dWlsZGluZyAiLCAkcHJvamVjdE5hbWUsICJcbiI7Cg==