211195 2020-04-29 11:36:04 -0700 Add better handling of an uncleared bundle identifier in WebKitTestRunner 2020-04-29 16:42:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney ap bfulgham pvollan oldest_to_newest 1647080 0 katherine_cheney 2020-04-29 11:36:04 -0700 Calling exit(1) provides very little detail and makes debugging of this difficult. 1647081 1 katherine_cheney 2020-04-29 11:36:32 -0700 <rdar://problem/62117145> 1647083 2 397982 katherine_cheney 2020-04-29 11:40:08 -0700 Created attachment 397982 Patch 1647180 3 397982 ap 2020-04-29 15:22:43 -0700 Comment on attachment 397982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397982&action=review Thank you! > Tools/WebKitTestRunner/TestController.cpp:644 > + // ASSERT the bundle identifier has not already been set, since it can only be set once. I think that it would be better wording to not restate what the code does. So I'd say "The bundle identifier can only be set once." Maybe also add an explanation of how to resolve this, for the person hitting this. Something like this, if it's accurate: "WebContent process needs to be relaunched after every test that sets the bundle identifier." 1647201 4 398007 katherine_cheney 2020-04-29 16:21:09 -0700 Created attachment 398007 Patch for landing 1647202 5 katherine_cheney 2020-04-29 16:22:22 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 397982 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397982&action=review > > Thank you! > > > Tools/WebKitTestRunner/TestController.cpp:644 > > + // ASSERT the bundle identifier has not already been set, since it can only be set once. > > I think that it would be better wording to not restate what the code does. > So I'd say "The bundle identifier can only be set once." > > Maybe also add an explanation of how to resolve this, for the person hitting > this. Something like this, if it's accurate: "WebContent process needs to be > relaunched after every test that sets the bundle identifier." Thanks! I updated the comment. No resolution should be necessary from now on, because the bundleID will get cleared between all tests. I wrote that in the comment. 1647207 6 ews-feeder 2020-04-29 16:42:10 -0700 Committed r260926: <https://trac.webkit.org/changeset/260926> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398007. 397982 2020-04-29 11:40:08 -0700 2020-04-29 16:21:08 -0700 Patch bug-211195-20200429114008.patch text/plain 1770 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTQ1ZWZjNThjOGMwN2IyNzQ5NzE3ZDU1YzI1YjJhM2Zh YjJkZGE1ZC4uYWEyMjQ3NGU1NzhhMTk5ZGQxNzQ3MjkwMWYwNmEyNTgxNzk1ZDhkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA0LTI5ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29t PgorCisgICAgICAgIEFkZCBiZXR0ZXIgaGFuZGxpbmcgb2YgYW4gdW5jbGVhcmVkIGJ1bmRsZSBp ZGVudGlmaWVyIGluIFdlYktpdFRlc3RSdW5uZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTE5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjIx MTcxNDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVz dENvbnRyb2xsZXI6OmNyZWF0ZVdlYlZpZXdXaXRoT3B0aW9ucyk6CisKIDIwMjAtMDQtMjkgIEth dGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0 b3IgbGF5b3V0IHRlc3RzIGFmdGVyIHVwZGF0ZXMgdG8gSW4tQXBwIEJyb3dzZXIgUHJpdmFjeQpk aWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAppbmRleCA4NjdmMmMxZDlm NzhhMzA0NDcyMjIwZDllODBiMmNmMjQ4NDI1NWMzLi4xOTAzYTcwODgxMjIwN2UzM2Y1ZDUzMGJm OGQ2YmM2ODYxZDc0Y2FmIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RD b250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVy LmNwcApAQCAtNjQwLDExICs2NDAsOSBAQCBXS1JldGFpblB0cjxXS1BhZ2VDb25maWd1cmF0aW9u UmVmPiBUZXN0Q29udHJvbGxlcjo6Z2VuZXJhdGVQYWdlQ29uZmlndXJhdGlvbihjbwogdm9pZCBU ZXN0Q29udHJvbGxlcjo6Y3JlYXRlV2ViVmlld1dpdGhPcHRpb25zKGNvbnN0IFRlc3RPcHRpb25z JiBvcHRpb25zKQogewogI2lmIFBMQVRGT1JNKENPQ09BKQotICAgIGlmIChtX2hhc1NldEFwcGxp Y2F0aW9uQnVuZGxlSWRlbnRpZmllcikgewotICAgICAgICAvLyBFeGl0IGlmIHRoZSBhcHBsaWNh dGlvbiBidW5kbGUgaWRlbnRpZmllciBoYXMgYWxyZWFkeSBiZWVuIHNldCwgc2luY2UgaXQgY2Fu IG9ubHkgYmUgc2V0IG9uY2UuCi0gICAgICAgIGV4aXQoMSk7Ci0gICAgfQogICAgIGlmICghb3B0 aW9ucy5hcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIuaXNFbXB0eSgpKSB7CisgICAgICAgIC8v IEFTU0VSVCB0aGUgYnVuZGxlIGlkZW50aWZpZXIgaGFzIG5vdCBhbHJlYWR5IGJlZW4gc2V0LCBz aW5jZSBpdCBjYW4gb25seSBiZSBzZXQgb25jZS4KKyAgICAgICAgUkVMRUFTRV9BU1NFUlQoIW1f aGFzU2V0QXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKTsKICAgICAgICAgc2V0QXBwbGljYXRp b25CdW5kbGVJZGVudGlmaWVyKG9wdGlvbnMuYXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKTsK ICAgICAgICAgbV9oYXNTZXRBcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIgPSB0cnVlOwogICAg IH0K 398007 2020-04-29 16:21:09 -0700 2020-04-29 16:42:10 -0700 Patch for landing bug-211195-20200429162109.patch text/plain 1772 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTQ1ZWZjNThjOGMwN2IyNzQ5NzE3ZDU1YzI1YjJhM2Zh YjJkZGE1ZC4uMDY2N2Q5OWJiMjJmNDg3YTBmYmJhMTM2MDA5ZGM4Y2RiNDYzODk2NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA0LTI5ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29t PgorCisgICAgICAgIEFkZCBiZXR0ZXIgaGFuZGxpbmcgb2YgYW4gdW5jbGVhcmVkIGJ1bmRsZSBp ZGVudGlmaWVyIGluIFdlYktpdFRlc3RSdW5uZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTE5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjIx MTcxNDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAg ICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RS OjpUZXN0Q29udHJvbGxlcjo6Y3JlYXRlV2ViVmlld1dpdGhPcHRpb25zKToKKwogMjAyMC0wNC0y OSAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZWZhY3RvciBsYXlvdXQgdGVzdHMgYWZ0ZXIgdXBkYXRlcyB0byBJbi1BcHAgQnJvd3NlciBQcml2 YWN5CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNw cCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDg2N2Yy YzFkOWY3OGEzMDQ0NzIyMjBkOWU4MGIyY2YyNDg0MjU1YzMuLjBiMjQ3NTE4OGZiYTQ5ZTFhYjk3 NTNlNmFiMzU0YTEzOWRjYzk2YzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv VGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRy b2xsZXIuY3BwCkBAIC02NDAsMTEgKzY0MCw5IEBAIFdLUmV0YWluUHRyPFdLUGFnZUNvbmZpZ3Vy YXRpb25SZWY+IFRlc3RDb250cm9sbGVyOjpnZW5lcmF0ZVBhZ2VDb25maWd1cmF0aW9uKGNvCiB2 b2lkIFRlc3RDb250cm9sbGVyOjpjcmVhdGVXZWJWaWV3V2l0aE9wdGlvbnMoY29uc3QgVGVzdE9w dGlvbnMmIG9wdGlvbnMpCiB7CiAjaWYgUExBVEZPUk0oQ09DT0EpCi0gICAgaWYgKG1faGFzU2V0 QXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKSB7Ci0gICAgICAgIC8vIEV4aXQgaWYgdGhlIGFw cGxpY2F0aW9uIGJ1bmRsZSBpZGVudGlmaWVyIGhhcyBhbHJlYWR5IGJlZW4gc2V0LCBzaW5jZSBp dCBjYW4gb25seSBiZSBzZXQgb25jZS4KLSAgICAgICAgZXhpdCgxKTsKLSAgICB9CiAgICAgaWYg KCFvcHRpb25zLmFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllci5pc0VtcHR5KCkpIHsKKyAgICAg ICAgLy8gVGhlIGJ1bmRsZSBpZGVudGlmaWVyIGNhbiBvbmx5IGJlIHNldCBvbmNlIHBlciB0ZXN0 LCBhbmQgaXMgY2xlYXJlZCBiZXR3ZWVuIHRlc3RzLgorICAgICAgICBSRUxFQVNFX0FTU0VSVCgh bV9oYXNTZXRBcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIpOwogICAgICAgICBzZXRBcHBsaWNh dGlvbkJ1bmRsZUlkZW50aWZpZXIob3B0aW9ucy5hcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIp OwogICAgICAgICBtX2hhc1NldEFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllciA9IHRydWU7CiAg ICAgfQo=