211193 2020-04-29 10:29:31 -0700 [clang 11] fix build errors due to -WWc++11-narrowing 2020-04-30 10:08:21 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner aperez bugs-noreply calvaris cdumez darin eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 1647051 0 cturner 2020-04-29 10:29:31 -0700 [clang 11] fix build errors due to -WWc++11-narrowing 1647064 1 397978 cturner 2020-04-29 10:36:56 -0700 Created attachment 397978 Patch 1647370 2 ews-feeder 2020-04-30 08:12:40 -0700 Committed r260951: <https://trac.webkit.org/changeset/260951> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397978. 1647405 3 397978 darin 2020-04-30 10:08:21 -0700 Comment on attachment 397978 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397978&action=review > Source/WebCore/style/StyleResolver.cpp:106 > - m_mediaQueryEvaluator = MediaQueryEvaluator { "all" }; > + m_mediaQueryEvaluator = MediaQueryEvaluator { }; This is a great change. But note that it changes behavior in a big way. The old code was passing true for mediaFeatureResult, by accident. The new code correctly passes false. We need to find a way to get this code path tested. 397978 2020-04-29 10:36:56 -0700 2020-04-30 08:12:41 -0700 Patch bug-211193-20200429183655.patch text/plain 4713 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTdjNzg5MjFhMjg4Zjkz Y2IyN2Y3ZTEzMzcwZGQ1ZTk0MWE5YTZjOS4uOWUxZDJmYTFhMzFlNzMxZTNjNGFkMzRmMTViMDc5 ZmFiMTA3NzIyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQyIEBACisyMDIwLTA0LTI5ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbY2xhbmcgMTFdIGZp eCBidWlsZCBlcnJvcnMgZHVlIHRvIC1XV2MrKzExLW5hcnJvd2luZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTkzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgdGhlIGZvbGxvd2luZyBlcnJv cnMsCisKKyAgICAgICAgU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNw cDoxMDU5Ojk6IGVycm9yOiB0eXBlICdXZWJDb3JlOjpSZW5kZXJNZWRpYSAqJyBjYW5ub3QgYmUg bmFycm93ZWQgdG8gJ2Jvb2wnIGluIGluaXRpYWxpemVyIGxpc3QgWy1XYysrMTEtbmFycm93aW5n XQorICAgICAgICBtX2VsZW1lbnQucmVuZGVyZXIoKSwKKyAgICAgICAgXn5+fn5+fn5+fn5+fn5+ fn5+fn4KKworICAgICAgICBTb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVJlc29sdmVyLmNwcDox MDY6NTU6IGVycm9yOiB0eXBlICdjb25zdCBjaGFyIFs0XScgY2Fubm90IGJlIG5hcnJvd2VkIHRv ICdib29sJyBpbiBpbml0aWFsaXplciBsaXN0IFstV2MrKzExLW5hcnJvd2luZ10KKyAgICAgICAg bV9tZWRpYVF1ZXJ5RXZhbHVhdG9yID0gTWVkaWFRdWVyeUV2YWx1YXRvciB7ICJhbGwiIH07Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+ fgorICAgICAgICBTb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVJlc29sdmVyLmNwcDoxMDY6NTU6 IG5vdGU6IGluc2VydCBhbiBleHBsaWNpdCBjYXN0IHRvIHNpbGVuY2UgdGhpcyBpc3N1ZQorICAg ICAgICBtX21lZGlhUXVlcnlFdmFsdWF0b3IgPSBNZWRpYVF1ZXJ5RXZhbHVhdG9yIHsgImFsbCIg fTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IF5+fn5+CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdGF0aWNfY2FzdDxib29sPiggKQorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVt ZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpoYXNSZW5kZXJlciBj b25zdCk6CisgICAgICAgIE1lZGlhRWxlbWVudFNlc3Npb24gd2FzIGltcGxpY2l0bHkgY2FzdGlu ZyBhIHBvaW50ZXIgdG8gYSBib29sLAorICAgICAgICB3aGljaCBpcyBub3QgYWxsb3dlZCB3aXRo IG1vZGVybiBDbGFuZyBjaGVja3MuIEFkZCBhIGhlbHBlciBtZXRob2QKKyAgICAgICAgdG8gZW5j YXBzdWxhdGUgdGhlIG5vdyByZXF1aXJlZCBzdGF0aWNfY2FzdDxib29sPi4KKyAgICAgICAgKiBo dG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwOiBVc2UgdGhlIG5ldyBoZWxwZXIgbWV0aG9kIHRv IHNlZQorICAgICAgICBpZiB0aGUgSFRNTE1lZGlhRWxlbWVudCBoYXMgYW4gYXNzb2NpYXRlZCBy ZW5kZXJlci4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Npb246OnVwZGF0ZU1l ZGlhVXNhZ2VJZkNoYW5nZWQpOgorICAgICAgICAqIHN0eWxlL1N0eWxlUmVzb2x2ZXIuY3BwOiBU aGlzIHdhcyBjYWxsaW5nIE1lZGlhUXVlcnlFdmFsdWF0b3IgeworICAgICAgICAiYWxsIiB9OyBh bmQgc2VlbWluZ2x5IGV4cGVjdGluZyB0byBjYXN0IGEgY29uc3QgY2hhcltdIHRvIGEgYm9vbCwK KyAgICAgICAgb3IgbWF5YmUgU3RyaW5nPyBJdCdzIGNvbmZ1c2luZyBiZWNhdXNlIG9mIHRoZSBN ZWRpYVF1ZXJ5RXZhbHVhdG9yCisgICAgICAgIEFQSS4gSWYgaXQgd2FzIGltcGxpY2l0bHkgY29u dmVydGluZyB0byBib29sIHRoZW4gdGhhdCBjb3VsZCBiZQorICAgICAgICB1bmludGVudGlvbmFs LiBTdWNoIGNhc3RzIGFyZSBub3QgYWxsb3dlZCBlaXRoZXIgbm93LiBUaGUKKyAgICAgICAgTWVk aWFRdWVyeUV2YWx1YXRvcidzIGRlZmF1bHQgY29uc3RydWN0b3Igc2F5cyBpdCByZXR1cm5zIHRy dWUgZm9yCisgICAgICAgICJhbGwiLCB3aGljaCBhcHBlYXJzIHRvIGJlIHRoZSBvcmlnaW5hbCBp bnRlbnQgb2YgdGhpcyBjYWxsLCBzbyBJCisgICAgICAgIHJlcGxhY2VkIGl0IHdpdGggdGhhdC4K KyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjpSZXNvbHZlcjo6UmVzb2x2ZXIpOgorCiAyMDIwLTA0 LTI5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gRm9y bWF0dGluZ0NvbnRleHQ6OmNvbnN0cmFpbnRzRm9ySW5GbG93L091dE9mRmxvd0NvbnRlbnQgc2hv dWxkIHRha2UgY29uc3QgQ29udGFpbmVyQm94JgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MTWVkaWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuaAppbmRleCBiNDY2ZGZjMTM5ZDcyMDBhZDE1Y2Q4YmQ5ODI3ODA1NGQ0MmMzMDI3Li40 NDRmMzQ5ZGY4N2I3NGVjNDQ3MDczZGU3N2I0NWJiNGMxNWE2YjliIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuaApAQCAtMTU1LDYgKzE1NSw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIGJvb2wgaXNWaWRlbygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgYm9vbCBo YXNWaWRlbygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgYm9vbCBoYXNB dWRpbygpIGNvbnN0IG92ZXJyaWRlOworICAgIGJvb2wgaGFzUmVuZGVyZXIoKSBjb25zdCB7IHJl dHVybiBzdGF0aWNfY2FzdDxib29sPihyZW5kZXJlcigpKTsgfQogCiAgICAgc3RhdGljIEhhc2hT ZXQ8SFRNTE1lZGlhRWxlbWVudCo+JiBhbGxNZWRpYUVsZW1lbnRzKCk7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCmluZGV4IDVlZTUwZWJhZDlhNmI2NzE0 Yjc1OTYxOWQ2ZTg1YjFkMWQ0ZWQxZmYuLjZmMTQ5NWU0YTdlMjUwMmVjZWViMDY2YTg0OTEyNDgx NDU3YjgyNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vz c2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNw cApAQCAtMTA1Niw3ICsxMDU2LDcgQEAgdm9pZCBNZWRpYUVsZW1lbnRTZXNzaW9uOjp1cGRhdGVN ZWRpYVVzYWdlSWZDaGFuZ2VkKCkKICAgICAgICAgaXNBdWRpbywKICAgICAgICAgbV9lbGVtZW50 Lmhhc1ZpZGVvKCksCiAgICAgICAgIG1fZWxlbWVudC5oYXNBdWRpbygpLAotICAgICAgICBtX2Vs ZW1lbnQucmVuZGVyZXIoKSwKKyAgICAgICAgbV9lbGVtZW50Lmhhc1JlbmRlcmVyKCksCiAgICAg ICAgIGlzQXVkaW8gJiYgaGFzQmVoYXZpb3JSZXN0cmljdGlvbihSZXF1aXJlVXNlckdlc3R1cmVU b0NvbnRyb2xDb250cm9sc01hbmFnZXIpICYmICFwcm9jZXNzaW5nVXNlckdlc3R1cmUsCiAgICAg ICAgIG1fZWxlbWVudC5oYXNBdWRpbygpICYmIGlzUGxheWluZyAmJiBhbGxvd3NQbGF5YmFja0Nv bnRyb2xzRm9yQXV0b3BsYXlpbmdBdWRpbygpLCAvLyB1c2VySGFzUGxheWVkQXVkaW9CZWZvcmUK ICAgICAgICAgaXNFbGVtZW50UmVjdE1vc3RseUluTWFpbkZyYW1lKG1fZWxlbWVudCksCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDY1MWY4ZjFlMmQ3ODkyMTk5MDY1 NmFmYTRmZDllNjllZGNhYzNjMjQuLjkzMzNiODM5MTNhNDNjYTUxZDY4NjE2YWJmMWIyNTBmNjc0 M2IyYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2ZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2ZXIuY3BwCkBAIC0xMDMsNyAr MTAzLDcgQEAgUmVzb2x2ZXI6OlJlc29sdmVyKERvY3VtZW50JiBkb2N1bWVudCkKICAgICBpZiAo dmlldykKICAgICAgICAgbV9tZWRpYVF1ZXJ5RXZhbHVhdG9yID0gTWVkaWFRdWVyeUV2YWx1YXRv ciB7IHZpZXctPm1lZGlhVHlwZSgpIH07CiAgICAgZWxzZQotICAgICAgICBtX21lZGlhUXVlcnlF dmFsdWF0b3IgPSBNZWRpYVF1ZXJ5RXZhbHVhdG9yIHsgImFsbCIgfTsKKyAgICAgICAgbV9tZWRp YVF1ZXJ5RXZhbHVhdG9yID0gTWVkaWFRdWVyeUV2YWx1YXRvciB7IH07CiAKICAgICBpZiAocm9v dCkgewogICAgICAgICBtX3Jvb3REZWZhdWx0U3R5bGUgPSBzdHlsZUZvckVsZW1lbnQoKnJvb3Qs IG1fZG9jdW1lbnQucmVuZGVyU3R5bGUoKSwgbnVsbHB0ciwgUnVsZU1hdGNoaW5nQmVoYXZpb3I6 Ok1hdGNoT25seVVzZXJBZ2VudFJ1bGVzKS5yZW5kZXJTdHlsZTsK