211182 2020-04-29 07:24:47 -0700 [GStreamer] Video loops when ran in rr record --chaos 2020-05-05 07:36:55 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1646978 0 aboya 2020-04-29 07:24:47 -0700 While trying to investigate a different bug, I ran the browser with `rr record --chaos`, which makes it run very slowly and shuffles thread scheduling to try to make existing race conditions more likely to show up, also inevitably making the software run very slow. Doing so I found something strange: the video kept looping even though it didn't have the `loop` attribute set. After some debugging I found that MediaPlayer decides if the video has ended in part by checking `currentMediaTime()` is greater or equal to the video duration, which was not guaranteed to be the case in MediaPlayerPrivateGStreamer. As a consequence of this patch, one new LayoutTest has passed. 1646979 1 397960 aboya 2020-04-29 07:28:19 -0700 Created attachment 397960 Patch 1646983 2 pnormand 2020-04-29 07:38:55 -0700 Looks similar to bug 191259 1649132 3 pnormand 2020-05-05 02:11:21 -0700 *** Bug 191259 has been marked as a duplicate of this bug. *** 1649184 4 ews-feeder 2020-05-05 07:36:54 -0700 Committed r261165: <https://trac.webkit.org/changeset/261165> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397960. 397960 2020-04-29 07:28:19 -0700 2020-05-05 07:36:55 -0700 Patch bug-211182-20200429162816.patch text/plain 4499 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjgwNmRjNzhhZGExYzhi MzhjM2QwMzJkODZjN2ZmYWRmMDk3ZmFhOC4uN2ZkNDIxMzMwYTc1YjRkMDgxN2ZlYWRhN2QzMDFl ZWUzMGQwYzM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIwLTA0LTI4ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBWaWRlbyBsb29wcyB3aGVuIHJhbiBpbiByciByZWNvcmQgLS1jaGFvcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTgyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpbGUgdHJ5aW5nIHRvIGludmVz dGlnYXRlIGEgZGlmZmVyZW50IGJ1ZywgSSByYW4gdGhlIGJyb3dzZXIgd2l0aAorICAgICAgICBg cnIgcmVjb3JkIC0tY2hhb3NgLCB3aGljaCBtYWtlcyBpdCBydW4gdmVyeSBzbG93bHkgYW5kIHNo dWZmbGVzCisgICAgICAgIHRocmVhZCBzY2hlZHVsaW5nIHRvIHRyeSB0byBtYWtlIGV4aXN0aW5n IHJhY2UgY29uZGl0aW9ucyBtb3JlIGxpa2VseQorICAgICAgICB0byBzaG93IHVwLCBhbHNvIGlu ZXZpdGFibHkgbWFraW5nIHRoZSBzb2Z0d2FyZSBydW4gdmVyeSBzbG93LgorCisgICAgICAgIERv aW5nIHNvIEkgZm91bmQgc29tZXRoaW5nIHN0cmFuZ2U6IHRoZSB2aWRlbyBrZXB0IGxvb3Bpbmcg ZXZlbiB0aG91Z2gKKyAgICAgICAgaXQgZGlkbid0IGhhdmUgdGhlIGBsb29wYCBhdHRyaWJ1dGUg c2V0LgorCisgICAgICAgIEFmdGVyIHNvbWUgZGVidWdnaW5nIEkgZm91bmQgdGhhdCBNZWRpYVBs YXllciBkZWNpZGVzIGlmIHRoZSB2aWRlbyBoYXMKKyAgICAgICAgZW5kZWQgaW4gcGFydCBieSBj aGVja2luZyBgY3VycmVudE1lZGlhVGltZSgpYCBpcyBncmVhdGVyIG9yIGVxdWFsIHRvCisgICAg ICAgIHRoZSB2aWRlbyBkdXJhdGlvbiwgd2hpY2ggd2FzIG5vdCBndWFyYW50ZWVkIHRvIGJlIHRo ZSBjYXNlIGluCisgICAgICAgIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci4KKworICAgICAg ICBBcyBhIGNvbnNlcXVlbmNlIG9mIHRoaXMgcGF0Y2gsIG9uZSBuZXcgTGF5b3V0VGVzdCBoYXMg cGFzc2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXI6OnBsYXliYWNrUG9zaXRpb24gY29uc3QpOgorCiAyMDIwLTA0LTI4ICBB bGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBQbGF0Zm9y bU1lZGlhUmVzb3VyY2VMb2FkZXIgc2hvdWxkIGJlIGRlc3Ryb3llZCBvbiB0aGUgbWFpbiB0aHJl YWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5k ZXggNjE2MmFkYWU2YmZmNTE2NzFlM2JlNTMyMjI3ZTdkZTU3OTk5ZmRmMC4uMjRiY2Q2NWYzOTJj ZTBiYzJmMTJmZTUyZGIyYzY3MDNhNjNhMDBiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTE2MjAsOCArMTYyMCwxMCBAQCBHc3RFbGVt ZW50KiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmF1ZGlvU2luaygpIGNvbnN0CiBNZWRp YVRpbWUgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpwbGF5YmFja1Bvc2l0aW9uKCkgY29u c3QKIHsKICAgICBHU1RfVFJBQ0VfT0JKRUNUKHBpcGVsaW5lKCksICJpc0VuZFJlYWNoZWQ6ICVz LCBzZWVraW5nOiAlcywgc2Vla1RpbWU6ICVzIiwgYm9vbEZvclByaW50aW5nKG1faXNFbmRSZWFj aGVkKSwgYm9vbEZvclByaW50aW5nKG1faXNTZWVraW5nKSwgbV9zZWVrVGltZS50b1N0cmluZygp LnV0ZjgoKS5kYXRhKCkpOwotICAgIGlmIChtX2lzRW5kUmVhY2hlZCAmJiBtX2lzU2Vla2luZykK KyAgICBpZiAobV9pc1NlZWtpbmcpCiAgICAgICAgIHJldHVybiBtX3NlZWtUaW1lOworICAgIGlm IChtX2lzRW5kUmVhY2hlZCkKKyAgICAgICAgcmV0dXJuIG1fcGxheWJhY2tSYXRlID4gMCA/IGR1 cmF0aW9uTWVkaWFUaW1lKCkgOiBNZWRpYVRpbWU6Onplcm9UaW1lKCk7CiAKICAgICAvLyBUaGlz IGNvbnN0YW50IHNob3VsZCByZW1haW4gbG93ZXIgdGhhbiBIVE1MTWVkaWFFbGVtZW50J3MgbWF4 VGltZXVwZGF0ZUV2ZW50RnJlcXVlbmN5LgogICAgIHN0YXRpYyBjb25zdCBTZWNvbmRzIHBvc2l0 aW9uQ2FjaGVUaHJlc2hvbGQgPSAyMDBfbXM7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTI2NDljN2JlYjE2NWQwMjkyYmY5 YTlkNTAyNjhlNGJlOTgwYWFjMi4uOTQzOWYyYTIyZTVhNzA2NDY5ZjBkMjlhNDg3ZjMwZTJkZjQ3 MWEwZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTI5ICBBbGljaWEgQm95YSBHYXJj w61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBWaWRlbyBsb29w cyB3aGVuIHJhbiBpbiByciByZWNvcmQgLS1jaGFvcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9t ZWRpYS1zb3VyY2UvbWVkaWFzb3VyY2UtZ2V0dmlkZW9wbGF5YmFja3F1YWxpdHkuaHRtbAorICAg ICAgICBpcyBub3cgcGFzc2luZy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0 YXRpb25zOgorCiAyMDIwLTA0LTA5ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBSZXdvcmsgV2ViS2l0V2ViU3JjIHRocmVhZGlu ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA0MmZjMmQ0 ZWYwZTlmNmU3OTVmN2NmNzdlMmQ0NDI2OTgzYTQ2MTFhLi4wZTQ2ZWYwNWUzODI3ODVkOTkzZDQ5 YmE4ZmIwYjc5NDhmZDQxZmJlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVj dGF0aW9ucwpAQCAtMTU0OCw3ICsxNTQ4LDYgQEAgd2Via2l0Lm9yZy9iLzIwMzA3OCBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhLXNvdXJjZS9tZWRpYXNvdXJjZS1yZW0KIHdl YmtpdC5vcmcvYi8yMDMwNzggbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1yZW1vdmUt dW5sb2FkLWNyYXNoLmh0bWwgWyBQYXNzIENyYXNoIF0KIHdlYmtpdC5vcmcvYi8yMDMwNzggbWVk aWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1zZWVrLWNvbXBsZXRlLmh0bWwgWyBQYXNzIENy YXNoIF0KIHdlYmtpdC5vcmcvYi8yMDMwNzggbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJj ZS1zZWVrLWRldGFjaC1jcmFzaC5odG1sIFsgUGFzcyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMjAz MDc4IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbWVkaWEtc291cmNlL21lZGlhc291 cmNlLWdldHZpZGVvcGxheWJhY2txdWFsaXR5Lmh0bWwgWyBGYWlsdXJlIENyYXNoIF0KIHdlYmtp dC5vcmcvYi8yMDMwNzggaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3Vy Y2UvbWVkaWFzb3VyY2UtcmVwbGF5Lmh0bWwgWyBGYWlsdXJlIENyYXNoIF0KIHdlYmtpdC5vcmcv Yi8yMDMwNzggaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3VyY2UvbWVk aWFzb3VyY2Utc2Vlay1kdXJpbmctcGVuZGluZy1zZWVrLmh0bWwgWyBQYXNzIENyYXNoIF0KIHdl YmtpdC5vcmcvYi8yMDMwNzggaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1z b3VyY2UvbWVkaWFzb3VyY2UtcmVkdW5kYW50LXNlZWsuaHRtbCBbIFBhc3MgQ3Jhc2ggXQo=