211175 2020-04-29 02:24:44 -0700 [GTK4] Add support click events 2020-04-30 04:24:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 210100 1 cgarcia webkit-unassigned aperez berto ews-watchlist gustavo webkit-bug-importer oldest_to_newest 1646928 0 cgarcia 2020-04-29 02:24:44 -0700 . 1646930 1 397948 cgarcia 2020-04-29 02:27:03 -0700 Created attachment 397948 Patch 1646931 2 ews-watchlist 2020-04-29 02:27:59 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1646961 3 397948 aperez 2020-04-29 05:17:34 -0700 Comment on attachment 397948 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397948&action=review > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:86 > struct ClickCounter { Nice to see the ClickCounter is not needed now \o/ 1647325 4 cgarcia 2020-04-30 04:23:34 -0700 Committed r260939: <https://trac.webkit.org/changeset/260939> 1647326 5 webkit-bug-importer 2020-04-30 04:24:13 -0700 <rdar://problem/62644595> 397948 2020-04-29 02:27:03 -0700 2020-04-29 05:17:34 -0700 Patch wkgtk4-clicks.diff text/plain 5724 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZTc1MjA0MWNjYzM2Li5kYTE5MWRkMTE3MTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTkgQEAKKzIwMjAtMDQtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEs0XSBBZGQgc3VwcG9ydCBjbGljayBldmVudHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTE3NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhbmRsZSBidXR0b24g cHJlc3NlZCBhbmQgcmVsZWFzZWQgZXZlbnRzIHVzaW5nIGEgR3RrR2VzdHVyZUNsaWNrLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAg ICAoQ2xpY2tDb3VudGVyOjpjdXJyZW50Q2xpY2tDb3VudEZvckdka0J1dHRvbkV2ZW50KToKKyAg ICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlQnV0dG9uUHJlc3NlZCk6CisgICAgICAgICh3ZWJraXRX ZWJWaWV3QmFzZUJ1dHRvblJlbGVhc2VkKToKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlQ29u c3RydWN0ZWQpOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VSZXNldENsaWNrQ291bnRlcik6 CisKIDIwMjAtMDQtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEs0XSBBZGQgc3VwcG9ydCBmb3Iga2V5IGV2ZW50cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApp bmRleCA2YmI0MjAwYWIyOTkuLjY3OGI5Yzc4ZjU0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTgyLDYgKzgy LDcgQEAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK IAorI2lmICFVU0UoR1RLNCkKIHN0cnVjdCBDbGlja0NvdW50ZXIgewogcHVibGljOgogICAgIHZv aWQgcmVzZXQoKQpAQCAtOTQsNyArOTUsNiBAQCBwdWJsaWM6CiAKICAgICBpbnQgY3VycmVudENs aWNrQ291bnRGb3JHZGtCdXR0b25FdmVudChHZGtFdmVudCogZXZlbnQpCiAgICAgewotI2lmICFV U0UoR1RLNCkKICAgICAgICAgaW50IGRvdWJsZUNsaWNrRGlzdGFuY2UgPSAyNTA7CiAgICAgICAg IGludCBkb3VibGVDbGlja1RpbWUgPSA1OwogICAgICAgICBnX29iamVjdF9nZXQoZ3RrX3NldHRp bmdzX2dldF9mb3Jfc2NyZWVuKGdka19ldmVudF9nZXRfc2NyZWVuKGV2ZW50KSksCkBAIC0xMzEs NyArMTMxLDYgQEAgcHVibGljOgogICAgICAgICBwcmV2aW91c0NsaWNrUG9pbnQgPSBJbnRQb2lu dCh4LCB5KTsKICAgICAgICAgcHJldmlvdXNDbGlja0J1dHRvbiA9IGJ1dHRvbjsKICAgICAgICAg cHJldmlvdXNDbGlja1RpbWUgPSBldmVudFRpbWU7Ci0jZW5kaWYKIAogICAgICAgICByZXR1cm4g Y3VycmVudENsaWNrQ291bnQ7CiAgICAgfQpAQCAtMTQyLDYgKzE0MSw3IEBAIHByaXZhdGU6CiAg ICAgdW5zaWduZWQgcHJldmlvdXNDbGlja0J1dHRvbjsKICAgICBpbnQgcHJldmlvdXNDbGlja1Rp bWU7CiB9OworI2VuZGlmCiAKIHR5cGVkZWYgSGFzaE1hcDxHdGtXaWRnZXQqLCBJbnRSZWN0PiBX ZWJLaXRXZWJWaWV3Q2hpbGRyZW5NYXA7CiB0eXBlZGVmIEhhc2hNYXA8dWludDMyX3QsIEdVbmlx dWVQdHI8R2RrRXZlbnQ+PiBUb3VjaEV2ZW50c01hcDsKQEAgLTE4MSw3ICsxODEsOSBAQCBzdHJ1 Y3QgX1dlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSB7CiAgICAgUmVmUHRyPFdlYlBhZ2VQcm94eT4g cGFnZVByb3h5OwogICAgIGJvb2wgc2hvdWxkRm9yd2FyZE5leHRLZXlFdmVudCB7IGZhbHNlIH07 CiAgICAgYm9vbCBzaG91bGRGb3J3YXJkTmV4dFdoZWVsRXZlbnQgeyBmYWxzZSB9OworI2lmICFV U0UoR1RLNCkKICAgICBDbGlja0NvdW50ZXIgY2xpY2tDb3VudGVyOworI2VuZGlmCiAgICAgQ1N0 cmluZyB0b29sdGlwVGV4dDsKICAgICBJbnRSZWN0IHRvb2x0aXBBcmVhOwogICAgIEdSZWZQdHI8 QXRrT2JqZWN0PiBhY2Nlc3NpYmxlOwpAQCAtMTAyNyw3ICsxMDI5LDQ4IEBAIHN0YXRpYyBnYm9v bGVhbiB3ZWJraXRXZWJWaWV3QmFzZUJ1dHRvblJlbGVhc2VFdmVudChHdGtXaWRnZXQqIHdpZGdl dCwgR2RrRXZlbnRCCiAKICAgICByZXR1cm4gR0RLX0VWRU5UX1NUT1A7CiB9CisjZW5kaWYKKwor I2lmIFVTRShHVEs0KQorc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VCdXR0b25QcmVzc2Vk KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgaW50IGNsaWNrQ291bnQsIGRvdWJsZSB4 LCBkb3VibGUgeSwgR3RrR2VzdHVyZSogZ2VzdHVyZSkKK3sKKyAgICBXZWJLaXRXZWJWaWV3QmFz ZVByaXZhdGUqIHByaXYgPSB3ZWJWaWV3QmFzZS0+cHJpdjsKKyAgICBpZiAocHJpdi0+ZGlhbG9n KQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoY2xpY2tDb3VudCA9PSAxKQorICAgICAgICBw cml2LT5pbnB1dE1ldGhvZEZpbHRlci5jYW5jZWxDb21wb3NpdGlvbigpOworICAgIGd0a193aWRn ZXRfZ3JhYl9mb2N1cyhHVEtfV0lER0VUKHdlYlZpZXdCYXNlKSk7CisKKyAgICBhdXRvKiBzZXF1 ZW5jZSA9IGd0a19nZXN0dXJlX3NpbmdsZV9nZXRfY3VycmVudF9zZXF1ZW5jZShHVEtfR0VTVFVS RV9TSU5HTEUoZ2VzdHVyZSkpOworICAgIGd0a19nZXN0dXJlX3NldF9zZXF1ZW5jZV9zdGF0ZShn ZXN0dXJlLCBzZXF1ZW5jZSwgR1RLX0VWRU5UX1NFUVVFTkNFX0NMQUlNRUQpOworCisgICAgYXV0 byBidXR0b24gPSBndGtfZ2VzdHVyZV9zaW5nbGVfZ2V0X2N1cnJlbnRfYnV0dG9uKEdUS19HRVNU VVJFX1NJTkdMRShnZXN0dXJlKSk7CisgICAgYXV0byogZXZlbnQgPSBndGtfZ2VzdHVyZV9nZXRf bGFzdF9ldmVudChnZXN0dXJlLCBzZXF1ZW5jZSk7CisKKyAgICAvLyBJZiBpdCdzIGEgcmlnaHQg Y2xpY2sgZXZlbnQgc2F2ZSBpdCBhcyBhIHBvc3NpYmxlIGNvbnRleHQgbWVudSBldmVudC4KKyAg ICBpZiAoYnV0dG9uID09IEdES19CVVRUT05fU0VDT05EQVJZKQorICAgICAgICBwcml2LT5jb250 ZXh0TWVudUV2ZW50LnJlc2V0KGdka19ldmVudF9jb3B5KGV2ZW50KSk7CisKKyAgICBwcml2LT5w YWdlUHJveHktPmhhbmRsZU1vdXNlRXZlbnQoTmF0aXZlV2ViTW91c2VFdmVudChldmVudCwgeyBj bGFtcFRvSW50ZWdlcih4KSwgY2xhbXBUb0ludGVnZXIoeSkgfSwgY2xpY2tDb3VudCwgV1RGOjpu dWxsb3B0KSk7Cit9CisKK3N0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlQnV0dG9uUmVsZWFz ZWQoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlLCBpbnQgY2xpY2tDb3VudCwgZG91Ymxl IHgsIGRvdWJsZSB5LCBHdGtHZXN0dXJlKiBnZXN0dXJlKQoreworICAgIFdlYktpdFdlYlZpZXdC YXNlUHJpdmF0ZSogcHJpdiA9IHdlYlZpZXdCYXNlLT5wcml2OworICAgIGlmIChwcml2LT5kaWFs b2cpCisgICAgICAgIHJldHVybjsKKworICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhHVEtfV0lE R0VUKHdlYlZpZXdCYXNlKSk7CiAKKyAgICBhdXRvKiBzZXF1ZW5jZSA9IGd0a19nZXN0dXJlX3Np bmdsZV9nZXRfY3VycmVudF9zZXF1ZW5jZShHVEtfR0VTVFVSRV9TSU5HTEUoZ2VzdHVyZSkpOwor ICAgIGd0a19nZXN0dXJlX3NldF9zZXF1ZW5jZV9zdGF0ZShnZXN0dXJlLCBzZXF1ZW5jZSwgR1RL X0VWRU5UX1NFUVVFTkNFX0NMQUlNRUQpOworCisgICAgcHJpdi0+cGFnZVByb3h5LT5oYW5kbGVN b3VzZUV2ZW50KE5hdGl2ZVdlYk1vdXNlRXZlbnQoZ3RrX2dlc3R1cmVfZ2V0X2xhc3RfZXZlbnQo Z2VzdHVyZSwgc2VxdWVuY2UpLCB7IGNsYW1wVG9JbnRlZ2VyKHgpLCBjbGFtcFRvSW50ZWdlcih5 KSB9LCBjbGlja0NvdW50LCBXVEY6Om51bGxvcHQpKTsKK30KKyNlbmRpZgorCisjaWYgIVVTRShH VEs0KQogc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VIYW5kbGVXaGVlbEV2ZW50KFdlYktp dFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgR2RrRXZlbnQqIGV2ZW50LCBPcHRpb25hbDxXZWJX aGVlbEV2ZW50OjpQaGFzZT4gcGhhc2UgPSBXVEY6Om51bGxvcHQsIE9wdGlvbmFsPFdlYldoZWVs RXZlbnQ6OlBoYXNlPiBtb21lbnR1bSA9IFdURjo6bnVsbG9wdCkKIHsKICAgICBWaWV3R2VzdHVy ZUNvbnRyb2xsZXIqIGNvbnRyb2xsZXIgPSB3ZWJraXRXZWJWaWV3QmFzZVZpZXdHZXN0dXJlQ29u dHJvbGxlcih3ZWJWaWV3QmFzZSk7CkBAIC0xNjYxLDYgKzE3MDQsMTIgQEAgc3RhdGljIHZvaWQg d2Via2l0V2ViVmlld0Jhc2VDb25zdHJ1Y3RlZChHT2JqZWN0KiBvYmplY3QpCiAgICAgZ19zaWdu YWxfY29ubmVjdF9vYmplY3QoY29udHJvbGxlciwgImtleS1wcmVzc2VkIiwgR19DQUxMQkFDSyh3 ZWJraXRXZWJWaWV3QmFzZUtleVByZXNzZWQpLCB2aWV3V2lkZ2V0LCBHX0NPTk5FQ1RfU1dBUFBF RCk7CiAgICAgZ19zaWduYWxfY29ubmVjdF9vYmplY3QoY29udHJvbGxlciwgImtleS1yZWxlYXNl ZCIsIEdfQ0FMTEJBQ0sod2Via2l0V2ViVmlld0Jhc2VLZXlSZWxlYXNlZCksIHZpZXdXaWRnZXQs IEdfQ09OTkVDVF9TV0FQUEVEKTsKICAgICBndGtfd2lkZ2V0X2FkZF9jb250cm9sbGVyKHZpZXdX aWRnZXQsIGNvbnRyb2xsZXIpOworCisgICAgYXV0byogZ2VzdHVyZSA9IGd0a19nZXN0dXJlX2Ns aWNrX25ldygpOworICAgIGd0a19nZXN0dXJlX3NpbmdsZV9zZXRfYnV0dG9uKEdUS19HRVNUVVJF X1NJTkdMRShnZXN0dXJlKSwgMCk7CisgICAgZ19zaWduYWxfY29ubmVjdF9vYmplY3QoZ2VzdHVy ZSwgInByZXNzZWQiLCBHX0NBTExCQUNLKHdlYmtpdFdlYlZpZXdCYXNlQnV0dG9uUHJlc3NlZCks IHZpZXdXaWRnZXQsIEdfQ09OTkVDVF9TV0FQUEVEKTsKKyAgICBnX3NpZ25hbF9jb25uZWN0X29i amVjdChnZXN0dXJlLCAicmVsZWFzZWQiLCBHX0NBTExCQUNLKHdlYmtpdFdlYlZpZXdCYXNlQnV0 dG9uUmVsZWFzZWQpLCB2aWV3V2lkZ2V0LCBHX0NPTk5FQ1RfU1dBUFBFRCk7CisgICAgZ3RrX3dp ZGdldF9hZGRfY29udHJvbGxlcih2aWV3V2lkZ2V0LCBHVEtfRVZFTlRfQ09OVFJPTExFUihnZXN0 dXJlKSk7CiAjZW5kaWYKIH0KIApAQCAtMTk1NCw3ICsyMDAzLDkgQEAgdm9pZCB3ZWJraXRXZWJW aWV3QmFzZVNldENvbnRlbnRzU2l6ZShXZWJLaXRXZWJWaWV3QmFzZSogd2Via2l0V2ViVmlld0Jh c2UsIGNvbnMKIAogdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVJlc2V0Q2xpY2tDb3VudGVyKFdlYktp dFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFzZSkKIHsKKyNpZiAhVVNFKEdUSzQpCiAgICAg d2Via2l0V2ViVmlld0Jhc2UtPnByaXYtPmNsaWNrQ291bnRlci5yZXNldCgpOworI2VuZGlmCiB9 CiAKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2Rl KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFzZSwgY29uc3QgTGF5ZXJUcmVlQ29u dGV4dCYgbGF5ZXJUcmVlQ29udGV4dCkK