211169 2020-04-29 00:40:32 -0700 Update SWServer.cpp originURL after https://trac.webkit.org/changeset/260707 2020-05-01 10:54:31 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210431 InRadar P2 Normal --- 1 youennf youennf achristensen ap cdumez cturner darin koivisto webkit-bug-importer oldest_to_newest 1646895 0 youennf 2020-04-29 00:40:32 -0700 Update SWServer.cpp originURL after https://trac.webkit.org/changeset/260707 1646896 1 397938 youennf 2020-04-29 00:52:47 -0700 Created attachment 397938 Patch 1646897 2 youennf 2020-04-29 00:53:10 -0700 <<rdar://problem/62541423>> 1646903 3 youennf 2020-04-29 01:01:28 -0700 We could write an API test, but we would need to run a server on port 80 or 443. Not sure whether that is fine. 1647035 4 ews-feeder 2020-04-29 09:55:13 -0700 Committed r260902: <https://trac.webkit.org/changeset/260902> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397938. 1647084 5 397938 darin 2020-04-29 11:40:43 -0700 Comment on attachment 397938 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397938&action=review > Source/WebCore/workers/service/server/SWServer.cpp:430 > - url.setPort(*origin.port()); > + url.setPort(origin.port()); Thanks for fixing this for me. Sorry I got it wrong! 1647921 6 youennf 2020-05-01 10:54:31 -0700 *** Bug 211233 has been marked as a duplicate of this bug. *** 397938 2020-04-29 00:52:47 -0700 2020-04-29 09:55:14 -0700 Patch bug-211169-20200429095245.patch text/plain 1366 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRmNmY4ZjgyOTFiMmY4 NzcwZWMzNTYzZWY0ZGZkYzM5MDJiNWZhNi4uYjBmODViNjA1MzBhNDBhYjJmYzgzN2I2ODYyY2Zk MjAzMWYxMjc5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA0LTI5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgU1dTZXJ2ZXIu Y3BwIG9yaWdpblVSTCBhZnRlciBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjYw NzA3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEx NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdv cmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6b3Jp Z2luVVJMKToKKyAgICAgICAgTm8gbmVlZCB0byBkZXJlZmVyZW5jZSBwb3J0IHNpbmNlIFVSTDo6 c2V0UG9ydCB0YWtlcyBhbiBPcHRpb25hbC4KKwogMjAyMC0wNC0yOCAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRGVsYXkgU3lzdGVtQXR0cmlidXRpb24gY2Fs bCBmcm9tIHByb2Nlc3MgbGF1bmNoIHRvIHdoZW4gYmVpbmcgdXNlZnVsCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4IGEzZjcw NmI5YTdjZGQyODIwMjYwODUzYTBhMTk3NzQ4M2IwNjEyYTcuLjg0ZDI0N2MxZTA3ZGM2N2NiN2Iz ZDFlYmI2ODFlYTI3MWMwZmE4NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv c2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv c2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC00MjcsNyArNDI3LDcgQEAgVVJMIHN0YXRp YyBpbmxpbmUgb3JpZ2luVVJMKGNvbnN0IFNlY3VyaXR5T3JpZ2luJiBvcmlnaW4pCiAgICAgVVJM IHVybDsKICAgICB1cmwuc2V0UHJvdG9jb2wob3JpZ2luLnByb3RvY29sKCkpOwogICAgIHVybC5z ZXRIb3N0KG9yaWdpbi5ob3N0KCkpOwotICAgIHVybC5zZXRQb3J0KCpvcmlnaW4ucG9ydCgpKTsK KyAgICB1cmwuc2V0UG9ydChvcmlnaW4ucG9ydCgpKTsKICAgICByZXR1cm4gdXJsOwogfQogCg==