211158 2020-04-28 17:51:01 -0700 check-webkit-style should suggest CheckedSize for Checked<size_t, RecordOverflow> 2020-04-28 20:00:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210461 InRadar P2 Normal --- 1 ddkilzer ddkilzer darin ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1646782 0 ddkilzer 2020-04-28 17:51:01 -0700 check-webkit-style should suggest CheckedSize for Checked<size_t, RecordOverflow>. 1646784 1 397915 ddkilzer 2020-04-28 17:56:01 -0700 Created attachment 397915 Patch v1 1646804 2 397915 ddkilzer 2020-04-28 19:57:09 -0700 Comment on attachment 397915 Patch v1 Marking cq+ since the Windnows build and api-ios tests aren't affected by this check-webkit-style change. 1646806 3 ews-feeder 2020-04-28 19:59:57 -0700 Committed r260860: <https://trac.webkit.org/changeset/260860> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397915. 1646807 4 webkit-bug-importer 2020-04-28 20:00:18 -0700 <rdar://problem/62569082> 397915 2020-04-28 17:56:01 -0700 2020-04-28 19:59:57 -0700 Patch v1 bug-211158-20200428175831.patch text/plain 4854 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDYxNWIyYWY1YjcyMWEzYTNiYjg3MGNiNjUwZjBiYjdj MTQ3ZTNkZC4uNTE3MDA0MTkxNDMyZDllMTBlZWU0OGUyNjk5YTU0ZDA3YzlkMGRjMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTA0LTI4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCBzdWdnZXN0IENoZWNrZWRTaXplIGZvciBD aGVja2VkPHNpemVfdCwgUmVjb3JkT3ZlcmZsb3c+CisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8yMTExNTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAg KGNoZWNrX3d0Zl9jaGVja2VkX3NpemUpOiBBZGQgY2hlY2tlci4KKyAgICAgICAgKGNoZWNrX3N0 eWxlKTogQ2FsbCBjaGVja193dGZfY2hlY2tlZF9zaXplKCkgdG8gY2hlY2suCisgICAgICAgIChD cHBDaGVja2VyKTogQWRkICdydW50aW1lL3d0Zl9jaGVja2VkX3NpemUnLgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAo V2ViS2l0U3R5bGVUZXN0LnRlc3Rfd3RmX2NoZWNrZWRfc2l6ZSk6IEFkZCB0ZXN0cy4KKwogMjAy MC0wNC0yOCAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAg ICAgICBDcmVhdGUgYSBtZWNoYW5pc20gdG8gYWRkIG1pc3NpbmcgSVRQIERhdGFiYXNlIHRhYmxl cyB3aGVuIHRoZSBzY2hlbWEgaXMgdXBkYXRlZApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA0MDM4NmY0OTgxYjY0YmQzYmZhNjEyZTE2YTVjNGE2 ZjUxOGIzYzYyLi5kM2JiMWEyNjQyNjdjMDgxNmZiMTZlMjY5MjMwZjNhZTc5MzE3ZDg0IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjQ3Myw2 ICsyNDczLDMwIEBAIGRlZiBjaGVja19tYXhfbWluX21hY3JvcyhjbGVhbl9saW5lcywgbGluZV9u dW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToKICAgICAgICAgICAlIChtYXhfbWluX21hY3JvX2xv d2VyLCBtYXhfbWluX21hY3JvX2xvd2VyLCBtYXhfbWluX21hY3JvKSkKIAogCitkZWYgY2hlY2tf d3RmX2NoZWNrZWRfc2l6ZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVy cm9yKToKKyAgICAiIiJMb29rcyBmb3IgdXNlIG9mICdDaGVja2VkPHNpemVfdCwgUmVjb3JkT3Zl cmZsb3c+JyB3aGljaCBzaG91bGQgYmUgcmVwbGFjZWQgd2l0aCAnQ2hlY2tlZFNpemUnLgorCisg ICAgQXJnczoKKyAgICAgIGNsZWFuX2xpbmVzOiBBIENsZWFuc2VkTGluZXMgaW5zdGFuY2UgY29u dGFpbmluZyB0aGUgZmlsZS4KKyAgICAgIGxpbmVfbnVtYmVyOiBUaGUgbnVtYmVyIG9mIHRoZSBs aW5lIHRvIGNoZWNrLgorICAgICAgZmlsZV9zdGF0ZTogQSBfRmlsZVN0YXRlIGluc3RhbmNlIHdo aWNoIG1haW50YWlucyBpbmZvcm1hdGlvbiBhYm91dAorICAgICAgICAgICAgICAgICAgdGhlIHN0 YXRlIG9mIHRoaW5ncyBpbiB0aGUgZmlsZS4KKyAgICAgIGVycm9yOiBUaGUgZnVuY3Rpb24gdG8g Y2FsbCB3aXRoIGFueSBlcnJvcnMgZm91bmQuCisgICAgIiIiCisKKyAgICBpZiBmaWxlX3N0YXRl LmlzX2Nfb3Jfb2JqZWN0aXZlX2MoKToKKyAgICAgICAgcmV0dXJuCisKKyAgICBsaW5lID0gY2xl YW5fbGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyXQorCisgICAgdXNpbmdfY2hlY2tlZF9zaXplX3Jl Y29yZF9vdmVyZmxvdyA9IHNlYXJjaChyJ1xiQ2hlY2tlZFxzKjxccypzaXplX3QsXHMqUmVjb3Jk T3ZlcmZsb3dccyo+XHMqKFxifFwoKScsIGxpbmUpCisgICAgaWYgbm90IHVzaW5nX2NoZWNrZWRf c2l6ZV9yZWNvcmRfb3ZlcmZsb3c6CisgICAgICAgIHJldHVybgorCisgICAgZXJyb3IobGluZV9u dW1iZXIsICdydW50aW1lL3d0Zl9jaGVja2VkX3NpemUnLCA1LAorICAgICAgICAgICJVc2UgJ0No ZWNrZWRTaXplJyBpbnN0ZWFkIG9mICdDaGVja2VkPHNpemVfdCwgUmVjb3JkT3ZlcmZsb3c+Jy4i KQorCisKIGRlZiBjaGVja193dGZfbW92ZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVf c3RhdGUsIGVycm9yKToKICAgICAiIiJMb29rcyBmb3IgdXNlIG9mICdzdGQ6Om1vdmUoKScgd2hp Y2ggc2hvdWxkIGJlIHJlcGxhY2VkIHdpdGggJ1dURk1vdmUoKScuCiAKQEAgLTMxNDMsNiArMzE2 Nyw3IEBAIGRlZiBjaGVja19zdHlsZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0 ZW5zaW9uLCBjbGFzc19zdGF0ZSwgZmlsZV9zdGF0CiAgICAgY2hlY2tfdXNpbmdfc3RkKGNsZWFu X2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfdXNpbmdf bmFtZXNwYWNlKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNpb24sIGVycm9y KQogICAgIGNoZWNrX21heF9taW5fbWFjcm9zKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmls ZV9zdGF0ZSwgZXJyb3IpCisgICAgY2hlY2tfd3RmX2NoZWNrZWRfc2l6ZShjbGVhbl9saW5lcywg bGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKQogICAgIGNoZWNrX3d0Zl9tb3ZlKGNsZWFu X2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfd3RmX29w dGlvbmFsKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAgICAg Y2hlY2tfd3RmX21ha2VfdW5pcXVlKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0 ZSwgZXJyb3IpCkBAIC00MzI1LDYgKzQzNTAsNyBAQCBjbGFzcyBDcHBDaGVja2VyKG9iamVjdCk6 CiAgICAgICAgICdydW50aW1lL3RocmVhZHNhZmVfZm4nLAogICAgICAgICAncnVudGltZS91bnNp Z25lZCcsCiAgICAgICAgICdydW50aW1lL3ZpcnR1YWwnLAorICAgICAgICAncnVudGltZS93dGZf Y2hlY2tlZF9zaXplJywKICAgICAgICAgJ3J1bnRpbWUvd3RmX29wdGlvbmFsJywKICAgICAgICAg J3J1bnRpbWUvd3RmX21ha2VfdW5pcXVlJywKICAgICAgICAgJ3J1bnRpbWUvd3RmX21vdmUnLApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQppbmRleCA4MjY1ZDQ4MzhkZGQzNDM3ZTRkOTA3OWYxYjU5NGNiNzdmODg2NTkwLi4w N2Y2MTMwZjNjNGVmOGVlYjY4ZWE4MjI5OTEwZjMxNGY3YTZkNWY3IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAt NTQzMiw2ICs1NDMyLDMxIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNl KToKICAgICAgICAgICAgICcgIFtydW50aW1lL21heF9taW5fbWFjcm9zXSBbNF0nLAogICAgICAg ICAgICAgJ2Zvby5oJykKIAorICAgIGRlZiB0ZXN0X3d0Zl9jaGVja2VkX3NpemUoc2VsZik6Cisg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnQ2hlY2tlZFNpemUgdG90YWxT aXplID0gYmFyU2l6ZTtcbicKKyAgICAgICAgICAgICd0b3RhbFNpemUgKz0gYmF6U2l6ZTsnLAor ICAgICAgICAgICAgJycsCisgICAgICAgICAgICAnZm9vLmNwcCcpCisKKyAgICAgICAgc2VsZi5h c3NlcnRfbGludCgKKyAgICAgICAgICAgICdhdXRvIHRvdGFsU2l6ZSA9IENoZWNrZWRTaXplKGJh clNpemUpICsgYmF6U2l6ZTsnLAorICAgICAgICAgICAgJycsCisgICAgICAgICAgICAnZm9vLmNw cCcpCisKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdDaGVja2VkPHNp emVfdCwgUmVjb3JkT3ZlcmZsb3c+IHRvdGFsU2l6ZSA9IGJhclNpemU7XG4nCisgICAgICAgICAg ICAndG90YWxTaXplICs9IGJhelNpemU7JywKKyAgICAgICAgICAgICJVc2UgJ0NoZWNrZWRTaXpl JyBpbnN0ZWFkIG9mICdDaGVja2VkPHNpemVfdCwgUmVjb3JkT3ZlcmZsb3c+Jy4iCisgICAgICAg ICAgICAiICBbcnVudGltZS93dGZfY2hlY2tlZF9zaXplXSBbNV0iLAorICAgICAgICAgICAgJ2Zv by5jcHAnKQorCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnYXV0byB0 b3RhbFNpemUgPSBDaGVja2VkPHNpemVfdCwgUmVjb3JkT3ZlcmZsb3c+KGJhclNpemUpICsgYmF6 U2l6ZTsnLAorICAgICAgICAgICAgIlVzZSAnQ2hlY2tlZFNpemUnIGluc3RlYWQgb2YgJ0NoZWNr ZWQ8c2l6ZV90LCBSZWNvcmRPdmVyZmxvdz4nLiIKKyAgICAgICAgICAgICIgIFtydW50aW1lL3d0 Zl9jaGVja2VkX3NpemVdIFs1XSIsCisgICAgICAgICAgICAnZm9vLmNwcCcpCisKICAgICBkZWYg dGVzdF93dGZfbWFrZV91bmlxdWUoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAg ICAgICAgICAgICAgJ3N0ZDo6dW5pcXVlX3B0cjxGb28+IGZvbyA9IFdURjo6bWFrZVVuaXF1ZTxG b28+KCk7JywK