211154 2020-04-28 16:20:44 -0700 REGRESSION (r260243): [ Mac WK1 ] fast/media/mq-inverted-colors-live-update-for-listener.html is a flaky failure 2020-05-01 12:42:51 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203288 InRadar P2 Normal --- 1 tsavell cdumez achristensen ashvayka cdumez darin eric.carlson esprehn+autocc ews-watchlist ggaren glenn gyuyoung.kim jer.noble koivisto kondapallykalyan macpherson menard philipj sergio webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1646731 0 tsavell 2020-04-28 16:20:44 -0700 fast/media/mq-inverted-colors-live-update-for-listener.html This test began flaky failing with https://trac.webkit.org/changeset/260243/webkit I am able to reproduce this using command: run-webkit-tests --iterations 2000 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --debug-rwt-logging --no-retry --force --no-build -f -1 fast/media/mq-inverted-colors-live-update-for-listener.html I can reproduce this on 260243 but not on 260241 History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fmedia%2Fmq-inverted-colors-live-update-for-listener.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/fast/media/mq-inverted-colors-live-update-for-listener-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/fast/media/mq-inverted-colors-live-update-for-listener-actual.txt @@ -3,9 +3,10 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS didCallListener is true +FAIL didCallListener should be true. Was false. PASS matchMedia("(inverted-colors)").matches is true PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1646734 1 webkit-bug-importer 2020-04-28 16:21:56 -0700 <rdar://problem/62555128> 1647085 2 ashvayka 2020-04-29 11:41:54 -0700 (In reply to Truitt Savell from comment #0) > History: > https://results.webkit.org/?suite=layout-tests&test=fast%2Fmedia%2Fmq-inverted-colors-live-update-for-listener.html Thank you tracking this down, Truitt! https://results.webkit.org/?suite=layout-tests&test=fast%2Fmedia%2Fmq-prefers-reduced-motion-live-update-for-listener.html is also flaky failing, yet https://results.webkit.org/?suite=layout-tests&test=fast%2Fmedia%2Fmq-prefers-reduced-motion-matchMedia.html is all green. The crucial difference between them is that latter references MQL instance inside addListener() callback, while former doesn't. All points to GC issue Darin mentioned in https://bugs.webkit.org/show_bug.cgi?id=203288#c19. 1647613 3 cdumez 2020-04-30 15:55:09 -0700 Will fix this. 1647624 4 ashvayka 2020-04-30 16:11:45 -0700 (In reply to Chris Dumez from comment #3) > Will fix this. Chris, I am on it: we should make MediaQueryList an ActiveDOMObject. 1647625 5 cdumez 2020-04-30 16:12:20 -0700 (In reply to Alexey Shvayka from comment #4) > (In reply to Chris Dumez from comment #3) > > Will fix this. > > Chris, I am on it: we should make MediaQueryList an ActiveDOMObject. I have the patch ready. The radar was assigned to me as P1, sorry. 1647627 6 398114 cdumez 2020-04-30 16:14:01 -0700 Created attachment 398114 Patch 1647633 7 ashvayka 2020-04-30 16:19:37 -0700 (In reply to Chris Dumez from comment #5) > I have the patch ready. The radar was assigned to me as P1, sorry. No problem. http://webkit.org/b/209862 seems to be failing the same ASSERT. 1647640 8 398114 ashvayka 2020-04-30 16:26:12 -0700 Comment on attachment 398114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398114&action=review > Source/WebCore/css/MediaQueryList.cpp:44 > + list->suspendIfNeeded(); I wonder if we could invoke this in constructor? 1647643 9 398114 cdumez 2020-04-30 16:28:33 -0700 Comment on attachment 398114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398114&action=review >> Source/WebCore/css/MediaQueryList.cpp:44 >> + list->suspendIfNeeded(); > > I wonder if we could invoke this in constructor? It is not safe to call this in the constructor in general (although it would work for this particular class). The reason is that suspendIfNeeded() may call suspend() which may ref |this|. RefCounted has an assertion that forbids increasing the refcount before adoption. This is why this is the usual pattern for calling suspendIfNeeded() on ActiveDOMObjects. 1647654 10 ashvayka 2020-04-30 16:44:20 -0700 (In reply to Chris Dumez from comment #9) > It is not safe to call this in the constructor in general (although it would > work for this particular class). The reason is that suspendIfNeeded() may > call suspend() which may ref |this|. RefCounted has an assertion that > forbids increasing the refcount before adoption. > This is why this is the usual pattern for calling suspendIfNeeded() on > ActiveDOMObjects. Thanks for your insight! 1647985 11 ews-feeder 2020-05-01 12:42:49 -0700 Committed r261012: <https://trac.webkit.org/changeset/261012> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398114. 398114 2020-04-30 16:14:01 -0700 2020-05-01 12:42:50 -0700 Patch bug-211154-20200430161400.patch text/plain 8053 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ1MjBmMGE2MGNiMjVm MmM4NjRmN2M0ZmQxNzQ1NTBkOTc0NTdhOC4uNDFlYzVmNDcxZjJiNGIxZTI1MTI4ZDVlNGQ0MzA5 NWI1ZjhkZjczMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDIwLTA0LTMwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2MDI0 Myk6IFsgTWFjIFdLMSBdIGZhc3QvbWVkaWEvbXEtaW52ZXJ0ZWQtY29sb3JzLWxpdmUtdXBkYXRl LWZvci1saXN0ZW5lci5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTU0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS82MjU1NTEyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYWtlIE1lZGlhUXVlcnlMaXN0IGFuIEFjdGl2ZURPTU9iamVjdCBhbmQgbWFrZSBz dXJlIGl0cyBKUyB3cmFwcGVyIHN0YXlzIGFsaXZlIGFzIGxvbmcgYXMKKyAgICAgICAgaXQgbWF5 IGZpcmUgY2hhbmdlIGV2ZW50cyBhbmQgdGhlcmUgaXMgYXQgbGVhc3QgMSBjaGFuZ2UgZXZlbnQg bGlzdGVuZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBjc3MvTWVkaWFRdWVyeUxpc3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFRdWVyeUxpc3Q6Ok1lZGlhUXVlcnlMaXN0KToKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUXVlcnlMaXN0OjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFR dWVyeUxpc3Q6On5NZWRpYVF1ZXJ5TGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVF1ZXJ5 TGlzdDo6ZGV0YWNoRnJvbU1hdGNoZXIpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFRdWVyeUxp c3Q6OmV2YWx1YXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUXVlcnlMaXN0OjpzZXRNYXRj aGVzKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUXVlcnlMaXN0OjptYXRjaGVzKToKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUXVlcnlMaXN0OjpldmVudExpc3RlbmVyc0RpZENoYW5nZSk6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVF1ZXJ5TGlzdDo6YWN0aXZlRE9NT2JqZWN0TmFtZSBjb25z dCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVF1ZXJ5TGlzdDo6dmlydHVhbEhhc1BlbmRpbmdB Y3Rpdml0eSBjb25zdCk6CisgICAgICAgICogY3NzL01lZGlhUXVlcnlMaXN0Lmg6CisgICAgICAg ICogY3NzL01lZGlhUXVlcnlMaXN0LmlkbDoKKyAgICAgICAgKiBjc3MvTWVkaWFRdWVyeU1hdGNo ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFRdWVyeU1hdGNoZXI6OmRvY3VtZW50RGVz dHJveWVkKToKKwogMjAyMC0wNC0zMCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViS2l0LldlYkNvbnRlbnQgcHJvY2VzcyBjcmFzaGVzIHdoZW4gd2ViIGRl dmVsb3BlciB0b29scyBhcmUgb3BlbmVkIGluIFNhZmFyaQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL01lZGlhUXVlcnlMaXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1 ZXJ5TGlzdC5jcHAKaW5kZXggNWUyZDIzOTQ5NzcwZjNmNWNlZmU0MmQxMWVkNjJhZjY0YzAwYzlh Mi4uNjc0ZThlMWVkZDkzNjE0NjdhOWRhOWNhYjUzMTNiYzZjMWFlOWU2OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlMaXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvTWVkaWFRdWVyeUxpc3QuY3BwCkBAIC0yOCwyNCArMjgsMzIgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogV1RGX01BS0VfSVNPX0FMTE9DQVRFRF9JTVBMKE1lZGlhUXVlcnlMaXN0KTsKIAog TWVkaWFRdWVyeUxpc3Q6Ok1lZGlhUXVlcnlMaXN0KERvY3VtZW50JiBkb2N1bWVudCwgTWVkaWFR dWVyeU1hdGNoZXImIG1hdGNoZXIsIFJlZjxNZWRpYVF1ZXJ5U2V0PiYmIG1lZGlhLCBib29sIG1h dGNoZXMpCi0gICAgOiBDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcigmZG9jdW1lbnQpCi0gICAg LCBtX21hdGNoZXIobWF0Y2hlcikKKyAgICA6IEFjdGl2ZURPTU9iamVjdCgmZG9jdW1lbnQpCisg ICAgLCBtX21hdGNoZXIoJm1hdGNoZXIpCiAgICAgLCBtX21lZGlhKFdURk1vdmUobWVkaWEpKQot ICAgICwgbV9ldmFsdWF0aW9uUm91bmQobV9tYXRjaGVyLT5ldmFsdWF0aW9uUm91bmQoKSkKKyAg ICAsIG1fZXZhbHVhdGlvblJvdW5kKG1hdGNoZXIuZXZhbHVhdGlvblJvdW5kKCkpCiAgICAgLCBt X2NoYW5nZVJvdW5kKG1fZXZhbHVhdGlvblJvdW5kIC0gMSkgLy8gQW55IHZhbHVlIHRoYXQgaXMg bm90IHRoZSBzYW1lIGFzIG1fZXZhbHVhdGlvblJvdW5kIHdvdWxkIGRvLgogICAgICwgbV9tYXRj aGVzKG1hdGNoZXMpCiB7Ci0gICAgbV9tYXRjaGVyLT5hZGRNZWRpYVF1ZXJ5TGlzdCgqdGhpcyk7 CisgICAgbWF0Y2hlci5hZGRNZWRpYVF1ZXJ5TGlzdCgqdGhpcyk7CiB9CiAKIFJlZjxNZWRpYVF1 ZXJ5TGlzdD4gTWVkaWFRdWVyeUxpc3Q6OmNyZWF0ZShEb2N1bWVudCYgZG9jdW1lbnQsIE1lZGlh UXVlcnlNYXRjaGVyJiBtYXRjaGVyLCBSZWY8TWVkaWFRdWVyeVNldD4mJiBtZWRpYSwgYm9vbCBt YXRjaGVzKQogewotICAgIHJldHVybiBhZG9wdFJlZigqbmV3IE1lZGlhUXVlcnlMaXN0KGRvY3Vt ZW50LCBtYXRjaGVyLCBXVEZNb3ZlKG1lZGlhKSwgbWF0Y2hlcykpOworICAgIGF1dG8gbGlzdCA9 IGFkb3B0UmVmKCpuZXcgTWVkaWFRdWVyeUxpc3QoZG9jdW1lbnQsIG1hdGNoZXIsIFdURk1vdmUo bWVkaWEpLCBtYXRjaGVzKSk7CisgICAgbGlzdC0+c3VzcGVuZElmTmVlZGVkKCk7CisgICAgcmV0 dXJuIGxpc3Q7CiB9CiAKIE1lZGlhUXVlcnlMaXN0Ojp+TWVkaWFRdWVyeUxpc3QoKQogewotICAg IG1fbWF0Y2hlci0+cmVtb3ZlTWVkaWFRdWVyeUxpc3QoKnRoaXMpOworICAgIGlmIChtX21hdGNo ZXIpCisgICAgICAgIG1fbWF0Y2hlci0+cmVtb3ZlTWVkaWFRdWVyeUxpc3QoKnRoaXMpOworfQor Cit2b2lkIE1lZGlhUXVlcnlMaXN0OjpkZXRhY2hGcm9tTWF0Y2hlcigpCit7CisgICAgbV9tYXRj aGVyID0gbnVsbHB0cjsKIH0KIAogU3RyaW5nIE1lZGlhUXVlcnlMaXN0OjptZWRpYSgpIGNvbnN0 CkBAIC03MSw2ICs3OSwxMSBAQCB2b2lkIE1lZGlhUXVlcnlMaXN0OjpyZW1vdmVMaXN0ZW5lcihS ZWZQdHI8RXZlbnRMaXN0ZW5lcj4mJiBsaXN0ZW5lcikKIAogdm9pZCBNZWRpYVF1ZXJ5TGlzdDo6 ZXZhbHVhdGUoTWVkaWFRdWVyeUV2YWx1YXRvciYgZXZhbHVhdG9yLCBib29sJiBub3RpZmljYXRp b25OZWVkZWQpCiB7CisgICAgaWYgKCFtX21hdGNoZXIpIHsKKyAgICAgICAgbm90aWZpY2F0aW9u TmVlZGVkID0gZmFsc2U7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBpZiAobV9ldmFs dWF0aW9uUm91bmQgIT0gbV9tYXRjaGVyLT5ldmFsdWF0aW9uUm91bmQoKSkKICAgICAgICAgc2V0 TWF0Y2hlcyhldmFsdWF0b3IuZXZhbHVhdGUobV9tZWRpYS5nZXQoKSkpOwogICAgIG5vdGlmaWNh dGlvbk5lZWRlZCA9IG1fY2hhbmdlUm91bmQgPT0gbV9tYXRjaGVyLT5ldmFsdWF0aW9uUm91bmQo KTsKQEAgLTc4LDYgKzkxLDcgQEAgdm9pZCBNZWRpYVF1ZXJ5TGlzdDo6ZXZhbHVhdGUoTWVkaWFR dWVyeUV2YWx1YXRvciYgZXZhbHVhdG9yLCBib29sJiBub3RpZmljYXRpb24KIAogdm9pZCBNZWRp YVF1ZXJ5TGlzdDo6c2V0TWF0Y2hlcyhib29sIG5ld1ZhbHVlKQogeworICAgIEFTU0VSVChtX21h dGNoZXIpOwogICAgIG1fZXZhbHVhdGlvblJvdW5kID0gbV9tYXRjaGVyLT5ldmFsdWF0aW9uUm91 bmQoKTsKIAogICAgIGlmIChuZXdWYWx1ZSA9PSBtX21hdGNoZXMpCkBAIC04OSw5ICsxMDMsMjQg QEAgdm9pZCBNZWRpYVF1ZXJ5TGlzdDo6c2V0TWF0Y2hlcyhib29sIG5ld1ZhbHVlKQogCiBib29s IE1lZGlhUXVlcnlMaXN0OjptYXRjaGVzKCkKIHsKLSAgICBpZiAobV9ldmFsdWF0aW9uUm91bmQg IT0gbV9tYXRjaGVyLT5ldmFsdWF0aW9uUm91bmQoKSkKKyAgICBpZiAobV9tYXRjaGVyICYmIG1f ZXZhbHVhdGlvblJvdW5kICE9IG1fbWF0Y2hlci0+ZXZhbHVhdGlvblJvdW5kKCkpCiAgICAgICAg IHNldE1hdGNoZXMobV9tYXRjaGVyLT5ldmFsdWF0ZShtX21lZGlhLmdldCgpKSk7CiAgICAgcmV0 dXJuIG1fbWF0Y2hlczsKIH0KIAordm9pZCBNZWRpYVF1ZXJ5TGlzdDo6ZXZlbnRMaXN0ZW5lcnNE aWRDaGFuZ2UoKQoreworICAgIG1faGFzQ2hhbmdlRXZlbnRMaXN0ZW5lciA9IGhhc0V2ZW50TGlz dGVuZXJzKGV2ZW50TmFtZXMoKS5jaGFuZ2VFdmVudCk7Cit9CisKK2NvbnN0IGNoYXIqIE1lZGlh UXVlcnlMaXN0OjphY3RpdmVET01PYmplY3ROYW1lKCkgY29uc3QKK3sKKyAgICByZXR1cm4gIk1l ZGlhUXVlcnlMaXN0IjsKK30KKworYm9vbCBNZWRpYVF1ZXJ5TGlzdDo6dmlydHVhbEhhc1BlbmRp bmdBY3Rpdml0eSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1faGFzQ2hhbmdlRXZlbnRMaXN0ZW5l ciAmJiBtX21hdGNoZXI7Cit9CisKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9N ZWRpYVF1ZXJ5TGlzdC5oIGIvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlMaXN0LmgKaW5k ZXggOTYyN2I2MmYzOTI4Y2FkYjAxZmYzNTc2Njc4YjY3NTMyYjE0YjM1MS4uYjcwYWE1NTY2YmM5 NzU0MDFlN2RiZjhlNTFiNmE5NzBkYjU1ZTdmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL01lZGlhUXVlcnlMaXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlM aXN0LmgKQEAgLTE5LDcgKzE5LDcgQEAKIAogI3ByYWdtYSBvbmNlCiAKLSNpbmNsdWRlICJDb250 ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlci5oIgorI2luY2x1ZGUgIkFjdGl2ZURPTU9iamVjdC5oIgog I2luY2x1ZGUgIkV2ZW50VGFyZ2V0LmgiCiAjaW5jbHVkZSAiTWVkaWFMaXN0LmgiCiAjaW5jbHVk ZSAiTWVkaWFRdWVyeUV2YWx1YXRvci5oIgpAQCAtMzIsNyArMzIsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAvLyByZXRyaWV2ZSB0aGUgY3VycmVudCB2YWx1ZSBvZiB0aGUgZ2l2ZW4gbWVkaWEg cXVlcnkgYW5kIHRvIGFkZC9yZW1vdmUgbGlzdGVuZXJzIHRoYXQKIC8vIHdpbGwgYmUgY2FsbGVk IHdoZW5ldmVyIHRoZSB2YWx1ZSBvZiB0aGUgcXVlcnkgY2hhbmdlcy4KIAotY2xhc3MgTWVkaWFR dWVyeUxpc3QgZmluYWwgOiBwdWJsaWMgUmVmQ291bnRlZDxNZWRpYVF1ZXJ5TGlzdD4sIHB1Ymxp YyBFdmVudFRhcmdldFdpdGhJbmxpbmVEYXRhLCBwdWJsaWMgQ2FuTWFrZVdlYWtQdHI8TWVkaWFR dWVyeUxpc3Q+LCBwcml2YXRlIENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyIHsKK2NsYXNzIE1l ZGlhUXVlcnlMaXN0IGZpbmFsIDogcHVibGljIFJlZkNvdW50ZWQ8TWVkaWFRdWVyeUxpc3Q+LCBw dWJsaWMgRXZlbnRUYXJnZXRXaXRoSW5saW5lRGF0YSwgcHVibGljIENhbk1ha2VXZWFrUHRyPE1l ZGlhUXVlcnlMaXN0PiwgcHVibGljIEFjdGl2ZURPTU9iamVjdCB7CiAgICAgV1RGX01BS0VfSVNP X0FMTE9DQVRFRChNZWRpYVF1ZXJ5TGlzdCk7CiBwdWJsaWM6CiAgICAgc3RhdGljIFJlZjxNZWRp YVF1ZXJ5TGlzdD4gY3JlYXRlKERvY3VtZW50JiwgTWVkaWFRdWVyeU1hdGNoZXImLCBSZWY8TWVk aWFRdWVyeVNldD4mJiwgYm9vbCBtYXRjaGVzKTsKQEAgLTQ2LDYgKzQ2LDggQEAgcHVibGljOgog CiAgICAgdm9pZCBldmFsdWF0ZShNZWRpYVF1ZXJ5RXZhbHVhdG9yJiwgYm9vbCYgbm90aWZpY2F0 aW9uTmVlZGVkKTsKIAorICAgIHZvaWQgZGV0YWNoRnJvbU1hdGNoZXIoKTsKKwogICAgIHVzaW5n IFJlZkNvdW50ZWQ6OnJlZjsKICAgICB1c2luZyBSZWZDb3VudGVkOjpkZXJlZjsKIApAQCAtNTgs MTIgKzYwLDE4IEBAIHByaXZhdGU6CiAgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0 RXhlY3V0aW9uQ29udGV4dCgpIGNvbnN0IGZpbmFsIHsgcmV0dXJuIENvbnRleHREZXN0cnVjdGlv bk9ic2VydmVyOjpzY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7IH0KICAgICB2b2lkIHJlZkV2ZW50 VGFyZ2V0KCkgZmluYWwgeyByZWYoKTsgfQogICAgIHZvaWQgZGVyZWZFdmVudFRhcmdldCgpIGZp bmFsIHsgZGVyZWYoKTsgfQorICAgIHZvaWQgZXZlbnRMaXN0ZW5lcnNEaWRDaGFuZ2UoKSBmaW5h bDsKKworICAgIC8vIEFjdGl2ZURPTU9iamVjdC4KKyAgICBjb25zdCBjaGFyKiBhY3RpdmVET01P YmplY3ROYW1lKCkgY29uc3QgZmluYWw7CisgICAgYm9vbCB2aXJ0dWFsSGFzUGVuZGluZ0FjdGl2 aXR5KCkgY29uc3QgZmluYWw7CiAKLSAgICBSZWY8TWVkaWFRdWVyeU1hdGNoZXI+IG1fbWF0Y2hl cjsKKyAgICBSZWZQdHI8TWVkaWFRdWVyeU1hdGNoZXI+IG1fbWF0Y2hlcjsKICAgICBSZWY8TWVk aWFRdWVyeVNldD4gbV9tZWRpYTsKICAgICB1bnNpZ25lZCBtX2V2YWx1YXRpb25Sb3VuZDsgLy8g SW5kaWNhdGVzIGlmIHRoZSBxdWVyeSBoYXMgYmVlbiBldmFsdWF0ZWQgYWZ0ZXIgdGhlIGxhc3Qg c3R5bGUgc2VsZWN0b3IgY2hhbmdlLgogICAgIHVuc2lnbmVkIG1fY2hhbmdlUm91bmQ7IC8vIFVz ZWQgdG8ga25vdyBpZiB0aGUgcXVlcnkgaGFzIGNoYW5nZWQgaW4gdGhlIGxhc3Qgc3R5bGUgc2Vs ZWN0b3IgY2hhbmdlLgogICAgIGJvb2wgbV9tYXRjaGVzOworICAgIGJvb2wgbV9oYXNDaGFuZ2VF dmVudExpc3RlbmVyIHsgZmFsc2UgfTsKIH07CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9NZWRpYVF1ZXJ5TGlzdC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVy eUxpc3QuaWRsCmluZGV4IDAyZWI5YzNlMWQ1NDhhNDExZjdkNmU5ODU5NzZmMmI5YTMzM2NkNWUu LjE1YTdjOWM4YjcyOGUwYTI0N2VmY2M0ZGI4ODUzMjYyNjUzMjU4NTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5TGlzdC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL01lZGlhUXVlcnlMaXN0LmlkbApAQCAtMTcsNiArMTcsNyBAQAogICogIEJvc3RvbiwgTUEg MDIxMTAtMTMwMSwgVVNBLgogICovCiBbCisgICAgQWN0aXZlRE9NT2JqZWN0LAogICAgIEV4cG9z ZWQ9V2luZG93CiBdIGludGVyZmFjZSBNZWRpYVF1ZXJ5TGlzdCA6IEV2ZW50VGFyZ2V0IHsKICAg ICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIG1lZGlhOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL01lZGlhUXVlcnlNYXRjaGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9N ZWRpYVF1ZXJ5TWF0Y2hlci5jcHAKaW5kZXggOTRiYTNkMTgwYTk4NjljMDNjMDg3OTI4NzhkNTA4 YzI0YTcxZDFkOC4uNzlmN2JhMzU4Y2IxNTEzMGI1YzViMDQ1NmU4OTE0ZGE5OTZmZjJhMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlNYXRjaGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeU1hdGNoZXIuY3BwCkBAIC00OCw3ICs0OCwxMSBA QCBNZWRpYVF1ZXJ5TWF0Y2hlcjo6fk1lZGlhUXVlcnlNYXRjaGVyKCkgPSBkZWZhdWx0Owogdm9p ZCBNZWRpYVF1ZXJ5TWF0Y2hlcjo6ZG9jdW1lbnREZXN0cm95ZWQoKQogewogICAgIG1fZG9jdW1l bnQgPSBudWxscHRyOwotICAgIG1fbWVkaWFRdWVyeUxpc3RzLmNsZWFyKCk7CisgICAgYXV0byBt ZWRpYVF1ZXJ5TGlzdHMgPSBzdGQ6OmV4Y2hhbmdlKG1fbWVkaWFRdWVyeUxpc3RzLCB7IH0pOwor ICAgIGZvciAoYXV0byYgbWVkaWFRdWVyeUxpc3QgOiBtZWRpYVF1ZXJ5TGlzdHMpIHsKKyAgICAg ICAgaWYgKG1lZGlhUXVlcnlMaXN0KQorICAgICAgICAgICAgbWVkaWFRdWVyeUxpc3QtPmRldGFj aEZyb21NYXRjaGVyKCk7CisgICAgfQogfQogCiBTdHJpbmcgTWVkaWFRdWVyeU1hdGNoZXI6Om1l ZGlhVHlwZSgpIGNvbnN0Cg==