211147 2020-04-28 14:39:46 -0700 AsyncFromSyncIterator methods should not pass absent values 2020-04-29 14:43:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Minor --- 1 ashvayka ashvayka ews-watchlist joepeck keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1646682 0 ashvayka 2020-04-28 14:39:46 -0700 AsyncFromSyncIterator methods should not pass absent values 1646686 1 397887 ashvayka 2020-04-28 14:51:49 -0700 Created attachment 397887 Patch 1646690 2 397888 ashvayka 2020-04-28 15:06:25 -0700 Created attachment 397888 Patch Use ternary + @call instead of @apply. 1646696 3 397887 ross.kirsling 2020-04-28 15:24:18 -0700 Comment on attachment 397887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397887&action=review > Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:41 > - var nextResult = @getByIdDirectPrivate(this, "nextMethod").@call(syncIterator, value); > + var nextResult = @getByIdDirectPrivate(this, "nextMethod").@apply(syncIterator, arguments); This gets the job done, but the idea is just that `value` is optional, right? Using `arguments` made me think that we're expecting any number of values, before I rechecked the PR. 1646698 4 ross.kirsling 2020-04-28 15:25:03 -0700 Oops, I commented on the old patch...will mark obsolete. 1646728 5 397888 ross.kirsling 2020-04-28 16:10:06 -0700 Comment on attachment 397888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397888&action=review > Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:42 > + var nextResult = @argumentCount() === 0 ? nextMethod.@call(syncIterator) : nextMethod.@call(syncIterator, value); Seems good as long as we're meant to distinguish explicit `undefined`. 1647130 6 ashvayka 2020-04-29 13:20:09 -0700 (In reply to Ross Kirsling from comment #5) Thanks for taking a look, Ross. > Seems good as long as we're meant to distinguish explicit `undefined`. We are: the spec PR uses "is present" wording. There are a few test262 cases failing if we do `=== @undefined`, but not as many as I would like. A few more tests are coming in https://github.com/tc39/test262/pull/2604. 1647162 7 ews-feeder 2020-04-29 14:39:45 -0700 Committed r260915: <https://trac.webkit.org/changeset/260915> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397888. 1647163 8 webkit-bug-importer 2020-04-29 14:40:19 -0700 <rdar://problem/62618464> 397887 2020-04-28 14:51:49 -0700 2020-04-28 15:06:22 -0700 Patch bug-211147-20200429005147.patch text/plain 5045 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjA4NDYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIwLTA0LTI4ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBBc3luY0Zyb21TeW5jSXRlcmF0b3IgbWV0aG9kcyBzaG91 bGQgbm90IHBhc3MgYWJzZW50IHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sOiBNYXJrIDQgdGVz dCBjYXNlcyBhcyBwYXNzaW5nLgorCiAyMDIwLTA0LTI4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVr aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gTnVtYmVyQ29uc3RydWN0b3Igc2hvdWxkIGFj Y2VwdCBCaWdJbnQKSW5kZXg6IEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwJKHJldmlzaW9uIDI2 MDgxNikKKysrIEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAkod29ya2luZyBjb3B5 KQpAQCAtNzI5LDEyICs3MjksNiBAQCB0ZXN0L2J1aWx0LWlucy9BcnJheUJ1ZmZlci9wcm90b3R5 cGUvc2xpCiB0ZXN0L2J1aWx0LWlucy9BcnJheUl0ZXJhdG9yUHJvdG90eXBlL25leHQvZGV0YWNo LXR5cGVkYXJyYXktaW4tcHJvZ3Jlc3MuanM6CiAgIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4 cGVjdGVkIGEgVHlwZUVycm9yIHRvIGJlIHRocm93biBidXQgbm8gZXhjZXB0aW9uIHdhcyB0aHJv d24gYXQgYWxsIChUZXN0aW5nIHdpdGggRmxvYXQ2NEFycmF5LiknCiAgIHN0cmljdCBtb2RlOiAn VGVzdDI2MkVycm9yOiBFeHBlY3RlZCBhIFR5cGVFcnJvciB0byBiZSB0aHJvd24gYnV0IG5vIGV4 Y2VwdGlvbiB3YXMgdGhyb3duIGF0IGFsbCAoVGVzdGluZyB3aXRoIEZsb2F0NjRBcnJheS4pJwot dGVzdC9idWlsdC1pbnMvQXN5bmNGcm9tU3luY0l0ZXJhdG9yUHJvdG90eXBlL25leHQvYWJzZW50 LXZhbHVlLW5vdC1wYXNzZWQuanM6Ci0gIGRlZmF1bHQ6ICdUZXN0MjYyOkFzeW5jVGVzdEZhaWx1 cmU6VGVzdDI2MkVycm9yOiBUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCqzHCuywg wqswwrspIHRvIGJlIHRydWUnCi0gIHN0cmljdCBtb2RlOiAnVGVzdDI2MjpBc3luY1Rlc3RGYWls dXJlOlRlc3QyNjJFcnJvcjogVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqsxwrss IMKrMMK7KSB0byBiZSB0cnVlJwotdGVzdC9idWlsdC1pbnMvQXN5bmNGcm9tU3luY0l0ZXJhdG9y UHJvdG90eXBlL3JldHVybi9hYnNlbnQtdmFsdWUtbm90LXBhc3NlZC5qczoKLSAgZGVmYXVsdDog J1Rlc3QyNjI6QXN5bmNUZXN0RmFpbHVyZTpUZXN0MjYyRXJyb3I6IFRlc3QyNjJFcnJvcjogRXhw ZWN0ZWQgU2FtZVZhbHVlKMKrMcK7LCDCqzDCuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0IG1vZGU6 ICdUZXN0MjYyOkFzeW5jVGVzdEZhaWx1cmU6VGVzdDI2MkVycm9yOiBUZXN0MjYyRXJyb3I6IEV4 cGVjdGVkIFNhbWVWYWx1ZSjCqzHCuywgwqswwrspIHRvIGJlIHRydWUnCiB0ZXN0L2J1aWx0LWlu cy9Bc3luY0dlbmVyYXRvclByb3RvdHlwZS9yZXR1cm4vcmV0dXJuLXN1c3BlbmRlZFlpZWxkLXBy b21pc2UuanM6CiAgIGRlZmF1bHQ6ICdUZXN0MjYyOkFzeW5jVGVzdEZhaWx1cmU6VGVzdDI2MkVy cm9yOiBUZXN0MjYyRXJyb3I6IEFzeW5jR2VuZXJhdG9yUmVzb2x2ZShnZW5lcmF0b3IsIHJlc3Vs dFZhbHVlLCB0cnVlKSBFeHBlY3RlZCBTYW1lVmFsdWUowqtbb2JqZWN0IFByb21pc2VdwrssIMKr dW53cmFwcGVkLXZhbHVlwrspIHRvIGJlIHRydWUnCiAgIHN0cmljdCBtb2RlOiAnVGVzdDI2MjpB c3luY1Rlc3RGYWlsdXJlOlRlc3QyNjJFcnJvcjogVGVzdDI2MkVycm9yOiBBc3luY0dlbmVyYXRv clJlc29sdmUoZ2VuZXJhdG9yLCByZXN1bHRWYWx1ZSwgdHJ1ZSkgRXhwZWN0ZWQgU2FtZVZhbHVl KMKrW29iamVjdCBQcm9taXNlXcK7LCDCq3Vud3JhcHBlZC12YWx1ZcK7KSB0byBiZSB0cnVlJwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjA4MTYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMjAtMDQtMjggIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisg ICAgICAgIEFzeW5jRnJvbVN5bmNJdGVyYXRvciBtZXRob2RzIHNob3VsZCBub3QgcGFzcyBhYnNl bnQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTExNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIHBhdGNoIGltcGxlbWVudHMgbWlub3Igc3BlYyBjaGFuZ2UgWzFdIHRvIG1hdGNoIGFz eW5jIGFuZCBzeW5jIGl0ZXJhdGlvbgorICAgICAgICBmcm9tIHRoZSBwZXJzcGVjdGl2ZSBvZiB1 c2VybGFuZCBgbmV4dGAgYW5kIGByZXR1cm5gIGl0ZXJhdG9yIG1ldGhvZHMuCisgICAgICAgIGB0 aHJvd2AgbWV0aG9kIGFsd2F5cyByZWNlaXZlcyBhbiBhcmd1bWVudCwgYnV0IHdlIGFsaWduIHdp dGggb3RoZXJzIHRvIGJlCisgICAgICAgIGNvbnNpc3RlbnQgYW5kIGZ1dHVyZS1wcm9vZi4KKwor ICAgICAgICBUaGlzIGNoYW5nZSBpcyBhbHJlYWR5IGltcGxlbWVudGVkIGluIFNwaWRlck1vbmtl eS4KKworICAgICAgICBbMV06IGh0dHBzOi8vZ2l0aHViLmNvbS90YzM5L2VjbWEyNjIvcHVsbC8x Nzc2CisKKyAgICAgICAgKiBidWlsdGlucy9Bc3luY0Zyb21TeW5jSXRlcmF0b3JQcm90b3R5cGUu anM6CisKIDIwMjAtMDQtMjcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAog ICAgICAgICBbSlNDXSBUaHJvdyBPdXRPZk1lbW9yeUVycm9yIGluc3RlYWQgb2YgUmFuZ2VFcnJv ciBpZiBCaWdJbnQgaXMgdG9vIGJpZwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL0FzeW5jRnJvbVN5bmNJdGVyYXRvclByb3RvdHlwZS5qcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXN5bmNGcm9tU3luY0l0ZXJhdG9yUHJvdG90eXBl LmpzCShyZXZpc2lvbiAyNjA4MTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMv QXN5bmNGcm9tU3luY0l0ZXJhdG9yUHJvdG90eXBlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw3 ICsyNCw3IEBACiAgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKLWZ1bmN0aW9uIG5leHQodmFsdWUpCitm dW5jdGlvbiBuZXh0KC8qIHZhbHVlICovKQogewogICAgICJ1c2Ugc3RyaWN0IjsKIApAQCAtMzgs NyArMzgsNyBAQCBmdW5jdGlvbiBuZXh0KHZhbHVlKQogICAgIHZhciBzeW5jSXRlcmF0b3IgPSBA Z2V0QnlJZERpcmVjdFByaXZhdGUodGhpcywgInN5bmNJdGVyYXRvciIpOwogCiAgICAgdHJ5IHsK LSAgICAgICAgdmFyIG5leHRSZXN1bHQgPSBAZ2V0QnlJZERpcmVjdFByaXZhdGUodGhpcywgIm5l eHRNZXRob2QiKS5AY2FsbChzeW5jSXRlcmF0b3IsIHZhbHVlKTsKKyAgICAgICAgdmFyIG5leHRS ZXN1bHQgPSBAZ2V0QnlJZERpcmVjdFByaXZhdGUodGhpcywgIm5leHRNZXRob2QiKS5AYXBwbHko c3luY0l0ZXJhdG9yLCBhcmd1bWVudHMpOwogICAgICAgICB2YXIgbmV4dERvbmUgPSAhIW5leHRS ZXN1bHQuZG9uZTsKICAgICAgICAgdmFyIG5leHRWYWx1ZSA9IG5leHRSZXN1bHQudmFsdWU7CiAg ICAgICAgIEByZXNvbHZlV2l0aG91dFByb21pc2UobmV4dFZhbHVlLApAQCAtNzksNyArNzksNyBA QCBmdW5jdGlvbiByZXR1cm4odmFsdWUpCiAgICAgfQogICAgIAogICAgIHRyeSB7Ci0gICAgICAg IHZhciByZXR1cm5SZXN1bHQgPSByZXR1cm5NZXRob2QuQGNhbGwoc3luY0l0ZXJhdG9yLCB2YWx1 ZSk7CisgICAgICAgIHZhciByZXR1cm5SZXN1bHQgPSByZXR1cm5NZXRob2QuQGFwcGx5KHN5bmNJ dGVyYXRvciwgYXJndW1lbnRzKTsKIAogICAgICAgICBpZiAoIUBpc09iamVjdChyZXR1cm5SZXN1 bHQpKSB7CiAgICAgICAgICAgICBAcmVqZWN0UHJvbWlzZVdpdGhGaXJzdFJlc29sdmluZ0Z1bmN0 aW9uQ2FsbENoZWNrKHByb21pc2UsIEBtYWtlVHlwZUVycm9yKCdJdGVyYXRvciByZXN1bHQgaW50 ZXJmYWNlIGlzIG5vdCBhbiBvYmplY3QuJykpOwpAQCAtMTI2LDcgKzEyNiw3IEBAIGZ1bmN0aW9u IHRocm93KGV4Y2VwdGlvbikKICAgICB9CiAgICAgCiAgICAgdHJ5IHsKLSAgICAgICAgdmFyIHRo cm93UmVzdWx0ID0gdGhyb3dNZXRob2QuQGNhbGwoc3luY0l0ZXJhdG9yLCBleGNlcHRpb24pOwor ICAgICAgICB2YXIgdGhyb3dSZXN1bHQgPSB0aHJvd01ldGhvZC5AYXBwbHkoc3luY0l0ZXJhdG9y LCBhcmd1bWVudHMpOwogICAgICAgICAKICAgICAgICAgaWYgKCFAaXNPYmplY3QodGhyb3dSZXN1 bHQpKSB7CiAgICAgICAgICAgICBAcmVqZWN0UHJvbWlzZVdpdGhGaXJzdFJlc29sdmluZ0Z1bmN0 aW9uQ2FsbENoZWNrKHByb21pc2UsIEBtYWtlVHlwZUVycm9yKCdJdGVyYXRvciByZXN1bHQgaW50 ZXJmYWNlIGlzIG5vdCBhbiBvYmplY3QuJykpOwo= 397888 2020-04-28 15:06:25 -0700 2020-04-29 14:39:46 -0700 Patch bug-211147-20200429010624.patch text/plain 5083 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjA4NDYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIwLTA0LTI4ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBBc3luY0Zyb21TeW5jSXRlcmF0b3IgbWV0aG9kcyBzaG91 bGQgbm90IHBhc3MgYWJzZW50IHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sOiBNYXJrIDQgdGVz dCBjYXNlcyBhcyBwYXNzaW5nLgorCiAyMDIwLTA0LTI4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVr aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gTnVtYmVyQ29uc3RydWN0b3Igc2hvdWxkIGFj Y2VwdCBCaWdJbnQKSW5kZXg6IEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwJKHJldmlzaW9uIDI2 MDgxNikKKysrIEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAkod29ya2luZyBjb3B5 KQpAQCAtNzI5LDEyICs3MjksNiBAQCB0ZXN0L2J1aWx0LWlucy9BcnJheUJ1ZmZlci9wcm90b3R5 cGUvc2xpCiB0ZXN0L2J1aWx0LWlucy9BcnJheUl0ZXJhdG9yUHJvdG90eXBlL25leHQvZGV0YWNo LXR5cGVkYXJyYXktaW4tcHJvZ3Jlc3MuanM6CiAgIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4 cGVjdGVkIGEgVHlwZUVycm9yIHRvIGJlIHRocm93biBidXQgbm8gZXhjZXB0aW9uIHdhcyB0aHJv d24gYXQgYWxsIChUZXN0aW5nIHdpdGggRmxvYXQ2NEFycmF5LiknCiAgIHN0cmljdCBtb2RlOiAn VGVzdDI2MkVycm9yOiBFeHBlY3RlZCBhIFR5cGVFcnJvciB0byBiZSB0aHJvd24gYnV0IG5vIGV4 Y2VwdGlvbiB3YXMgdGhyb3duIGF0IGFsbCAoVGVzdGluZyB3aXRoIEZsb2F0NjRBcnJheS4pJwot dGVzdC9idWlsdC1pbnMvQXN5bmNGcm9tU3luY0l0ZXJhdG9yUHJvdG90eXBlL25leHQvYWJzZW50 LXZhbHVlLW5vdC1wYXNzZWQuanM6Ci0gIGRlZmF1bHQ6ICdUZXN0MjYyOkFzeW5jVGVzdEZhaWx1 cmU6VGVzdDI2MkVycm9yOiBUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCqzHCuywg wqswwrspIHRvIGJlIHRydWUnCi0gIHN0cmljdCBtb2RlOiAnVGVzdDI2MjpBc3luY1Rlc3RGYWls dXJlOlRlc3QyNjJFcnJvcjogVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqsxwrss IMKrMMK7KSB0byBiZSB0cnVlJwotdGVzdC9idWlsdC1pbnMvQXN5bmNGcm9tU3luY0l0ZXJhdG9y UHJvdG90eXBlL3JldHVybi9hYnNlbnQtdmFsdWUtbm90LXBhc3NlZC5qczoKLSAgZGVmYXVsdDog J1Rlc3QyNjI6QXN5bmNUZXN0RmFpbHVyZTpUZXN0MjYyRXJyb3I6IFRlc3QyNjJFcnJvcjogRXhw ZWN0ZWQgU2FtZVZhbHVlKMKrMcK7LCDCqzDCuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0IG1vZGU6 ICdUZXN0MjYyOkFzeW5jVGVzdEZhaWx1cmU6VGVzdDI2MkVycm9yOiBUZXN0MjYyRXJyb3I6IEV4 cGVjdGVkIFNhbWVWYWx1ZSjCqzHCuywgwqswwrspIHRvIGJlIHRydWUnCiB0ZXN0L2J1aWx0LWlu cy9Bc3luY0dlbmVyYXRvclByb3RvdHlwZS9yZXR1cm4vcmV0dXJuLXN1c3BlbmRlZFlpZWxkLXBy b21pc2UuanM6CiAgIGRlZmF1bHQ6ICdUZXN0MjYyOkFzeW5jVGVzdEZhaWx1cmU6VGVzdDI2MkVy cm9yOiBUZXN0MjYyRXJyb3I6IEFzeW5jR2VuZXJhdG9yUmVzb2x2ZShnZW5lcmF0b3IsIHJlc3Vs dFZhbHVlLCB0cnVlKSBFeHBlY3RlZCBTYW1lVmFsdWUowqtbb2JqZWN0IFByb21pc2VdwrssIMKr dW53cmFwcGVkLXZhbHVlwrspIHRvIGJlIHRydWUnCiAgIHN0cmljdCBtb2RlOiAnVGVzdDI2MjpB c3luY1Rlc3RGYWlsdXJlOlRlc3QyNjJFcnJvcjogVGVzdDI2MkVycm9yOiBBc3luY0dlbmVyYXRv clJlc29sdmUoZ2VuZXJhdG9yLCByZXN1bHRWYWx1ZSwgdHJ1ZSkgRXhwZWN0ZWQgU2FtZVZhbHVl KMKrW29iamVjdCBQcm9taXNlXcK7LCDCq3Vud3JhcHBlZC12YWx1ZcK7KSB0byBiZSB0cnVlJwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjA4MTYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMjAtMDQtMjggIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisg ICAgICAgIEFzeW5jRnJvbVN5bmNJdGVyYXRvciBtZXRob2RzIHNob3VsZCBub3QgcGFzcyBhYnNl bnQgdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTExNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIHBhdGNoIGltcGxlbWVudHMgbWlub3Igc3BlYyBjaGFuZ2UgWzFdIHRvIG1hdGNoIGFz eW5jIGFuZCBzeW5jIGl0ZXJhdGlvbgorICAgICAgICBmcm9tIHRoZSBwZXJzcGVjdGl2ZSBvZiB1 c2VybGFuZCBgbmV4dGAgYW5kIGByZXR1cm5gIGl0ZXJhdG9yIG1ldGhvZHMuCisgICAgICAgIGB0 aHJvd2AgbWV0aG9kIGFsd2F5cyByZWNlaXZlcyBhbiBhcmd1bWVudCwgeWV0IHdlIGFsaWduIHdp dGggb3RoZXJzIHRvIGJlCisgICAgICAgIGNvbnNpc3RlbnQgYW5kIGZ1dHVyZS1wcm9vZi4KKwor ICAgICAgICBUaGlzIGNoYW5nZSBpcyBhbHJlYWR5IGltcGxlbWVudGVkIGluIFNwaWRlck1vbmtl eS4KKworICAgICAgICBbMV06IGh0dHBzOi8vZ2l0aHViLmNvbS90YzM5L2VjbWEyNjIvcHVsbC8x Nzc2CisKKyAgICAgICAgKiBidWlsdGlucy9Bc3luY0Zyb21TeW5jSXRlcmF0b3JQcm90b3R5cGUu anM6CisKIDIwMjAtMDQtMjcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAog ICAgICAgICBbSlNDXSBUaHJvdyBPdXRPZk1lbW9yeUVycm9yIGluc3RlYWQgb2YgUmFuZ2VFcnJv ciBpZiBCaWdJbnQgaXMgdG9vIGJpZwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL0FzeW5jRnJvbVN5bmNJdGVyYXRvclByb3RvdHlwZS5qcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXN5bmNGcm9tU3luY0l0ZXJhdG9yUHJvdG90eXBl LmpzCShyZXZpc2lvbiAyNjA4MTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMv QXN5bmNGcm9tU3luY0l0ZXJhdG9yUHJvdG90eXBlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw5 ICszNiwxMCBAQCBmdW5jdGlvbiBuZXh0KHZhbHVlKQogICAgIH0KIAogICAgIHZhciBzeW5jSXRl cmF0b3IgPSBAZ2V0QnlJZERpcmVjdFByaXZhdGUodGhpcywgInN5bmNJdGVyYXRvciIpOworICAg IHZhciBuZXh0TWV0aG9kID0gQGdldEJ5SWREaXJlY3RQcml2YXRlKHRoaXMsICJuZXh0TWV0aG9k Iik7CiAKICAgICB0cnkgewotICAgICAgICB2YXIgbmV4dFJlc3VsdCA9IEBnZXRCeUlkRGlyZWN0 UHJpdmF0ZSh0aGlzLCAibmV4dE1ldGhvZCIpLkBjYWxsKHN5bmNJdGVyYXRvciwgdmFsdWUpOwor ICAgICAgICB2YXIgbmV4dFJlc3VsdCA9IEBhcmd1bWVudENvdW50KCkgPT09IDAgPyBuZXh0TWV0 aG9kLkBjYWxsKHN5bmNJdGVyYXRvcikgOiBuZXh0TWV0aG9kLkBjYWxsKHN5bmNJdGVyYXRvciwg dmFsdWUpOwogICAgICAgICB2YXIgbmV4dERvbmUgPSAhIW5leHRSZXN1bHQuZG9uZTsKICAgICAg ICAgdmFyIG5leHRWYWx1ZSA9IG5leHRSZXN1bHQudmFsdWU7CiAgICAgICAgIEByZXNvbHZlV2l0 aG91dFByb21pc2UobmV4dFZhbHVlLApAQCAtNzksNyArODAsNyBAQCBmdW5jdGlvbiByZXR1cm4o dmFsdWUpCiAgICAgfQogICAgIAogICAgIHRyeSB7Ci0gICAgICAgIHZhciByZXR1cm5SZXN1bHQg PSByZXR1cm5NZXRob2QuQGNhbGwoc3luY0l0ZXJhdG9yLCB2YWx1ZSk7CisgICAgICAgIHZhciBy ZXR1cm5SZXN1bHQgPSBAYXJndW1lbnRDb3VudCgpID09PSAwID8gcmV0dXJuTWV0aG9kLkBjYWxs KHN5bmNJdGVyYXRvcikgOiByZXR1cm5NZXRob2QuQGNhbGwoc3luY0l0ZXJhdG9yLCB2YWx1ZSk7 CiAKICAgICAgICAgaWYgKCFAaXNPYmplY3QocmV0dXJuUmVzdWx0KSkgewogICAgICAgICAgICAg QHJlamVjdFByb21pc2VXaXRoRmlyc3RSZXNvbHZpbmdGdW5jdGlvbkNhbGxDaGVjayhwcm9taXNl LCBAbWFrZVR5cGVFcnJvcignSXRlcmF0b3IgcmVzdWx0IGludGVyZmFjZSBpcyBub3QgYW4gb2Jq ZWN0LicpKTsKQEAgLTEyNiw3ICsxMjcsNyBAQCBmdW5jdGlvbiB0aHJvdyhleGNlcHRpb24pCiAg ICAgfQogICAgIAogICAgIHRyeSB7Ci0gICAgICAgIHZhciB0aHJvd1Jlc3VsdCA9IHRocm93TWV0 aG9kLkBjYWxsKHN5bmNJdGVyYXRvciwgZXhjZXB0aW9uKTsKKyAgICAgICAgdmFyIHRocm93UmVz dWx0ID0gQGFyZ3VtZW50Q291bnQoKSA9PT0gMCA/IHRocm93TWV0aG9kLkBjYWxsKHN5bmNJdGVy YXRvcikgOiB0aHJvd01ldGhvZC5AY2FsbChzeW5jSXRlcmF0b3IsIGV4Y2VwdGlvbik7CiAgICAg ICAgIAogICAgICAgICBpZiAoIUBpc09iamVjdCh0aHJvd1Jlc3VsdCkpIHsKICAgICAgICAgICAg IEByZWplY3RQcm9taXNlV2l0aEZpcnN0UmVzb2x2aW5nRnVuY3Rpb25DYWxsQ2hlY2socHJvbWlz ZSwgQG1ha2VUeXBlRXJyb3IoJ0l0ZXJhdG9yIHJlc3VsdCBpbnRlcmZhY2UgaXMgbm90IGFuIG9i amVjdC4nKSk7Cg==