211144 2020-04-28 13:42:02 -0700 [GTK] update-webkitgtk-libs: TypeError: cannot use a string pattern on a bytes-like object 2020-04-28 17:26:42 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro lmoura bugs-noreply lmoura mcatanzaro pnormand oldest_to_newest 1646660 0 mcatanzaro 2020-04-28 13:42:02 -0700 Looks like this script was written for python2 (in 2018!) and then never updated: $ update-webkitgtk-libs Adding repo webkit-sdk Updating Flatpak Debug environment Installing from webkit-sdk org.webkit.Platform x86_64 0.2 Looking for matches… ID Branch Op Remote Download 1. [✓] org.webkit.Platform.Locale 0.2 i webkit-sdk 16.9 kB / 1.3 GB 2. [✓] org.webkit.Platform 0.2 i webkit-sdk 367.1 MB / 1.2 GB Installation complete. Installing from webkit-sdk org.webkit.Sdk x86_64 0.2 Looking for matches… ID Branch Op Remote Download 1. [✓] org.webkit.Sdk.Locale 0.2 i webkit-sdk 16.9 kB / 1.4 GB 2. [✓] org.webkit.Sdk 0.2 i webkit-sdk 489.9 MB / 2.3 GB Installation complete. Installing from flathub org.freedesktop.Platform.GL.default x86_64 19.08 Looking for matches… ID Branch Op Remote Download 1. [✓] org.freedesktop.Platform.GL.default 19.08 i flathub 94.4 MB / 94.9 MB Installation complete. Installing from webkit-sdk org.webkit.Sdk.Debug x86_64 0.2 Looking for matches… ID Branch Op Remote Download 1. [✓] org.webkit.Sdk.Debug 0.2 i webkit-sdk 2.3 GB / 3.7 GB Installation complete. bwrap: Can't find source path /run/user/b'1000'/doc: No such file or directory Traceback (most recent call last): File "Tools/Scripts/update-webkit-flatpak", line 28, in <module> WebkitFlatpak.load_from_args(["--update"] + sys.argv[1:]).run() File "./Tools/flatpak/flatpakutils.py", line 805, in run return self.main() File "./Tools/flatpak/flatpakutils.py", line 797, in main self.setup_icecc("gcc") File "./Tools/flatpak/flatpakutils.py", line 826, in setup_icecc icc_version_filename, = re.findall(r'.*creating (.*)', tmpfile.read()) File "/usr/lib64/python3.8/re.py", line 239, in findall return _compile(pattern, flags).findall(string) TypeError: cannot use a string pattern on a bytes-like object Died at /home/mcatanzaro/Projects/WebKit/Tools/Scripts/update-webkitgtk-libs line 28. 1646715 1 397893 lmoura 2020-04-28 15:52:21 -0700 Created attachment 397893 Patch 1646729 2 397893 mcatanzaro 2020-04-28 16:13:30 -0700 Comment on attachment 397893 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397893&action=review LGTM, thanks. > Tools/ChangeLog:12 > + Also check if the doc directory exists before passing it to bwrap. > + Should avoid errors like these: > + > + bwrap: Can't find source path /run/user/1000/doc: No such file or directory Hm, well I actually do have /run/user/1000/doc. That error must have been caused because the script was not mounting /run/user/1000/doc, it was mounting /run/user/b'1000'/doc. Oops. :) I'll let you decide whether it's still worth checking if that exists. 1646737 3 lmoura 2020-04-28 16:26:53 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 397893 [details] > Hm, well I actually do have /run/user/1000/doc. That error must have been > caused because the script was not mounting /run/user/1000/doc, it was > mounting /run/user/b'1000'/doc. Oops. :) I'll let you decide whether it's > still worth checking if that exists. Yeah, this is an issue that is happening in the WPE Debug test bot (and can happen if the dir does not exist). 1646738 4 ews-feeder 2020-04-28 16:27:35 -0700 /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 1646776 5 lmoura 2020-04-28 17:26:42 -0700 Committed r260859: <https://trac.webkit.org/changeset/260859> 397893 2020-04-28 15:52:21 -0700 2020-04-28 16:27:35 -0700 Patch bug-211144-20200428195219.patch text/plain 2139 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDYxNWIyYWY1YjcyMWEzYTNiYjg3MGNiNjUwZjBiYjdj MTQ3ZTNkZC4uNTJkNWM1NTQwYjY4MWIwMGVmZGEwOGY4NzUxYmI4NzkxYWI1MDI2MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIwLTA0LTI4ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIHVwZGF0ZS13ZWJraXRndGstbGliczogVHlwZUVycm9yOiBjYW5ub3QgdXNlIGEg c3RyaW5nIHBhdHRlcm4gb24gYSBieXRlcy1saWtlIG9iamVjdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTQ0CisKKyAgICAgICAgVW5jb25kaXRp b25hbGx5IGRlY29kZSB0aGUgb3V0cHV0IGZyb20gdGhlICdpZCcgY29tbWFuZCB0byBtYWtlIGl0 CisgICAgICAgIHdvcmsgd2l0aCBweXRob24zLgorCisgICAgICAgIEFsc28gY2hlY2sgaWYgdGhl IGRvYyBkaXJlY3RvcnkgZXhpc3RzIGJlZm9yZSBwYXNzaW5nIGl0IHRvIGJ3cmFwLgorICAgICAg ICBTaG91bGQgYXZvaWQgZXJyb3JzIGxpa2UgdGhlc2U6CisKKyAgICAgICAgYndyYXA6IENhbid0 IGZpbmQgc291cmNlIHBhdGggL3J1bi91c2VyLzEwMDAvZG9jOiBObyBzdWNoIGZpbGUgb3IgZGly ZWN0b3J5CisKKyAgICAgICAgKiBmbGF0cGFrL2ZsYXRwYWt1dGlscy5weToKKyAgICAgICAgKFdl YmtpdEZsYXRwYWsucnVuX2luX3NhbmRib3gpOgorCiAyMDIwLTA0LTI4ICBLYXRlIENoZW5leSAg PGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIENyZWF0ZSBhIG1lY2hhbmlz bSB0byBhZGQgbWlzc2luZyBJVFAgRGF0YWJhc2UgdGFibGVzIHdoZW4gdGhlIHNjaGVtYSBpcyB1 cGRhdGVkCmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weSBiL1Rvb2xz L2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CmluZGV4IGE1N2YzNzA4MzVhNTY0MDk1OTYzMGM0MWIy ODRiOTljYWNlNjNkMjguLjc0NjAwZjc4NjI4NjM0NWIwYTY0YWE4NDFhZjMwYmJmZjFmYTUyNDUg MTAwNjQ0Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CisrKyBiL1Rvb2xzL2Zs YXRwYWsvZmxhdHBha3V0aWxzLnB5CkBAIC02NjEsOCArNjYxLDEyIEBAIGNsYXNzIFdlYmtpdEZs YXRwYWs6CiAKICAgICAgICAgICAgIHRyeToKICAgICAgICAgICAgICAgICB3aXRoIG9wZW4ob3Mu ZGV2bnVsbCwgJ3cnKSBhcyBkZXZudWxsOgotICAgICAgICAgICAgICAgICAgICB1aWQgPSBzdWJw cm9jZXNzLmNoZWNrX291dHB1dCgoImlkIiwgIi11IiksIHN0ZGVycj1kZXZudWxsKS5zdHJpcCgp Ci0gICAgICAgICAgICAgICAgICAgIGZsYXRwYWtfY29tbWFuZC5hcHBlbmQoIi0tYmluZC1tb3Vu dD0vcnVuL3VzZXIve3VpZH0vZG9jPS9ydW4vdXNlci97dWlkfS9kb2MiLmZvcm1hdCh1aWQ9dWlk KSkKKyAgICAgICAgICAgICAgICAgICAgdWlkID0gc3VicHJvY2Vzcy5jaGVja19vdXRwdXQoKCJp ZCIsICItdSIpLCBzdGRlcnI9ZGV2bnVsbCkuc3RyaXAoKS5kZWNvZGUoKQorICAgICAgICAgICAg ICAgICAgICB1aWRfZG9jX3BhdGggPSAnL3J1bi91c2VyL3t1aWR9L2RvYycuZm9ybWF0KHVpZD11 aWQpCisgICAgICAgICAgICAgICAgICAgIGlmIG9zLnBhdGguZXhpc3RzKHVpZF9kb2NfcGF0aCk6 CisgICAgICAgICAgICAgICAgICAgICAgICBmbGF0cGFrX2NvbW1hbmQuYXBwZW5kKCItLWJpbmQt bW91bnQ9e3VpZF9kb2NfcGF0aH09e3VpZF9kb2NfcGF0aH0iLmZvcm1hdCh1aWRfZG9jX3BhdGg9 dWlkX2RvY19wYXRoKSkKKyAgICAgICAgICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAg ICAgICAgICAgIF9sb2cuZGVidWcoIkNhbid0IGZpbmQgdXNlciBkb2N1bWVudCBwYXRoIGF0ICd7 dWlkX2RvY19wYXRofScuIE5vdCBtb3VudGluZyBpdC4iLmZvcm1hdCh1aWRfZG9jX3BhdGg9dWlk X2RvY19wYXRoKSkKICAgICAgICAgICAgIGV4Y2VwdCBzdWJwcm9jZXNzLkNhbGxlZFByb2Nlc3NF cnJvcjoKICAgICAgICAgICAgICAgICBwYXNzCiAK