211137 2020-04-28 11:32:22 -0700 Rewrite GraphicsLayerCA::updateSublayerList() 2020-04-28 14:16:16 -0700 1 1 1 Unclassified WebKit Compositing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser webkit-bug-importer zalan oldest_to_newest 1646577 0 simon.fraser 2020-04-28 11:32:22 -0700 Rewrite GraphicsLayerCA::updateSublayerList() 1646581 1 397861 simon.fraser 2020-04-28 11:34:00 -0700 Created attachment 397861 Patch 1646670 2 ews-feeder 2020-04-28 14:15:37 -0700 Committed r260845: <https://trac.webkit.org/changeset/260845> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397861. 1646672 3 webkit-bug-importer 2020-04-28 14:16:16 -0700 <rdar://problem/62545236> 397861 2020-04-28 11:34:00 -0700 2020-04-28 14:15:38 -0700 Patch bug-211137-20200428113359.patch text/plain 5058 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhmY2Q4NTQ4NDMzMzg1 YzBmMWZhNzEzMDAzZjY2YTgwMWM1YzYwMy4uZDlmZWJiNDg5MWRlZTY5YjA1OTY1YmU0YzBiMTAw NDc5NzhjOTAwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA0LTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJld3JpdGUgR3Jh cGhpY3NMYXllckNBOjp1cGRhdGVTdWJsYXllckxpc3QoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmdW5jdGlvbiB3YXMgaGFyZCB0byB1bmRl cnN0YW5kLCB3aXRoIGFsaWFzaW5nIG9mIGEgbGF5ZXIgbGlzdCB0byBoYW5kbGUKKyAgICAgICAg dGhlIHZhcmlvdXMgY29uZmlndXJhdGlvbnMuIEZ1dHVyZSBwYXRjaGVzIHdpbGwgYWRkIGEgYml0 IG1vcmUgY29tcGxleGl0eSBoZXJlLgorCisgICAgICAgIFJld3JpdGUgdXNpbmcgbGFtYmRhcywg d2hpY2ggbWFrZXMgaXQgZWFzaWVyIHRvIGZvbGxvdy4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0xheWVyQ0E6OnVwZGF0ZVN1YmxheWVyTGlzdCk6CisKIDIwMjAtMDQtMjcgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gY29ycmVjdCBjbGlwcGlu ZyBvZiBjb21wb3NpdGVkIHJlcGxhY2VkIGVsZW1lbnRzIHdpdGggYm9yZGVyLXJhZGl1cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXll ckNBLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5 ZXJDQS5jcHAKaW5kZXggZjA1ZjczZTI5NmFmMDkyNGRjYmJjODY5YWYxYTM0ZTRlM2Y5ZDIyMC4u MmVlYzJmZGIzZWRmNTBiMzE5N2ZjZDJjNDc1NTc4ZTk0YjRiNmE5NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3Bw CkBAIC0xOTcxLDQ4ICsxOTcxLDY4IEBAIHZvaWQgR3JhcGhpY3NMYXllckNBOjp1cGRhdGVTdWJs YXllckxpc3QoYm9vbCBtYXhMYXllckRlcHRoUmVhY2hlZCkKICAgICAgICAgbV9sYXllci0+c2V0 U3VibGF5ZXJzKFBsYXRmb3JtQ0FMYXllckxpc3QoKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9 CisKKyAgICBhdXRvIGFwcGVuZFN0cnVjdHVyYWxMYXllckNoaWxkcmVuID0gWyZdKFBsYXRmb3Jt Q0FMYXllckxpc3QmIGxpc3QpIHsKKyAgICAgICAgaWYgKG1fYmFja2Ryb3BMYXllcikKKyAgICAg ICAgICAgIGxpc3QuYXBwZW5kKG1fYmFja2Ryb3BMYXllcik7CisKKyAgICAgICAgaWYgKG1fcmVw bGljYUxheWVyKQorICAgICAgICAgICAgbGlzdC5hcHBlbmQoZG93bmNhc3Q8R3JhcGhpY3NMYXll ckNBPigqbV9yZXBsaWNhTGF5ZXIpLnByaW1hcnlMYXllcigpKTsKICAgICAKLSAgICBjb25zdCBQ bGF0Zm9ybUNBTGF5ZXJMaXN0KiBjdXN0b21TdWJsYXllcnMgPSBtX2xheWVyLT5jdXN0b21TdWJs YXllcnMoKTsKKyAgICAgICAgbGlzdC5hcHBlbmQobV9sYXllcik7CisgICAgfTsKIAotICAgIFBs YXRmb3JtQ0FMYXllckxpc3Qgc3RydWN0dXJhbExheWVyQ2hpbGRyZW47Ci0gICAgUGxhdGZvcm1D QUxheWVyTGlzdCBwcmltYXJ5TGF5ZXJDaGlsZHJlbjsKKyAgICBhdXRvIGFwcGVuZENsaXBwaW5n TGF5ZXJzID0gWyZdKFBsYXRmb3JtQ0FMYXllckxpc3QmIGxpc3QpIHsKKyAgICAgICAgaWYgKCFt X2NvbnRlbnRzVmlzaWJsZSkKKyAgICAgICAgICAgIHJldHVybjsKIAotICAgIFBsYXRmb3JtQ0FM YXllckxpc3QmIGNoaWxkTGlzdEZvclN1YmxheWVycyA9IG1fc3RydWN0dXJhbExheWVyID8gc3Ry dWN0dXJhbExheWVyQ2hpbGRyZW4gOiBwcmltYXJ5TGF5ZXJDaGlsZHJlbjsKKyAgICAgICAgaWYg KG1fY29udGVudHNDbGlwcGluZ0xheWVyKSB7CisgICAgICAgICAgICBsaXN0LmFwcGVuZChtX2Nv bnRlbnRzQ2xpcHBpbmdMYXllcik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KIAot ICAgIGlmIChjdXN0b21TdWJsYXllcnMpCi0gICAgICAgIHByaW1hcnlMYXllckNoaWxkcmVuLmFw cGVuZFZlY3RvcigqY3VzdG9tU3VibGF5ZXJzKTsKKyAgICAgICAgaWYgKG1fY29udGVudHNMYXll cikKKyAgICAgICAgICAgIGxpc3QuYXBwZW5kKG1fY29udGVudHNMYXllcik7CisgICAgfTsKIAot ICAgIGlmIChtX3N0cnVjdHVyYWxMYXllcikgewotICAgICAgICBpZiAobV9iYWNrZHJvcExheWVy KQotICAgICAgICAgICAgc3RydWN0dXJhbExheWVyQ2hpbGRyZW4uYXBwZW5kKG1fYmFja2Ryb3BM YXllcik7CisgICAgYXV0byBhcHBlbmRDdXN0b21BbmRDbGlwcGluZ0xheWVycyA9IFsmXShQbGF0 Zm9ybUNBTGF5ZXJMaXN0JiBsaXN0KSB7CisgICAgICAgIGlmIChhdXRvKiBjdXN0b21TdWJsYXll cnMgPSBtX2xheWVyLT5jdXN0b21TdWJsYXllcnMoKSkKKyAgICAgICAgICAgIGxpc3QuYXBwZW5k VmVjdG9yKCpjdXN0b21TdWJsYXllcnMpOwogCi0gICAgICAgIGlmIChtX3JlcGxpY2FMYXllcikK LSAgICAgICAgICAgIHN0cnVjdHVyYWxMYXllckNoaWxkcmVuLmFwcGVuZChkb3duY2FzdDxHcmFw aGljc0xheWVyQ0E+KCptX3JlcGxpY2FMYXllcikucHJpbWFyeUxheWVyKCkpOwotICAgIAotICAg ICAgICBzdHJ1Y3R1cmFsTGF5ZXJDaGlsZHJlbi5hcHBlbmQobV9sYXllcik7Ci0gICAgfQorICAg ICAgICBhcHBlbmRDbGlwcGluZ0xheWVycyhsaXN0KTsKKyAgICB9OwogCi0gICAgaWYgKG1fY29u dGVudHNMYXllciAmJiBtX2NvbnRlbnRzVmlzaWJsZSkgewotICAgICAgICAvLyBGSVhNRTogYWRk IHRoZSBjb250ZW50cyBsYXllciBpbiB0aGUgY29ycmVjdCBvcmRlciB3aXRoIG5lZ2F0aXZlIHot b3JkZXIgY2hpbGRyZW4uCi0gICAgICAgIC8vIFRoaXMgZG9lcyBub3QgY2F1c2UgdmlzaWJsZSBy ZW5kZXJpbmcgaXNzdWVzIGJlY2F1c2UgY3VycmVudGx5IGNvbnRlbnRzIGxheWVycyBhcmUgb25s eSB1c2VkCi0gICAgICAgIC8vIGZvciByZXBsYWNlZCBlbGVtZW50cyB0aGF0IGRvbid0IGhhdmUg Y2hpbGRyZW4uCi0gICAgICAgIHByaW1hcnlMYXllckNoaWxkcmVuLmFwcGVuZChtX2NvbnRlbnRz Q2xpcHBpbmdMYXllciA/IG1fY29udGVudHNDbGlwcGluZ0xheWVyIDogbV9jb250ZW50c0xheWVy KTsKLSAgICB9Ci0gICAgCi0gICAgZm9yIChjb25zdCBhdXRvJiBsYXllciA6IGNoaWxkcmVuKCkp IHsKLSAgICAgICAgY29uc3QgYXV0byYgY3VycmVudENoaWxkID0gZG93bmNhc3Q8R3JhcGhpY3NM YXllckNBPihsYXllci5nZXQoKSk7Ci0gICAgICAgIFBsYXRmb3JtQ0FMYXllciogY2hpbGRMYXll ciA9IGN1cnJlbnRDaGlsZC5sYXllckZvclN1cGVybGF5ZXIoKTsKLSAgICAgICAgY2hpbGRMaXN0 Rm9yU3VibGF5ZXJzLmFwcGVuZChjaGlsZExheWVyKTsKLSAgICB9CisgICAgYXV0byBhcHBlbmRM YXllcnNGcm9tQ2hpbGRyZW4gPSBbJl0oUGxhdGZvcm1DQUxheWVyTGlzdCYgbGlzdCkgeworICAg ICAgICBmb3IgKGNvbnN0IGF1dG8mIGxheWVyIDogY2hpbGRyZW4oKSkgeworICAgICAgICAgICAg Y29uc3QgYXV0byYgY3VycmVudENoaWxkID0gZG93bmNhc3Q8R3JhcGhpY3NMYXllckNBPihsYXll ci5nZXQoKSk7CisgICAgICAgICAgICBQbGF0Zm9ybUNBTGF5ZXIqIGNoaWxkTGF5ZXIgPSBjdXJy ZW50Q2hpbGQubGF5ZXJGb3JTdXBlcmxheWVyKCk7CisgICAgICAgICAgICBsaXN0LmFwcGVuZChj aGlsZExheWVyKTsKKyAgICAgICAgfQorICAgIH07CiAKKyAgICBhdXRvIGFwcGVuZERlYnVnTGF5 ZXJzID0gWyZdKFBsYXRmb3JtQ0FMYXllckxpc3QmIGxpc3QpIHsKICNpZmRlZiBWSVNJQkxFX1RJ TEVfV0FTSAotICAgIGlmIChtX3Zpc2libGVUaWxlV2FzaExheWVyKQotICAgICAgICBjaGlsZExp c3RGb3JTdWJsYXllcnMuYXBwZW5kKG1fdmlzaWJsZVRpbGVXYXNoTGF5ZXIpOworICAgICAgICBp ZiAobV92aXNpYmxlVGlsZVdhc2hMYXllcikKKyAgICAgICAgICAgIGxpc3QuYXBwZW5kKG1fdmlz aWJsZVRpbGVXYXNoTGF5ZXIpOworI2Vsc2UKKyAgICAgICAgVU5VU0VEX1BBUkFNKGxpc3QpOwog I2VuZGlmCisgICAgfTsKKworICAgIFBsYXRmb3JtQ0FMYXllckxpc3QgcHJpbWFyeUxheWVyQ2hp bGRyZW47CisgICAgYXBwZW5kQ3VzdG9tQW5kQ2xpcHBpbmdMYXllcnMocHJpbWFyeUxheWVyQ2hp bGRyZW4pOworCisgICAgaWYgKG1fc3RydWN0dXJhbExheWVyKSB7CisgICAgICAgIFBsYXRmb3Jt Q0FMYXllckxpc3QgbGF5ZXJMaXN0OworICAgICAgICBhcHBlbmRTdHJ1Y3R1cmFsTGF5ZXJDaGls ZHJlbihsYXllckxpc3QpOworICAgICAgICBhcHBlbmRMYXllcnNGcm9tQ2hpbGRyZW4obGF5ZXJM aXN0KTsKKyAgICAgICAgYXBwZW5kRGVidWdMYXllcnMobGF5ZXJMaXN0KTsKKyAgICAgICAgbV9z dHJ1Y3R1cmFsTGF5ZXItPnNldFN1YmxheWVycyhsYXllckxpc3QpOworICAgIH0gZWxzZSB7Cisg ICAgICAgIGFwcGVuZExheWVyc0Zyb21DaGlsZHJlbihwcmltYXJ5TGF5ZXJDaGlsZHJlbik7Cisg ICAgICAgIGFwcGVuZERlYnVnTGF5ZXJzKHByaW1hcnlMYXllckNoaWxkcmVuKTsKKyAgICB9CiAK LSAgICBpZiAobV9zdHJ1Y3R1cmFsTGF5ZXIpCi0gICAgICAgIG1fc3RydWN0dXJhbExheWVyLT5z ZXRTdWJsYXllcnMoc3RydWN0dXJhbExheWVyQ2hpbGRyZW4pOwotICAgIAogICAgIG1fbGF5ZXIt PnNldFN1YmxheWVycyhwcmltYXJ5TGF5ZXJDaGlsZHJlbik7CiB9CiAK