21113 2008-09-25 11:41:12 -0700 r36771 caused www.nytimes.com to not display when you return to it using back/forward 2008-09-25 18:22:26 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://www.nytimes.com P2 Normal --- 1 beidson hyatt civic.mac hyatt naofumi oldest_to_newest 92764 0 beidson 2008-09-25 11:41:12 -0700 r36771 caused www.nytimes.com to not display when you return to it using back/forward. Since this was primarily a "cleanup patch", I rolled it out in r36902 as this was a pretty severe regression (important site). Steps to reproduce with 36771 in place: 1 - Visit www.google.com, let it finish loading 2 - Visit www.nytimes.com, let it finish loading 3 - Click "back" to return to google.com 4 - Click "forward" to return to nytimes.com After step 4, nytimes.com is blank. All of the resources are there and loaded, and Cmd-R to forcefully refresh the page causes it to actually render, but whenever you return to it through back or forward, it is always blank. 92781 1 23817 hyatt 2008-09-25 12:58:57 -0700 Created attachment 23817 Patch #2 92786 2 23817 darin 2008-09-25 13:10:01 -0700 Comment on attachment 23817 Patch #2 CSSRule* CSSRule::parentRule() const { - // FIXME: I believe this always returns 0. - // A correct implementation would have to look farther up than just the parent. return (parent() && parent()->isRule()) ? static_cast<CSSRule*>(parent()) : 0; } Why is this comment wrong. Isn't the parent almost always a style sheet, and not a rule? r=me 92788 3 hyatt 2008-09-25 13:16:17 -0700 Fixed in r36904. 92801 4 hyatt 2008-09-25 14:11:22 -0700 *** Bug 21119 has been marked as a duplicate of this bug. *** 92839 5 dev+webkit 2008-09-25 18:22:26 -0700 *** Bug 21125 has been marked as a duplicate of this bug. *** 23817 2008-09-25 12:58:57 -0700 2008-09-25 13:10:01 -0700 Patch #2 patch.txt text/plain 5312 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM2OTAy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMDkt MjUgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTExMworCisgICAgICAgIFB1dHRpbmcgcjM2 NzcxIGJhY2sgaW4gd2l0aCBhIGZpeCB0byB0aGUgYWRkUGVuZGluZ1NoZWV0IGNoZWNrIGluIENT U0ltcG9ydFJ1bGU6Omluc2VydGVkSW50b1BhcmVudC4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9DU1NJbXBvcnRSdWxlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNTU0ltcG9ydFJ1bGU6Omluc2VydGVkSW50b1BhcmVudCk6CisgICAgICAg ICogY3NzL0NTU1J1bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUnVsZTo6cGFyZW50U3R5 bGVTaGVldCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NSdWxlOjpwYXJlbnRSdWxlKToKKyAgICAg ICAgKiBjc3MvQ1NTU3R5bGVTaGVldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNo ZWV0OjpDU1NTdHlsZVNoZWV0KToKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTaGVldC5oOgorCiAy MDA4LTA5LTI1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBS dWJiZXJzdGFtcGVkIGJ5IE1hcmsgUm93ZQpJbmRleDogY3NzL0NTU0ltcG9ydFJ1bGUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGNzcy9DU1NJbXBvcnRSdWxlLmNwcAkocmV2aXNpb24gMzY5MDIpCisrKyBj c3MvQ1NTSW1wb3J0UnVsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc0LDI3ICs3NCwyNiBAQCBi b29sIENTU0ltcG9ydFJ1bGU6OmlzTG9hZGluZygpIGNvbnN0CiAKIHZvaWQgQ1NTSW1wb3J0UnVs ZTo6aW5zZXJ0ZWRJbnRvUGFyZW50KCkKIHsKLSAgICBTdHlsZUJhc2UqIHJvb3QgPSB0aGlzOwot ICAgIFN0eWxlQmFzZSogcGFyZW50OwotICAgIHdoaWxlICgocGFyZW50ID0gcm9vdC0+cGFyZW50 KCkpKQotICAgICAgICByb290ID0gcGFyZW50OwotICAgIGlmICghcm9vdC0+aXNDU1NTdHlsZVNo ZWV0KCkpCisgICAgQ1NTU3R5bGVTaGVldCogcGFyZW50U2hlZXQgPSBwYXJlbnRTdHlsZVNoZWV0 KCk7CisgICAgaWYgKCFwYXJlbnRTaGVldCkKICAgICAgICAgcmV0dXJuOwotICAgIERvY0xvYWRl ciogZG9jTG9hZGVyID0gc3RhdGljX2Nhc3Q8Q1NTU3R5bGVTaGVldCo+KHJvb3QpLT5kb2NMb2Fk ZXIoKTsKKworICAgIERvY0xvYWRlciogZG9jTG9hZGVyID0gcGFyZW50U2hlZXQtPmRvYygpLT5k b2NMb2FkZXIoKTsKICAgICBpZiAoIWRvY0xvYWRlcikKICAgICAgICAgcmV0dXJuOwogCiAgICAg U3RyaW5nIGFic0hyZWYgPSBtX3N0ckhyZWY7Ci0gICAgQ1NTU3R5bGVTaGVldCogcGFyZW50U2hl ZXQgPSBwYXJlbnRTdHlsZVNoZWV0KCk7CiAgICAgaWYgKCFwYXJlbnRTaGVldC0+aHJlZigpLmlz TnVsbCgpKQogICAgICAgICAvLyB1c2UgcGFyZW50IHN0eWxlaGVldCdzIFVSTCBhcyB0aGUgYmFz ZSBVUkwKICAgICAgICAgYWJzSHJlZiA9IEtVUkwoS1VSTChwYXJlbnRTaGVldC0+aHJlZigpKSwg bV9zdHJIcmVmKS5zdHJpbmcoKTsKIAogICAgIC8vIENoZWNrIGZvciBhIGN5Y2xlIGluIG91ciBp bXBvcnQgY2hhaW4uICBJZiB3ZSBlbmNvdW50ZXIgYSBzdHlsZXNoZWV0CiAgICAgLy8gaW4gb3Vy IHBhcmVudCBjaGFpbiB3aXRoIHRoZSBzYW1lIFVSTCwgdGhlbiBqdXN0IGJhaWwuCi0gICAgZm9y IChwYXJlbnQgPSBzdGF0aWNfY2FzdDxTdHlsZUJhc2UqPih0aGlzKS0+cGFyZW50KCk7IHBhcmVu dDsgcGFyZW50ID0gcGFyZW50LT5wYXJlbnQoKSkgewotICAgICAgICBpZiAocGFyZW50LT5pc0NT U1N0eWxlU2hlZXQoKSAmJiBhYnNIcmVmID09IHN0YXRpY19jYXN0PENTU1N0eWxlU2hlZXQqPihw YXJlbnQpLT5ocmVmKCkpCisgICAgU3R5bGVCYXNlKiByb290ID0gdGhpczsKKyAgICBmb3IgKFN0 eWxlQmFzZSogY3VyciA9IHBhcmVudCgpOyBjdXJyOyBjdXJyID0gY3Vyci0+cGFyZW50KCkpIHsK KyAgICAgICAgaWYgKGN1cnItPmlzQ1NTU3R5bGVTaGVldCgpICYmIGFic0hyZWYgPT0gc3RhdGlj X2Nhc3Q8Q1NTU3R5bGVTaGVldCo+KGN1cnIpLT5ocmVmKCkpCiAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIHJvb3QgPSBjdXJyOwogICAgIH0KIAogICAgIG1fY2FjaGVkU2hlZXQgPSBkb2NM b2FkZXItPnJlcXVlc3RDU1NTdHlsZVNoZWV0KGFic0hyZWYsIHBhcmVudFNoZWV0LT5jaGFyc2V0 KCkpOwpAQCAtMTAyLDcgKzEwMSw3IEBAIHZvaWQgQ1NTSW1wb3J0UnVsZTo6aW5zZXJ0ZWRJbnRv UGFyZW50KCkKICAgICAgICAgLy8gaWYgdGhlIGltcG9ydCBydWxlIGlzIGlzc3VlZCBkeW5hbWlj YWxseSwgdGhlIHNoZWV0IG1heSBiZQogICAgICAgICAvLyByZW1vdmVkIGZyb20gdGhlIHBlbmRp bmcgc2hlZXQgY291bnQsIHNvIGxldCB0aGUgZG9jIGtub3cKICAgICAgICAgLy8gdGhlIHNoZWV0 IGJlaW5nIGltcG9ydGVkIGlzIHBlbmRpbmcuCi0gICAgICAgIGlmIChwYXJlbnRTaGVldCAmJiBw YXJlbnRTaGVldC0+bG9hZENvbXBsZXRlZCgpICYmIHBhcmVudFNoZWV0LT5kb2MoKSkKKyAgICAg ICAgaWYgKHBhcmVudFNoZWV0ICYmIHBhcmVudFNoZWV0LT5sb2FkQ29tcGxldGVkKCkgJiYgcm9v dCA9PSBwYXJlbnRTaGVldCkKICAgICAgICAgICAgIHBhcmVudFNoZWV0LT5kb2MoKS0+YWRkUGVu ZGluZ1NoZWV0KCk7CiAgICAgICAgIG1fbG9hZGluZyA9IHRydWU7CiAgICAgICAgIG1fY2FjaGVk U2hlZXQtPmFkZENsaWVudCh0aGlzKTsKSW5kZXg6IGNzcy9DU1NSdWxlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBjc3MvQ1NTUnVsZS5jcHAJKHJldmlzaW9uIDM2OTAyKQorKysgY3NzL0NTU1J1bGUuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxMyArMjksMTQgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiBDU1NTdHlsZVNoZWV0KiBDU1NSdWxlOjpwYXJlbnRTdHlsZVNoZWV0KCkgY29uc3QKIHsKLSAg ICByZXR1cm4gKHBhcmVudCgpICYmIHBhcmVudCgpLT5pc0NTU1N0eWxlU2hlZXQoKSkgPyBzdGF0 aWNfY2FzdDxDU1NTdHlsZVNoZWV0Kj4ocGFyZW50KCkpIDogMDsKKyAgICBTdHlsZUJhc2UqIGN1 cnIgPSBwYXJlbnQoKTsKKyAgICB3aGlsZSAoY3VyciAmJiAhY3Vyci0+aXNDU1NTdHlsZVNoZWV0 KCkpCisgICAgICAgIGN1cnIgPSBjdXJyLT5wYXJlbnQoKTsKKyAgICByZXR1cm4gY3VyciA/IHN0 YXRpY19jYXN0PENTU1N0eWxlU2hlZXQqPihjdXJyKSA6IDA7CiB9CiAKIENTU1J1bGUqIENTU1J1 bGU6OnBhcmVudFJ1bGUoKSBjb25zdAogewotICAgIC8vIEZJWE1FOiBJIGJlbGlldmUgdGhpcyBh bHdheXMgcmV0dXJucyAwLgotICAgIC8vIEEgY29ycmVjdCBpbXBsZW1lbnRhdGlvbiB3b3VsZCBo YXZlIHRvIGxvb2sgZmFydGhlciB1cCB0aGFuIGp1c3QgdGhlIHBhcmVudC4KICAgICByZXR1cm4g KHBhcmVudCgpICYmIHBhcmVudCgpLT5pc1J1bGUoKSkgPyBzdGF0aWNfY2FzdDxDU1NSdWxlKj4o cGFyZW50KCkpIDogMDsKIH0KIApJbmRleDogY3NzL0NTU1N0eWxlU2hlZXQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGNzcy9DU1NTdHlsZVNoZWV0LmNwcAkocmV2aXNpb24gMzY5MDIpCisrKyBjc3MvQ1NT U3R5bGVTaGVldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxLDExICs1MSwxMiBAQCBDU1NTdHls ZVNoZWV0OjpDU1NTdHlsZVNoZWV0KE5vZGUgKnBhcmVuCiAKIENTU1N0eWxlU2hlZXQ6OkNTU1N0 eWxlU2hlZXQoQ1NTUnVsZSAqb3duZXJSdWxlLCBjb25zdCBTdHJpbmcmIGhyZWYsIGNvbnN0IFN0 cmluZyYgY2hhcnNldCkKICAgICA6IFN0eWxlU2hlZXQob3duZXJSdWxlLCBocmVmKQotICAgICwg bV9kb2MoMCkKICAgICAsIG1fbmFtZXNwYWNlcygwKQogICAgICwgbV9jaGFyc2V0KGNoYXJzZXQp CiAgICAgLCBtX2xvYWRDb21wbGV0ZWQoZmFsc2UpCiB7CisgICAgQ1NTU3R5bGVTaGVldCogcGFy ZW50U2hlZXQgPSBvd25lclJ1bGUgPyBvd25lclJ1bGUtPnBhcmVudFN0eWxlU2hlZXQoKSA6IDA7 CisgICAgbV9kb2MgPSBwYXJlbnRTaGVldCA/IHBhcmVudFNoZWV0LT5kb2MoKSA6IDA7CiB9CiAK IENTU1N0eWxlU2hlZXQ6On5DU1NTdHlsZVNoZWV0KCkKQEAgLTE3OSwxNSArMTgwLDYgQEAgdm9p ZCBDU1NTdHlsZVNoZWV0OjpjaGVja0xvYWRlZCgpCiAgICAgbV9sb2FkQ29tcGxldGVkID0gb3du ZXJOb2RlKCkgPyBvd25lck5vZGUoKS0+c2hlZXRMb2FkZWQoKSA6IHRydWU7CiB9CiAKLURvY0xv YWRlciAqQ1NTU3R5bGVTaGVldDo6ZG9jTG9hZGVyKCkKLXsKLSAgICBpZiAoIW1fZG9jKSAvLyBk b2MgaXMgMCBmb3IgdGhlIHVzZXItIGFuZCBkZWZhdWx0LXNoZWV0IQotICAgICAgICByZXR1cm4g MDsKLQotICAgIC8vICMjIyByZW1vdmU/IChjbGllbnRzIGp1c3QgdXNlIHNoZWV0LT5kb2MoKS0+ ZG9jTG9hZGVyKCkpCi0gICAgcmV0dXJuIG1fZG9jLT5kb2NMb2FkZXIoKTsKLX0KLQogdm9pZCBD U1NTdHlsZVNoZWV0OjpzdHlsZVNoZWV0Q2hhbmdlZCgpCiB7CiAgICAgU3R5bGVCYXNlKiByb290 ID0gdGhpczsKSW5kZXg6IGNzcy9DU1NTdHlsZVNoZWV0LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY3NzL0NT U1N0eWxlU2hlZXQuaAkocmV2aXNpb24gMzY5MDIpCisrKyBjc3MvQ1NTU3R5bGVTaGVldC5oCSh3 b3JraW5nIGNvcHkpCkBAIC04MCw4ICs4MCw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wg aXNMb2FkaW5nKCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgY2hlY2tMb2FkZWQoKTsKLSAgICBEb2NM b2FkZXIqIGRvY0xvYWRlcigpOworCiAgICAgRG9jdW1lbnQqIGRvYygpIHsgcmV0dXJuIG1fZG9j OyB9CisKICAgICBjb25zdCBTdHJpbmcmIGNoYXJzZXQoKSBjb25zdCB7IHJldHVybiBtX2NoYXJz ZXQ7IH0KIAogICAgIGJvb2wgbG9hZENvbXBsZXRlZCgpIGNvbnN0IHsgcmV0dXJuIG1fbG9hZENv bXBsZXRlZDsgfQo=