211116 2020-04-27 23:08:29 -0700 [GTK] Fix build failures for ANGLE_WEBGL after r259589 2020-04-28 15:42:30 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 changseok changseok achristensen annulen bugs-noreply dino ews-watchlist graouts gyuyoung.kim kbr kondapallykalyan ryuan.choi sergio zan oldest_to_newest 1646396 0 changseok 2020-04-27 23:08:29 -0700 SISA. 1646399 1 397811 changseok 2020-04-27 23:25:18 -0700 Created attachment 397811 Patch 1646402 2 ews-watchlist 2020-04-27 23:26:13 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1646657 3 397811 kbr 2020-04-28 13:38:36 -0700 Comment on attachment 397811 Patch LGTM but I don't have reviewer privileges. Maybe dino@ can help review. 1646693 4 kbr 2020-04-28 15:23:16 -0700 Maybe achristensen@ can help review this too? 1646707 5 ews-feeder 2020-04-28 15:42:28 -0700 Committed r260852: <https://trac.webkit.org/changeset/260852> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397811. 397811 2020-04-27 23:25:18 -0700 2020-04-28 15:42:29 -0700 Patch bug-211116-20200428022517.patch text/plain 6137 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMjQyMzkwMDA5ZmE0N2MwZmY2MGFkMTJiNDhmMWM2NWVkY2E0N2ZjZS4uZGNhYWU5NzYzZTAx NzZhODA2YWU5OWZjYTkxOWI5MTAxMGMxNzUxZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTI3ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2tA d2Via2l0Lm9yZz4KKworICAgICAgICBbR1RLXSBGaXggYnVpbGQgZmFpbHVyZXMgZm9yIEFOR0xF X1dFQkdMIGFmdGVyIHIyNTk1ODkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMTExNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBBTkdMRV9XRUJHTCBpcyBicm9rZW4gYWZ0ZXIgQU5HTEUgaXMgdXBk YXRlZCBpbiByMjU5NTg5LiBNaXNzaW5nIHNvdXJjZXMKKyAgICAgICAgc2hvdWxkIGJlIGFkZGVk IHRvIHRoZSBidWlsZCB0YXJnZXQuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogQWRk IGxpYmFuZ2xlX2dsX2VnbF9zb3VyY2VzIGFuZCBsaWJhbmdsZV9nbF9lZ2xfZGxfc291cmNlcy4K KwogMjAyMC0wNC0yNSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAg W0NvY29hXSBEZWFsIHdpdGggYW5vdGhlciByb3VuZCBvZiBYY29kZSB1cGdyYWRlIGNoZWNrcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDYzZjQ5MWQ5ZmQwNDdmODQ1MWQwZDEwMTRmMjZjN2E3MTk0MGVkMjkuLjhm NWY1YWFiMjY4MTI5Mjg2ZWNmOWQ4MGY3Mzg1MjVjNTRhY2JlM2QgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAyMC0wNC0yNyAgQ2hhbmdTZW9rIE9oICA8Y2hhbmdzZW9rQHdlYmtpdC5v cmc+CisKKyAgICAgICAgW0dUS10gRml4IGJ1aWxkIGZhaWx1cmVzIGZvciBBTkdMRV9XRUJHTCBh ZnRlciByMjU5NTg5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTExMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgY29tcGlsZXIgaXMgdW5oYXBweSB3aXRoIGNvdmVydGluZyBHQ0dMaW50NjQgKGxv bmcgbG9uZyBpbnQpIHRvIEdMSW50NjQgKGxvbmcgaW50KS4KKyAgICAgICAgUGFzc2luZyBHQ0dM dWludDYyIGFzIEdMdWludDY0IGlzIGEgc2ltaWxhciBpc3N1ZS4KKworICAgICAgICBObyBuZXcg dGVzdHMgc2luY2Ugbm8gbmV3IGZ1bmN0aW9uYWxpdGllcy4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2FuZ2xlL0V4dGVuc2lvbnNHTEFOR0xFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkV4dGVuc2lvbnNHTEFOR0xFOjpnZXRJbnRlZ2VyNjR2Um9idXN0QU5HTEUpOgorICAgICAgICAo V2ViQ29yZTo6RXh0ZW5zaW9uc0dMQU5HTEU6OmdldEludGVnZXI2NGlfdlJvYnVzdEFOR0xFKToK KyAgICAgICAgKFdlYkNvcmU6OkV4dGVuc2lvbnNHTEFOR0xFOjpnZXRCdWZmZXJQYXJhbWV0ZXJp NjR2Um9idXN0QU5HTEUpOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uc0dMQU5HTEU6Omdl dFF1ZXJ5T2JqZWN0aTY0dlJvYnVzdEFOR0xFKToKKyAgICAgICAgKFdlYkNvcmU6OkV4dGVuc2lv bnNHTEFOR0xFOjpnZXRRdWVyeU9iamVjdHVpNjR2Um9idXN0QU5HTEUpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL25pY29zaWEvdGV4bWFwL05pY29zaWFHQzNETGF5ZXIuY3BwOgorICAg ICAgICAoTmljb3NpYTo6R0MzRExheWVyOjpzd2FwQnVmZmVyc0lmTmVlZGVkKTogVW5hY2NlbGVy YXRlZCAtPiBSZW5kZXJpbmdNb2RlOjpVbmFjY2VsZXJhdGVkCisKIDIwMjAtMDQtMjUgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIEFw cGxlUGF5IGNvZGUgZnJvbSBXZWJLaXRBZGRpdGlvbnMgdG8gV2ViQ29yZSBhbmQgV2ViS2l0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9QbGF0Zm9ybUdUSy5jbWFrZSBiL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDMzZTRjNjA0MGUw OWMxZWRlNzAzNTlkZGYwMjNjZTU2MzAyMmQ1ODguLmQwMDQ3MjdlZWE4NTc0NjQyMzkxODQ0ODlm YjM1YWMyOTZlYzlkZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL1BsYXRm b3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL1BsYXRmb3JtR1RLLmNt YWtlCkBAIC0xOCw4ICsxOCwxMCBAQCBpZiAoVVNFX0FOR0xFX0VHTCkKICAgICBsaXN0KEFQUEVO RCBBTkdMRV9TT1VSQ0VTCiAgICAgICAgICR7YW5nbGVfc3lzdGVtX3V0aWxzX3NvdXJjZXNfbGlu dXh9CiAgICAgICAgICR7YW5nbGVfc3lzdGVtX3V0aWxzX3NvdXJjZXNfcG9zaXh9Ci0gICAgICAg ICR7bGliYW5nbGVfZ2xfc291cmNlc30KKyAgICAgICAgJHtsaWJhbmdsZV9nbF9lZ2xfZGxfc291 cmNlc30KKyAgICAgICAgJHtsaWJhbmdsZV9nbF9lZ2xfc291cmNlc30KICAgICAgICAgJHtsaWJh bmdsZV9nbF9nbHhfc291cmNlc30KKyAgICAgICAgJHtsaWJhbmdsZV9nbF9zb3VyY2VzfQogICAg ICkKIAogICAgIGxpc3QoQVBQRU5EIEFOR0xFX0RFRklOSVRJT05TCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9FeHRlbnNpb25zR0xBTkdMRS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9FeHRlbnNpb25zR0xBTkdM RS5jcHAKaW5kZXggMTIxNzExZTVlYjE4OTNjNGE5NTlhN2U1MjA1MzhiYmE1NDRiNGY5Zi4uM2Ux NjZkMDIyNWQ1OWYxNDMxZjg5MDA5ODBkYzQyMDQ3ZjExYzNiNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvRXh0ZW5zaW9uc0dMQU5HTEUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0V4dGVuc2lvbnNHTEFO R0xFLmNwcApAQCAtNDI1LDE3ICs0MjUsMTcgQEAgdm9pZCBFeHRlbnNpb25zR0xBTkdMRTo6Z2V0 QWN0aXZlVW5pZm9ybUJsb2NraXZSb2J1c3RBTkdMRShHQ0dMdWludCBwcm9ncmFtLCBHQ0cKIAog dm9pZCBFeHRlbnNpb25zR0xBTkdMRTo6Z2V0SW50ZWdlcjY0dlJvYnVzdEFOR0xFKEdDR0xlbnVt IHBuYW1lLCBHQ0dMc2l6ZWkgYnVmU2l6ZSwgR0NHTHNpemVpICpsZW5ndGgsIEdDR0xpbnQ2NCAq ZGF0YSkKIHsKLSAgICBnbDo6R2V0SW50ZWdlcjY0dlJvYnVzdEFOR0xFKHBuYW1lLCBidWZTaXpl LCBsZW5ndGgsIGRhdGEpOworICAgIGdsOjpHZXRJbnRlZ2VyNjR2Um9idXN0QU5HTEUocG5hbWUs IGJ1ZlNpemUsIGxlbmd0aCwgcmVpbnRlcnByZXRfY2FzdDxHTGludDY0Kj4oZGF0YSkpOwogfQog CiB2b2lkIEV4dGVuc2lvbnNHTEFOR0xFOjpnZXRJbnRlZ2VyNjRpX3ZSb2J1c3RBTkdMRShHQ0dM ZW51bSB0YXJnZXQsIEdDR0x1aW50IGluZGV4LCBHQ0dMc2l6ZWkgYnVmU2l6ZSwgR0NHTHNpemVp ICpsZW5ndGgsIEdDR0xpbnQ2NCAqZGF0YSkKIHsKLSAgICBnbDo6R2V0SW50ZWdlcjY0aV92Um9i dXN0QU5HTEUodGFyZ2V0LCBpbmRleCwgYnVmU2l6ZSwgbGVuZ3RoLCBkYXRhKTsKKyAgICBnbDo6 R2V0SW50ZWdlcjY0aV92Um9idXN0QU5HTEUodGFyZ2V0LCBpbmRleCwgYnVmU2l6ZSwgbGVuZ3Ro LCByZWludGVycHJldF9jYXN0PEdMaW50NjQqPihkYXRhKSk7CiB9CiAKIHZvaWQgRXh0ZW5zaW9u c0dMQU5HTEU6OmdldEJ1ZmZlclBhcmFtZXRlcmk2NHZSb2J1c3RBTkdMRShHQ0dMZW51bSB0YXJn ZXQsIEdDR0xlbnVtIHBuYW1lLCBHQ0dMc2l6ZWkgYnVmU2l6ZSwgR0NHTHNpemVpICpsZW5ndGgs IEdDR0xpbnQ2NCAqcGFyYW1zKQogewotICAgIGdsOjpHZXRCdWZmZXJQYXJhbWV0ZXJpNjR2Um9i dXN0QU5HTEUodGFyZ2V0LCBwbmFtZSwgYnVmU2l6ZSwgbGVuZ3RoLCBwYXJhbXMpOworICAgIGds OjpHZXRCdWZmZXJQYXJhbWV0ZXJpNjR2Um9idXN0QU5HTEUodGFyZ2V0LCBwbmFtZSwgYnVmU2l6 ZSwgbGVuZ3RoLCByZWludGVycHJldF9jYXN0PEdMaW50NjQqPihwYXJhbXMpKTsKIH0KIAogdm9p ZCBFeHRlbnNpb25zR0xBTkdMRTo6c2FtcGxlclBhcmFtZXRlcml2Um9idXN0QU5HTEUoR0NHTHVp bnQgc2FtcGxlciwgR0NHTGVudW0gcG5hbWUsIEdDR0xzaXplaSBidWZTaXplLCBjb25zdCBHQ0dM aW50ICpwYXJhbSkKQEAgLTYwMSwxMiArNjAxLDEyIEBAIHZvaWQgRXh0ZW5zaW9uc0dMQU5HTEU6 OmdldFF1ZXJ5T2JqZWN0aXZSb2J1c3RBTkdMRShHQ0dMdWludCBpZCwgR0NHTGVudW0gcG5hbWUs CiAKIHZvaWQgRXh0ZW5zaW9uc0dMQU5HTEU6OmdldFF1ZXJ5T2JqZWN0aTY0dlJvYnVzdEFOR0xF KEdDR0x1aW50IGlkLCBHQ0dMZW51bSBwbmFtZSwgR0NHTHNpemVpIGJ1ZlNpemUsIEdDR0xzaXpl aSAqbGVuZ3RoLCBHQ0dMaW50NjQgKnBhcmFtcykKIHsKLSAgICBnbDo6R2V0UXVlcnlPYmplY3Rp NjR2Um9idXN0QU5HTEUoaWQsIHBuYW1lLCBidWZTaXplLCBsZW5ndGgsIHBhcmFtcyk7CisgICAg Z2w6OkdldFF1ZXJ5T2JqZWN0aTY0dlJvYnVzdEFOR0xFKGlkLCBwbmFtZSwgYnVmU2l6ZSwgbGVu Z3RoLCByZWludGVycHJldF9jYXN0PEdMaW50NjQqPihwYXJhbXMpKTsKIH0KIAogdm9pZCBFeHRl bnNpb25zR0xBTkdMRTo6Z2V0UXVlcnlPYmplY3R1aTY0dlJvYnVzdEFOR0xFKEdDR0x1aW50IGlk LCBHQ0dMZW51bSBwbmFtZSwgR0NHTHNpemVpIGJ1ZlNpemUsIEdDR0xzaXplaSAqbGVuZ3RoLCBH Q0dMdWludDY0ICpwYXJhbXMpCiB7Ci0gICAgZ2w6OkdldFF1ZXJ5T2JqZWN0dWk2NHZSb2J1c3RB TkdMRShpZCwgcG5hbWUsIGJ1ZlNpemUsIGxlbmd0aCwgcGFyYW1zKTsKKyAgICBnbDo6R2V0UXVl cnlPYmplY3R1aTY0dlJvYnVzdEFOR0xFKGlkLCBwbmFtZSwgYnVmU2l6ZSwgbGVuZ3RoLCByZWlu dGVycHJldF9jYXN0PEdMdWludDY0Kj4ocGFyYW1zKSk7CiB9CiAKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvbmljb3NpYS90ZXhtYXAvTmljb3NpYUdDM0RM YXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lhL3RleG1h cC9OaWNvc2lhR0MzRExheWVyLmNwcAppbmRleCA0YzRjNDI2OTYxMjcxYzdiN2ExOWQyOTZhOTQw MGVmZGMwZmFjOWFlLi43NTcwMDNiMWYxMWRmNGIyNzY2YjQwOWU4MjJjZDhiNDIwZmI0YTViIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9uaWNvc2lhL3RleG1h cC9OaWNvc2lhR0MzRExheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9uaWNvc2lhL3RleG1hcC9OaWNvc2lhR0MzRExheWVyLmNwcApAQCAtOTQsNyArOTQsNyBA QCB2b2lkIEdDM0RMYXllcjo6c3dhcEJ1ZmZlcnNJZk5lZWRlZCgpCiAgICAgSW50U2l6ZSB0ZXh0 dXJlU2l6ZShtX2NvbnRleHQubV9jdXJyZW50V2lkdGgsIG1fY29udGV4dC5tX2N1cnJlbnRIZWln aHQpOwogICAgIFRleHR1cmVNYXBwZXJHTDo6RmxhZ3MgZmxhZ3MgPSBtX2NvbnRleHQuY29udGV4 dEF0dHJpYnV0ZXMoKS5hbHBoYSA/IFRleHR1cmVNYXBwZXJHTDo6U2hvdWxkQmxlbmQgOiAwOwog I2lmIFVTRShBTkdMRSkKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IGltYWdlQnVm ZmVyID0gSW1hZ2VCdWZmZXI6OmNyZWF0ZSh0ZXh0dXJlU2l6ZSwgVW5hY2NlbGVyYXRlZCk7Cisg ICAgc3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyPiBpbWFnZUJ1ZmZlciA9IEltYWdlQnVmZmVy OjpjcmVhdGUodGV4dHVyZVNpemUsIFJlbmRlcmluZ01vZGU6OlVuYWNjZWxlcmF0ZWQpOwogICAg IGlmICghaW1hZ2VCdWZmZXIpCiAgICAgICAgIHJldHVybjsKIAo=