211094 2020-04-27 14:50:25 -0700 results.webkit.org: A suite running multiple times in a commit for a single configuration may pre-empt processing 2020-04-27 16:43:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211097 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain webkit-bug-importer oldest_to_newest 1646237 0 jbedard 2020-04-27 14:50:25 -0700 This is a difficult issue to catch because it causes a race condition. If we manage to pick up the processing task before the next run reports, everything works as expected. If we report too quickly, though, we over-write the redis key of the first run. 1646246 1 webkit-bug-importer 2020-04-27 14:56:49 -0700 <rdar://problem/62470170> 1646249 2 397746 jbedard 2020-04-27 14:58:39 -0700 Created attachment 397746 Patch 1646254 3 397746 aakash_jain 2020-04-27 15:02:57 -0700 Comment on attachment 397746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397746&action=review > Tools/resultsdbpy/resultsdbpy/model/upload_context.py:195 > + hash_key = hash(configuration) ^ hash(branch) ^ hash(self.commit_context.uuid_for_commits(commits)) ^ hash(suite) ^ hash(timestamp) Bug description or Changelog can be made more descriptive explaining that the hash key was colliding in certain cases. 1646290 4 397759 jbedard 2020-04-27 16:10:28 -0700 Created attachment 397759 Patch for landing 1646297 5 ews-feeder 2020-04-27 16:32:42 -0700 Committed r260796: <https://trac.webkit.org/changeset/260796> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397759. 397746 2020-04-27 14:58:39 -0700 2020-04-27 16:10:26 -0700 Patch bug-211094-20200427145839.patch text/plain 1732 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MDc4NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA0LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEEgc3VpdGUgcnVubmluZyBtdWx0aXBs ZSB0aW1lcyBpbiBhIGNvbW1pdCBmb3IgYSBzaW5nbGUgY29uZmlndXJhdGlvbiBtYXkgcHJlLWVt cHQgcHJvY2Vzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjExMDk0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjQ3MDE3MD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L21vZGVsL3VwbG9hZF9jb250ZXh0LnB5OgorICAgICAgICAoVXBsb2FkQ29udGV4 dC5wcm9jZXNzX3Rlc3RfcmVzdWx0cyk6IEluY2x1ZGUgdXBsb2FkIHRpbWVzdGFtcCBpbiB0aGUg aGFzaGVkIGtleS4KKwogMjAyMC0wNC0yNyAgWmhpZmVpIEZhbmcgIDx6aGlmZWlfZmFuZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHNvbWUgZGVidWcgb3V0cHV0IGZvciBydW4tanNjLXN0cmVz cy10ZXN0cwpJbmRleDogVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvdXBsb2Fk X2NvbnRleHQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkv bW9kZWwvdXBsb2FkX2NvbnRleHQucHkJKHJldmlzaW9uIDI2MDc4NykKKysrIFRvb2xzL3Jlc3Vs dHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL3VwbG9hZF9jb250ZXh0LnB5CSh3b3JraW5nIGNvcHkp CkBAIC0xOTIsOCArMTkyLDcgQEAgY2xhc3MgVXBsb2FkQ29udGV4dChvYmplY3QpOgogICAgICAg ICAgICAgcmV0dXJuIHNlbGYuc3luY2hyb25vdXNseV9wcm9jZXNzX3Rlc3RfcmVzdWx0cyhjb25m aWd1cmF0aW9uLCBjb21taXRzLCBzdWl0ZSwgdGVzdF9yZXN1bHRzPXRlc3RfcmVzdWx0cywgdGlt ZXN0YW1wPXRpbWVzdGFtcCkKIAogICAgICAgICBmb3IgYnJhbmNoIGluIHNlbGYuY29tbWl0X2Nv bnRleHQuYnJhbmNoX2tleXNfZm9yX2NvbW1pdHMoY29tbWl0cyk6Ci0gICAgICAgICAgICBoYXNo X2tleSA9IGhhc2goY29uZmlndXJhdGlvbikgXiBoYXNoKGJyYW5jaCkgXiBoYXNoKHNlbGYuY29t bWl0X2NvbnRleHQudXVpZF9mb3JfY29tbWl0cyhjb21taXRzKSkgXiBoYXNoKAotICAgICAgICAg ICAgICAgIHN1aXRlKQorICAgICAgICAgICAgaGFzaF9rZXkgPSBoYXNoKGNvbmZpZ3VyYXRpb24p IF4gaGFzaChicmFuY2gpIF4gaGFzaChzZWxmLmNvbW1pdF9jb250ZXh0LnV1aWRfZm9yX2NvbW1p dHMoY29tbWl0cykpIF4gaGFzaChzdWl0ZSkgXiBoYXNoKHRpbWVzdGFtcCkKICAgICAgICAgICAg IHNlbGYucmVkaXMuc2V0KAogICAgICAgICAgICAgICAgIGYne3NlbGYuUVVFVUVfTkFNRX06e2hh c2hfa2V5fScsCiAgICAgICAgICAgICAgICAganNvbi5kdW1wcyhkaWN0KHN0YXJ0ZWRfcHJvY2Vz c2luZz0wLCBhdHRlbXB0cz0wKSksCg== 397759 2020-04-27 16:10:28 -0700 2020-04-27 16:32:43 -0700 Patch for landing bug-211094-20200427161027.patch text/plain 1814 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MDc5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTA0LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEEgc3VpdGUgcnVubmluZyBtdWx0aXBs ZSB0aW1lcyBpbiBhIGNvbW1pdCBmb3IgYSBzaW5nbGUgY29uZmlndXJhdGlvbiBtYXkgcHJlLWVt cHQgcHJvY2Vzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjExMDk0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjQ3MDE3MD4KKworICAgICAg ICBSZXZpZXdlZCBieSBBYWthc2ggSmFpbi4KKworICAgICAgICBIYXNoIGNvbGxpc2lvbiBpbiBw cm9jZXNzaW5nIGtleSB3aGVuIHJlc3VsdHMgb25seSBkaWZmZXIgYnkgdXBsb2FkIHRpbWUuCisK KyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC91cGxvYWRfY29udGV4dC5w eToKKyAgICAgICAgKFVwbG9hZENvbnRleHQucHJvY2Vzc190ZXN0X3Jlc3VsdHMpOiBJbmNsdWRl IHVwbG9hZCB0aW1lc3RhbXAgaW4gdGhlIGhhc2hlZCBrZXkuCisKIDIwMjAtMDQtMjcgIFpoaWZl aSBGYW5nICA8emhpZmVpX2ZhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIGRlYnVn IG91dHB1dCBmb3IgcnVuLWpzYy1zdHJlc3MtdGVzdHMKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5 L3Jlc3VsdHNkYnB5L21vZGVsL3VwbG9hZF9jb250ZXh0LnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL3VwbG9hZF9jb250ZXh0LnB5CShyZXZpc2lv biAyNjA3OTUpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC91cGxvYWRf Y29udGV4dC5weQkod29ya2luZyBjb3B5KQpAQCAtMTkyLDggKzE5Miw3IEBAIGNsYXNzIFVwbG9h ZENvbnRleHQob2JqZWN0KToKICAgICAgICAgICAgIHJldHVybiBzZWxmLnN5bmNocm9ub3VzbHlf cHJvY2Vzc190ZXN0X3Jlc3VsdHMoY29uZmlndXJhdGlvbiwgY29tbWl0cywgc3VpdGUsIHRlc3Rf cmVzdWx0cz10ZXN0X3Jlc3VsdHMsIHRpbWVzdGFtcD10aW1lc3RhbXApCiAKICAgICAgICAgZm9y IGJyYW5jaCBpbiBzZWxmLmNvbW1pdF9jb250ZXh0LmJyYW5jaF9rZXlzX2Zvcl9jb21taXRzKGNv bW1pdHMpOgotICAgICAgICAgICAgaGFzaF9rZXkgPSBoYXNoKGNvbmZpZ3VyYXRpb24pIF4gaGFz aChicmFuY2gpIF4gaGFzaChzZWxmLmNvbW1pdF9jb250ZXh0LnV1aWRfZm9yX2NvbW1pdHMoY29t bWl0cykpIF4gaGFzaCgKLSAgICAgICAgICAgICAgICBzdWl0ZSkKKyAgICAgICAgICAgIGhhc2hf a2V5ID0gaGFzaChjb25maWd1cmF0aW9uKSBeIGhhc2goYnJhbmNoKSBeIGhhc2goc2VsZi5jb21t aXRfY29udGV4dC51dWlkX2Zvcl9jb21taXRzKGNvbW1pdHMpKSBeIGhhc2goc3VpdGUpIF4gaGFz aCh0aW1lc3RhbXApCiAgICAgICAgICAgICBzZWxmLnJlZGlzLnNldCgKICAgICAgICAgICAgICAg ICBmJ3tzZWxmLlFVRVVFX05BTUV9OntoYXNoX2tleX0nLAogICAgICAgICAgICAgICAgIGpzb24u ZHVtcHMoZGljdChzdGFydGVkX3Byb2Nlc3Npbmc9MCwgYXR0ZW1wdHM9MCkpLAo=