211089 2020-04-27 12:11:33 -0700 [JSC] Add $vm.assertEnabled() to suppress Debug crash expected tests in release+assert build 2020-04-27 14:15:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1646125 0 ysuzuki 2020-04-27 12:11:33 -0700 We have ASSERT which only fires when DOM object is wrongly implemented to catch wrong ones. We are using ASSERT in JSC side since we don't know all the DOM objects are correctly implemented. If it is not correctly implemented, in Release build, JSC is returning sub-optimal results. But in Debug build, we can catch the wrong ones, which allows us to fix the wrong thing while avoiding catastrophic crashes in release build. However, the test is assuming that ASSERT is not enabled if it is not Debug build. Release & Debug builds work, but Release+Assert does not meet this assumption. So, skip this based on `$vm.assertEnabled()`. 1646130 1 397713 ysuzuki 2020-04-27 12:22:59 -0700 Created attachment 397713 Patch 1646132 2 397715 ysuzuki 2020-04-27 12:25:48 -0700 Created attachment 397715 Patch 1646138 3 397715 keith_miller 2020-04-27 12:33:43 -0700 Comment on attachment 397715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397715&action=review r=me with suggestion > JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js:19 > +if (!$vm.assertEnabled()) { Why not `if (!$vm.assertEnabled()) quit()` 1646175 4 397715 ysuzuki 2020-04-27 13:39:15 -0700 Comment on attachment 397715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397715&action=review >> JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js:19 >> +if (!$vm.assertEnabled()) { > > Why not `if (!$vm.assertEnabled()) quit()` Sounds good! 1646206 5 ysuzuki 2020-04-27 14:14:23 -0700 Committed r260784: <https://trac.webkit.org/changeset/260784> 1646207 6 webkit-bug-importer 2020-04-27 14:15:17 -0700 <rdar://problem/62468324> 397713 2020-04-27 12:22:59 -0700 2020-04-27 12:25:47 -0700 Patch bug-211089-20200427122246.patch text/plain 6392 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZmVkYTI1ZDcxZGJlN2Q0NmQ3NzYxYmYwM2JhYmQ4NGYxMTRmYTkyLi4yMGJlNTc2NmY0NTQwZmQz MDk2NmZjYmVhMDYyODlmNWU1NTQ5ODFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0yNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCAkdm0uYXNzZXJ0RW5hYmxlZCgpIHRvIHN1cHByZXNzIERl YnVnIGNyYXNoIGV4cGVjdGVkIHRlc3RzIGluIHJlbGVhc2UrYXNzZXJ0IGJ1aWxkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEwODkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2UgQVNTRVJUX0VO QUJMRUQgY29uZGl0aW9uIHRvIHRoZSBzaGVsbCB0byBjb250cm9sIGNyYXNoIGV4cGVjdGVkIHRl c3RzLgorCisgICAgICAgICogdG9vbHMvSlNEb2xsYXJWTS5jcHA6CisgICAgICAgIChKU0M6OmZ1 bmN0aW9uQXNzZXJ0RW5hYmxlZCk6CisgICAgICAgIChKU0M6OkpTRG9sbGFyVk06OmZpbmlzaENy ZWF0aW9uKToKKwogMjAyMC0wNC0yNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CiAKICAgICAgICAgW0pTQ10gQ2FsbERhdGEvQ29uc3RydWN0RGF0YSBzaG91bGQgaW5j bHVkZSBDYWxsVHlwZS9Db25zdHJ1Y3RUeXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMv SlNEb2xsYXJWTS5jcHAKaW5kZXggYTcwZDYxMTAyNGRmNTM2NjU2MTQyYzA1MWU1Njc5NGE1NGY1 YTQ1Yy4uNGYxYTNiYTZlMmNiODQ5ODBlMjIyMjMxYmNlZGZkYjVkYzQ1MTlmMCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNLmNwcApAQCAtMjk4NCw2ICsyOTg0LDEx IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uSUNVVmVyc2lv bihKU0dsb2JhbE9iamVjdCosIENhbGxGcmFtCiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShq c051bWJlcih2ZXJzaW9uSW5mb1swXSkpOwogfQogCitzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBmdW5jdGlvbkFzc2VydEVuYWJsZWQoSlNHbG9iYWxPYmplY3QqLCBDYWxsRnJh bWUqKQoreworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFuKEFTU0VSVF9FTkFC TEVEKSk7Cit9CisKIHZvaWQgSlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogewog ICAgIERvbGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CkBAIC0zMTIzLDYgKzMxMjgsOCBA QCB2b2lkIEpTRG9sbGFyVk06OmZpbmlzaENyZWF0aW9uKFZNJiB2bSkKICAgICBhZGRGdW5jdGlv bih2bSwgInNldFVzZXJQcmVmZXJyZWRMYW5ndWFnZXMiLCBmdW5jdGlvblNldFVzZXJQcmVmZXJy ZWRMYW5ndWFnZXMsIDEpOwogICAgIGFkZEZ1bmN0aW9uKHZtLCAiaWN1VmVyc2lvbiIsIGZ1bmN0 aW9uSUNVVmVyc2lvbiwgMCk7CiAKKyAgICBhZGRGdW5jdGlvbih2bSwgImFzc2VydEVuYWJsZWQi LCBmdW5jdGlvbkFzc2VydEVuYWJsZWQsIDApOworCiAgICAgbV9vYmplY3REb2luZ1NpZGVFZmZl Y3RQdXRXaXRob3V0Q29ycmVjdFNsb3RTdGF0dXNTdHJ1Y3R1cmUuc2V0KHZtLCB0aGlzLCBPYmpl Y3REb2luZ1NpZGVFZmZlY3RQdXRXaXRob3V0Q29ycmVjdFNsb3RTdGF0dXM6OmNyZWF0ZVN0cnVj dHVyZSh2bSwgZ2xvYmFsT2JqZWN0LCBqc051bGwoKSkpOwogfQogCmRpZmYgLS1naXQgYS9KU1Rl c3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDIwZmZhYTdlZWRkY2JhZTk3 MzE0OWJmOWUxYzQ5MjA2NDRmY2FjZTEuLjVhMzAxZmM1YjI3YjBkMmFhZThhYzYxOGM4NjBjMzc1 MzQ1OTI2MDcgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMjAtMDQtMjcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgJHZtLmFzc2VydEVuYWJsZWQoKSB0 byBzdXBwcmVzcyBEZWJ1ZyBjcmFzaCBleHBlY3RlZCB0ZXN0cyBpbiByZWxlYXNlK2Fzc2VydCBi dWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEx MDg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug aGF2ZSBBU1NFUlQgd2hpY2ggb25seSBmaXJlcyB3aGVuIERPTSBvYmplY3QgaXMgd3JvbmdseSBp bXBsZW1lbnRlZCB0byBjYXRjaCB3cm9uZyBvbmVzLgorICAgICAgICBXZSBhcmUgdXNpbmcgQVNT RVJUIGluIEpTQyBzaWRlIHNpbmNlIHdlIGRvbid0IGtub3cgYWxsIHRoZSBET00gb2JqZWN0cyBh cmUgY29ycmVjdGx5IGltcGxlbWVudGVkLgorICAgICAgICBJZiBpdCBpcyBub3QgY29ycmVjdGx5 IGltcGxlbWVudGVkLCBpbiBSZWxlYXNlIGJ1aWxkLCBKU0MgaXMgcmV0dXJuaW5nIHN1Yi1vcHRp bWFsIGJ1dCByaWdodCByZXN1bHRzLgorICAgICAgICBCdXQgaW4gRGVidWcgYnVpbGQsIHdlIGNh biBjYXRjaCB0aGUgd3Jvbmcgb25lcywgd2hpY2ggYWxsb3dzIHVzIHRvIGZpeCB0aGUgd3Jvbmcg dGhpbmdzIHdoaWxlIGF2b2lkaW5nCisgICAgICAgIGNhdGFzdHJvcGhpYyBjcmFzaGVzIGluIHJl bGVhc2UgYnVpbGQuCisKKyAgICAgICAgSG93ZXZlciwgdGhlIHRlc3QgaXMgYXNzdW1pbmcgdGhh dCBBU1NFUlQgaXMgbm90IGVuYWJsZWQgaWYgaXQgaXMgbm90IERlYnVnIGJ1aWxkLiBSZWxlYXNl ICYgRGVidWcgYnVpbGRzCisgICAgICAgIHdvcmssIGJ1dCBSZWxlYXNlK0Fzc2VydCBkb2VzIG5v dCBtZWV0IHRoaXMgYXNzdW1wdGlvbi4KKworICAgICAgICBTbywgc2tpcCB0aGlzIGJhc2VkIG9u IGAkdm0uYXNzZXJ0RW5hYmxlZCgpYC4KKworICAgICAgICAqIHN0cmVzcy9pbmNvcnJlY3QtcHV0 LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5nLWJhZC1iZWhh dmlvci5qczoKKyAgICAgICAgKHZtLmFzc2VydEVuYWJsZWQucHV0dGVyKToKKyAgICAgICAgKHZt LmFzc2VydEVuYWJsZWQpOgorICAgICAgICAocHV0dGVyKTogRGVsZXRlZC4KKyAgICAgICAgKG5v dF9zdHJpbmcudG9TdHJpbmcpOiBEZWxldGVkLgorICAgICAgICAqIHN0cmVzcy9pbmNvcnJlY3Qt cHV0LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtaW52b2x2aW5nLWRpY3Rpb25hcnktZmxhdHRl bi5qczoKKyAgICAgICAgKHZtLmFzc2VydEVuYWJsZWQpOgorICAgICAgICAobm90X3N0cmluZy50 b1N0cmluZyk6IERlbGV0ZWQuCisKIDIwMjAtMDQtMjYgIEFsZXhleSBTaHZheWthICA8c2h2YWlr YWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIFN5bWJvbCBzaG91bGQgaGF2ZSBbW0NvbnN0cnVj dF1dIGludGVybmFsIG1ldGhvZApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvaW5jb3JyZWN0 LXB1dC1jb3VsZC1nZW5lcmF0ZS1pbnZhbGlkLWljLWJ1dC1zdGlsbC1ub3QtY2F1c2luZy1iYWQt YmVoYXZpb3IuanMgYi9KU1Rlc3RzL3N0cmVzcy9pbmNvcnJlY3QtcHV0LWNvdWxkLWdlbmVyYXRl LWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5nLWJhZC1iZWhhdmlvci5qcwppbmRleCA0 ZGZkYTM4ZDgyOTg2MjUxNTgxMjQ2OTdhYmVhZTdhNGYxZjk4MTkyLi5jYmRmNjBkNGE2ODFlMDNk M2VjOWE5MTNiOTlkNjM3MDgzMTllNTg2IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9pbmNv cnJlY3QtcHV0LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5n LWJhZC1iZWhhdmlvci5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9pbmNvcnJlY3QtcHV0LWNvdWxk LWdlbmVyYXRlLWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5nLWJhZC1iZWhhdmlvci5q cwpAQCAtNSwyMiArNSwyNCBAQCBmdW5jdGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVkKSB7 CiAgICAgICAgIHRocm93IG5ldyBFcnJvcignYmFkIHZhbHVlOiAnICsgYWN0dWFsKTsKIH0KIAot dmFyIHB1dHRlciA9IGZ1bmN0aW9uKG8pIHsKLSAgICBvLl91bnN1cHBvcnRlZCA9IG5vdF9zdHJp bmc7Ci19Ci0KLXZhciBvYmplY3Q7Ci12YXIgY291bnRlciA9IDA7Ci12YXIgbm90X3N0cmluZyA9 IHsKLSAgICB0b1N0cmluZygpIHsKLSAgICAgICAgY291bnRlcisrOwotICAgICAgICBvYmplY3Qu b2sgPSA0MjsKLSAgICAgICAgcmV0dXJuICJIZXkiOworaWYgKCEkdm0uYXNzZXJ0RW5hYmxlZCgp KSB7CisgICAgdmFyIHB1dHRlciA9IGZ1bmN0aW9uKG8pIHsKKyAgICAgICAgby5fdW5zdXBwb3J0 ZWQgPSBub3Rfc3RyaW5nOwogICAgIH0KLX07CiAKLWZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDsg KytpKSB7Ci0gICAgb2JqZWN0ID0gJHZtLmNyZWF0ZU9iamVjdERvaW5nU2lkZUVmZmVjdFB1dFdp dGhvdXRDb3JyZWN0U2xvdFN0YXR1cygpOwotICAgIHB1dHRlcihvYmplY3QpOworICAgIHZhciBv YmplY3Q7CisgICAgdmFyIGNvdW50ZXIgPSAwOworICAgIHZhciBub3Rfc3RyaW5nID0geworICAg ICAgICB0b1N0cmluZygpIHsKKyAgICAgICAgICAgIGNvdW50ZXIrKzsKKyAgICAgICAgICAgIG9i amVjdC5vayA9IDQyOworICAgICAgICAgICAgcmV0dXJuICJIZXkiOworICAgICAgICB9CisgICAg fTsKKworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDsgKytpKSB7CisgICAgICAgIG9iamVj dCA9ICR2bS5jcmVhdGVPYmplY3REb2luZ1NpZGVFZmZlY3RQdXRXaXRob3V0Q29ycmVjdFNsb3RT dGF0dXMoKTsKKyAgICAgICAgcHV0dGVyKG9iamVjdCk7CisgICAgfQorICAgIHNob3VsZEJlKGNv dW50ZXIsIDEwMDApOwogfQotc2hvdWxkQmUoY291bnRlciwgMTAwMCk7CmRpZmYgLS1naXQgYS9K U1Rlc3RzL3N0cmVzcy9pbmNvcnJlY3QtcHV0LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtaW52 b2x2aW5nLWRpY3Rpb25hcnktZmxhdHRlbi5qcyBiL0pTVGVzdHMvc3RyZXNzL2luY29ycmVjdC1w dXQtY291bGQtZ2VuZXJhdGUtaW52YWxpZC1pYy1pbnZvbHZpbmctZGljdGlvbmFyeS1mbGF0dGVu LmpzCmluZGV4IDMzNGExOTAxMTZmOTc3ZDQwN2IyMDI5ZDg3NzNjYWIyNzZjZTYwNGIuLjRmMWJl NDRhYjAzNDVlZDdkZDI5MTUzMzQ4ZjgyNzg1ZTM1YWRkZWMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMv c3RyZXNzL2luY29ycmVjdC1wdXQtY291bGQtZ2VuZXJhdGUtaW52YWxpZC1pYy1pbnZvbHZpbmct ZGljdGlvbmFyeS1mbGF0dGVuLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL2luY29ycmVjdC1wdXQt Y291bGQtZ2VuZXJhdGUtaW52YWxpZC1pYy1pbnZvbHZpbmctZGljdGlvbmFyeS1mbGF0dGVuLmpz CkBAIC0xNiwxOCArMTYsMjAgQEAgZnVuY3Rpb24gcHV0dGVyKG8pIHsKICAgICBvLl91bnN1cHBv cnRlZCA9IG5vdF9zdHJpbmc7CiB9CiAKLXZhciBkOwotdmFyIG5vdF9zdHJpbmcgPSB7Ci0gICAg dG9TdHJpbmcoKSB7Ci0gICAgICAgIGZvcih2YXIgaSA9IDM7IGkgPCA2NjsgaSsrKQotICAgICAg ICAgICAgZGVsZXRlIGRbJ3AnK2ldOwotICAgICAgICBmb3IoaSBpbiBPYmplY3QuY3JlYXRlKGQp KTsKLSAgICAgICAgcmV0dXJuIG51bGw7Ci0gICAgfQotfTsKK2lmICgkdm0uYXNzZXJ0RW5hYmxl ZCgpKSB7CisgICAgdmFyIGQ7CisgICAgdmFyIG5vdF9zdHJpbmcgPSB7CisgICAgICAgIHRvU3Ry aW5nKCkgeworICAgICAgICAgICAgZm9yKHZhciBpID0gMzsgaSA8IDY2OyBpKyspCisgICAgICAg ICAgICAgICAgZGVsZXRlIGRbJ3AnK2ldOworICAgICAgICAgICAgZm9yKGkgaW4gT2JqZWN0LmNy ZWF0ZShkKSk7CisgICAgICAgICAgICByZXR1cm4gbnVsbDsKKyAgICAgICAgfQorICAgIH07CiAK LWZvciAodmFyIGkgPSAwOyBpIDwgMTAwOyArK2kpIHsKLSAgICBkID0gZGljdGlvbmFyeSgpOwot ICAgIHB1dHRlcihkKTsKLSAgICBzaG91bGRCZSgncDMnIGluIGQsIGZhbHNlKTsKKyAgICBmb3Ig KHZhciBpID0gMDsgaSA8IDEwMDsgKytpKSB7CisgICAgICAgIGQgPSBkaWN0aW9uYXJ5KCk7Cisg ICAgICAgIHB1dHRlcihkKTsKKyAgICAgICAgc2hvdWxkQmUoJ3AzJyBpbiBkLCBmYWxzZSk7Cisg ICAgfQogfQo= 397715 2020-04-27 12:25:48 -0700 2020-04-27 12:33:43 -0700 Patch bug-211089-20200427122535.patch text/plain 6393 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZmVkYTI1ZDcxZGJlN2Q0NmQ3NzYxYmYwM2JhYmQ4NGYxMTRmYTkyLi4yMGJlNTc2NmY0NTQwZmQz MDk2NmZjYmVhMDYyODlmNWU1NTQ5ODFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0yNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCAkdm0uYXNzZXJ0RW5hYmxlZCgpIHRvIHN1cHByZXNzIERl YnVnIGNyYXNoIGV4cGVjdGVkIHRlc3RzIGluIHJlbGVhc2UrYXNzZXJ0IGJ1aWxkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEwODkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2UgQVNTRVJUX0VO QUJMRUQgY29uZGl0aW9uIHRvIHRoZSBzaGVsbCB0byBjb250cm9sIGNyYXNoIGV4cGVjdGVkIHRl c3RzLgorCisgICAgICAgICogdG9vbHMvSlNEb2xsYXJWTS5jcHA6CisgICAgICAgIChKU0M6OmZ1 bmN0aW9uQXNzZXJ0RW5hYmxlZCk6CisgICAgICAgIChKU0M6OkpTRG9sbGFyVk06OmZpbmlzaENy ZWF0aW9uKToKKwogMjAyMC0wNC0yNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CiAKICAgICAgICAgW0pTQ10gQ2FsbERhdGEvQ29uc3RydWN0RGF0YSBzaG91bGQgaW5j bHVkZSBDYWxsVHlwZS9Db25zdHJ1Y3RUeXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMv SlNEb2xsYXJWTS5jcHAKaW5kZXggYTcwZDYxMTAyNGRmNTM2NjU2MTQyYzA1MWU1Njc5NGE1NGY1 YTQ1Yy4uNGYxYTNiYTZlMmNiODQ5ODBlMjIyMjMxYmNlZGZkYjVkYzQ1MTlmMCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNLmNwcApAQCAtMjk4NCw2ICsyOTg0LDEx IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uSUNVVmVyc2lv bihKU0dsb2JhbE9iamVjdCosIENhbGxGcmFtCiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShq c051bWJlcih2ZXJzaW9uSW5mb1swXSkpOwogfQogCitzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBmdW5jdGlvbkFzc2VydEVuYWJsZWQoSlNHbG9iYWxPYmplY3QqLCBDYWxsRnJh bWUqKQoreworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFuKEFTU0VSVF9FTkFC TEVEKSk7Cit9CisKIHZvaWQgSlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogewog ICAgIERvbGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CkBAIC0zMTIzLDYgKzMxMjgsOCBA QCB2b2lkIEpTRG9sbGFyVk06OmZpbmlzaENyZWF0aW9uKFZNJiB2bSkKICAgICBhZGRGdW5jdGlv bih2bSwgInNldFVzZXJQcmVmZXJyZWRMYW5ndWFnZXMiLCBmdW5jdGlvblNldFVzZXJQcmVmZXJy ZWRMYW5ndWFnZXMsIDEpOwogICAgIGFkZEZ1bmN0aW9uKHZtLCAiaWN1VmVyc2lvbiIsIGZ1bmN0 aW9uSUNVVmVyc2lvbiwgMCk7CiAKKyAgICBhZGRGdW5jdGlvbih2bSwgImFzc2VydEVuYWJsZWQi LCBmdW5jdGlvbkFzc2VydEVuYWJsZWQsIDApOworCiAgICAgbV9vYmplY3REb2luZ1NpZGVFZmZl Y3RQdXRXaXRob3V0Q29ycmVjdFNsb3RTdGF0dXNTdHJ1Y3R1cmUuc2V0KHZtLCB0aGlzLCBPYmpl Y3REb2luZ1NpZGVFZmZlY3RQdXRXaXRob3V0Q29ycmVjdFNsb3RTdGF0dXM6OmNyZWF0ZVN0cnVj dHVyZSh2bSwgZ2xvYmFsT2JqZWN0LCBqc051bGwoKSkpOwogfQogCmRpZmYgLS1naXQgYS9KU1Rl c3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDIwZmZhYTdlZWRkY2JhZTk3 MzE0OWJmOWUxYzQ5MjA2NDRmY2FjZTEuLjVhMzAxZmM1YjI3YjBkMmFhZThhYzYxOGM4NjBjMzc1 MzQ1OTI2MDcgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMjAtMDQtMjcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgJHZtLmFzc2VydEVuYWJsZWQoKSB0 byBzdXBwcmVzcyBEZWJ1ZyBjcmFzaCBleHBlY3RlZCB0ZXN0cyBpbiByZWxlYXNlK2Fzc2VydCBi dWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEx MDg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug aGF2ZSBBU1NFUlQgd2hpY2ggb25seSBmaXJlcyB3aGVuIERPTSBvYmplY3QgaXMgd3JvbmdseSBp bXBsZW1lbnRlZCB0byBjYXRjaCB3cm9uZyBvbmVzLgorICAgICAgICBXZSBhcmUgdXNpbmcgQVNT RVJUIGluIEpTQyBzaWRlIHNpbmNlIHdlIGRvbid0IGtub3cgYWxsIHRoZSBET00gb2JqZWN0cyBh cmUgY29ycmVjdGx5IGltcGxlbWVudGVkLgorICAgICAgICBJZiBpdCBpcyBub3QgY29ycmVjdGx5 IGltcGxlbWVudGVkLCBpbiBSZWxlYXNlIGJ1aWxkLCBKU0MgaXMgcmV0dXJuaW5nIHN1Yi1vcHRp bWFsIGJ1dCByaWdodCByZXN1bHRzLgorICAgICAgICBCdXQgaW4gRGVidWcgYnVpbGQsIHdlIGNh biBjYXRjaCB0aGUgd3Jvbmcgb25lcywgd2hpY2ggYWxsb3dzIHVzIHRvIGZpeCB0aGUgd3Jvbmcg dGhpbmdzIHdoaWxlIGF2b2lkaW5nCisgICAgICAgIGNhdGFzdHJvcGhpYyBjcmFzaGVzIGluIHJl bGVhc2UgYnVpbGQuCisKKyAgICAgICAgSG93ZXZlciwgdGhlIHRlc3QgaXMgYXNzdW1pbmcgdGhh dCBBU1NFUlQgaXMgbm90IGVuYWJsZWQgaWYgaXQgaXMgbm90IERlYnVnIGJ1aWxkLiBSZWxlYXNl ICYgRGVidWcgYnVpbGRzCisgICAgICAgIHdvcmssIGJ1dCBSZWxlYXNlK0Fzc2VydCBkb2VzIG5v dCBtZWV0IHRoaXMgYXNzdW1wdGlvbi4KKworICAgICAgICBTbywgc2tpcCB0aGlzIGJhc2VkIG9u IGAkdm0uYXNzZXJ0RW5hYmxlZCgpYC4KKworICAgICAgICAqIHN0cmVzcy9pbmNvcnJlY3QtcHV0 LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5nLWJhZC1iZWhh dmlvci5qczoKKyAgICAgICAgKHZtLmFzc2VydEVuYWJsZWQucHV0dGVyKToKKyAgICAgICAgKHZt LmFzc2VydEVuYWJsZWQpOgorICAgICAgICAocHV0dGVyKTogRGVsZXRlZC4KKyAgICAgICAgKG5v dF9zdHJpbmcudG9TdHJpbmcpOiBEZWxldGVkLgorICAgICAgICAqIHN0cmVzcy9pbmNvcnJlY3Qt cHV0LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtaW52b2x2aW5nLWRpY3Rpb25hcnktZmxhdHRl bi5qczoKKyAgICAgICAgKHZtLmFzc2VydEVuYWJsZWQpOgorICAgICAgICAobm90X3N0cmluZy50 b1N0cmluZyk6IERlbGV0ZWQuCisKIDIwMjAtMDQtMjYgIEFsZXhleSBTaHZheWthICA8c2h2YWlr YWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIFN5bWJvbCBzaG91bGQgaGF2ZSBbW0NvbnN0cnVj dF1dIGludGVybmFsIG1ldGhvZApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvaW5jb3JyZWN0 LXB1dC1jb3VsZC1nZW5lcmF0ZS1pbnZhbGlkLWljLWJ1dC1zdGlsbC1ub3QtY2F1c2luZy1iYWQt YmVoYXZpb3IuanMgYi9KU1Rlc3RzL3N0cmVzcy9pbmNvcnJlY3QtcHV0LWNvdWxkLWdlbmVyYXRl LWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5nLWJhZC1iZWhhdmlvci5qcwppbmRleCA0 ZGZkYTM4ZDgyOTg2MjUxNTgxMjQ2OTdhYmVhZTdhNGYxZjk4MTkyLi5jYmRmNjBkNGE2ODFlMDNk M2VjOWE5MTNiOTlkNjM3MDgzMTllNTg2IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9pbmNv cnJlY3QtcHV0LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5n LWJhZC1iZWhhdmlvci5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9pbmNvcnJlY3QtcHV0LWNvdWxk LWdlbmVyYXRlLWludmFsaWQtaWMtYnV0LXN0aWxsLW5vdC1jYXVzaW5nLWJhZC1iZWhhdmlvci5q cwpAQCAtNSwyMiArNSwyNCBAQCBmdW5jdGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVkKSB7 CiAgICAgICAgIHRocm93IG5ldyBFcnJvcignYmFkIHZhbHVlOiAnICsgYWN0dWFsKTsKIH0KIAot dmFyIHB1dHRlciA9IGZ1bmN0aW9uKG8pIHsKLSAgICBvLl91bnN1cHBvcnRlZCA9IG5vdF9zdHJp bmc7Ci19Ci0KLXZhciBvYmplY3Q7Ci12YXIgY291bnRlciA9IDA7Ci12YXIgbm90X3N0cmluZyA9 IHsKLSAgICB0b1N0cmluZygpIHsKLSAgICAgICAgY291bnRlcisrOwotICAgICAgICBvYmplY3Qu b2sgPSA0MjsKLSAgICAgICAgcmV0dXJuICJIZXkiOworaWYgKCEkdm0uYXNzZXJ0RW5hYmxlZCgp KSB7CisgICAgdmFyIHB1dHRlciA9IGZ1bmN0aW9uKG8pIHsKKyAgICAgICAgby5fdW5zdXBwb3J0 ZWQgPSBub3Rfc3RyaW5nOwogICAgIH0KLX07CiAKLWZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDsg KytpKSB7Ci0gICAgb2JqZWN0ID0gJHZtLmNyZWF0ZU9iamVjdERvaW5nU2lkZUVmZmVjdFB1dFdp dGhvdXRDb3JyZWN0U2xvdFN0YXR1cygpOwotICAgIHB1dHRlcihvYmplY3QpOworICAgIHZhciBv YmplY3Q7CisgICAgdmFyIGNvdW50ZXIgPSAwOworICAgIHZhciBub3Rfc3RyaW5nID0geworICAg ICAgICB0b1N0cmluZygpIHsKKyAgICAgICAgICAgIGNvdW50ZXIrKzsKKyAgICAgICAgICAgIG9i amVjdC5vayA9IDQyOworICAgICAgICAgICAgcmV0dXJuICJIZXkiOworICAgICAgICB9CisgICAg fTsKKworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDsgKytpKSB7CisgICAgICAgIG9iamVj dCA9ICR2bS5jcmVhdGVPYmplY3REb2luZ1NpZGVFZmZlY3RQdXRXaXRob3V0Q29ycmVjdFNsb3RT dGF0dXMoKTsKKyAgICAgICAgcHV0dGVyKG9iamVjdCk7CisgICAgfQorICAgIHNob3VsZEJlKGNv dW50ZXIsIDEwMDApOwogfQotc2hvdWxkQmUoY291bnRlciwgMTAwMCk7CmRpZmYgLS1naXQgYS9K U1Rlc3RzL3N0cmVzcy9pbmNvcnJlY3QtcHV0LWNvdWxkLWdlbmVyYXRlLWludmFsaWQtaWMtaW52 b2x2aW5nLWRpY3Rpb25hcnktZmxhdHRlbi5qcyBiL0pTVGVzdHMvc3RyZXNzL2luY29ycmVjdC1w dXQtY291bGQtZ2VuZXJhdGUtaW52YWxpZC1pYy1pbnZvbHZpbmctZGljdGlvbmFyeS1mbGF0dGVu LmpzCmluZGV4IDMzNGExOTAxMTZmOTc3ZDQwN2IyMDI5ZDg3NzNjYWIyNzZjZTYwNGIuLjRiOTk3 NDFhZjUxNWM1ZGE1YjAyNzA2MGNiMjY3NzExMjcwZDE0MjQgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMv c3RyZXNzL2luY29ycmVjdC1wdXQtY291bGQtZ2VuZXJhdGUtaW52YWxpZC1pYy1pbnZvbHZpbmct ZGljdGlvbmFyeS1mbGF0dGVuLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL2luY29ycmVjdC1wdXQt Y291bGQtZ2VuZXJhdGUtaW52YWxpZC1pYy1pbnZvbHZpbmctZGljdGlvbmFyeS1mbGF0dGVuLmpz CkBAIC0xNiwxOCArMTYsMjAgQEAgZnVuY3Rpb24gcHV0dGVyKG8pIHsKICAgICBvLl91bnN1cHBv cnRlZCA9IG5vdF9zdHJpbmc7CiB9CiAKLXZhciBkOwotdmFyIG5vdF9zdHJpbmcgPSB7Ci0gICAg dG9TdHJpbmcoKSB7Ci0gICAgICAgIGZvcih2YXIgaSA9IDM7IGkgPCA2NjsgaSsrKQotICAgICAg ICAgICAgZGVsZXRlIGRbJ3AnK2ldOwotICAgICAgICBmb3IoaSBpbiBPYmplY3QuY3JlYXRlKGQp KTsKLSAgICAgICAgcmV0dXJuIG51bGw7Ci0gICAgfQotfTsKK2lmICghJHZtLmFzc2VydEVuYWJs ZWQoKSkgeworICAgIHZhciBkOworICAgIHZhciBub3Rfc3RyaW5nID0geworICAgICAgICB0b1N0 cmluZygpIHsKKyAgICAgICAgICAgIGZvcih2YXIgaSA9IDM7IGkgPCA2NjsgaSsrKQorICAgICAg ICAgICAgICAgIGRlbGV0ZSBkWydwJytpXTsKKyAgICAgICAgICAgIGZvcihpIGluIE9iamVjdC5j cmVhdGUoZCkpOworICAgICAgICAgICAgcmV0dXJuIG51bGw7CisgICAgICAgIH0KKyAgICB9Owog Ci1mb3IgKHZhciBpID0gMDsgaSA8IDEwMDsgKytpKSB7Ci0gICAgZCA9IGRpY3Rpb25hcnkoKTsK LSAgICBwdXR0ZXIoZCk7Ci0gICAgc2hvdWxkQmUoJ3AzJyBpbiBkLCBmYWxzZSk7CisgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCAxMDA7ICsraSkgeworICAgICAgICBkID0gZGljdGlvbmFyeSgpOwor ICAgICAgICBwdXR0ZXIoZCk7CisgICAgICAgIHNob3VsZEJlKCdwMycgaW4gZCwgZmFsc2UpOwor ICAgIH0KIH0K