<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>211047</bug_id>
          
          <creation_ts>2020-04-26 10:40:34 -0700</creation_ts>
          <short_desc>[Win] Fix windows build with MSBuild after r260672</short_desc>
          <delta_ts>2020-04-27 00:37:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Christopher Reid">chris.reid</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>annulen</cc>
    
    <cc>dpino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1645791</commentid>
    <comment_count>0</comment_count>
    <who name="Christopher Reid">chris.reid</who>
    <bug_when>2020-04-26 10:40:34 -0700</bug_when>
    <thetext>See https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/13003/steps/compile-webkit/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645792</commentid>
    <comment_count>1</comment_count>
      <attachid>397622</attachid>
    <who name="Christopher Reid">chris.reid</who>
    <bug_when>2020-04-26 10:44:58 -0700</bug_when>
    <thetext>Created attachment 397622
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645814</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-04-26 12:44:57 -0700</bug_when>
    <thetext>Found 1 new test failure: storage/indexeddb/result-request-cycle.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645815</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-04-26 12:51:44 -0700</bug_when>
    <thetext>Committed r260728: &lt;https://trac.webkit.org/changeset/260728&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397622.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645915</commentid>
    <comment_count>4</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2020-04-27 00:37:50 -0700</bug_when>
    <thetext>Reverted r260728 for reason:

Build fix after r260672, no needed since r260672 is also being reverted

Committed r260742: &lt;https://trac.webkit.org/changeset/260742&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>397622</attachid>
            <date>2020-04-26 10:44:58 -0700</date>
            <delta_ts>2020-04-26 12:51:44 -0700</delta_ts>
            <desc>patch</desc>
            <filename>fix.diff</filename>
            <type>text/plain</type>
            <size>1448</size>
            <attacher name="Christopher Reid">chris.reid</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj
ZS9XZWJJbnNwZWN0b3JVSS9DTWFrZUxpc3RzLnR4dAppbmRleCA0YjE0YTI4Nzk4YWEuLmE2ZjRk
NjJlNzJjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NNYWtlTGlzdHMudHh0
CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DTWFrZUxpc3RzLnR4dApAQCAtNDUsNyArNDUs
OCBAQCBXRUJLSVRfSU5DTFVERV9DT05GSUdfRklMRVNfSUZfRVhJU1RTKCkKICMgZXhwZWN0ZWQg
aW4gRGVyaXZlZFNvdXJjZXMvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC8u
CiBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgT1VUUFVUICR7V2ViSW5zcGVjdG9yVUlfREVSSVZF
RF9TT1VSQ0VTX0RJUn0vVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kQ29t
bWFuZHMuanMKLSAgICBERVBFTkRTICR7SmF2YVNjcmlwdENvcmVfREVSSVZFRF9TT1VSQ0VTX0RJ
Un0vaW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcworICAgIERFUEVORFMgSmF2
YVNjcmlwdENvcmUKKyAgICAgICAgICAgICR7SmF2YVNjcmlwdENvcmVfREVSSVZFRF9TT1VSQ0VT
X0RJUn0vaW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcwogICAgIENPTU1BTkQg
JHtDTUFLRV9DT01NQU5EfSAtRSBjb3B5ICR7SmF2YVNjcmlwdENvcmVfREVSSVZFRF9TT1VSQ0VT
X0RJUn0vaW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcyAke1dlYkluc3BlY3Rv
clVJX0RFUklWRURfU09VUkNFU19ESVJ9L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9y
QmFja2VuZENvbW1hbmRzLmpzCiAgICAgVkVSQkFUSU0KICkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9n
CmluZGV4IGQ0ODFjYWI2MzcwNS4uZDE5MDQ2MGE5NjNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMC0wNC0yNiAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlz
LnJlaWRAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gRml4IHdpbmRvd3MgYnVpbGQgd2l0aCBN
U0J1aWxkIGFmdGVyIDI2MDY3MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MjExMDQ3CisKKyAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAg
ICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAyMC0wNC0yNSAgRGFyaW4gQWRsZXIgIDxkYXJp
bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBEZWFsIHdpdGggYW5vdGhlciByb3VuZCBv
ZiBYY29kZSB1cGdyYWRlIGNoZWNrcwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>