211044 2020-04-26 02:12:11 -0700 [WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions 2020-04-27 03:09:23 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jh718.park jh718.park benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1645764 0 jh718.park 2020-04-26 02:12:11 -0700 (unsigned + signed) should return unsigned int type as a common type defined by usual arithmetic conversions. But gcc 9.3.0 returns signed int type for this case. I filed a bug for this issue on gcc bugzilla, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94767. To workaround this, I originally submitted the patch, http://svn.webkit.org/repository/webkit/trunk@260715, but according to Darin's comment, use unsigned integer suffix instead of static_cast<unsigned>. 1645765 1 397614 jh718.park 2020-04-26 02:15:01 -0700 Created attachment 397614 Patch 1645805 2 ews-feeder 2020-04-26 11:55:25 -0700 Committed r260727: <https://trac.webkit.org/changeset/260727> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397614. 1645807 3 webkit-bug-importer 2020-04-26 11:56:17 -0700 <rdar://problem/62403735> 1645945 4 jh718.park 2020-04-27 03:09:23 -0700 FYI, in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94767, Jonathan Wakely left a comment for a c++ standard entry for this issue. http://eel.is/c++draft/conv.prom#5, and the statement of this link is as below. "A prvalue for an integral bit-field ([class.bit]) can be converted to a prvalue of type int if int can represent all the values of the bit-field; otherwise, it can be converted to unsigned int if unsigned int can represent all the values of the bit-field. If the bit-field is larger yet, no integral promotion applies to it. If the bit-field has an enumerated type, it is treated as any other value of that type for promotion purposes." So I think gcc's build warning, warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare] was valid one and this patch could be a proper fix, not just a workaround. 397614 2020-04-26 02:15:01 -0700 2020-04-26 11:55:25 -0700 Patch bug-211044-20200426181500.patch text/plain 2643 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDI2OTk2ZjUxNzg1N2IyMmZmNDFkZTI4 ODYzNmJlNTJjYWQ2NDNmNjkuLjFhM2Q1ZDNhZWYxNGQwYWQyOWY3NjNkYTVmMGMzZWU2ZTI4MjM2 NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDQtMjYgIEpvb25naHVuIFBhcmsgIDxqaDcx OC5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXVEZdIFdvcmthcm91bmQgZ2NjIGJ1ZyBm b3IgdW5zaWduZWQgYml0ZmllbGQgcmVsYXRlZCB1c3VhbCBhcml0aG1ldGljIGNvbnZlcnNpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEwNDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9V UkwuY3BwOgorICAgICAgICAoV1RGOjpVUkw6OnNldEhvc3QpOgorICAgICAgICAoV1RGOjpVUkw6 OnNldEhvc3RBbmRQb3J0KToKKyAgICAgICAgKFdURjo6VVJMOjpzZXRVc2VyKToKKyAgICAgICAg KFdURjo6VVJMOjpzZXRQYXNzd29yZCk6CisKIDIwMjAtMDQtMjUgIEpvb25naHVuIFBhcmsgIDxq aDcxOC5wYXJrQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlbW92ZSB0aGUg YnVsaWQgd2FybmluZ3MgYmVsb3cgc2luY2UgcjI2MDcwNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL1VSTC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9VUkwuY3BwCmluZGV4IGIxMmNiZDQ2YzVh MWQ0YTM0MWExOWY0YjE2YjI1OTQ1MzBkZTJmODguLmU1NjJmZTA5MzJkZjU4MzI2YmRmMTI3MWUw ZjFlOTFlNGY2YjNjZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1VSTC5jcHAKKysrIGIv U291cmNlL1dURi93dGYvVVJMLmNwcApAQCAtNDM2LDcgKzQzNiw3IEBAIHZvaWQgVVJMOjpzZXRI b3N0KFN0cmluZ1ZpZXcgbmV3SG9zdCkKICAgICBpZiAoIWFwcGVuZEVuY29kZWRIb3N0bmFtZShl bmNvZGVkSG9zdE5hbWUsIG5ld0hvc3QpKQogICAgICAgICByZXR1cm47CiAKLSAgICBib29sIHNs YXNoU2xhc2hOZWVkZWQgPSBtX3VzZXJTdGFydCA9PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obV9z Y2hlbWVFbmQgKyAxKTsKKyAgICBib29sIHNsYXNoU2xhc2hOZWVkZWQgPSBtX3VzZXJTdGFydCA9 PSBtX3NjaGVtZUVuZCArIDFVOwogICAgIHBhcnNlKG1ha2VTdHJpbmcoCiAgICAgICAgIFN0cmlu Z1ZpZXcobV9zdHJpbmcpLmxlZnQoaG9zdFN0YXJ0KCkpLAogICAgICAgICBzbGFzaFNsYXNoTmVl ZGVkID8gIi8vIiA6ICIiLApAQCAtNDg2LDcgKzQ4Niw3IEBAIHZvaWQgVVJMOjpzZXRIb3N0QW5k UG9ydChTdHJpbmdWaWV3IGhvc3RBbmRQb3J0KQogICAgIGlmICghYXBwZW5kRW5jb2RlZEhvc3Ru YW1lKGVuY29kZWRIb3N0TmFtZSwgaG9zdE5hbWUpKQogICAgICAgICByZXR1cm47CiAKLSAgICBi b29sIHNsYXNoU2xhc2hOZWVkZWQgPSBtX3VzZXJTdGFydCA9PSBzdGF0aWNfY2FzdDx1bnNpZ25l ZD4obV9zY2hlbWVFbmQgKyAxKTsKKyAgICBib29sIHNsYXNoU2xhc2hOZWVkZWQgPSBtX3VzZXJT dGFydCA9PSBtX3NjaGVtZUVuZCArIDFVOwogICAgIHBhcnNlKG1ha2VTdHJpbmcoCiAgICAgICAg IFN0cmluZ1ZpZXcobV9zdHJpbmcpLmxlZnQoaG9zdFN0YXJ0KCkpLAogICAgICAgICBzbGFzaFNs YXNoTmVlZGVkID8gIi8vIiA6ICIiLApAQCAtNTQ3LDcgKzU0Nyw3IEBAIHZvaWQgVVJMOjpzZXRV c2VyKFN0cmluZ1ZpZXcgbmV3VXNlcikKIAogICAgIHVuc2lnbmVkIGVuZCA9IG1fdXNlckVuZDsK ICAgICBpZiAoIW5ld1VzZXIuaXNFbXB0eSgpKSB7Ci0gICAgICAgIGJvb2wgc2xhc2hTbGFzaE5l ZWRlZCA9IG1fdXNlclN0YXJ0ID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPihtX3NjaGVtZUVuZCAr IDEpOworICAgICAgICBib29sIHNsYXNoU2xhc2hOZWVkZWQgPSBtX3VzZXJTdGFydCA9PSBtX3Nj aGVtZUVuZCArIDFVOwogICAgICAgICBib29sIG5lZWRTZXBhcmF0b3IgPSBlbmQgPT0gbV9ob3N0 RW5kIHx8IChlbmQgPT0gbV9wYXNzd29yZEVuZCAmJiBtX3N0cmluZ1tlbmRdICE9ICdAJyk7CiAg ICAgICAgIHBhcnNlKG1ha2VTdHJpbmcoCiAgICAgICAgICAgICBTdHJpbmdWaWV3KG1fc3RyaW5n KS5sZWZ0KG1fdXNlclN0YXJ0KSwKQEAgLTU3MCw3ICs1NzAsNyBAQCB2b2lkIFVSTDo6c2V0UGFz c3dvcmQoU3RyaW5nVmlldyBuZXdQYXNzd29yZCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYg KCFuZXdQYXNzd29yZC5pc0VtcHR5KCkpIHsKLSAgICAgICAgYm9vbCBuZWVkTGVhZGluZ1NsYXNo ZXMgPSBtX3VzZXJFbmQgPT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1fc2NoZW1lRW5kICsgMSk7 CisgICAgICAgIGJvb2wgbmVlZExlYWRpbmdTbGFzaGVzID0gbV91c2VyRW5kID09IG1fc2NoZW1l RW5kICsgMVU7CiAgICAgICAgIHBhcnNlKG1ha2VTdHJpbmcoCiAgICAgICAgICAgICBTdHJpbmdW aWV3KG1fc3RyaW5nKS5sZWZ0KG1fdXNlckVuZCksCiAgICAgICAgICAgICBuZWVkTGVhZGluZ1Ns YXNoZXMgPyAiLy86IiA6ICI6IiwK