211030 2020-04-25 14:27:28 -0700 [JSC] Handle BigInt32 INT32_MIN shift amount 2020-04-25 21:45:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1645660 0 ysuzuki 2020-04-25 14:27:28 -0700 ... 1645669 1 397588 ysuzuki 2020-04-25 15:01:46 -0700 Created attachment 397588 Patch 1645721 2 397588 darin 2020-04-25 18:06:57 -0700 Comment on attachment 397588 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397588&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Handle BitInt32 INT32_MIN shift amount typo: BigInt32 > Source/JavaScriptCore/runtime/Operations.h:776 > + if (rightInt32 == INT32_MIN) { > + // Shift-amount is 0x80000000. For right-shift, shift-amount is reduced to 31. > + if (!isLeft) > + return jsBigInt32(leftInt32 >> 31); > + // Left-shift with 0x80000000 produces too large BigInt, and throws a RangeError. > + // But when leftInt32 is zero, we should return zero. > + if (!leftInt32) > + return jsBigInt32(0); > + throwRangeError(globalObject, scope, "BigInt generated from this operation is too big"_s); > + return { }; > + } > rightInt32 = -rightInt32; Would this simpler implementation still gives us the correct result? if (rightInt32 == INT32_MIN) rightInt32 = INT32_MAX; // Shifts one less than requested, but makes no observable difference. else rightInt32 = -rightInt32; Would you consider it if it does? 1645730 3 397588 ysuzuki 2020-04-25 18:54:21 -0700 Comment on attachment 397588 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397588&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] Handle BitInt32 INT32_MIN shift amount > > typo: BigInt32 Ooops, fixed. >> Source/JavaScriptCore/runtime/Operations.h:776 >> rightInt32 = -rightInt32; > > Would this simpler implementation still gives us the correct result? > > if (rightInt32 == INT32_MIN) > rightInt32 = INT32_MAX; // Shifts one less than requested, but makes no observable difference. > else > rightInt32 = -rightInt32; > > Would you consider it if it does? Good point! Right, sounds simpler. Fixed. 1645731 4 397604 ysuzuki 2020-04-25 18:58:19 -0700 Created attachment 397604 Patch for landing 1645732 5 397605 ysuzuki 2020-04-25 19:07:03 -0700 Created attachment 397605 Patch for landing 1645749 6 ews-feeder 2020-04-25 21:44:26 -0700 Committed r260720: <https://trac.webkit.org/changeset/260720> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397605. 1645750 7 webkit-bug-importer 2020-04-25 21:45:26 -0700 <rdar://problem/62380341> 397588 2020-04-25 15:01:46 -0700 2020-04-25 18:06:57 -0700 Patch bug-211030-20200425150145.patch text/plain 4933 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZDU1MmJmMzA2MTM0OGM1ZDczOGEzZThhOGMzMTgyOGFlODlmMWQzLi5mZDNhYjZhMWRmYjhlNTRl Y2MzNDZiMzBiODBlNmRmNTg2NmUzZDBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0yNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEhhbmRsZSBCaXRJbnQzMiBJTlQzMl9NSU4gc2hpZnQgYW1vdW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEwMzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXIgQmln SW50IHNoaWZ0LW9wZXJhdGlvbiBkb2VzIG5vdCBjb3JyZWN0bHkgaGFuZGxlIElOVDMyX01JTiBz aGlmdCBhbW91bnQsIGFuZCBwcm9kdWNpbmcgYSB3cm9uZyByZXN1bHQuCisgICAgICAgIFRoaXMg cGF0Y2ggZml4ZXMgaXQuCisKKyAgICAgICAgKiBydW50aW1lL09wZXJhdGlvbnMuaDoKKyAgICAg ICAgKEpTQzo6c2hpZnQpOgorCiAyMDIwLTA0LTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUHJlcGFyZSB0byByZW1vdmUgYXV0b21hdGlj IFVSTC0+U3RyaW5nIGNvbnZlcnNpb24gb3BlcmF0b3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9PcGVyYXRpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9PcGVyYXRpb25zLmgKaW5kZXggZTUwMjNlMjRhNWRiYWVjZmQ2YjE1ZTA3NmNlMDEx MTE4Nzk0NDM3Mi4uMjk1YTdiMTY5ZjJmN2EwNDI5ZDc0ZGI4YTEyOTYxNmNmNmYzMTNlYiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3BlcmF0aW9ucy5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wZXJhdGlvbnMuaApAQCAtNzYyLDYgKzc2 MiwxNyBAQCBBTFdBWVNfSU5MSU5FIEpTVmFsdWUgc2hpZnQoSlNHbG9iYWxPYmplY3QqIGdsb2Jh bE9iamVjdCwgSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2MgogICAgICAgICBpbnQzMl90IHJpZ2h0SW50 MzIgPSByaWdodE51bWVyaWMuYmlnSW50MzJBc0ludDMyKCk7CiAgICAgICAgIGlmIChyaWdodElu dDMyIDwgMCkgewogICAgICAgICAgICAgaXNMZWZ0ID0gIWlzTGVmdDsKKyAgICAgICAgICAgIGlm IChyaWdodEludDMyID09IElOVDMyX01JTikgeworICAgICAgICAgICAgICAgIC8vIFNoaWZ0LWFt b3VudCBpcyAweDgwMDAwMDAwLiBGb3IgcmlnaHQtc2hpZnQsIHNoaWZ0LWFtb3VudCBpcyByZWR1 Y2VkIHRvIDMxLgorICAgICAgICAgICAgICAgIGlmICghaXNMZWZ0KQorICAgICAgICAgICAgICAg ICAgICByZXR1cm4ganNCaWdJbnQzMihsZWZ0SW50MzIgPj4gMzEpOworICAgICAgICAgICAgICAg IC8vIExlZnQtc2hpZnQgd2l0aCAweDgwMDAwMDAwIHByb2R1Y2VzIHRvbyBsYXJnZSBCaWdJbnQs IGFuZCB0aHJvd3MgYSBSYW5nZUVycm9yLgorICAgICAgICAgICAgICAgIC8vIEJ1dCB3aGVuIGxl ZnRJbnQzMiBpcyB6ZXJvLCB3ZSBzaG91bGQgcmV0dXJuIHplcm8uCisgICAgICAgICAgICAgICAg aWYgKCFsZWZ0SW50MzIpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBqc0JpZ0ludDMyKDAp OworICAgICAgICAgICAgICAgIHRocm93UmFuZ2VFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlLCAi QmlnSW50IGdlbmVyYXRlZCBmcm9tIHRoaXMgb3BlcmF0aW9uIGlzIHRvbyBiaWciX3MpOworICAg ICAgICAgICAgICAgIHJldHVybiB7IH07CisgICAgICAgICAgICB9CiAgICAgICAgICAgICByaWdo dEludDMyID0gLXJpZ2h0SW50MzI7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9D aGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBkM2NhNjgxODc1NDMxOTI2YmYwMWZk YTcyOGNjNGI5ZWM3OTlkNDNjLi5jNTFjYjViY2Q5MWI2Njk3MjhlOWJlNTc5MzFlMzhjMDdmNDg2 MDYzIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTI1ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBh cHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gSGFuZGxlIEJpdEludDMyIElOVDMyX01JTiBzaGlm dCBhbW91bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMTAzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc3RyZXNzL2JpZ2ludC1pbnQzMi1taW4tc2hpZnQuanM6IEFkZGVkLgorICAgICAgICAoc2hv dWxkQmUpOgorICAgICAgICAoc2hvdWxkQmVBcnJheSk6CisgICAgICAgIChzaG91bGRUaHJvdyk6 CisKIDIwMjAtMDQtMjUgIFBhdWxvIE1hdG9zICA8cG1hdG9zQGlnYWxpYS5jb20+CiAKICAgICAg ICAgU2tpcCBzdHJlc3MvYnV0dGVyZmx5LXplcm8tdW51c2VkLWJ1dHRlcmZseS1wcm9wZXJ0aWVz LmpzIG9uIE1JUFMKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2JpZ2ludC1pbnQzMi1taW4t c2hpZnQuanMgYi9KU1Rlc3RzL3N0cmVzcy9iaWdpbnQtaW50MzItbWluLXNoaWZ0LmpzCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmYyNTFlZjFiMzM5MzQwZWM5MDI0NmIyYTBmOTQ3OTlmN2ZhNjI0NzgKLS0tIC9kZXYv bnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9iaWdpbnQtaW50MzItbWluLXNoaWZ0LmpzCkBAIC0w LDAgKzEsNjEgQEAKK2Z1bmN0aW9uIHNob3VsZEJlKGFjdHVhbCwgZXhwZWN0ZWQpIHsKKyAgICBp ZiAoYWN0dWFsICE9PSBleHBlY3RlZCkKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdiYWQgdmFs dWU6ICcgKyBhY3R1YWwpOworfQorCitmdW5jdGlvbiBzaG91bGRCZUFycmF5KGFjdHVhbCwgZXhw ZWN0ZWQpIHsKKyAgICBzaG91bGRCZShhY3R1YWwubGVuZ3RoLCBleHBlY3RlZC5sZW5ndGgpOwor ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgZXhwZWN0ZWQubGVuZ3RoOyArK2kpIHsKKyAgICAgICAg dHJ5IHsKKyAgICAgICAgICAgIHNob3VsZEJlKGFjdHVhbFtpXSwgZXhwZWN0ZWRbaV0pOworICAg ICAgICB9IGNhdGNoKGUpIHsKKyAgICAgICAgICAgIHByaW50KEpTT04uc3RyaW5naWZ5KGFjdHVh bCkpOworICAgICAgICAgICAgdGhyb3cgZTsKKyAgICAgICAgfQorICAgIH0KK30KKworZnVuY3Rp b24gc2hvdWxkVGhyb3coZnVuYywgZXJyb3JNZXNzYWdlKSB7CisgICAgdmFyIGVycm9yVGhyb3du ID0gZmFsc2U7CisgICAgdmFyIGVycm9yID0gbnVsbDsKKyAgICB0cnkgeworICAgICAgICBmdW5j KCk7CisgICAgfSBjYXRjaCAoZSkgeworICAgICAgICBlcnJvclRocm93biA9IHRydWU7CisgICAg ICAgIGVycm9yID0gZTsKKyAgICB9CisgICAgaWYgKCFlcnJvclRocm93bikKKyAgICAgICAgdGhy b3cgbmV3IEVycm9yKCdub3QgdGhyb3duJyk7CisgICAgaWYgKFN0cmluZyhlcnJvcikgIT09IGVy cm9yTWVzc2FnZSkKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKGBiYWQgZXJyb3I6ICR7U3RyaW5n KGVycm9yKX1gKTsKK30KKworbGV0IGludDMybWluID0gLTB4N2ZmZmZmZmZuIC0gMW47CitzaG91 bGRCZSgwbiA+PiBpbnQzMm1pbiwgMG4pOworc2hvdWxkQmUoMG4gPj4gKGludDMybWluICsgMW4p LCAwbik7CitzaG91bGRCZSgwbiA8PCBpbnQzMm1pbiwgMG4pOworc2hvdWxkQmUoMG4gPDwgKGlu dDMybWluICsgMW4pLCAwbik7CitzaG91bGRCZSgxbiA8PCBpbnQzMm1pbiwgMG4pOworc2hvdWxk QmUoMW4gPDwgKGludDMybWluICsgMW4pLCAwbik7CitzaG91bGRCZSgtMW4gPDwgaW50MzJtaW4s IC0xbik7CitzaG91bGRCZSgtMW4gPDwgKGludDMybWluICsgMW4pLCAtMW4pOworc2hvdWxkQmUo MHg3ZmZmZmZmZm4gPDwgaW50MzJtaW4sIDBuKTsKK3Nob3VsZEJlKDB4N2ZmZmZmZmZuIDw8IChp bnQzMm1pbiArIDFuKSwgMG4pOworc2hvdWxkQmUoMHg3ZmZmZmZmZmZmZmZuIDw8IGludDMybWlu LCAwbik7CitzaG91bGRCZSgweDdmZmZmZmZmZmZmZm4gPDwgKGludDMybWluICsgMW4pLCAwbik7 CitzaG91bGRCZSgtMHg3ZmZmZmZmZm4gPDwgaW50MzJtaW4sIC0xbik7CitzaG91bGRCZSgtMHg3 ZmZmZmZmZm4gPDwgKGludDMybWluICsgMW4pLCAtMW4pOworc2hvdWxkQmUoLTB4N2ZmZmZmZmZm ZmZmbiA8PCBpbnQzMm1pbiwgLTFuKTsKK3Nob3VsZEJlKC0weDdmZmZmZmZmZmZmZm4gPDwgKGlu dDMybWluICsgMW4pLCAtMW4pOworc2hvdWxkVGhyb3coKCkgPT4geworICAgIDFuID4+IGludDMy bWluOworfSwgYFJhbmdlRXJyb3I6IEJpZ0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlv biBpcyB0b28gYmlnYCk7CitzaG91bGRUaHJvdygoKSA9PiB7CisgICAgLTFuID4+IGludDMybWlu OworfSwgYFJhbmdlRXJyb3I6IEJpZ0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlvbiBp cyB0b28gYmlnYCk7CitzaG91bGRUaHJvdygoKSA9PiB7CisgICAgMHg3ZmZmZmZmZm4gPj4gaW50 MzJtaW47Cit9LCBgUmFuZ2VFcnJvcjogQmlnSW50IGdlbmVyYXRlZCBmcm9tIHRoaXMgb3BlcmF0 aW9uIGlzIHRvbyBiaWdgKTsKK3Nob3VsZFRocm93KCgpID0+IHsKKyAgICAoLTB4N2ZmZmZmZmZu IC0gMW4pID4+IGludDMybWluOworfSwgYFJhbmdlRXJyb3I6IEJpZ0ludCBnZW5lcmF0ZWQgZnJv bSB0aGlzIG9wZXJhdGlvbiBpcyB0b28gYmlnYCk7Cg== 397604 2020-04-25 18:58:19 -0700 2020-04-25 19:04:54 -0700 Patch for landing bug-211030-20200425185811.patch text/plain 4513 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 OTNiZmU4MWVjMzQxZDRmMTBiODFjN2M0YTU0NDM1M2Q5Y2JmYzE2Li44NGRkNzhiNDNjODlkYWIx MTJiZTY0M2Q5YjdjODM5NDQxZmNiMTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0yNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEhhbmRsZSBCaWdJbnQzMiBJTlQzMl9NSU4gc2hpZnQgYW1vdW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEwMzAK KworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBPdXIgQmlnSW50 IHNoaWZ0LW9wZXJhdGlvbiBkb2VzIG5vdCBjb3JyZWN0bHkgaGFuZGxlIElOVDMyX01JTiBzaGlm dCBhbW91bnQsIGFuZCBwcm9kdWNpbmcgYSB3cm9uZyByZXN1bHQuCisgICAgICAgIFRoaXMgcGF0 Y2ggZml4ZXMgaXQuCisKKyAgICAgICAgKiBydW50aW1lL09wZXJhdGlvbnMuaDoKKyAgICAgICAg KEpTQzo6c2hpZnQpOgorCiAyMDIwLTA0LTI1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIERlYWwgd2l0aCBhbm90aGVyIHJvdW5kIG9mIFhjb2RlIHVw Z3JhZGUgY2hlY2tzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P cGVyYXRpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcGVyYXRpb25zLmgK aW5kZXggMDU0MmExYTM0NmExM2JiNGE2MGFiYTUxMmE2YjU4NGI0OTgyNDQzMS4uODZjNTk5MjUz NTg4MDQ5ZGRlZGE2ODBmZmI4M2QwOGQ1YmNmNjY5NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvT3BlcmF0aW9ucy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL09wZXJhdGlvbnMuaApAQCAtNzYyLDcgKzc2MiwxMCBAQCBBTFdBWVNfSU5MSU5F IEpTVmFsdWUgc2hpZnQoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNWYWx1ZSB2MSwg SlNWYWx1ZSB2MgogICAgICAgICBpbnQzMl90IHJpZ2h0SW50MzIgPSByaWdodE51bWVyaWMuYmln SW50MzJBc0ludDMyKCk7CiAgICAgICAgIGlmIChyaWdodEludDMyIDwgMCkgewogICAgICAgICAg ICAgaXNMZWZ0ID0gIWlzTGVmdDsKLSAgICAgICAgICAgIHJpZ2h0SW50MzIgPSAtcmlnaHRJbnQz MjsKKyAgICAgICAgICAgIGlmIChyaWdodEludDMyID09IElOVDMyX01JTikKKyAgICAgICAgICAg ICAgICByaWdodEludDMyID0gSU5UMzJfTUFYOyAvLyBTaGlmdHMgb25lIGxlc3MgdGhhbiByZXF1 ZXN0ZWQsIGJ1dCBtYWtlcyBubyBvYnNlcnZhYmxlIGRpZmZlcmVuY2UuCisgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICAgICAgcmlnaHRJbnQzMiA9IC1yaWdodEludDMyOwogICAgICAgICB9 CiAgICAgICAgIEFTU0VSVChyaWdodEludDMyID49IDApOwogCmRpZmYgLS1naXQgYS9KU1Rlc3Rz L0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI5N2U3NWYyOWVhMmE3NTJmMzky ODVkY2U2MzBkNTMyNDEzMTI3NWUuLjEyYjY0NjU2ZDJjZjQ5NDA5NGJkMTcyZTZkZTNhNGQxYjg2 ZmFmMjMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMjUgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtp QGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBIYW5kbGUgQmlnSW50MzIgSU5UMzJfTUlOIHNo aWZ0IGFtb3VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjExMDMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAg KiBzdHJlc3MvYmlnaW50LWludDMyLW1pbi1zaGlmdC5qczogQWRkZWQuCisgICAgICAgIChzaG91 bGRCZSk6CisgICAgICAgIChzaG91bGRCZUFycmF5KToKKyAgICAgICAgKHNob3VsZFRocm93KToK KwogMjAyMC0wNC0yNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIFtKU0NdIEFkZCBmYXN0IHBhdGggZm9yIEJpZ0ludDMyIGxlZnQtc2hpZnQKZGlmZiAtLWdp dCBhL0pTVGVzdHMvc3RyZXNzL2JpZ2ludC1pbnQzMi1taW4tc2hpZnQuanMgYi9KU1Rlc3RzL3N0 cmVzcy9iaWdpbnQtaW50MzItbWluLXNoaWZ0LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYyNTFlZjFiMzM5MzQw ZWM5MDI0NmIyYTBmOTQ3OTlmN2ZhNjI0NzgKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0 cmVzcy9iaWdpbnQtaW50MzItbWluLXNoaWZ0LmpzCkBAIC0wLDAgKzEsNjEgQEAKK2Z1bmN0aW9u IHNob3VsZEJlKGFjdHVhbCwgZXhwZWN0ZWQpIHsKKyAgICBpZiAoYWN0dWFsICE9PSBleHBlY3Rl ZCkKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdiYWQgdmFsdWU6ICcgKyBhY3R1YWwpOworfQor CitmdW5jdGlvbiBzaG91bGRCZUFycmF5KGFjdHVhbCwgZXhwZWN0ZWQpIHsKKyAgICBzaG91bGRC ZShhY3R1YWwubGVuZ3RoLCBleHBlY3RlZC5sZW5ndGgpOworICAgIGZvciAodmFyIGkgPSAwOyBp IDwgZXhwZWN0ZWQubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgIHNo b3VsZEJlKGFjdHVhbFtpXSwgZXhwZWN0ZWRbaV0pOworICAgICAgICB9IGNhdGNoKGUpIHsKKyAg ICAgICAgICAgIHByaW50KEpTT04uc3RyaW5naWZ5KGFjdHVhbCkpOworICAgICAgICAgICAgdGhy b3cgZTsKKyAgICAgICAgfQorICAgIH0KK30KKworZnVuY3Rpb24gc2hvdWxkVGhyb3coZnVuYywg ZXJyb3JNZXNzYWdlKSB7CisgICAgdmFyIGVycm9yVGhyb3duID0gZmFsc2U7CisgICAgdmFyIGVy cm9yID0gbnVsbDsKKyAgICB0cnkgeworICAgICAgICBmdW5jKCk7CisgICAgfSBjYXRjaCAoZSkg eworICAgICAgICBlcnJvclRocm93biA9IHRydWU7CisgICAgICAgIGVycm9yID0gZTsKKyAgICB9 CisgICAgaWYgKCFlcnJvclRocm93bikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdub3QgdGhy b3duJyk7CisgICAgaWYgKFN0cmluZyhlcnJvcikgIT09IGVycm9yTWVzc2FnZSkKKyAgICAgICAg dGhyb3cgbmV3IEVycm9yKGBiYWQgZXJyb3I6ICR7U3RyaW5nKGVycm9yKX1gKTsKK30KKworbGV0 IGludDMybWluID0gLTB4N2ZmZmZmZmZuIC0gMW47CitzaG91bGRCZSgwbiA+PiBpbnQzMm1pbiwg MG4pOworc2hvdWxkQmUoMG4gPj4gKGludDMybWluICsgMW4pLCAwbik7CitzaG91bGRCZSgwbiA8 PCBpbnQzMm1pbiwgMG4pOworc2hvdWxkQmUoMG4gPDwgKGludDMybWluICsgMW4pLCAwbik7Citz aG91bGRCZSgxbiA8PCBpbnQzMm1pbiwgMG4pOworc2hvdWxkQmUoMW4gPDwgKGludDMybWluICsg MW4pLCAwbik7CitzaG91bGRCZSgtMW4gPDwgaW50MzJtaW4sIC0xbik7CitzaG91bGRCZSgtMW4g PDwgKGludDMybWluICsgMW4pLCAtMW4pOworc2hvdWxkQmUoMHg3ZmZmZmZmZm4gPDwgaW50MzJt aW4sIDBuKTsKK3Nob3VsZEJlKDB4N2ZmZmZmZmZuIDw8IChpbnQzMm1pbiArIDFuKSwgMG4pOwor c2hvdWxkQmUoMHg3ZmZmZmZmZmZmZmZuIDw8IGludDMybWluLCAwbik7CitzaG91bGRCZSgweDdm ZmZmZmZmZmZmZm4gPDwgKGludDMybWluICsgMW4pLCAwbik7CitzaG91bGRCZSgtMHg3ZmZmZmZm Zm4gPDwgaW50MzJtaW4sIC0xbik7CitzaG91bGRCZSgtMHg3ZmZmZmZmZm4gPDwgKGludDMybWlu ICsgMW4pLCAtMW4pOworc2hvdWxkQmUoLTB4N2ZmZmZmZmZmZmZmbiA8PCBpbnQzMm1pbiwgLTFu KTsKK3Nob3VsZEJlKC0weDdmZmZmZmZmZmZmZm4gPDwgKGludDMybWluICsgMW4pLCAtMW4pOwor c2hvdWxkVGhyb3coKCkgPT4geworICAgIDFuID4+IGludDMybWluOworfSwgYFJhbmdlRXJyb3I6 IEJpZ0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlvbiBpcyB0b28gYmlnYCk7CitzaG91 bGRUaHJvdygoKSA9PiB7CisgICAgLTFuID4+IGludDMybWluOworfSwgYFJhbmdlRXJyb3I6IEJp Z0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlvbiBpcyB0b28gYmlnYCk7CitzaG91bGRU aHJvdygoKSA9PiB7CisgICAgMHg3ZmZmZmZmZm4gPj4gaW50MzJtaW47Cit9LCBgUmFuZ2VFcnJv cjogQmlnSW50IGdlbmVyYXRlZCBmcm9tIHRoaXMgb3BlcmF0aW9uIGlzIHRvbyBiaWdgKTsKK3No b3VsZFRocm93KCgpID0+IHsKKyAgICAoLTB4N2ZmZmZmZmZuIC0gMW4pID4+IGludDMybWluOwor fSwgYFJhbmdlRXJyb3I6IEJpZ0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlvbiBpcyB0 b28gYmlnYCk7Cg== 397605 2020-04-25 19:07:03 -0700 2020-04-25 21:44:26 -0700 Patch for landing bug-211030-20200425190655.patch text/plain 4174 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 OTNiZmU4MWVjMzQxZDRmMTBiODFjN2M0YTU0NDM1M2Q5Y2JmYzE2Li44NGRkNzhiNDNjODlkYWIx MTJiZTY0M2Q5YjdjODM5NDQxZmNiMTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0yNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEhhbmRsZSBCaWdJbnQzMiBJTlQzMl9NSU4gc2hpZnQgYW1vdW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEwMzAK KworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBPdXIgQmlnSW50 IHNoaWZ0LW9wZXJhdGlvbiBkb2VzIG5vdCBjb3JyZWN0bHkgaGFuZGxlIElOVDMyX01JTiBzaGlm dCBhbW91bnQsIGFuZCBwcm9kdWNpbmcgYSB3cm9uZyByZXN1bHQuCisgICAgICAgIFRoaXMgcGF0 Y2ggZml4ZXMgaXQuCisKKyAgICAgICAgKiBydW50aW1lL09wZXJhdGlvbnMuaDoKKyAgICAgICAg KEpTQzo6c2hpZnQpOgorCiAyMDIwLTA0LTI1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIERlYWwgd2l0aCBhbm90aGVyIHJvdW5kIG9mIFhjb2RlIHVw Z3JhZGUgY2hlY2tzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P cGVyYXRpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcGVyYXRpb25zLmgK aW5kZXggMDU0MmExYTM0NmExM2JiNGE2MGFiYTUxMmE2YjU4NGI0OTgyNDQzMS4uODZjNTk5MjUz NTg4MDQ5ZGRlZGE2ODBmZmI4M2QwOGQ1YmNmNjY5NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvT3BlcmF0aW9ucy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL09wZXJhdGlvbnMuaApAQCAtNzYyLDcgKzc2MiwxMCBAQCBBTFdBWVNfSU5MSU5F IEpTVmFsdWUgc2hpZnQoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNWYWx1ZSB2MSwg SlNWYWx1ZSB2MgogICAgICAgICBpbnQzMl90IHJpZ2h0SW50MzIgPSByaWdodE51bWVyaWMuYmln SW50MzJBc0ludDMyKCk7CiAgICAgICAgIGlmIChyaWdodEludDMyIDwgMCkgewogICAgICAgICAg ICAgaXNMZWZ0ID0gIWlzTGVmdDsKLSAgICAgICAgICAgIHJpZ2h0SW50MzIgPSAtcmlnaHRJbnQz MjsKKyAgICAgICAgICAgIGlmIChyaWdodEludDMyID09IElOVDMyX01JTikKKyAgICAgICAgICAg ICAgICByaWdodEludDMyID0gSU5UMzJfTUFYOyAvLyBTaGlmdHMgb25lIGxlc3MgdGhhbiByZXF1 ZXN0ZWQsIGJ1dCBtYWtlcyBubyBvYnNlcnZhYmxlIGRpZmZlcmVuY2UuCisgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICAgICAgcmlnaHRJbnQzMiA9IC1yaWdodEludDMyOwogICAgICAgICB9 CiAgICAgICAgIEFTU0VSVChyaWdodEludDMyID49IDApOwogCmRpZmYgLS1naXQgYS9KU1Rlc3Rz L0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI5N2U3NWYyOWVhMmE3NTJmMzky ODVkY2U2MzBkNTMyNDEzMTI3NWUuLjUxZDMwZjgxMjBhMTYxYTg2NDZlZDkzNTZmY2Q4N2IzNDBh NTQ5MDcgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDQtMjUgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtp QGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBIYW5kbGUgQmlnSW50MzIgSU5UMzJfTUlOIHNo aWZ0IGFtb3VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjExMDMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAg KiBzdHJlc3MvYmlnaW50LWludDMyLW1pbi1zaGlmdC5qczogQWRkZWQuCisgICAgICAgIChzaG91 bGRCZSk6CisgICAgICAgIChzaG91bGRUaHJvdyk6CisKIDIwMjAtMDQtMjUgIFl1c3VrZSBTdXp1 a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBBZGQgZmFzdCBwYXRoIGZv ciBCaWdJbnQzMiBsZWZ0LXNoaWZ0CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9iaWdpbnQt aW50MzItbWluLXNoaWZ0LmpzIGIvSlNUZXN0cy9zdHJlc3MvYmlnaW50LWludDMyLW1pbi1zaGlm dC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi45ZGQ1Y2NkZDA0ZjBhYmJiZDdiMGVkNjYzZGZmNjc4NzlhMzg5NDVl Ci0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvYmlnaW50LWludDMyLW1pbi1zaGlm dC5qcwpAQCAtMCwwICsxLDQ5IEBACitmdW5jdGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVk KSB7CisgICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93IG5ldyBFcnJv cignYmFkIHZhbHVlOiAnICsgYWN0dWFsKTsKK30KKworZnVuY3Rpb24gc2hvdWxkVGhyb3coZnVu YywgZXJyb3JNZXNzYWdlKSB7CisgICAgdmFyIGVycm9yVGhyb3duID0gZmFsc2U7CisgICAgdmFy IGVycm9yID0gbnVsbDsKKyAgICB0cnkgeworICAgICAgICBmdW5jKCk7CisgICAgfSBjYXRjaCAo ZSkgeworICAgICAgICBlcnJvclRocm93biA9IHRydWU7CisgICAgICAgIGVycm9yID0gZTsKKyAg ICB9CisgICAgaWYgKCFlcnJvclRocm93bikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdub3Qg dGhyb3duJyk7CisgICAgaWYgKFN0cmluZyhlcnJvcikgIT09IGVycm9yTWVzc2FnZSkKKyAgICAg ICAgdGhyb3cgbmV3IEVycm9yKGBiYWQgZXJyb3I6ICR7U3RyaW5nKGVycm9yKX1gKTsKK30KKwor bGV0IGludDMybWluID0gLTB4N2ZmZmZmZmZuIC0gMW47CitzaG91bGRCZSgwbiA+PiBpbnQzMm1p biwgMG4pOworc2hvdWxkQmUoMG4gPj4gKGludDMybWluICsgMW4pLCAwbik7CitzaG91bGRCZSgw biA8PCBpbnQzMm1pbiwgMG4pOworc2hvdWxkQmUoMG4gPDwgKGludDMybWluICsgMW4pLCAwbik7 CitzaG91bGRCZSgxbiA8PCBpbnQzMm1pbiwgMG4pOworc2hvdWxkQmUoMW4gPDwgKGludDMybWlu ICsgMW4pLCAwbik7CitzaG91bGRCZSgtMW4gPDwgaW50MzJtaW4sIC0xbik7CitzaG91bGRCZSgt MW4gPDwgKGludDMybWluICsgMW4pLCAtMW4pOworc2hvdWxkQmUoMHg3ZmZmZmZmZm4gPDwgaW50 MzJtaW4sIDBuKTsKK3Nob3VsZEJlKDB4N2ZmZmZmZmZuIDw8IChpbnQzMm1pbiArIDFuKSwgMG4p Oworc2hvdWxkQmUoMHg3ZmZmZmZmZmZmZmZuIDw8IGludDMybWluLCAwbik7CitzaG91bGRCZSgw eDdmZmZmZmZmZmZmZm4gPDwgKGludDMybWluICsgMW4pLCAwbik7CitzaG91bGRCZSgtMHg3ZmZm ZmZmZm4gPDwgaW50MzJtaW4sIC0xbik7CitzaG91bGRCZSgtMHg3ZmZmZmZmZm4gPDwgKGludDMy bWluICsgMW4pLCAtMW4pOworc2hvdWxkQmUoLTB4N2ZmZmZmZmZmZmZmbiA8PCBpbnQzMm1pbiwg LTFuKTsKK3Nob3VsZEJlKC0weDdmZmZmZmZmZmZmZm4gPDwgKGludDMybWluICsgMW4pLCAtMW4p Oworc2hvdWxkVGhyb3coKCkgPT4geworICAgIDFuID4+IGludDMybWluOworfSwgYFJhbmdlRXJy b3I6IEJpZ0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlvbiBpcyB0b28gYmlnYCk7Citz aG91bGRUaHJvdygoKSA9PiB7CisgICAgLTFuID4+IGludDMybWluOworfSwgYFJhbmdlRXJyb3I6 IEJpZ0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlvbiBpcyB0b28gYmlnYCk7CitzaG91 bGRUaHJvdygoKSA9PiB7CisgICAgMHg3ZmZmZmZmZm4gPj4gaW50MzJtaW47Cit9LCBgUmFuZ2VF cnJvcjogQmlnSW50IGdlbmVyYXRlZCBmcm9tIHRoaXMgb3BlcmF0aW9uIGlzIHRvbyBiaWdgKTsK K3Nob3VsZFRocm93KCgpID0+IHsKKyAgICAoLTB4N2ZmZmZmZmZuIC0gMW4pID4+IGludDMybWlu OworfSwgYFJhbmdlRXJyb3I6IEJpZ0ludCBnZW5lcmF0ZWQgZnJvbSB0aGlzIG9wZXJhdGlvbiBp cyB0b28gYmlnYCk7Cg==