211019 2020-04-25 05:17:13 -0700 [Web Animations] KeyframeEffect should ensure its target remains alive 2020-04-26 10:47:18 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts darin dino graouts webkit-bug-importer oldest_to_newest 1645575 0 graouts 2020-04-25 05:17:13 -0700 [Web Animations] KeyframeEffect should ensure its target remains alive 1645576 1 397557 graouts 2020-04-25 05:19:09 -0700 Created attachment 397557 Patch 1645603 2 397557 dbates 2020-04-25 08:22:42 -0700 Comment on attachment 397557 Patch Patch looks good. 1645608 3 ews-feeder 2020-04-25 09:08:50 -0700 Committed r260705: <https://trac.webkit.org/changeset/260705> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397557. 1645609 4 webkit-bug-importer 2020-04-25 09:09:16 -0700 <rdar://problem/62372184> 1645619 5 397557 darin 2020-04-25 10:26:56 -0700 Comment on attachment 397557 Patch What prevents this from causing a reference cycle? 1645793 6 graouts 2020-04-26 10:47:18 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 397557 [details] > Patch > > What prevents this from causing a reference cycle? If an element is attached to the tree, document teardown will cause the effect-to-element relationship to be cleared. If the element is loose, like the one in this patch's testcase, it will potentially remain until the animation's effect is kept alive. If there are no JS references to the effect, then the procedure to remove replaced animations as defined in https://drafts.csswg.org/web-animations-1/#remove-replaced-animations will take care of this. 397557 2020-04-25 05:19:09 -0700 2020-04-25 09:08:51 -0700 Patch bug-211019-20200425141908.patch text/plain 5255 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjE1M2MzYmE3ODY3YjA1 MGUwNmY4YTFlMmYxNDFkZDIxZGMzYTA3Zi4uYmMwZWQwODNkNjRlZTFlM2E1YjhkOTg5OGRiMTkw YTZiMDkxYTg1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA0LTI1ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBLZXlmcmFtZUVmZmVjdCBzaG91bGQgZW5zdXJlIGl0cyB0YXJnZXQgcmVtYWlucyBhbGl2ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMDE5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogd2Vi YW5pbWF0aW9ucy9rZXlmcmFtZS1lZmZlY3QtdGFyZ2V0LWtlcHQtYWxpdmUuaHRtbAorCisgICAg ICAgIE1ha2UgS2V5ZnJhbWVFZmZlY3Q6Om1fdGFyZ2V0IGEgUmVmUHRyIHNvIHRoYXQgYXNzaWdu aW5nIGFuIGVsZW1lbnQgdG8gZWZmZWN0LnRhcmdldCBndWFyYW50ZWVzIHRoYXQgZWxlbWVudAor ICAgICAgICBpcyBrZXB0IGFsaXZlIGV2ZW4gaWYgdGhlcmUgYXJlIG5vIG90aGVyIHJlZmVyZW5j ZXMgdG8gdGhhdCBlbGVtZW50LgorCisgICAgICAgICogYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktleWZyYW1lRWZmZWN0OjpLZXlmcmFtZUVmZmVjdCk6 CisgICAgICAgIChXZWJDb3JlOjpLZXlmcmFtZUVmZmVjdDo6c2V0VGFyZ2V0KToKKyAgICAgICAg KiBhbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuaDoKKwogMjAyMC0wNC0yNCAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFVuYWJsZSB0byBzaWduIHVwIG9u IHR3aXR0ZXIuY29tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJh bWVFZmZlY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0LmNw cAppbmRleCBlNTRhNTk0MjMzNjE4ZjBjYjM2ZmNhNjc1YzlmZTkwOGE5MzNiY2NiLi5kMTBiMDJj ZThmNjIxNTA5MTU2MzM2OWQ2N2Q3ZDNmNmNkZjMyZTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Fu aW1hdGlvbi9LZXlmcmFtZUVmZmVjdC5jcHAKQEAgLTUyOCw3ICs1MjgsNyBAQCBSZWY8S2V5ZnJh bWVFZmZlY3Q+IEtleWZyYW1lRWZmZWN0OjpjcmVhdGUoY29uc3QgRWxlbWVudCYgdGFyZ2V0LCBQ c2V1ZG9JZCBwc2V1ZAogfQogCiBLZXlmcmFtZUVmZmVjdDo6S2V5ZnJhbWVFZmZlY3QoRWxlbWVu dCogdGFyZ2V0LCBQc2V1ZG9JZCBwc2V1ZG9JZCkKLSAgICA6IG1fdGFyZ2V0KG1ha2VXZWFrUHRy KHRhcmdldCkpCisgICAgOiBtX3RhcmdldCh0YXJnZXQpCiAgICAgLCBtX3BzZXVkb0lkKHBzZXVk b0lkKQogewogfQpAQCAtMTEyMSwxMSArMTEyMSwxMSBAQCBFbGVtZW50KiBLZXlmcmFtZUVmZmVj dDo6dGFyZ2V0RWxlbWVudE9yUHNldWRvRWxlbWVudCgpIGNvbnN0CiAKIHZvaWQgS2V5ZnJhbWVF ZmZlY3Q6OnNldFRhcmdldChSZWZQdHI8RWxlbWVudD4mJiBuZXdUYXJnZXQpCiB7Ci0gICAgaWYg KG1fdGFyZ2V0LmdldCgpID09IG5ld1RhcmdldC5nZXQoKSkKKyAgICBpZiAobV90YXJnZXQgPT0g bmV3VGFyZ2V0KQogICAgICAgICByZXR1cm47CiAKICAgICBhdXRvKiBwcmV2aW91c1RhcmdldEVs ZW1lbnRPclBzZXVkb0VsZW1lbnQgPSB0YXJnZXRFbGVtZW50T3JQc2V1ZG9FbGVtZW50KCk7Ci0g ICAgbV90YXJnZXQgPSBtYWtlV2Vha1B0cihuZXdUYXJnZXQuZ2V0KCkpOworICAgIG1fdGFyZ2V0 ID0gV1RGTW92ZShuZXdUYXJnZXQpOwogICAgIGRpZENoYW5nZVRhcmdldEVsZW1lbnRPclBzZXVk b0VsZW1lbnQocHJldmlvdXNUYXJnZXRFbGVtZW50T3JQc2V1ZG9FbGVtZW50KTsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuaAppbmRleCBjM2E0MGFmZTM0NmEy Y2MxYzY0MGIxNTM0YWM2MmJhYjEzMjVlYTc4Li5hY2YxNzRjZThlZmNiNjVlZWE3NjkzY2YwZDA4 NmFjZGI2ZjMxMTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJh bWVFZmZlY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3Qu aApAQCAtMjAyLDcgKzIwMiw3IEBAIHByaXZhdGU6CiAgICAgS2V5ZnJhbWVMaXN0IG1fYmxlbmRp bmdLZXlmcmFtZXMgeyBlbXB0eVN0cmluZygpIH07CiAgICAgVmVjdG9yPFBhcnNlZEtleWZyYW1l PiBtX3BhcnNlZEtleWZyYW1lczsKICAgICBWZWN0b3I8QWNjZWxlcmF0ZWRBY3Rpb24+IG1fcGVu ZGluZ0FjY2VsZXJhdGVkQWN0aW9uczsKLSAgICBXZWFrUHRyPEVsZW1lbnQ+IG1fdGFyZ2V0Owor ICAgIFJlZlB0cjxFbGVtZW50PiBtX3RhcmdldDsKICAgICBQc2V1ZG9JZCBtX3BzZXVkb0lkIHsg UHNldWRvSWQ6Ok5vbmUgfTsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8Y29uc3QgUmVuZGVyU3R5bGU+ IG1fdW5hbmltYXRlZFN0eWxlOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDM3ZDE1MDcyOTFjMTNmODVhZDc3NDI3YjU3 ZTRiZmYzMjgxNTFlOS4uYzhhMGRmMjJkZmEwMDc0NjQ3MTEwY2I4MDI2ZGJlN2QzNjc3M2Q1NCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTI1ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0 c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25zXSBLZXlmcmFtZUVmZmVjdCBz aG91bGQgZW5zdXJlIGl0cyB0YXJnZXQgcmVtYWlucyBhbGl2ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMDE5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGNyZWF0ZXMgYSBL ZXlmcmFtZUVmZmVjdCB0YXJnZXRpbmcgYW4gZWxlbWVudCB3aXRoIG5vIG90aGVyIHJlZmVyZW5j ZSBhbmQgdHJpZ2dlcgorICAgICAgICBnYXJiYWdlIGNvbGxlY3Rpb24gdG8gY2hlY2sgdGhhdCB0 aGUgZWZmZWN0J3MgdGFyZ2V0IGV4aXN0cy4gVGhpcyB0ZXN0IHdvdWxkIGhhdmUgZmFpbGVkIHBy aW9yIHRvCisgICAgICAgIHRoaXMgcGF0Y2gncyBjb2RlIGNoYW5nZXMuCisKKyAgICAgICAgKiB3 ZWJhbmltYXRpb25zL2tleWZyYW1lLWVmZmVjdC10YXJnZXQta2VwdC1hbGl2ZS1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIHdlYmFuaW1hdGlvbnMva2V5ZnJhbWUtZWZmZWN0LXRhcmdl dC1rZXB0LWFsaXZlLmh0bWw6IEFkZGVkLgorCiAyMDIwLTA0LTI1ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgU2tpcCBsZWdhY3kgbWVkaWEgY29udHJvbHMg dGVzdHMgb24gbWFjT1MgYW5kIGlPUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYW5pbWF0 aW9ucy9rZXlmcmFtZS1lZmZlY3QtdGFyZ2V0LWtlcHQtYWxpdmUtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvd2ViYW5pbWF0aW9ucy9rZXlmcmFtZS1lZmZlY3QtdGFyZ2V0LWtlcHQtYWxpdmUt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhhMTczOTIzNGMxOGVhNTFiOTIyMjc2MjkyODc2NjRi ZDU5MTNiMWMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy93ZWJhbmltYXRpb25zL2tl eWZyYW1lLWVmZmVjdC10YXJnZXQta2VwdC1hbGl2ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwx MCBAQAorVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEga2V5ZnJhbWUgZWZmZWN0IGtlZXBzIGl0cyB0 YXJnZXQgYWxpdmUgZXZlbiBpZiB0aGF0IG5vZGUgaGFzIG5vIG90aGVyIHJlZmVyZW5jZS4KKwor T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgZWZmZWN0LnRhcmdldC5sb2NhbE5h bWUgaXMgImRpdiIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhbmltYXRpb25zL2tleWZyYW1lLWVm ZmVjdC10YXJnZXQta2VwdC1hbGl2ZS5odG1sIGIvTGF5b3V0VGVzdHMvd2ViYW5pbWF0aW9ucy9r ZXlmcmFtZS1lZmZlY3QtdGFyZ2V0LWtlcHQtYWxpdmUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xN2YwNmEw ZGE1M2RhY2VhNDNlYjc5MWIwMmI5NDI3MmQwMDI2ODlhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvd2ViYW5pbWF0aW9ucy9rZXlmcmFtZS1lZmZlY3QtdGFyZ2V0LWtlcHQtYWxpdmUu aHRtbApAQCAtMCwwICsxLDE3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8 ZGl2IGlkPSJ0YXJnZXQiPjwvZGl2PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBjaGVj a3MgdGhhdCBhIGtleWZyYW1lIGVmZmVjdCBrZWVwcyBpdHMgdGFyZ2V0IGFsaXZlIGV2ZW4gaWYg dGhhdCBub2RlIGhhcyBubyBvdGhlciByZWZlcmVuY2UuIik7CisKK2djKCk7Citjb25zdCBlZmZl Y3QgPSBuZXcgS2V5ZnJhbWVFZmZlY3QoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2IiksIHsg fSk7CitnYygpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJlZmZlY3QudGFyZ2V0LmxvY2FsTmFt ZSIsICJkaXYiKTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRl c3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQo=