211012 2020-04-24 23:20:17 -0700 Suppress ASan on DFG::clobberize() to work around an ASan bug. 2020-04-25 00:25:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist ggaren keith_miller msaboff pgyanchandani saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1645543 0 mark.lam 2020-04-24 23:20:17 -0700 ASan was incorrectly thinking that we're accessing invalid stack memory when we're not. <rdar://problem/62275430> 1645544 1 397545 mark.lam 2020-04-24 23:46:19 -0700 Created attachment 397545 proposed patch. 1645546 2 397545 ysuzuki 2020-04-24 23:59:35 -0700 Comment on attachment 397545 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=397545&action=review r=me > Source/JavaScriptCore/dfg/DFGClobberize.h:43 > +SUPPRESS_ASAN void clobberize(Graph& graph, Node* node, const ReadFunctor& read, const WriteFunctor& write, const DefFunctor& def) Can you add FIXME comment describing why SUPPRESS_ASAN is necessary (describing about ASAN bug)? 1645550 3 mark.lam 2020-04-25 00:25:18 -0700 (In reply to Yusuke Suzuki from comment #2) > Can you add FIXME comment describing why SUPPRESS_ASAN is necessary > (describing about ASAN bug)? Thanks for the review. I've added the FIXME with explanation. Landed in r260692: <http://trac.webkit.org/r260692>. 397545 2020-04-24 23:46:19 -0700 2020-04-24 23:59:35 -0700 proposed patch. bug-211012.patch text/plain 3682 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYwNjkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDIwLTA0LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBT dXBwcmVzcyBBU2FuIG9uIERGRzo6Y2xvYmJlcml6ZSgpIHRvIHdvcmsgYXJvdW5kIGFuIEFTYW4g YnVnLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEx MDEyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI3NTQzMD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU2FuIHdhcyBpbmNvcnJlY3RseSB0aGlu a2luZyB0aGF0IHdlJ3JlIGFjY2Vzc2luZyBpbnZhbGlkIHN0YWNrIG1lbW9yeSB3aGVuIHdlJ3Jl IG5vdC4KKworICAgICAgICAqIGRmZy9ERkdDbG9iYmVyaXplLmg6CisgICAgICAgIChKU0M6OkRG Rzo6Y2xvYmJlcml6ZSk6CisKIDIwMjAtMDQtMjQgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxl c2hAZ21haWwuY29tPgogCiAgICAgICAgIEZpeCBXQVNNIEVycm9yIGNsYXNzZXMgYW5kIHJlLXN5 bmMgd3B0L3dhc20vanNhcGkgZnJvbSB1cHN0cmVhbQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdDbG9iYmVyaXplLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdDbG9iYmVyaXplLmgJKHJldmlzaW9uIDI2MDY5MSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0 MCw3IEBACiBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKIHRlbXBsYXRlPHR5cGVu YW1lIFJlYWRGdW5jdG9yLCB0eXBlbmFtZSBXcml0ZUZ1bmN0b3IsIHR5cGVuYW1lIERlZkZ1bmN0 b3I+Ci12b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlLCBjb25zdCBSZWFk RnVuY3RvciYgcmVhZCwgY29uc3QgV3JpdGVGdW5jdG9yJiB3cml0ZSwgY29uc3QgRGVmRnVuY3Rv ciYgZGVmKQorU1VQUFJFU1NfQVNBTiB2b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2Rl KiBub2RlLCBjb25zdCBSZWFkRnVuY3RvciYgcmVhZCwgY29uc3QgV3JpdGVGdW5jdG9yJiB3cml0 ZSwgY29uc3QgRGVmRnVuY3RvciYgZGVmKQogewogICAgIC8vIFNvbWUgbm90ZXM6CiAgICAgLy8K SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI2MDY5MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTI0ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KKworICAgICAgICBTdXBwcmVzcyBBU2FuIG9uIERGRzo6Y2xvYmJlcml6 ZSgpIHRvIHdvcmsgYXJvdW5kIGFuIEFTYW4gYnVnLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMDEyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82 MjI3NTQzMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUZXN0IGlzIGNvdXJ0ZXN5IG9mIEZhYmllbiBEdWNoZW5lIGFuZCBQaW5raSBHeWFuY2hhbmRh bmkuCisKKyAgICAgICAgKiBqcy9zdXBwcmVzcy1hc2FuLW9uLWNsb2JiZXJpemUtdG8td29ya2Fy b3VuZC1hc2FuLWJ1Zy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL3N1cHByZXNz LWFzYW4tb24tY2xvYmJlcml6ZS10by13b3JrYXJvdW5kLWFzYW4tYnVnLmh0bWw6IEFkZGVkLgor CiAyMDIwLTA0LTI0ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgog CiAgICAgICAgIFJlbW92aW5nIHdlYnNpdGUgZGF0YSBmb3IgYSBkb21haW4gc2hvdWxkIGRlbGV0 ZSBjb3JyZXNwb25kaW5nIElUUCBlbnRyeQpJbmRleDogTGF5b3V0VGVzdHMvanMvc3VwcHJlc3Mt YXNhbi1vbi1jbG9iYmVyaXplLXRvLXdvcmthcm91bmQtYXNhbi1idWctZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3N1cHByZXNzLWFzYW4tb24tY2xvYmJlcml6ZS10 by13b3JrYXJvdW5kLWFzYW4tYnVnLWV4cGVjdGVkLnR4dAkobm9uZXhpc3RlbnQpCisrKyBMYXlv dXRUZXN0cy9qcy9zdXBwcmVzcy1hc2FuLW9uLWNsb2JiZXJpemUtdG8td29ya2Fyb3VuZC1hc2Fu LWJ1Zy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzIEBACitUaGlzIHRl c3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoLgorCisKSW5kZXg6IExheW91dFRlc3RzL2pz L3N1cHByZXNzLWFzYW4tb24tY2xvYmJlcml6ZS10by13b3JrYXJvdW5kLWFzYW4tYnVnLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvc3VwcHJlc3MtYXNhbi1vbi1jbG9iYmVyaXpl LXRvLXdvcmthcm91bmQtYXNhbi1idWcuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0 cy9qcy9zdXBwcmVzcy1hc2FuLW9uLWNsb2JiZXJpemUtdG8td29ya2Fyb3VuZC1hc2FuLWJ1Zy5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjggQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0 bWw+CisKKzxzdHlsZT4KKy5jbGFzczEgeyAgYm9yZGVyLWltYWdlLXNvdXJjZTogdXJsKCNodG1s dmFyMDAwMDIpOyAgLXdlYmtpdC10cmFuc2l0aW9uLWR1cmF0aW9uOiAxczsgcG9zaXRpb246IGZp eGVkIH0KKzwvc3R5bGU+CisKKzxzY3JpcHQ+CitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIGlm ICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAg IGVsZW1lbnRTdHlsZSA9IGRpdi5zdHlsZTsKKyAgICBlbGVtZW50U3R5bGUuc2V0UHJvcGVydHko Ii13ZWJraXQtYm9yZGVyLXN0YXJ0LXdpZHRoIiwgIjFweCIpOworICAgIGVsZW1lbnRTdHlsZS5z ZXRQcm9wZXJ0eSgiY29sdW1uLXNwYW4iLCAiYWxsIik7CisgICAgYW5pbWF0aW9uID0gZGl2Lmdl dEFuaW1hdGlvbnMoKVswXTsKKyAgICBhbmltYXRpb24uZWZmZWN0ID0gbmV3IEtleWZyYW1lRWZm ZWN0KGxpLCBbIHsgfSBdLCA2KTsgCit9CisKKzwvc2NyaXB0PgorCis8Ym9keSBvbmxvYWQ9cnVu VGVzdCgpPgorPHA+VGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBubyBjcmFzaC48L3A+Cis8 ZGl2IGlkPSJkaXYiIGNsYXNzPSJjbGFzczEiID4KKzxhdWRpbyBjb250cm9scz0iY29udHJvbHMi PgorPGxpIGlkPSJsaSI+Cis8L2JvZHk+Cis8L2h0bWw+Cg==