211010 2020-04-24 23:00:16 -0700 Use static initialized Lock instead of LazyNeverDestroyed<Lock> 2020-04-25 17:33:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki cdumez dino esprehn+autocc ews-watchlist graouts gyuyoung.kim kondapallykalyan mark.lam mmaxfield webkit-bug-importer oldest_to_newest 1645534 0 ysuzuki 2020-04-24 23:00:16 -0700 Use static initialized Lock instead of LazyNeverDestroyed<Lock> 1645535 1 397543 ysuzuki 2020-04-24 23:01:09 -0700 Created attachment 397543 Patch 1645537 2 397543 mark.lam 2020-04-24 23:05:38 -0700 Comment on attachment 397543 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397543&action=review r=me > Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:110 > +static Lock deviceMutex; Why not just declare it as a static inside its accessor function? Ditto below. 1645696 3 397543 ysuzuki 2020-04-25 17:16:47 -0700 Comment on attachment 397543 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397543&action=review Thanks! >> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:110 >> +static Lock deviceMutex; > > Why not just declare it as a static inside its accessor function? Ditto below. Yeah, right. We can put it in a function. Fixed! 1645703 4 ysuzuki 2020-04-25 17:32:04 -0700 Committed r260714: <https://trac.webkit.org/changeset/260714> 1645704 5 webkit-bug-importer 2020-04-25 17:33:14 -0700 <rdar://problem/62378157> 397543 2020-04-24 23:01:09 -0700 2020-04-24 23:05:38 -0700 Patch bug-211010-20200424230108.patch text/plain 4395 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ3NDE1Y2E1NTQ3NzBj ODFlMmFlOGMxMTJlMzQ3YWYzOTZhYzYxYi4uOWFlOWRlMDU0MTJiNDAxYzk1NTMxZjA5Zjg1NTll OTEzNjRkOGQxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA0LTI0ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHN0YXRpYyBpbml0 aWFsaXplZCBMb2NrIGluc3RlYWQgb2YgTGF6eU5ldmVyRGVzdHJveWVkPExvY2s+CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEwMTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXVEY6OkxvY2sgY2FuIGJl IHN0YXRpYy1pbml0aWFsaXplZCwgc28gbm8gbmVlZCB0byB1c2UgTGF6eU5ldmVyRGVzdHJveWVk PExvY2s+LgorCisgICAgICAgICogTW9kdWxlcy93ZWJncHUvV2ViR1BVRGV2aWNlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYkdQVURldmljZTo6aW5zdGFuY2VzTXV0ZXgpOgorICAgICAgICAq IE1vZHVsZXMvd2ViZ3B1L1dlYkdQVVBpcGVsaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oldl YkdQVVBpcGVsaW5lOjppbnN0YW5jZXNNdXRleCk6CisgICAgICAgICogaHRtbC9jYW52YXMvQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJp bmdDb250ZXh0OjppbnN0YW5jZXNNdXRleCk6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xQ cm9ncmFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUHJvZ3JhbTo6aW5zdGFuY2VzTXV0 ZXgpOgorCiAyMDIwLTA0LTI0ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dURl0gYWxsVGhyZWFkcyByZWdpc3RyYXRpb24gaXMgcmFjeSB3aXRoIGFsbFRo cmVhZHMgdW5yZWdpc3RyYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViZ3B1L1dlYkdQVURldmljZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9X ZWJHUFVEZXZpY2UuY3BwCmluZGV4IDBmZmQ5YjhlMzAyZDNlM2NiYzQ3ZGFkODFmNmVmMTMzNjRj NWZhYzkuLjAxYTZiOGNhMTU0NGM1YWFhMTg3NmI0OGZiYWNhOTA2ZmZhYTg1NzAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dlYkdQVURldmljZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV2ViR1BVRGV2aWNlLmNwcApAQCAtMTA3LDE0 ICsxMDcsMTAgQEAgSGFzaFNldDxXZWJHUFVEZXZpY2UqPiYgV2ViR1BVRGV2aWNlOjppbnN0YW5j ZXMoY29uc3QgTG9ja0hvbGRlciYpCiAgICAgcmV0dXJuIGluc3RhbmNlczsKIH0KIAorc3RhdGlj IExvY2sgZGV2aWNlTXV0ZXg7CiBMb2NrJiBXZWJHUFVEZXZpY2U6Omluc3RhbmNlc011dGV4KCkK IHsKLSAgICBzdGF0aWMgTGF6eU5ldmVyRGVzdHJveWVkPExvY2s+IG11dGV4OwotICAgIHN0YXRp YyBzdGQ6Om9uY2VfZmxhZyBpbml0aWFsaXplTXV0ZXg7Ci0gICAgc3RkOjpjYWxsX29uY2UoaW5p dGlhbGl6ZU11dGV4LCBbXSB7Ci0gICAgICAgIG11dGV4LmNvbnN0cnVjdCgpOwotICAgIH0pOwot ICAgIHJldHVybiBtdXRleC5nZXQoKTsKKyAgICByZXR1cm4gZGV2aWNlTXV0ZXg7CiB9CiAKIFdl YkdQVURldmljZTo6V2ViR1BVRGV2aWNlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmIGNvbnRleHQs IFJlZjxjb25zdCBXZWJHUFVBZGFwdGVyPiYmIGFkYXB0ZXIsIFJlZjxHUFVEZXZpY2U+JiYgZGV2 aWNlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV2ViR1BVUGlw ZWxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV2ViR1BVUGlwZWxpbmUu Y3BwCmluZGV4IGYzM2JhZjRmYzkyODcxMDM3YWNjN2U1MDA5NGI1ZDI4Zjg0YTQzNTMuLmVlMTdk NGM0YTZkZjBlNjY1NjU5NTIwZGQ0NWFhNTlkNWY2NjdmNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dlYkdQVVBpcGVsaW5lLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmdwdS9XZWJHUFVQaXBlbGluZS5jcHAKQEAgLTQ1LDE0ICs0NSwxMCBA QCBIYXNoTWFwPFdlYkdQVVBpcGVsaW5lKiwgV2ViR1BVRGV2aWNlKj4mIFdlYkdQVVBpcGVsaW5l OjppbnN0YW5jZXMoY29uc3QgTG9ja0hvbAogICAgIHJldHVybiBpbnN0YW5jZXM7CiB9CiAKK3N0 YXRpYyBMb2NrIHBpcGVsaW5lTXV0ZXg7CiBMb2NrJiBXZWJHUFVQaXBlbGluZTo6aW5zdGFuY2Vz TXV0ZXgoKQogewotICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8TG9jaz4gbXV0ZXg7Ci0g ICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIGluaXRpYWxpemVNdXRleDsKLSAgICBzdGQ6OmNhbGxf b25jZShpbml0aWFsaXplTXV0ZXgsIFtdIHsKLSAgICAgICAgbXV0ZXguY29uc3RydWN0KCk7Ci0g ICAgfSk7Ci0gICAgcmV0dXJuIG11dGV4LmdldCgpOworICAgIHJldHVybiBwaXBlbGluZU11dGV4 OwogfQogCiBXZWJHUFVQaXBlbGluZTo6V2ViR1BVUGlwZWxpbmUoV2ViR1BVRGV2aWNlJiBkZXZp Y2UsIEdQVUVycm9yU2NvcGVzJiBlcnJvclNjb3BlcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggYzE0NzEzMzRl ZmIzZTJhMDFhMDhkNGM0ZDUwYTIwM2Y5NGY5MDFjNi4uNjRkZTFlNmQ5ZGQ3MDMzYWIzZGZkOTY5 MGU0MzY2ZWM4OTI5NDk4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv Q2FudmFzUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTUwLDE0ICs1MCwxMCBAQCBIYXNoU2V0 PENhbnZhc1JlbmRlcmluZ0NvbnRleHQqPiYgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDo6aW5zdGFu Y2VzKGNvbnN0IExvY2tIbwogICAgIHJldHVybiBpbnN0YW5jZXM7CiB9CiAKK3N0YXRpYyBMb2Nr IGNhbnZhc011dGV4OwogTG9jayYgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDo6aW5zdGFuY2VzTXV0 ZXgoKQogewotICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8TG9jaz4gbXV0ZXg7Ci0gICAg c3RhdGljIHN0ZDo6b25jZV9mbGFnIGluaXRpYWxpemVNdXRleDsKLSAgICBzdGQ6OmNhbGxfb25j ZShpbml0aWFsaXplTXV0ZXgsIFtdIHsKLSAgICAgICAgbXV0ZXguY29uc3RydWN0KCk7Ci0gICAg fSk7Ci0gICAgcmV0dXJuIG11dGV4LmdldCgpOworICAgIHJldHVybiBjYW52YXNNdXRleDsKIH0K IAogQ2FudmFzUmVuZGVyaW5nQ29udGV4dDo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dChDYW52YXNC YXNlJiBjYW52YXMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TFByb2dyYW0uY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xQcm9ncmFtLmNw cAppbmRleCAxNjgxZDdmMjA1YTMwMmRjNjM2NWRhODhlMWIzOGE3MjBiYjFkN2M1Li45NTg0Y2Y5 OTJiNDcxYWM5MTE3NmI1NzM2NTViYjgwMjcwMTQxMTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMUHJvZ3JhbS5jcHAKQEAgLTQ0LDE0ICs0NCwxMCBAQCBIYXNoTWFwPFdl YkdMUHJvZ3JhbSosIFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UqPiYgV2ViR0xQcm9ncmFtOjpp bnN0YW5jZXMoY29ucwogICAgIHJldHVybiBpbnN0YW5jZXM7CiB9CiAKK3N0YXRpYyBMb2NrIHBy b2dyYW1NdXRleDsKIExvY2smIFdlYkdMUHJvZ3JhbTo6aW5zdGFuY2VzTXV0ZXgoKQogewotICAg IHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8TG9jaz4gbXV0ZXg7Ci0gICAgc3RhdGljIHN0ZDo6 b25jZV9mbGFnIGluaXRpYWxpemVNdXRleDsKLSAgICBzdGQ6OmNhbGxfb25jZShpbml0aWFsaXpl TXV0ZXgsIFtdIHsKLSAgICAgICAgbXV0ZXguY29uc3RydWN0KCk7Ci0gICAgfSk7Ci0gICAgcmV0 dXJuIG11dGV4LmdldCgpOworICAgIHJldHVybiBwcm9ncmFtTXV0ZXg7CiB9CiAKIFJlZjxXZWJH TFByb2dyYW0+IFdlYkdMUHJvZ3JhbTo6Y3JlYXRlKFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2Um IGN0eCkK