211002 2020-04-24 15:57:33 -0700 WebPasteboardProxy::getPasteboardStringsForType() and WebPasteboardProxy::readURLFromPasteboard() should check return value of SharedMemory::createHandle() 2020-09-01 15:56:25 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 211542 1 ddkilzer ddkilzer commit-queue darin katherine_cheney useafterfree webkit-bug-importer wenson_hsieh oldest_to_newest 1645448 0 ddkilzer 2020-04-24 15:57:33 -0700 WebPasteboardProxy::getPasteboardStringsForType() and WebPasteboardProxy::readURLFromPasteboard() should check return value of SharedMemory::createHandle(). <rdar://problem/60103950> 1645452 1 397525 ddkilzer 2020-04-24 16:02:14 -0700 Created attachment 397525 Patch v1 1645504 2 397525 ddkilzer 2020-04-24 18:12:55 -0700 Comment on attachment 397525 Patch v1 This code is only used on Apple platforms, so adding cq+ and ignoring build errors on GTK and WPE ports. 1645511 3 ews-feeder 2020-04-24 18:33:02 -0700 Committed r260689: <https://trac.webkit.org/changeset/260689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397525. 1645620 4 darin 2020-04-25 10:29:56 -0700 Are we going to add WARN_UNUSED_RETURN to createHandle? 1645880 5 ddkilzer 2020-04-26 20:16:11 -0700 (In reply to Darin Adler from comment #4) > Are we going to add WARN_UNUSED_RETURN to createHandle? Yes, after we fix all the individual issues. Tracked by <rdar://problem/62274167>. 1645883 6 darin 2020-04-26 22:03:29 -0700 Great! 1649922 7 commit-queue 2020-05-06 18:54:58 -0700 Re-opened since this is blocked by bug 211542 1684547 8 407698 katherine_cheney 2020-09-01 11:05:44 -0700 Created attachment 407698 Patch 1684550 9 katherine_cheney 2020-09-01 11:11:04 -0700 Thanks for the review Wenson. Going to wait for EWS before I cq+. 1684603 10 407698 ddkilzer 2020-09-01 13:40:07 -0700 Comment on attachment 407698 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407698&action=review > Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:217 > - sharedMemoryBuffer->createHandle(handle, SharedMemory::Protection::ReadOnly); > + if (!sharedMemoryBuffer->createHandle(handle, SharedMemory::Protection::ReadOnly)) > + return completionHandler({ }); To find all places where this return value should be changed (and to prevent this from being re-introduced), change this in Source/WebKit/Platform/SharedMemory.h: bool createHandle(Handle&, Protection); To this: WARN_UNUSED_RETURN bool createHandle(Handle&, Protection); Then fix all the warnings. (Not necessary to do for this patch.) 1684604 11 407698 ddkilzer 2020-09-01 13:40:36 -0700 Comment on attachment 407698 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407698&action=review >> Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:217 >> + return completionHandler({ }); > > To find all places where this return value should be changed (and to prevent this from being re-introduced), change this in Source/WebKit/Platform/SharedMemory.h: > > bool createHandle(Handle&, Protection); > > To this: > > WARN_UNUSED_RETURN bool createHandle(Handle&, Protection); > > Then fix all the warnings. (Not necessary to do for this patch.) Aaaaaand...I should have read the comments first. :) 1684608 12 katherine_cheney 2020-09-01 13:58:53 -0700 (In reply to David Kilzer (:ddkilzer) from comment #11) > Comment on attachment 407698 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407698&action=review > > >> Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:217 > >> + return completionHandler({ }); > > > > To find all places where this return value should be changed (and to prevent this from being re-introduced), change this in Source/WebKit/Platform/SharedMemory.h: > > > > bool createHandle(Handle&, Protection); > > > > To this: > > > > WARN_UNUSED_RETURN bool createHandle(Handle&, Protection); > > > > Then fix all the warnings. (Not necessary to do for this patch.) > > Aaaaaand...I should have read the comments first. :) It's a good reminder! I can tackle that next. 1684647 13 ews-feeder 2020-09-01 15:56:24 -0700 Committed r266416: <https://trac.webkit.org/changeset/266416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407698. 397525 2020-04-24 16:02:14 -0700 2020-09-01 11:05:42 -0700 Patch v1 bug-211002-20200424160417.patch text/plain 2325 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNhYjg1ZDMyNjcwNzI5ODZh MGNlMDU1YzRjZDg1OTFhNGVjYjEyOTAuLjMzYjNhNTJiZTYxMDQ1YWNiZjI1Y2Y5OGMwZDJiNjBh Zjk3MWNhNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDQtMjQgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJQYXN0ZWJvYXJkUHJveHk6 OmdldFBhc3RlYm9hcmRTdHJpbmdzRm9yVHlwZSgpIGFuZCBXZWJQYXN0ZWJvYXJkUHJveHk6OnJl YWRVUkxGcm9tUGFzdGVib2FyZCgpIHNob3VsZCBjaGVjayByZXR1cm4gdmFsdWUgb2YgU2hhcmVk TWVtb3J5OjpjcmVhdGVIYW5kbGUoKQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjEx MDAyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0NvY29hL1dlYlBhc3RlYm9hcmRQcm94eUNvY29hLm1tOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYXN0ZWJvYXJkUHJveHk6OmdldFBhc3RlYm9hcmRCdWZmZXJGb3JUeXBlKToKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFzdGVib2FyZFByb3h5OjpyZWFkQnVmZmVyRnJvbVBhc3RlYm9h cmQpOgorICAgICAgICAtIENoZWNrIHJlc3VsdCBvZiBTaGFyZWRNZW1vcnk6OmNyZWF0ZUhhbmRs ZSgpIGFuZCByZXR1cm4gZWFybHkKKyAgICAgICAgICBvbiBmYWlsdXJlLgorCiAyMDIwLTA0LTI0 ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgSVBDOjpEZWNv ZGVyOjppc0ludmFsaWQoKSBzaG91bGQgYmUgcmVuYW1lZCB0byBpc1ZhbGlkKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlBhc3RlYm9hcmRQcm94eUNvY29h Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFzdGVib2FyZFByb3h5Q29j b2EubW0KaW5kZXggZDc3MzZlODM4MGYwZTFmZmU5NzRiMjdkN2E1ZDNlZjVlMDFmMTg5Mi4uZGEx MDg4ZjNjYjE5YTViOWVkM2I3MDk2NGE5ODJlZDNhZTYwMzYyZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFzdGVib2FyZFByb3h5Q29jb2EubW0KKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFzdGVib2FyZFByb3h5Q29jb2EubW0K QEAgLTE4NSw3ICsxODUsOCBAQCB2b2lkIFdlYlBhc3RlYm9hcmRQcm94eTo6Z2V0UGFzdGVib2Fy ZEJ1ZmZlckZvclR5cGUoSVBDOjpDb25uZWN0aW9uJiBjb25uZWN0aW9uLAogICAgICAgICByZXR1 cm4gY29tcGxldGlvbkhhbmRsZXIoeyB9LCAwKTsKICAgICBtZW1jcHkoc2hhcmVkTWVtb3J5QnVm ZmVyLT5kYXRhKCksIGJ1ZmZlci0+ZGF0YSgpLCBzaXplKTsKICAgICBTaGFyZWRNZW1vcnk6Okhh bmRsZSBoYW5kbGU7Ci0gICAgc2hhcmVkTWVtb3J5QnVmZmVyLT5jcmVhdGVIYW5kbGUoaGFuZGxl LCBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJlYWRPbmx5KTsKKyAgICBpZiAoIXNoYXJlZE1l bW9yeUJ1ZmZlci0+Y3JlYXRlSGFuZGxlKGhhbmRsZSwgU2hhcmVkTWVtb3J5OjpQcm90ZWN0aW9u OjpSZWFkT25seSkpCisgICAgICAgIHJldHVybiBjb21wbGV0aW9uSGFuZGxlcih7IH0sIDApOwog ICAgIGNvbXBsZXRpb25IYW5kbGVyKFdURk1vdmUoaGFuZGxlKSwgc2l6ZSk7CiB9CiAKQEAgLTM4 Nyw3ICszODgsOCBAQCB2b2lkIFdlYlBhc3RlYm9hcmRQcm94eTo6cmVhZEJ1ZmZlckZyb21QYXN0 ZWJvYXJkKElQQzo6Q29ubmVjdGlvbiYgY29ubmVjdGlvbiwgcwogICAgICAgICByZXR1cm4gY29t cGxldGlvbkhhbmRsZXIoeyB9LCAwKTsKICAgICBtZW1jcHkoc2hhcmVkTWVtb3J5QnVmZmVyLT5k YXRhKCksIGJ1ZmZlci0+ZGF0YSgpLCBzaXplKTsKICAgICBTaGFyZWRNZW1vcnk6OkhhbmRsZSBo YW5kbGU7Ci0gICAgc2hhcmVkTWVtb3J5QnVmZmVyLT5jcmVhdGVIYW5kbGUoaGFuZGxlLCBTaGFy ZWRNZW1vcnk6OlByb3RlY3Rpb246OlJlYWRPbmx5KTsKKyAgICBpZiAoIXNoYXJlZE1lbW9yeUJ1 ZmZlci0+Y3JlYXRlSGFuZGxlKGhhbmRsZSwgU2hhcmVkTWVtb3J5OjpQcm90ZWN0aW9uOjpSZWFk T25seSkpCisgICAgICAgIHJldHVybiBjb21wbGV0aW9uSGFuZGxlcih7IH0sIDApOwogICAgIGNv bXBsZXRpb25IYW5kbGVyKFdURk1vdmUoaGFuZGxlKSwgc2l6ZSk7CiB9CiAK 407698 2020-09-01 11:05:44 -0700 2020-09-01 15:56:24 -0700 Patch bug-211002-20200901110543.patch text/plain 2434 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmMDMxZmY2MjcxZjVlNTJi MzhmMWFkZTFkYTBlNWU1Mjc2YWFlNjQuLjRhZTEzMDhlN2IyNmY3YWRmMjg5ZjJiMmNhYjY3MjA3 MDg2NDYzOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDktMDEgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViUGFzdGVib2Fy ZFByb3h5OjpnZXRQYXN0ZWJvYXJkU3RyaW5nc0ZvclR5cGUoKSBhbmQgV2ViUGFzdGVib2FyZFBy b3h5OjpyZWFkVVJMRnJvbVBhc3RlYm9hcmQoKSBzaG91bGQgY2hlY2sgcmV0dXJuIHZhbHVlIG9m IFNoYXJlZE1lbW9yeTo6Y3JlYXRlSGFuZGxlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTAwMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAx MDM5NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQ29jb2EvV2ViUGFzdGVib2FyZFByb3h5Q29jb2EubW06CisgICAgICAgIChX ZWJLaXQ6OldlYlBhc3RlYm9hcmRQcm94eTo6Z2V0UGFzdGVib2FyZEJ1ZmZlckZvclR5cGUpOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYXN0ZWJvYXJkUHJveHk6OnJlYWRCdWZmZXJGcm9tUGFzdGVi b2FyZCk6CisgICAgICAgIENoZWNrIHJlc3VsdCBvZiBTaGFyZWRNZW1vcnk6OmNyZWF0ZUhhbmRs ZSgpIGFuZCByZXR1cm4gZWFybHkKKyAgICAgICAgb24gZmFpbHVyZS4KKwogMjAyMC0wOC0zMSAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBVcHN0cmVh bSBzdXBwb3J0IGZvciBpbWFnZSBwaWNrZXIgY29uZmlybWF0aW9uIGFuZCBkb3duc2NhbGluZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFzdGVib2FyZFBy b3h5Q29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQYXN0ZWJvYXJk UHJveHlDb2NvYS5tbQppbmRleCAwMDFlMTU1OWEwMWZmYzk0NWEzNWRjNzBhMjM1M2NlYThjODg0 MzQwLi41Y2MwNjlkZmNjY2ZkZjBkZTA4ZTkxMWJmY2M4Yzg5MDIwNzFkZjljIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQYXN0ZWJvYXJkUHJveHlDb2NvYS5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQYXN0ZWJvYXJkUHJveHlD b2NvYS5tbQpAQCAtMjEzLDcgKzIxMyw4IEBAIHZvaWQgV2ViUGFzdGVib2FyZFByb3h5OjpnZXRQ YXN0ZWJvYXJkQnVmZmVyRm9yVHlwZShJUEM6OkNvbm5lY3Rpb24mIGNvbm5lY3Rpb24sCiAgICAg ICAgIHJldHVybiBjb21wbGV0aW9uSGFuZGxlcih7IH0pOwogICAgIG1lbWNweShzaGFyZWRNZW1v cnlCdWZmZXItPmRhdGEoKSwgYnVmZmVyLT5kYXRhKCksIHNpemUpOwogICAgIFNoYXJlZE1lbW9y eTo6SGFuZGxlIGhhbmRsZTsKLSAgICBzaGFyZWRNZW1vcnlCdWZmZXItPmNyZWF0ZUhhbmRsZSho YW5kbGUsIFNoYXJlZE1lbW9yeTo6UHJvdGVjdGlvbjo6UmVhZE9ubHkpOworICAgIGlmICghc2hh cmVkTWVtb3J5QnVmZmVyLT5jcmVhdGVIYW5kbGUoaGFuZGxlLCBTaGFyZWRNZW1vcnk6OlByb3Rl Y3Rpb246OlJlYWRPbmx5KSkKKyAgICAgICAgcmV0dXJuIGNvbXBsZXRpb25IYW5kbGVyKHsgfSk7 CiAgICAgY29tcGxldGlvbkhhbmRsZXIoU2hhcmVkTWVtb3J5OjpJUENIYW5kbGUgeyBXVEZNb3Zl KGhhbmRsZSksIHNpemUgfSk7CiB9CiAKQEAgLTQzMCw3ICs0MzEsOCBAQCB2b2lkIFdlYlBhc3Rl Ym9hcmRQcm94eTo6cmVhZEJ1ZmZlckZyb21QYXN0ZWJvYXJkKElQQzo6Q29ubmVjdGlvbiYgY29u bmVjdGlvbiwgcwogICAgICAgICByZXR1cm4gY29tcGxldGlvbkhhbmRsZXIoeyB9KTsKICAgICBt ZW1jcHkoc2hhcmVkTWVtb3J5QnVmZmVyLT5kYXRhKCksIGJ1ZmZlci0+ZGF0YSgpLCBzaXplKTsK ICAgICBTaGFyZWRNZW1vcnk6OkhhbmRsZSBoYW5kbGU7Ci0gICAgc2hhcmVkTWVtb3J5QnVmZmVy LT5jcmVhdGVIYW5kbGUoaGFuZGxlLCBTaGFyZWRNZW1vcnk6OlByb3RlY3Rpb246OlJlYWRPbmx5 KTsKKyAgICBpZiAoIXNoYXJlZE1lbW9yeUJ1ZmZlci0+Y3JlYXRlSGFuZGxlKGhhbmRsZSwgU2hh cmVkTWVtb3J5OjpQcm90ZWN0aW9uOjpSZWFkT25seSkpCisgICAgICAgIHJldHVybiBjb21wbGV0 aW9uSGFuZGxlcih7IH0pOwogICAgIGNvbXBsZXRpb25IYW5kbGVyKFNoYXJlZE1lbW9yeTo6SVBD SGFuZGxlIHsgV1RGTW92ZShoYW5kbGUpLCBzaXplIH0pOwogfQogCg==