211000 2020-04-24 15:29:34 -0700 IPC::Decoder::isInvalid() should be renamed to isValid() 2020-04-28 15:50:15 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210949 https://bugs.webkit.org/show_bug.cgi?id=211006 https://bugs.webkit.org/show_bug.cgi?id=203880 https://bugs.webkit.org/show_bug.cgi?id=211152 InRadar P2 Normal --- 1 ddkilzer ddkilzer darin ggaren useafterfree webkit-bug-importer oldest_to_newest 1645423 0 ddkilzer 2020-04-24 15:29:34 -0700 IPC::Decoder::isInvalid() should be renamed to isValid(). Negative logic is more difficult to reason about. 1645429 1 397519 ddkilzer 2020-04-24 15:32:59 -0700 Created attachment 397519 Patch v1 1645432 2 397519 ddkilzer 2020-04-24 15:39:27 -0700 Comment on attachment 397519 Patch v1 Apparently there is usage of isInvalid() in assert statements! 1645486 3 397529 ddkilzer 2020-04-24 17:23:44 -0700 Created attachment 397529 Patch v2 1645494 4 397529 darin 2020-04-24 17:41:40 -0700 Comment on attachment 397529 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=397529&action=review > Source/WebKit/ChangeLog:3 > + IPC::Decoder::isInvalid() should be renamed to isValid() You don’t say why > Source/WebKit/Platform/IPC/Decoder.h:79 > - bool isInvalid() const > + bool isValid() const > { > // (m_bufferPos == m_bufferEnd) is a valid state for decoding if the last parameter > // is a variable length byte array and its size == 0. > - return m_bufferPos < m_buffer || m_bufferPos > m_bufferEnd; > + return m_bufferPos >= m_buffer && m_bufferPos <= m_bufferEnd; > } This is a very peculiar function. Why isn’t it just a null check? If we run off the end of the buffer, the damage has been done. Returning false from isValid doesn’t seem to do much good. 1645507 5 397529 ddkilzer 2020-04-24 18:16:59 -0700 Comment on attachment 397529 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=397529&action=review >> Source/WebKit/ChangeLog:3 >> + IPC::Decoder::isInvalid() should be renamed to isValid() > > You don’t say why I'll add this to the ChangeLog (see Comment #0): Negative logic is more difficult to reason about. >> Source/WebKit/Platform/IPC/Decoder.h:79 >> } > > This is a very peculiar function. Why isn’t it just a null check? If we run off the end of the buffer, the damage has been done. Returning false from isValid doesn’t seem to do much good. Tracking this issue in Bug 211006. 1645509 6 397533 ddkilzer 2020-04-24 18:25:04 -0700 Created attachment 397533 Patch for landing 1645605 7 ews-feeder 2020-04-25 08:46:52 -0700 Committed r260704: <https://trac.webkit.org/changeset/260704> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397533. 1645606 8 webkit-bug-importer 2020-04-25 08:47:12 -0700 <rdar://problem/62371804> 397519 2020-04-24 15:32:59 -0700 2020-04-24 15:39:49 -0700 Patch v1 bug-211000-20200424153502.patch text/plain 6008 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIwMTBjOTA3MjI1MWQxOWFj NGU2NDhmYWYyNTU1NzQ2YWE3NDAxMDAuLjc5ODM4MGQxYWFiNzdjZTdkODJmNDA4ZjliZDQxMWU1 ODJlZmY3NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDQtMjQgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBJUEM6OkRlY29kZXI6OmlzSW52 YWxpZCgpIHNob3VsZCBiZSByZW5hbWVkIHRvIGlzVmFsaWQoKQorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMjExMDAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoSVBD OjpDb25uZWN0aW9uOjpkaXNwYXRjaE1lc3NhZ2UpOgorICAgICAgICAqIFBsYXRmb3JtL0lQQy9D b25uZWN0aW9uLmg6CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OnNlbmRXaXRoQXN5bmNSZXBs eSk6CisgICAgICAgICogUGxhdGZvcm0vSVBDL0RlY29kZXIuY3BwOgorICAgICAgICAoSVBDOjpE ZWNvZGVyOjpjcmVhdGUpOgorICAgICAgICAqIFBsYXRmb3JtL0lQQy9EZWNvZGVyLmg6CisgICAg ICAgIChJUEM6OkRlY29kZXI6OmlzVmFsaWQgY29uc3QpOiBSZW5hbWUgZnJvbSBpc0ludmFsaWQo KQorICAgICAgICBhbmQgaW52ZXJ0IGxvZ2ljLgorICAgICAgICAoSVBDOjpEZWNvZGVyOjppc0lu dmFsaWQgY29uc3QpOiBSZW5hbWUgdG8gaXNWYWxpZCgpLgorICAgICAgICAqIFBsYXRmb3JtL0lQ Qy9NZXNzYWdlU2VuZGVyLmg6CisgICAgICAgICogVUlQcm9jZXNzL0F1eGlsaWFyeVByb2Nlc3NQ cm94eS5oOgorICAgICAgICAoV2ViS2l0OjpBdXhpbGlhcnlQcm9jZXNzUHJveHk6OnNlbmRXaXRo QXN5bmNSZXBseSk6CisKIDIwMjAtMDQtMjQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KIAogICAgICAgICBVc2UgQ29jb2FJbWFnZSBwbGF0Zm9ybSBhYnN0cmFjdGlvbiBmb3Ig TlNJbWFnZS9VSUltYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9D b25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3Bw CmluZGV4IGQwYjY0MGQyMGJkM2MyMDEwZjFiZGY0MjQ1OGYzNDg0NDc2YzFlNTUuLjQyNWQ1NTg1 OTA1MjViMTNlYWZjMWE2MzlkMDkzZWMxN2U4MWVjODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0Nvbm5lY3Rpb24uY3BwCkBAIC0xMDc2LDcgKzEwNzYsNyBAQCB2b2lkIENvbm5lY3Rp b246OmRpc3BhdGNoTWVzc2FnZShzdGQ6OnVuaXF1ZV9wdHI8RGVjb2Rlcj4gbWVzc2FnZSkKICAg ICBlbHNlCiAgICAgICAgIGRpc3BhdGNoTWVzc2FnZSgqbWVzc2FnZSk7CiAKLSAgICBtX2RpZFJl Y2VpdmVJbnZhbGlkTWVzc2FnZSB8PSBtZXNzYWdlLT5pc0ludmFsaWQoKTsKKyAgICBtX2RpZFJl Y2VpdmVJbnZhbGlkTWVzc2FnZSB8PSAhbWVzc2FnZS0+aXNWYWxpZCgpOwogICAgIG1faW5EaXNw YXRjaE1lc3NhZ2VDb3VudC0tOwogCiAgICAgLy8gRklYTUU6IEZvciBzeW5jaHJvbm91cyBtZXNz YWdlcywgd2Ugc2hvdWxkIG5vdCBkZWNyZW1lbnQgdGhlIGNvdW50ZXIgdW50aWwgd2Ugc2VuZCBh IHJlc3BvbnNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVj dGlvbi5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oCmluZGV4IDA2 ZGUyNTVkM2I3ZGYxODYzM2MzY2FkZWJhYWMwMWQ3Nzc4ZDBiZjIuLjUzNWZmOTg3OWE2OGUyY2Nj MTNkMzc5YTA3MWU5MGRmNGIwYTQ4NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0Nvbm5lY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Db25u ZWN0aW9uLmgKQEAgLTQ4Myw3ICs0ODMsNyBAQCB2b2lkIENvbm5lY3Rpb246OnNlbmRXaXRoQXN5 bmNSZXBseShUJiYgbWVzc2FnZSwgQyYmIGNvbXBsZXRpb25IYW5kbGVyLCB1aW50NjRfdAogICAg IGVuY29kZXItPmVuY29kZShtZXNzYWdlLmFyZ3VtZW50cygpKTsKICAgICBzZW5kTWVzc2FnZShX VEZNb3ZlKGVuY29kZXIpLCBzZW5kT3B0aW9ucyk7CiAgICAgYWRkQXN5bmNSZXBseUhhbmRsZXIo KnRoaXMsIGxpc3RlbmVySUQsIFtjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlv bkhhbmRsZXIpXSAoRGVjb2RlciogZGVjb2RlcikgbXV0YWJsZSB7Ci0gICAgICAgIGlmIChkZWNv ZGVyICYmICFkZWNvZGVyLT5pc0ludmFsaWQoKSkKKyAgICAgICAgaWYgKGRlY29kZXIgJiYgZGVj b2Rlci0+aXNWYWxpZCgpKQogICAgICAgICAgICAgVDo6Y2FsbFJlcGx5KCpkZWNvZGVyLCBXVEZN b3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIFQ6OmNh bmNlbFJlcGx5KFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0RlY29kZXIuY3BwIGIvU291cmNlL1dlYktpdC9QbGF0Zm9y bS9JUEMvRGVjb2Rlci5jcHAKaW5kZXggNDQ5MDc3YjkzMjFkYmI5MWI4ZDk3NjRjMmRmOGM4M2E4 OTY3YTVmZC4uOThjODYyZTUyMGQzNmMzNzZlMTc4N2U4ZmFiOTAxNDNlYmE2YjJhOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5jcHAKKysrIGIvU291cmNl L1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5jcHAKQEAgLTQ4LDcgKzQ4LDcgQEAgc3RhdGlj IGNvbnN0IHVpbnQ4X3QqIGNvcHlCdWZmZXIoY29uc3QgdWludDhfdCogYnVmZmVyLCBzaXplX3Qg YnVmZmVyU2l6ZSkKIHN0ZDo6dW5pcXVlX3B0cjxEZWNvZGVyPiBEZWNvZGVyOjpjcmVhdGUoY29u c3QgdWludDhfdCogYnVmZmVyLCBzaXplX3QgYnVmZmVyU2l6ZSwgdm9pZCAoKmJ1ZmZlckRlYWxs b2NhdG9yKShjb25zdCB1aW50OF90Kiwgc2l6ZV90KSwgVmVjdG9yPEF0dGFjaG1lbnQ+JiYgYXR0 YWNobWVudHMpCiB7CiAgICAgYXV0byBkZWNvZGVyID0gbWFrZVVuaXF1ZTxEZWNvZGVyPihidWZm ZXIsIGJ1ZmZlclNpemUsIGJ1ZmZlckRlYWxsb2NhdG9yLCBXVEZNb3ZlKGF0dGFjaG1lbnRzKSk7 Ci0gICAgcmV0dXJuIGRlY29kZXItPmlzSW52YWxpZCgpID8gbnVsbHB0ciA6IFdURk1vdmUoZGVj b2Rlcik7CisgICAgcmV0dXJuIGRlY29kZXItPmlzVmFsaWQoKSA/IFdURk1vdmUoZGVjb2Rlcikg OiBudWxscHRyOwogfQogCiBEZWNvZGVyOjpEZWNvZGVyKGNvbnN0IHVpbnQ4X3QqIGJ1ZmZlciwg c2l6ZV90IGJ1ZmZlclNpemUsIHZvaWQgKCpidWZmZXJEZWFsbG9jYXRvcikoY29uc3QgdWludDhf dCosIHNpemVfdCksIFZlY3RvcjxBdHRhY2htZW50PiYmIGF0dGFjaG1lbnRzKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5oIGIvU291cmNlL1dlYktpdC9Q bGF0Zm9ybS9JUEMvRGVjb2Rlci5oCmluZGV4IDgyYzc4NWY4ZjM2MWJhNGJmM2Q5MjY5OWIyOTc4 Nzk2NmQxZWVkNmYuLjdhMmU5ZjU1NTQyY2IzMGM2NjM4ZTM0OTBiMTFjOTAyOGNmMTEwZjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0RlY29kZXIuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmgKQEAgLTcxLDExICs3MSwxMSBAQCBwdWJs aWM6CiAKICAgICBzaXplX3QgbGVuZ3RoKCkgY29uc3QgeyByZXR1cm4gbV9idWZmZXJFbmQgLSBt X2J1ZmZlcjsgfQogCi0gICAgYm9vbCBpc0ludmFsaWQoKSBjb25zdAorICAgIGJvb2wgaXNWYWxp ZCgpIGNvbnN0CiAgICAgewogICAgICAgICAvLyAobV9idWZmZXJQb3MgPT0gbV9idWZmZXJFbmQp IGlzIGEgdmFsaWQgc3RhdGUgZm9yIGRlY29kaW5nIGlmIHRoZSBsYXN0IHBhcmFtZXRlcgogICAg ICAgICAvLyBpcyBhIHZhcmlhYmxlIGxlbmd0aCBieXRlIGFycmF5IGFuZCBpdHMgc2l6ZSA9PSAw LgotICAgICAgICByZXR1cm4gbV9idWZmZXJQb3MgPCBtX2J1ZmZlciB8fCBtX2J1ZmZlclBvcyA+ IG1fYnVmZmVyRW5kOworICAgICAgICByZXR1cm4gbV9idWZmZXJQb3MgPj0gbV9idWZmZXIgJiYg bV9idWZmZXJQb3MgPD0gbV9idWZmZXJFbmQ7CiAgICAgfQogICAgIHZvaWQgbWFya0ludmFsaWQo KSB7IG1fYnVmZmVyUG9zID0gbnVsbHB0cjsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtL0lQQy9NZXNzYWdlU2VuZGVyLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQ Qy9NZXNzYWdlU2VuZGVyLmgKaW5kZXggMzIxOWM3ZGRhNWMxZTRhZDAyNDA4MDNmNDQ1M2YwZjM4 MjgxN2QxZi4uNjY3MWU2M2M0NzAzNmM5YzVhNGUyZmUxYzA4YTk2MDQyODEyMzY1ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvTWVzc2FnZVNlbmRlci5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL01lc3NhZ2VTZW5kZXIuaApAQCAtOTMsNyArOTMsNyBA QCBwdWJsaWM6CiAgICAgICAgIGVuY29kZXItPmVuY29kZShsaXN0ZW5lcklEKTsKICAgICAgICAg ZW5jb2Rlci0+ZW5jb2RlKG1lc3NhZ2UuYXJndW1lbnRzKCkpOwogICAgICAgICBzZW5kTWVzc2Fn ZShXVEZNb3ZlKGVuY29kZXIpLCBzZW5kT3B0aW9ucywge3sgW2NvbXBsZXRpb25IYW5kbGVyID0g V1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildIChJUEM6OkRlY29kZXIqIGRlY29kZXIpIG11dGFi bGUgewotICAgICAgICAgICAgaWYgKGRlY29kZXIgJiYgIWRlY29kZXItPmlzSW52YWxpZCgpKQor ICAgICAgICAgICAgaWYgKGRlY29kZXIgJiYgZGVjb2Rlci0+aXNWYWxpZCgpKQogICAgICAgICAg ICAgICAgIFQ6OmNhbGxSZXBseSgqZGVjb2RlciwgV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikp OwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIFQ6OmNhbmNlbFJlcGx5KFdURk1v dmUoY29tcGxldGlvbkhhbmRsZXIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0F1eGlsaWFyeVByb2Nlc3NQcm94eS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV4 aWxpYXJ5UHJvY2Vzc1Byb3h5LmgKaW5kZXggMTJhOWM0ODExODM4YmZhNzQ0YjFhN2UyNTMxOTUx YjUzNTY4NTczNC4uN2EyNjhjNGJiNzlkNWFjM2VlYTQ1ZmE5NjU2NjgyY2QzZTU5ZmIzMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5LmgK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5LmgKQEAg LTE3OSw3ICsxNzksNyBAQCB2b2lkIEF1eGlsaWFyeVByb2Nlc3NQcm94eTo6c2VuZFdpdGhBc3lu Y1JlcGx5KFQmJiBtZXNzYWdlLCBDJiYgY29tcGxldGlvbkhhbmRsZQogICAgIGVuY29kZXItPmVu Y29kZShsaXN0ZW5lcklEKTsKICAgICBlbmNvZGVyLT5lbmNvZGUobWVzc2FnZS5hcmd1bWVudHMo KSk7CiAgICAgc2VuZE1lc3NhZ2UoV1RGTW92ZShlbmNvZGVyKSwgc2VuZE9wdGlvbnMsIHt7IFtj b21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoSVBDOjpEZWNv ZGVyKiBkZWNvZGVyKSBtdXRhYmxlIHsKLSAgICAgICAgaWYgKGRlY29kZXIgJiYgIWRlY29kZXIt PmlzSW52YWxpZCgpKQorICAgICAgICBpZiAoZGVjb2RlciAmJiBkZWNvZGVyLT5pc1ZhbGlkKCkp CiAgICAgICAgICAgICBUOjpjYWxsUmVwbHkoKmRlY29kZXIsIFdURk1vdmUoY29tcGxldGlvbkhh bmRsZXIpKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgVDo6Y2FuY2VsUmVwbHkoV1RGTW92 ZShjb21wbGV0aW9uSGFuZGxlcikpOwo= 397529 2020-04-24 17:23:44 -0700 2020-04-25 08:49:07 -0700 Patch v2 bug-211000-20200424172548.patch text/plain 7410 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZhMjc1NTBiYWZmNzhkM2Mw MWQ1MjVhY2Y5NTUzZjkyZDA0MWU4OWQuLmVlZGQ3NjI0ZTFiYjE2NWM3ZjdjMzYyMWNkYTA4ODdh YzQ5OGYyYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjAtMDQtMjQgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBJUEM6OkRlY29kZXI6OmlzSW52 YWxpZCgpIHNob3VsZCBiZSByZW5hbWVkIHRvIGlzVmFsaWQoKQorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMjExMDAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoSVBD OjpDb25uZWN0aW9uOjpkaXNwYXRjaE1lc3NhZ2UpOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9u OjpkaXNwYXRjaFdvcmtRdWV1ZU1lc3NhZ2VSZWNlaXZlck1lc3NhZ2UpOgorICAgICAgICAoSVBD OjpDb25uZWN0aW9uOjpkaXNwYXRjaFRocmVhZE1lc3NhZ2VSZWNlaXZlck1lc3NhZ2UpOgorICAg ICAgICAoSVBDOjpDb25uZWN0aW9uOjpkaXNwYXRjaFN5bmNNZXNzYWdlKToKKyAgICAgICAgKiBQ bGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpzZW5k V2l0aEFzeW5jUmVwbHkpOgorICAgICAgICAqIFBsYXRmb3JtL0lQQy9EZWNvZGVyLmNwcDoKKyAg ICAgICAgKElQQzo6RGVjb2Rlcjo6Y3JlYXRlKToKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvRGVj b2Rlci5oOgorICAgICAgICAoSVBDOjpEZWNvZGVyOjppc1ZhbGlkIGNvbnN0KTogUmVuYW1lIGZy b20gaXNJbnZhbGlkKCkKKyAgICAgICAgYW5kIGludmVydCBsb2dpYy4KKyAgICAgICAgKElQQzo6 RGVjb2Rlcjo6aXNJbnZhbGlkIGNvbnN0KTogUmVuYW1lIHRvIGlzVmFsaWQoKS4KKyAgICAgICAg KiBQbGF0Zm9ybS9JUEMvTWVzc2FnZVNlbmRlci5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BdXhp bGlhcnlQcm9jZXNzUHJveHkuaDoKKyAgICAgICAgKFdlYktpdDo6QXV4aWxpYXJ5UHJvY2Vzc1By b3h5OjpzZW5kV2l0aEFzeW5jUmVwbHkpOgorICAgICAgICAtIENoYW5nZSBEZWNvZGVyOjppc0lu dmFsaWQoKSB0byBEZWNvZGVyOjppc1ZhbGlkKCkgYW5kIHJldmVyc2UKKyAgICAgICAgICBCb29s ZWFuIGxvZ2ljLgorCiAyMDIwLTA0LTI0ICBDaHJpc3RvcGhlciBSZWlkICA8Y2hyaXMucmVpZEBz b255LmNvbT4KIAogICAgICAgICBbV2luXSBCdW5kbGUgSW5zcGVjdG9yIFJlc291cmNlcyBpbiBS ZWxlYXNlIGJ1aWxkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29u bmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcApp bmRleCBkMGI2NDBkMjBiZDNjMjAxMGYxYmRmNDI0NThmMzQ4NDQ3NmMxZTU1Li44NTQ3MDcxYjRk ZTBkYTk3YjE4YmY5ZWNlMTlkZWYwYTMxODA2ODlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3Jt L0lQQy9Db25uZWN0aW9uLmNwcApAQCAtMzU1LDcgKzM1NSw3IEBAIHZvaWQgQ29ubmVjdGlvbjo6 ZGlzcGF0Y2hXb3JrUXVldWVNZXNzYWdlUmVjZWl2ZXJNZXNzYWdlKFdvcmtRdWV1ZU1lc3NhZ2VS ZWNlaXZlCiAgICAgd29ya1F1ZXVlTWVzc2FnZVJlY2VpdmVyLmRpZFJlY2VpdmVTeW5jTWVzc2Fn ZSgqdGhpcywgZGVjb2RlciwgcmVwbHlFbmNvZGVyKTsKIAogICAgIC8vIEZJWE1FOiBJZiB0aGUg bWVzc2FnZSB3YXMgaW52YWxpZCwgd2Ugc2hvdWxkIHNlbmQgYmFjayBhIFN5bmNNZXNzYWdlRXJy b3IuCi0gICAgQVNTRVJUKCFkZWNvZGVyLmlzSW52YWxpZCgpKTsKKyAgICBBU1NFUlQoZGVjb2Rl ci5pc1ZhbGlkKCkpOwogCiAgICAgaWYgKHJlcGx5RW5jb2RlcikKICAgICAgICAgc2VuZFN5bmNS ZXBseShXVEZNb3ZlKHJlcGx5RW5jb2RlcikpOwpAQCAtMzk5LDcgKzM5OSw3IEBAIHZvaWQgQ29u bmVjdGlvbjo6ZGlzcGF0Y2hUaHJlYWRNZXNzYWdlUmVjZWl2ZXJNZXNzYWdlKFRocmVhZE1lc3Nh Z2VSZWNlaXZlciYgdGhyCiAgICAgdGhyZWFkTWVzc2FnZVJlY2VpdmVyLmRpZFJlY2VpdmVTeW5j TWVzc2FnZSgqdGhpcywgZGVjb2RlciwgcmVwbHlFbmNvZGVyKTsKIAogICAgIC8vIEZJWE1FOiBJ ZiB0aGUgbWVzc2FnZSB3YXMgaW52YWxpZCwgd2Ugc2hvdWxkIHNlbmQgYmFjayBhIFN5bmNNZXNz YWdlRXJyb3IuCi0gICAgQVNTRVJUKCFkZWNvZGVyLmlzSW52YWxpZCgpKTsKKyAgICBBU1NFUlQo ZGVjb2Rlci5pc1ZhbGlkKCkpOwogCiAgICAgaWYgKHJlcGx5RW5jb2RlcikKICAgICAgICAgc2Vu ZFN5bmNSZXBseShXVEZNb3ZlKHJlcGx5RW5jb2RlcikpOwpAQCAtOTMwLDcgKzkzMCw3IEBAIHZv aWQgQ29ubmVjdGlvbjo6ZGlzcGF0Y2hTeW5jTWVzc2FnZShEZWNvZGVyJiBkZWNvZGVyKQogICAg IH0KIAogICAgIC8vIEZJWE1FOiBJZiB0aGUgbWVzc2FnZSB3YXMgaW52YWxpZCwgd2Ugc2hvdWxk IHNlbmQgYmFjayBhIFN5bmNNZXNzYWdlRXJyb3IuCi0gICAgQVNTRVJUKCFkZWNvZGVyLmlzSW52 YWxpZCgpKTsKKyAgICBBU1NFUlQoZGVjb2Rlci5pc1ZhbGlkKCkpOwogCiAgICAgaWYgKHJlcGx5 RW5jb2RlcikKICAgICAgICAgc2VuZFN5bmNSZXBseShXVEZNb3ZlKHJlcGx5RW5jb2RlcikpOwpA QCAtMTA3Niw3ICsxMDc2LDcgQEAgdm9pZCBDb25uZWN0aW9uOjpkaXNwYXRjaE1lc3NhZ2Uoc3Rk Ojp1bmlxdWVfcHRyPERlY29kZXI+IG1lc3NhZ2UpCiAgICAgZWxzZQogICAgICAgICBkaXNwYXRj aE1lc3NhZ2UoKm1lc3NhZ2UpOwogCi0gICAgbV9kaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2UgfD0g bWVzc2FnZS0+aXNJbnZhbGlkKCk7CisgICAgbV9kaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2UgfD0g IW1lc3NhZ2UtPmlzVmFsaWQoKTsKICAgICBtX2luRGlzcGF0Y2hNZXNzYWdlQ291bnQtLTsKIAog ICAgIC8vIEZJWE1FOiBGb3Igc3luY2hyb25vdXMgbWVzc2FnZXMsIHdlIHNob3VsZCBub3QgZGVj cmVtZW50IHRoZSBjb3VudGVyIHVudGlsIHdlIHNlbmQgYSByZXNwb25zZS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uaAppbmRleCAwNmRlMjU1ZDNiN2RmMTg2MzNjM2NhZGVi YWFjMDFkNzc3OGQwYmYyLi41MzVmZjk4NzlhNjhlMmNjYzEzZDM3OWEwNzFlOTBkZjRiMGE0ODRm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmgKKysr IGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oCkBAIC00ODMsNyArNDgz LDcgQEAgdm9pZCBDb25uZWN0aW9uOjpzZW5kV2l0aEFzeW5jUmVwbHkoVCYmIG1lc3NhZ2UsIEMm JiBjb21wbGV0aW9uSGFuZGxlciwgdWludDY0X3QKICAgICBlbmNvZGVyLT5lbmNvZGUobWVzc2Fn ZS5hcmd1bWVudHMoKSk7CiAgICAgc2VuZE1lc3NhZ2UoV1RGTW92ZShlbmNvZGVyKSwgc2VuZE9w dGlvbnMpOwogICAgIGFkZEFzeW5jUmVwbHlIYW5kbGVyKCp0aGlzLCBsaXN0ZW5lcklELCBbY29t cGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0gKERlY29kZXIqIGRl Y29kZXIpIG11dGFibGUgewotICAgICAgICBpZiAoZGVjb2RlciAmJiAhZGVjb2Rlci0+aXNJbnZh bGlkKCkpCisgICAgICAgIGlmIChkZWNvZGVyICYmIGRlY29kZXItPmlzVmFsaWQoKSkKICAgICAg ICAgICAgIFQ6OmNhbGxSZXBseSgqZGVjb2RlciwgV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikp OwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBUOjpjYW5jZWxSZXBseShXVEZNb3ZlKGNvbXBs ZXRpb25IYW5kbGVyKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9E ZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0RlY29kZXIuY3BwCmluZGV4 IDQ0OTA3N2I5MzIxZGJiOTFiOGQ5NzY0YzJkZjhjODNhODk2N2E1ZmQuLjk4Yzg2MmU1MjBkMzZj Mzc2ZTE3ODdlOGZhYjkwMTQzZWJhNmIyYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm0vSVBDL0RlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Rl Y29kZXIuY3BwCkBAIC00OCw3ICs0OCw3IEBAIHN0YXRpYyBjb25zdCB1aW50OF90KiBjb3B5QnVm ZmVyKGNvbnN0IHVpbnQ4X3QqIGJ1ZmZlciwgc2l6ZV90IGJ1ZmZlclNpemUpCiBzdGQ6OnVuaXF1 ZV9wdHI8RGVjb2Rlcj4gRGVjb2Rlcjo6Y3JlYXRlKGNvbnN0IHVpbnQ4X3QqIGJ1ZmZlciwgc2l6 ZV90IGJ1ZmZlclNpemUsIHZvaWQgKCpidWZmZXJEZWFsbG9jYXRvcikoY29uc3QgdWludDhfdCos IHNpemVfdCksIFZlY3RvcjxBdHRhY2htZW50PiYmIGF0dGFjaG1lbnRzKQogewogICAgIGF1dG8g ZGVjb2RlciA9IG1ha2VVbmlxdWU8RGVjb2Rlcj4oYnVmZmVyLCBidWZmZXJTaXplLCBidWZmZXJE ZWFsbG9jYXRvciwgV1RGTW92ZShhdHRhY2htZW50cykpOwotICAgIHJldHVybiBkZWNvZGVyLT5p c0ludmFsaWQoKSA/IG51bGxwdHIgOiBXVEZNb3ZlKGRlY29kZXIpOworICAgIHJldHVybiBkZWNv ZGVyLT5pc1ZhbGlkKCkgPyBXVEZNb3ZlKGRlY29kZXIpIDogbnVsbHB0cjsKIH0KIAogRGVjb2Rl cjo6RGVjb2Rlcihjb25zdCB1aW50OF90KiBidWZmZXIsIHNpemVfdCBidWZmZXJTaXplLCB2b2lk ICgqYnVmZmVyRGVhbGxvY2F0b3IpKGNvbnN0IHVpbnQ4X3QqLCBzaXplX3QpLCBWZWN0b3I8QXR0 YWNobWVudD4mJiBhdHRhY2htZW50cykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0RlY29kZXIuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0RlY29kZXIuaApp bmRleCA4MmM3ODVmOGYzNjFiYTRiZjNkOTI2OTliMjk3ODc5NjZkMWVlZDZmLi43YTJlOWY1NTU0 MmNiMzBjNjYzOGUzNDkwYjExYzkwMjhjZjExMGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMv RGVjb2Rlci5oCkBAIC03MSwxMSArNzEsMTEgQEAgcHVibGljOgogCiAgICAgc2l6ZV90IGxlbmd0 aCgpIGNvbnN0IHsgcmV0dXJuIG1fYnVmZmVyRW5kIC0gbV9idWZmZXI7IH0KIAotICAgIGJvb2wg aXNJbnZhbGlkKCkgY29uc3QKKyAgICBib29sIGlzVmFsaWQoKSBjb25zdAogICAgIHsKICAgICAg ICAgLy8gKG1fYnVmZmVyUG9zID09IG1fYnVmZmVyRW5kKSBpcyBhIHZhbGlkIHN0YXRlIGZvciBk ZWNvZGluZyBpZiB0aGUgbGFzdCBwYXJhbWV0ZXIKICAgICAgICAgLy8gaXMgYSB2YXJpYWJsZSBs ZW5ndGggYnl0ZSBhcnJheSBhbmQgaXRzIHNpemUgPT0gMC4KLSAgICAgICAgcmV0dXJuIG1fYnVm ZmVyUG9zIDwgbV9idWZmZXIgfHwgbV9idWZmZXJQb3MgPiBtX2J1ZmZlckVuZDsKKyAgICAgICAg cmV0dXJuIG1fYnVmZmVyUG9zID49IG1fYnVmZmVyICYmIG1fYnVmZmVyUG9zIDw9IG1fYnVmZmVy RW5kOwogICAgIH0KICAgICB2b2lkIG1hcmtJbnZhbGlkKCkgeyBtX2J1ZmZlclBvcyA9IG51bGxw dHI7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvTWVzc2FnZVNl bmRlci5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvTWVzc2FnZVNlbmRlci5oCmluZGV4 IDMyMTljN2RkYTVjMWU0YWQwMjQwODAzZjQ0NTNmMGYzODI4MTdkMWYuLjY2NzFlNjNjNDcwMzZj OWM1YTRlMmZlMWMwOGE5NjA0MjgxMjM2NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm0vSVBDL01lc3NhZ2VTZW5kZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQ Qy9NZXNzYWdlU2VuZGVyLmgKQEAgLTkzLDcgKzkzLDcgQEAgcHVibGljOgogICAgICAgICBlbmNv ZGVyLT5lbmNvZGUobGlzdGVuZXJJRCk7CiAgICAgICAgIGVuY29kZXItPmVuY29kZShtZXNzYWdl LmFyZ3VtZW50cygpKTsKICAgICAgICAgc2VuZE1lc3NhZ2UoV1RGTW92ZShlbmNvZGVyKSwgc2Vu ZE9wdGlvbnMsIHt7IFtjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRs ZXIpXSAoSVBDOjpEZWNvZGVyKiBkZWNvZGVyKSBtdXRhYmxlIHsKLSAgICAgICAgICAgIGlmIChk ZWNvZGVyICYmICFkZWNvZGVyLT5pc0ludmFsaWQoKSkKKyAgICAgICAgICAgIGlmIChkZWNvZGVy ICYmIGRlY29kZXItPmlzVmFsaWQoKSkKICAgICAgICAgICAgICAgICBUOjpjYWxsUmVwbHkoKmRl Y29kZXIsIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAgICAgICAgICAgIGVsc2UKICAg ICAgICAgICAgICAgICBUOjpjYW5jZWxSZXBseShXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXhpbGlhcnlQcm9jZXNzUHJv eHkuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1eGlsaWFyeVByb2Nlc3NQcm94eS5oCmlu ZGV4IDEyYTljNDgxMTgzOGJmYTc0NGIxYTdlMjUzMTk1MWI1MzU2ODU3MzQuLjdhMjY4YzRiYjc5 ZDVhYzNlZWE0NWZhOTY1NjY4MmNkM2U1OWZiMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0F1eGlsaWFyeVByb2Nlc3NQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0F1eGlsaWFyeVByb2Nlc3NQcm94eS5oCkBAIC0xNzksNyArMTc5LDcgQEAgdm9pZCBB dXhpbGlhcnlQcm9jZXNzUHJveHk6OnNlbmRXaXRoQXN5bmNSZXBseShUJiYgbWVzc2FnZSwgQyYm IGNvbXBsZXRpb25IYW5kbGUKICAgICBlbmNvZGVyLT5lbmNvZGUobGlzdGVuZXJJRCk7CiAgICAg ZW5jb2Rlci0+ZW5jb2RlKG1lc3NhZ2UuYXJndW1lbnRzKCkpOwogICAgIHNlbmRNZXNzYWdlKFdU Rk1vdmUoZW5jb2RlciksIHNlbmRPcHRpb25zLCB7eyBbY29tcGxldGlvbkhhbmRsZXIgPSBXVEZN b3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0gKElQQzo6RGVjb2RlciogZGVjb2RlcikgbXV0YWJsZSB7 Ci0gICAgICAgIGlmIChkZWNvZGVyICYmICFkZWNvZGVyLT5pc0ludmFsaWQoKSkKKyAgICAgICAg aWYgKGRlY29kZXIgJiYgZGVjb2Rlci0+aXNWYWxpZCgpKQogICAgICAgICAgICAgVDo6Y2FsbFJl cGx5KCpkZWNvZGVyLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiAgICAgICAgIGVsc2UK ICAgICAgICAgICAgIFQ6OmNhbmNlbFJlcGx5KFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsK 397533 2020-04-24 18:25:04 -0700 2020-04-25 08:46:52 -0700 Patch for landing bug-211000-20200424182709.patch text/plain 7501 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZhMjc1NTBiYWZmNzhkM2Mw MWQ1MjVhY2Y5NTUzZjkyZDA0MWU4OWQuLjc0M2U5MTIzM2NlMTBjM2JmOTMzNjVmZGVhYmM3OTMy MmMzNjViMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzIgQEAKKzIwMjAtMDQtMjQgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBJUEM6OkRlY29kZXI6OmlzSW52 YWxpZCgpIHNob3VsZCBiZSByZW5hbWVkIHRvIGlzVmFsaWQoKQorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMjExMDAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor CisgICAgICAgIE5lZ2F0aXZlIGxvZ2ljIGlzIG1vcmUgZGlmZmljdWx0IHRvIHJlYXNvbiBhYm91 dCB0aGFuIHBvc2l0aXZlCisgICAgICAgIGxvZ2ljLgorCisgICAgICAgICogUGxhdGZvcm0vSVBD L0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpkaXNwYXRjaE1lc3Nh Z2UpOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpkaXNwYXRjaFdvcmtRdWV1ZU1lc3NhZ2VS ZWNlaXZlck1lc3NhZ2UpOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpkaXNwYXRjaFRocmVh ZE1lc3NhZ2VSZWNlaXZlck1lc3NhZ2UpOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpkaXNw YXRjaFN5bmNNZXNzYWdlKToKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oOgor ICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpzZW5kV2l0aEFzeW5jUmVwbHkpOgorICAgICAgICAq IFBsYXRmb3JtL0lQQy9EZWNvZGVyLmNwcDoKKyAgICAgICAgKElQQzo6RGVjb2Rlcjo6Y3JlYXRl KToKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvRGVjb2Rlci5oOgorICAgICAgICAoSVBDOjpEZWNv ZGVyOjppc1ZhbGlkIGNvbnN0KTogUmVuYW1lIGZyb20gaXNJbnZhbGlkKCkKKyAgICAgICAgYW5k IGludmVydCBsb2dpYy4KKyAgICAgICAgKElQQzo6RGVjb2Rlcjo6aXNJbnZhbGlkIGNvbnN0KTog UmVuYW1lIHRvIGlzVmFsaWQoKS4KKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvTWVzc2FnZVNlbmRl ci5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BdXhpbGlhcnlQcm9jZXNzUHJveHkuaDoKKyAgICAg ICAgKFdlYktpdDo6QXV4aWxpYXJ5UHJvY2Vzc1Byb3h5OjpzZW5kV2l0aEFzeW5jUmVwbHkpOgor ICAgICAgICAtIENoYW5nZSBEZWNvZGVyOjppc0ludmFsaWQoKSB0byBEZWNvZGVyOjppc1ZhbGlk KCkgYW5kIHJldmVyc2UKKyAgICAgICAgICB0aGUgQm9vbGVhbiBsb2dpYy4KKwogMjAyMC0wNC0y NCAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5jb20+CiAKICAgICAgICAgW1dp bl0gQnVuZGxlIEluc3BlY3RvciBSZXNvdXJjZXMgaW4gUmVsZWFzZSBidWlsZHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKaW5kZXggZDBiNjQwZDIwYmQzYzIwMTBm MWJkZjQyNDU4ZjM0ODQ0NzZjMWU1NS4uODU0NzA3MWI0ZGUwZGE5N2IxOGJmOWVjZTE5ZGVmMGEz MTgwNjg5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlv bi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKQEAg LTM1NSw3ICszNTUsNyBAQCB2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNoV29ya1F1ZXVlTWVzc2Fn ZVJlY2VpdmVyTWVzc2FnZShXb3JrUXVldWVNZXNzYWdlUmVjZWl2ZQogICAgIHdvcmtRdWV1ZU1l c3NhZ2VSZWNlaXZlci5kaWRSZWNlaXZlU3luY01lc3NhZ2UoKnRoaXMsIGRlY29kZXIsIHJlcGx5 RW5jb2Rlcik7CiAKICAgICAvLyBGSVhNRTogSWYgdGhlIG1lc3NhZ2Ugd2FzIGludmFsaWQsIHdl IHNob3VsZCBzZW5kIGJhY2sgYSBTeW5jTWVzc2FnZUVycm9yLgotICAgIEFTU0VSVCghZGVjb2Rl ci5pc0ludmFsaWQoKSk7CisgICAgQVNTRVJUKGRlY29kZXIuaXNWYWxpZCgpKTsKIAogICAgIGlm IChyZXBseUVuY29kZXIpCiAgICAgICAgIHNlbmRTeW5jUmVwbHkoV1RGTW92ZShyZXBseUVuY29k ZXIpKTsKQEAgLTM5OSw3ICszOTksNyBAQCB2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNoVGhyZWFk TWVzc2FnZVJlY2VpdmVyTWVzc2FnZShUaHJlYWRNZXNzYWdlUmVjZWl2ZXImIHRocgogICAgIHRo cmVhZE1lc3NhZ2VSZWNlaXZlci5kaWRSZWNlaXZlU3luY01lc3NhZ2UoKnRoaXMsIGRlY29kZXIs IHJlcGx5RW5jb2Rlcik7CiAKICAgICAvLyBGSVhNRTogSWYgdGhlIG1lc3NhZ2Ugd2FzIGludmFs aWQsIHdlIHNob3VsZCBzZW5kIGJhY2sgYSBTeW5jTWVzc2FnZUVycm9yLgotICAgIEFTU0VSVCgh ZGVjb2Rlci5pc0ludmFsaWQoKSk7CisgICAgQVNTRVJUKGRlY29kZXIuaXNWYWxpZCgpKTsKIAog ICAgIGlmIChyZXBseUVuY29kZXIpCiAgICAgICAgIHNlbmRTeW5jUmVwbHkoV1RGTW92ZShyZXBs eUVuY29kZXIpKTsKQEAgLTkzMCw3ICs5MzAsNyBAQCB2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNo U3luY01lc3NhZ2UoRGVjb2RlciYgZGVjb2RlcikKICAgICB9CiAKICAgICAvLyBGSVhNRTogSWYg dGhlIG1lc3NhZ2Ugd2FzIGludmFsaWQsIHdlIHNob3VsZCBzZW5kIGJhY2sgYSBTeW5jTWVzc2Fn ZUVycm9yLgotICAgIEFTU0VSVCghZGVjb2Rlci5pc0ludmFsaWQoKSk7CisgICAgQVNTRVJUKGRl Y29kZXIuaXNWYWxpZCgpKTsKIAogICAgIGlmIChyZXBseUVuY29kZXIpCiAgICAgICAgIHNlbmRT eW5jUmVwbHkoV1RGTW92ZShyZXBseUVuY29kZXIpKTsKQEAgLTEwNzYsNyArMTA3Niw3IEBAIHZv aWQgQ29ubmVjdGlvbjo6ZGlzcGF0Y2hNZXNzYWdlKHN0ZDo6dW5pcXVlX3B0cjxEZWNvZGVyPiBt ZXNzYWdlKQogICAgIGVsc2UKICAgICAgICAgZGlzcGF0Y2hNZXNzYWdlKCptZXNzYWdlKTsKIAot ICAgIG1fZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlIHw9IG1lc3NhZ2UtPmlzSW52YWxpZCgpOwor ICAgIG1fZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlIHw9ICFtZXNzYWdlLT5pc1ZhbGlkKCk7CiAg ICAgbV9pbkRpc3BhdGNoTWVzc2FnZUNvdW50LS07CiAKICAgICAvLyBGSVhNRTogRm9yIHN5bmNo cm9ub3VzIG1lc3NhZ2VzLCB3ZSBzaG91bGQgbm90IGRlY3JlbWVudCB0aGUgY291bnRlciB1bnRp bCB3ZSBzZW5kIGEgcmVzcG9uc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3Jt L0lQQy9Db25uZWN0aW9uLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9u LmgKaW5kZXggMDZkZTI1NWQzYjdkZjE4NjMzYzNjYWRlYmFhYzAxZDc3NzhkMGJmMi4uNTM1ZmY5 ODc5YTY4ZTJjY2MxM2QzNzlhMDcxZTkwZGY0YjBhNDg0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL0Nvbm5lY3Rpb24uaApAQCAtNDgzLDcgKzQ4Myw3IEBAIHZvaWQgQ29ubmVjdGlvbjo6 c2VuZFdpdGhBc3luY1JlcGx5KFQmJiBtZXNzYWdlLCBDJiYgY29tcGxldGlvbkhhbmRsZXIsIHVp bnQ2NF90CiAgICAgZW5jb2Rlci0+ZW5jb2RlKG1lc3NhZ2UuYXJndW1lbnRzKCkpOwogICAgIHNl bmRNZXNzYWdlKFdURk1vdmUoZW5jb2RlciksIHNlbmRPcHRpb25zKTsKICAgICBhZGRBc3luY1Jl cGx5SGFuZGxlcigqdGhpcywgbGlzdGVuZXJJRCwgW2NvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92 ZShjb21wbGV0aW9uSGFuZGxlcildIChEZWNvZGVyKiBkZWNvZGVyKSBtdXRhYmxlIHsKLSAgICAg ICAgaWYgKGRlY29kZXIgJiYgIWRlY29kZXItPmlzSW52YWxpZCgpKQorICAgICAgICBpZiAoZGVj b2RlciAmJiBkZWNvZGVyLT5pc1ZhbGlkKCkpCiAgICAgICAgICAgICBUOjpjYWxsUmVwbHkoKmRl Y29kZXIsIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAgICAgICAgZWxzZQogICAgICAg ICAgICAgVDo6Y2FuY2VsUmVwbHkoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmNwcAppbmRleCA0NDkwNzdiOTMyMWRiYjkxYjhkOTc2 NGMyZGY4YzgzYTg5NjdhNWZkLi45OGM4NjJlNTIwZDM2YzM3NmUxNzg3ZThmYWI5MDE0M2ViYTZi MmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmNwcApAQCAtNDgsNyArNDgs NyBAQCBzdGF0aWMgY29uc3QgdWludDhfdCogY29weUJ1ZmZlcihjb25zdCB1aW50OF90KiBidWZm ZXIsIHNpemVfdCBidWZmZXJTaXplKQogc3RkOjp1bmlxdWVfcHRyPERlY29kZXI+IERlY29kZXI6 OmNyZWF0ZShjb25zdCB1aW50OF90KiBidWZmZXIsIHNpemVfdCBidWZmZXJTaXplLCB2b2lkICgq YnVmZmVyRGVhbGxvY2F0b3IpKGNvbnN0IHVpbnQ4X3QqLCBzaXplX3QpLCBWZWN0b3I8QXR0YWNo bWVudD4mJiBhdHRhY2htZW50cykKIHsKICAgICBhdXRvIGRlY29kZXIgPSBtYWtlVW5pcXVlPERl Y29kZXI+KGJ1ZmZlciwgYnVmZmVyU2l6ZSwgYnVmZmVyRGVhbGxvY2F0b3IsIFdURk1vdmUoYXR0 YWNobWVudHMpKTsKLSAgICByZXR1cm4gZGVjb2Rlci0+aXNJbnZhbGlkKCkgPyBudWxscHRyIDog V1RGTW92ZShkZWNvZGVyKTsKKyAgICByZXR1cm4gZGVjb2Rlci0+aXNWYWxpZCgpID8gV1RGTW92 ZShkZWNvZGVyKSA6IG51bGxwdHI7CiB9CiAKIERlY29kZXI6OkRlY29kZXIoY29uc3QgdWludDhf dCogYnVmZmVyLCBzaXplX3QgYnVmZmVyU2l6ZSwgdm9pZCAoKmJ1ZmZlckRlYWxsb2NhdG9yKShj b25zdCB1aW50OF90Kiwgc2l6ZV90KSwgVmVjdG9yPEF0dGFjaG1lbnQ+JiYgYXR0YWNobWVudHMp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmggYi9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmgKaW5kZXggODJjNzg1ZjhmMzYxYmE0YmYz ZDkyNjk5YjI5Nzg3OTY2ZDFlZWQ2Zi4uN2EyZTlmNTU1NDJjYjMwYzY2MzhlMzQ5MGIxMWM5MDI4 Y2YxMTBmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVjb2Rlci5o CisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0RlY29kZXIuaApAQCAtNzEsMTEgKzcx LDExIEBAIHB1YmxpYzoKIAogICAgIHNpemVfdCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX2J1 ZmZlckVuZCAtIG1fYnVmZmVyOyB9CiAKLSAgICBib29sIGlzSW52YWxpZCgpIGNvbnN0CisgICAg Ym9vbCBpc1ZhbGlkKCkgY29uc3QKICAgICB7CiAgICAgICAgIC8vIChtX2J1ZmZlclBvcyA9PSBt X2J1ZmZlckVuZCkgaXMgYSB2YWxpZCBzdGF0ZSBmb3IgZGVjb2RpbmcgaWYgdGhlIGxhc3QgcGFy YW1ldGVyCiAgICAgICAgIC8vIGlzIGEgdmFyaWFibGUgbGVuZ3RoIGJ5dGUgYXJyYXkgYW5kIGl0 cyBzaXplID09IDAuCi0gICAgICAgIHJldHVybiBtX2J1ZmZlclBvcyA8IG1fYnVmZmVyIHx8IG1f YnVmZmVyUG9zID4gbV9idWZmZXJFbmQ7CisgICAgICAgIHJldHVybiBtX2J1ZmZlclBvcyA+PSBt X2J1ZmZlciAmJiBtX2J1ZmZlclBvcyA8PSBtX2J1ZmZlckVuZDsKICAgICB9CiAgICAgdm9pZCBt YXJrSW52YWxpZCgpIHsgbV9idWZmZXJQb3MgPSBudWxscHRyOyB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL01lc3NhZ2VTZW5kZXIuaCBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vSVBDL01lc3NhZ2VTZW5kZXIuaAppbmRleCAzMjE5YzdkZGE1YzFlNGFkMDI0MDgw M2Y0NDUzZjBmMzgyODE3ZDFmLi42NjcxZTYzYzQ3MDM2YzljNWE0ZTJmZTFjMDhhOTYwNDI4MTIz NjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9NZXNzYWdlU2VuZGVy LmgKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvTWVzc2FnZVNlbmRlci5oCkBAIC05 Myw3ICs5Myw3IEBAIHB1YmxpYzoKICAgICAgICAgZW5jb2Rlci0+ZW5jb2RlKGxpc3RlbmVySUQp OwogICAgICAgICBlbmNvZGVyLT5lbmNvZGUobWVzc2FnZS5hcmd1bWVudHMoKSk7CiAgICAgICAg IHNlbmRNZXNzYWdlKFdURk1vdmUoZW5jb2RlciksIHNlbmRPcHRpb25zLCB7eyBbY29tcGxldGlv bkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0gKElQQzo6RGVjb2RlciogZGVj b2RlcikgbXV0YWJsZSB7Ci0gICAgICAgICAgICBpZiAoZGVjb2RlciAmJiAhZGVjb2Rlci0+aXNJ bnZhbGlkKCkpCisgICAgICAgICAgICBpZiAoZGVjb2RlciAmJiBkZWNvZGVyLT5pc1ZhbGlkKCkp CiAgICAgICAgICAgICAgICAgVDo6Y2FsbFJlcGx5KCpkZWNvZGVyLCBXVEZNb3ZlKGNvbXBsZXRp b25IYW5kbGVyKSk7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgVDo6Y2FuY2Vs UmVwbHkoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BdXhpbGlhcnlQcm9jZXNzUHJveHkuaAppbmRleCAxMmE5YzQ4MTE4MzhiZmE3NDRi MWE3ZTI1MzE5NTFiNTM1Njg1NzM0Li43YTI2OGM0YmI3OWQ1YWMzZWVhNDVmYTk2NTY2ODJjZDNl NTlmYjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXhpbGlhcnlQcm9j ZXNzUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXhpbGlhcnlQcm9jZXNz UHJveHkuaApAQCAtMTc5LDcgKzE3OSw3IEBAIHZvaWQgQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5Ojpz ZW5kV2l0aEFzeW5jUmVwbHkoVCYmIG1lc3NhZ2UsIEMmJiBjb21wbGV0aW9uSGFuZGxlCiAgICAg ZW5jb2Rlci0+ZW5jb2RlKGxpc3RlbmVySUQpOwogICAgIGVuY29kZXItPmVuY29kZShtZXNzYWdl LmFyZ3VtZW50cygpKTsKICAgICBzZW5kTWVzc2FnZShXVEZNb3ZlKGVuY29kZXIpLCBzZW5kT3B0 aW9ucywge3sgW2NvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcild IChJUEM6OkRlY29kZXIqIGRlY29kZXIpIG11dGFibGUgewotICAgICAgICBpZiAoZGVjb2RlciAm JiAhZGVjb2Rlci0+aXNJbnZhbGlkKCkpCisgICAgICAgIGlmIChkZWNvZGVyICYmIGRlY29kZXIt PmlzVmFsaWQoKSkKICAgICAgICAgICAgIFQ6OmNhbGxSZXBseSgqZGVjb2RlciwgV1RGTW92ZShj b21wbGV0aW9uSGFuZGxlcikpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBUOjpjYW5jZWxS ZXBseShXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7Cg==