210997 2020-04-24 15:19:07 -0700 REGRESSION(260485) Payment requests don't do anything 2020-04-24 16:32:09 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210702 InRadar P2 Normal --- 1 achristensen achristensen benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1645415 0 achristensen 2020-04-24 15:19:07 -0700 REGRESSION(260485) Payment requests don't do anything 1645416 1 397515 achristensen 2020-04-24 15:21:47 -0700 Created attachment 397515 Patch 1645417 2 achristensen 2020-04-24 15:21:50 -0700 <rdar://problem/62275343> 1645456 3 397515 darin 2020-04-24 16:04:29 -0700 Comment on attachment 397515 Patch I would have fixed this with a lambda at the call site rather than a makeNSArrayElement in URL.h. But this fix is OK too. 1645458 4 achristensen 2020-04-24 16:05:40 -0700 I think this will prevent future bugs. I'm also working to reduce use of then remove URL's operator String. 1645475 5 ews-feeder 2020-04-24 16:32:08 -0700 Committed r260679: <https://trac.webkit.org/changeset/260679> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397515. 397515 2020-04-24 15:21:47 -0700 2020-04-24 16:32:08 -0700 Patch bug-210997-20200424152146.patch text/plain 3714 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjA1NDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA0LTI0ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTigyNjA0ODUpIFBh eW1lbnQgcmVxdWVzdHMgZG9uJ3QgZG8gYW55dGhpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDk5NworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjIyNzUzNDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2Ugd2VyZSBnaXZpbmcgdGhlIFBLUGF5bWVudFJlcXVlc3QgYW4gTlNBcnJheTxOU1N0cmlu ZyAqPiBpbnN0ZWFkIG9mIE5TQXJyYXk8TlNVUkwgKj4uCisgICAgICAgIFRoaXMgd2FzIGEgcHJv YmxlbSB3aXRoIGFsbCB1c2VzIG9mIGNyZWF0ZU5TQXJyYXkgd2l0aCBWZWN0b3I8VVJMPi4KKyAg ICAgICAgTm93IGl0J3MgZml4ZWQgd2l0aCBhIHRlc3QuCisKKyAgICAgICAgKiB3dGYvVVJMLmg6 CisgICAgICAgICogd3RmL2NvY29hL1VSTENvY29hLm1tOgorICAgICAgICAoV1RGOjptYWtlTlNB cnJheUVsZW1lbnQpOgorICAgICAgICAoV1RGOjptYWtlVmVjdG9yRWxlbWVudCk6CisKIDIwMjAt MDQtMjIgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR1RLNF0gU2V2ZXJhbCBmaXhlcyB0byBHZGtFdmVudCBBUElzIGZvciBHVEs0CkluZGV4OiBT b3VyY2UvV1RGL3d0Zi9VUkwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9VUkwuaAko cmV2aXNpb24gMjYwNTQyKQorKysgU291cmNlL1dURi93dGYvVVJMLmgJKHdvcmtpbmcgY29weSkK QEAgLTI4Nyw2ICsyODcsMTMgQEAgV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBtaW1lVHlwZUZy b21EYQogLy8gRklYTUU6IFRoaXMgaXMgYSB3cm9uZyBjb25jZXB0IHRvIGV4cG9zZSwgZGlmZmVy ZW50IHBhcnRzIG9mIGEgVVJMIG5lZWQgZGlmZmVyZW50IGVzY2FwaW5nIHBlciB0aGUgVVJMIFN0 YW5kYXJkLgogV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBlbmNvZGVXaXRoVVJMRXNjYXBlU2Vx dWVuY2VzKGNvbnN0IFN0cmluZyYpOwogCisjaWZkZWYgX19PQkpDX18KKworV1RGX0VYUE9SVF9Q UklWQVRFIFJldGFpblB0cjxpZD4gbWFrZU5TQXJyYXlFbGVtZW50KGNvbnN0IFVSTCYpOworV1RG X0VYUE9SVF9QUklWQVRFIE9wdGlvbmFsPFVSTD4gbWFrZVZlY3RvckVsZW1lbnQoY29uc3QgVVJM KiwgaWQpOworCisjZW5kaWYKKwogLy8gSW5saW5lcy4KIAogaW5saW5lIGJvb2wgb3BlcmF0b3I9 PShjb25zdCBVUkwmIGEsIGNvbnN0IFVSTCYgYikKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL2NvY29h L1VSTENvY29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL2NvY29hL1VSTENvY29h Lm1tCShyZXZpc2lvbiAyNjA1NDIpCisrKyBTb3VyY2UvV1RGL3d0Zi9jb2NvYS9VUkxDb2NvYS5t bQkod29ya2luZyBjb3B5KQpAQCAtOTEsNCArOTEsMTYgQEAgYm9vbCBVUkw6Omhvc3RJc0lQQWRk cmVzcyhTdHJpbmdWaWV3IGhvcwogICAgIHJldHVybiBbaG9zdC5jcmVhdGVOU1N0cmluZ1dpdGhv dXRDb3B5aW5nKCkuZ2V0KCkgX3dlYl9sb29rc0xpa2VJUEFkZHJlc3NdOwogfQogCitSZXRhaW5Q dHI8aWQ+IG1ha2VOU0FycmF5RWxlbWVudChjb25zdCBVUkwmIHZlY3RvckVsZW1lbnQpCit7Cisg ICAgcmV0dXJuIGFkb3B0TlMoKF9fYnJpZGdlX3RyYW5zZmVyIGlkKXZlY3RvckVsZW1lbnQuY3Jl YXRlQ0ZVUkwoKS5sZWFrUmVmKCkpOworfQorCitPcHRpb25hbDxVUkw+IG1ha2VWZWN0b3JFbGVt ZW50KGNvbnN0IFVSTCosIGlkIGFycmF5RWxlbWVudCkKK3sKKyAgICBpZiAoIVthcnJheUVsZW1l bnQgaXNLaW5kT2ZDbGFzczpOU1VSTC5jbGFzc10pCisgICAgICAgIHJldHVybiBXVEY6Om51bGxv cHQ7CisgICAgcmV0dXJuIHsgeyBhcnJheUVsZW1lbnQgfSB9OworfQorCiB9CkluZGV4OiBUb29s cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjA2 NzQpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAyMC0wNC0yNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT04oMjYwNDg1KSBQYXltZW50IHJlcXVlc3RzIGRvbid0IGRvIGFu eXRoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTA5OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL2NvY29hL1VSTEV4dHJhcy5tbToKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIwLTA0LTI0ICBLYXRlIENoZW5leSAgPGthdGhlcmlu ZV9jaGVuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92aW5nIHdlYnNpdGUgZGF0YSBmb3Ig YSBkb21haW4gc2hvdWxkIGRlbGV0ZSBjb3JyZXNwb25kaW5nIElUUCBlbnRyeQpJbmRleDogVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvY29jb2EvVVJMRXh0cmFzLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL2NvY29hL1VSTEV4dHJhcy5tbQkocmV2 aXNpb24gMjYwNTQyKQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvY29jb2EvVVJM RXh0cmFzLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw5ICsyNCwxMSBAQAogICovCiAKICNpbXBv cnQgImNvbmZpZy5oIgorI2ltcG9ydCA8d3RmL1VSTC5oPgogCiAjaW1wb3J0IDx3dGYvVmVjdG9y Lmg+CiAjaW1wb3J0IDx3dGYvY29jb2EvTlNVUkxFeHRyYXMuaD4KKyNpbXBvcnQgPHd0Zi9jb2Nv YS9WZWN0b3JDb2NvYS5oPgogI2ltcG9ydCA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIG5hbWVz cGFjZSBUZXN0V2ViS2l0QVBJIHsKQEAgLTIxMiw1ICsyMTQsMTIgQEAgVEVTVChXVEZfVVJMRXh0 cmFzLCBVUkxFeHRyYXNfTmlsKQogICAgIEVYUEVDVF9UUlVFKHVybDIgPT0gbmlsKTsKIH0KIAor VEVTVChXVEZfVVJMRXh0cmFzLCBDcmVhdGVOU0FycmF5KQoreworICAgIFZlY3RvcjxVUkw+IHVy bHMgeyBVUkwoVVJMKCksICJodHRwczovL3dlYmtpdC5vcmcvIikgfTsKKyAgICBhdXRvIGFycmF5 ID0gY3JlYXRlTlNBcnJheSh1cmxzKTsKKyAgICBFWFBFQ1RfVFJVRShbYXJyYXkuZ2V0KClbMF0g aXNLaW5kT2ZDbGFzczpOU1VSTC5jbGFzc10pOworfQorCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2Vi S2l0QVBJCiAK