210991 2020-04-24 13:28:33 -0700 [iOS] Always run WKTR's WKWebViews at foreground priority 2020-04-25 17:49:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ap ggaren jlewis3 keith_miller ryanhaddad tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1645356 0 cdumez 2020-04-24 13:28:33 -0700 Always run WKTR's WKWebViews at foreground priority. This makes sure that they don't suspend and run at foreground priority on iOS, even if those views are not visible on screen. This is an issue to address flakiness on the bots. 1645357 1 397496 cdumez 2020-04-24 13:29:25 -0700 Created attachment 397496 Patch 1645364 2 397496 keith_miller 2020-04-24 13:36:48 -0700 Comment on attachment 397496 Patch r=me 1645424 3 ews-feeder 2020-04-24 15:29:47 -0700 Committed r260675: <https://trac.webkit.org/changeset/260675> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397496. 1645427 4 webkit-bug-importer 2020-04-24 15:30:24 -0700 <rdar://problem/62344052> 1645702 5 ap 2020-04-25 17:30:28 -0700 Now I'm curious if this reduced the flakiness, and how WKTR's view could be invisible in the first place. 1645717 6 cdumez 2020-04-25 17:49:13 -0700 (In reply to Alexey Proskuryakov from comment #5) > Now I'm curious if this reduced the flakiness, and how WKTR's view could be > invisible in the first place. Well, the plan is the monitor the known flaky tests on iOS and see. How can the views be not visible? I have a couple of theories: - we are using simulators, sometimes multiple ones to run tests in parallel. How do we know all simulators are visible? E.g can one simulator be on top of another? - some tests open new windows but on iOS we normally only display only 1 window at a time on screen. - we may have issues determining visibility accurately in the simulator. I will note that we disabled suspension for api tests on iOS about a year ago and it definitely addressed some of the flakiness that we were seeing. We did so by lying and saying that the views were visible at all times. In any case, I will monitor tests with this change and I plan to look into tests that seem to have become flaky after adopting running board assertion to identify why next week. 397496 2020-04-24 13:29:25 -0700 2020-04-24 15:29:48 -0700 Patch bug-210991-20200424132924.patch text/plain 1885 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDBjNDUzY2JmYTEwYjczZjAzMTNkYThjZjI0MmYxYzgx Yzg2NzRlNy4uMTcwNzFiY2ZiMzg1YzIyMTg5ODk4MzFkZGE1Y2ZmMThhZWUzM2M2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTA0LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgW2lPU10gQWx3YXlzIHJ1biBXS1RSJ3MgV0tXZWJWaWV3cyBhdCBmb3JlZ3JvdW5kIHByaW9y aXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA5 OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHdh eXMgcnVuIFdLVFIncyBXS1dlYlZpZXdzIGF0IGZvcmVncm91bmQgcHJpb3JpdHkuIFRoaXMgbWFr ZXMgc3VyZSB0aGF0IHRoZXkgZG9uJ3Qgc3VzcGVuZCBhbmQKKyAgICAgICAgcnVuIGF0IGZvcmVn cm91bmQgcHJpb3JpdHkgb24gaU9TLCBldmVuIGlmIHRob3NlIHZpZXdzIGFyZSBub3QgdmlzaWJs ZSBvbiBzY3JlZW4uCisgICAgICAgIFRoaXMgaXMgYW4gaXNzdWUgdG8gYWRkcmVzcyBmbGFraW5l c3Mgb24gdGhlIGJvdHMuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rlc3RD b250cm9sbGVyQ29jb2EubW06CisgICAgICAgIChXVFI6OmluaXRpYWxpemVXZWJWaWV3Q29uZmln dXJhdGlvbik6CisKIDIwMjAtMDQtMjQgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gV2hpdGUtbGlzdCBtb3JlIEdTdHJlYW1lciBl bnZpcm9ubWVudCB2YXJpYWJsZXMgaW4gd2Via2l0cHkKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvY29jb2EvVGVzdENvbnRyb2xsZXJDb2NvYS5tbSBiL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvY29jb2EvVGVzdENvbnRyb2xsZXJDb2NvYS5tbQppbmRleCAyNTYyZTZkN2NhZGI2 NGViOGY0NTNiODNiMmU2MDY2MTRkOWVjNjZiLi4xY2UzZGQzOTdmODViZTBkMmI0MDkyNTczZWJj YTJhZWVmOTY5NTM0IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rl c3RDb250cm9sbGVyQ29jb2EubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9U ZXN0Q29udHJvbGxlckNvY29hLm1tCkBAIC04Niw2ICs4Niw5IEBAIHZvaWQgaW5pdGlhbGl6ZVdl YlZpZXdDb25maWd1cmF0aW9uKGNvbnN0IGNoYXIqIGxpYnJhcnlQYXRoLCBXS1N0cmluZ1JlZiBp bmplY3RlCiAgICAgZ2xvYmFsV2ViVmlld0NvbmZpZ3VyYXRpb24uX2ludmlzaWJsZUF1dG9wbGF5 Tm90UGVybWl0dGVkID0gTk87CiAgICAgZ2xvYmFsV2ViVmlld0NvbmZpZ3VyYXRpb24uX21lZGlh RGF0YUxvYWRzQXV0b21hdGljYWxseSA9IFlFUzsKICAgICBnbG9iYWxXZWJWaWV3Q29uZmlndXJh dGlvbi5yZXF1aXJlc1VzZXJBY3Rpb25Gb3JNZWRpYVBsYXliYWNrID0gTk87CisKKyAgICAvLyBN YWtlIHN1cmUgdGhlIHZpZXcgZG9lcyBub3QgZ2V0IHN1c3BlbmRlZCBhbmQgcnVucyBhdCBmb3Jl Z3JvdW5kIHByaW9yaXR5LCBldmVuIGlmIG5vdCB2aXNpYmxlIG9uIHNjcmVlbi4KKyAgICBnbG9i YWxXZWJWaWV3Q29uZmlndXJhdGlvbi5fYWx3YXlzUnVuc0F0Rm9yZWdyb3VuZFByaW9yaXR5ID0g WUVTOwogI2VuZGlmCiAgICAgZ2xvYmFsV2ViVmlld0NvbmZpZ3VyYXRpb24ubWVkaWFUeXBlc1Jl cXVpcmluZ1VzZXJBY3Rpb25Gb3JQbGF5YmFjayA9IFdLQXVkaW92aXN1YWxNZWRpYVR5cGVOb25l OwogCg==