210976 2020-04-24 09:57:51 -0700 media/track/track-load-error-readyState.html passes only when accompanied by some other tests 2020-04-29 14:19:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211132 https://bugs.webkit.org/show_bug.cgi?id=211133 https://bugs.webkit.org/show_bug.cgi?id=211194 P2 Normal --- 1 aboya pnormand bugs-noreply calvaris eric.carlson ews-watchlist glenn jer.noble philipj pnormand sergio tsavell oldest_to_newest 1645232 0 aboya 2020-04-24 09:57:51 -0700 Ok, this is a weird one. This is media/track/track-load-error-readyState.html, the whole thing: <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> <script src=../media-file.js></script> <script src=../video-test.js></script> <script> function trackError() { consoleWrite("EVENT(error)"); track = document.getElementById('testTrackError'); testExpected("track.readyState", HTMLTrackElement.ERROR); endTest(); } </script> </head> <body> <p>Tests the error event on HTMLTrackElement and ERROR readyState on TextTrack.</p> <video id="videotests"> <track id="testTrackError" src="junk" onerror="trackError()" default> </video> </body> </html> Run it in a minibrowser and it will timeout every time. The onerror() handler will not be called and no text will be printed. 100% reproducible. Run it in singly run-webkit-tests, and indeed, you will get a timeout, 100% of the time: $ run-webkit-tests --gtk --debug media/track/track-load-error-readyState.html Using port 'gtk-wk2' Test configuration: <, x86, debug> Placing test results in /webkit/WebKitBuild/Debug/layout-test-results Using Debug build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /webkit/Tools/jhbuild/jhbuild-wrapper --gtk run /webkit/WebKitBuild/Debug/bin/WebKitTestRunner - Found 1 test; running 1, skipping 0. Verbose baseline search path: platform/gtk -> platform/wk2 -> generic Baseline search path: platform/gtk -> platform/wk2 -> generic Running 1 test Running 1 WebKitTestRunner. [1/1] media/track/track-load-error-readyState.html failed unexpectedly (test timed out, text diff) Retrying 1 unexpected failure ... Running 1 WebKitTestRunner. [1/1] media/track/track-load-error-readyState.html failed unexpectedly (test timed out, text diff) 0 tests ran as expected, 1 didn't: Regressions: Unexpected timeouts (1) media/track/track-load-error-readyState.html [ Timeout ] But here comes the surprise. Run it within certain sets of tests, and it will pass, 100% of the time. For instance: $ run-webkit-tests --gtk --debug media/track/track-in-band-style.html media/track/track-in-band-subtitles-too-large.html media/track/track-kind.html media/track/track-legacyapi-with-automatic-mode.html media/track/track-load-error-readyState.html Using port 'gtk-wk2' Test configuration: <, x86, debug> Placing test results in /webkit/WebKitBuild/Debug/layout-test-results Using Debug build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /webkit/Tools/jhbuild/jhbuild-wrapper --gtk run /webkit/WebKitBuild/Debug/bin/WebKitTestRunner - Found 5 tests; running 5, skipping 0. Verbose baseline search path: platform/gtk -> platform/wk2 -> generic Baseline search path: platform/gtk -> platform/wk2 -> generic Running 5 tests Running 1 WebKitTestRunner. All 5 tests ran as expected. This is also the case when running all the tests. Therefore, according to the bots, this test passes. I made changes to the test file to confirm that it is in fact being run. The onerror callback is called, and modifying the code there modifies the output which makes the test fail as expected. 1646418 1 397820 pnormand 2020-04-28 01:38:18 -0700 Created attachment 397820 Patch 1646436 2 397824 pnormand 2020-04-28 03:29:42 -0700 Created attachment 397824 Patch 1646442 3 397827 pnormand 2020-04-28 04:27:53 -0700 Created attachment 397827 Patch 1646457 4 pnormand 2020-04-28 05:10:18 -0700 EWS should green now, please review :) 1646473 5 pnormand 2020-04-28 07:17:35 -0700 Committed r260822: <https://trac.webkit.org/changeset/260822> 1646510 6 tsavell 2020-04-28 09:15:31 -0700 The changes in https://trac.webkit.org/changeset/260822/webkit broke media/track/track-in-band-metadata-display-order.html on Mac history: https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack-in-band-metadata-display-order.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-in-band-metadata-display-order-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/media/track/track-in-band-metadata-display-order-actual.txt @@ -15,7 +15,7 @@ RUN(metadataTrack.addCue(new DataCue(2.25, video.duration, "second data cue"))) RUN(video.currentTime = 3) EVENT(seeked) -EXPECTED (textTrackDisplayElement(video, "display", 0).textContent == 'I am later') OK -EXPECTED (textTrackDisplayElement(video, "display", 1).textContent == 'I am earlier') OK +EXPECTED (textTrackDisplayElement(video, "display", 0).textContent == 'I am later'), OBSERVED 'I am later ::cue{background-color:rgba(0, 0, 0, 0) !important;color:#ffffff;font-family: "Helvetica";} ::-webkit-media-text-track-display-backdrop{background-color:rgba(0, 0, 0, 0.498) !important;padding: .4em !important;border-radius:8px !important;}' FAIL +EXPECTED (textTrackDisplayElement(video, "display", 1).textContent == 'I am earlier'), OBSERVED 'I am earlier ::cue{background-color:rgba(0, 0, 0, 0) !important;color:#ffffff;font-family: "Helvetica";} ::-webkit-media-text-track-display-backdrop{background-color:rgba(0, 0, 0, 0.498) !important;padding: .4em !important;border-radius:8px !important;}' FAIL END OF TEST 1646513 7 397827 eric.carlson 2020-04-28 09:19:52 -0700 Comment on attachment 397827 Patch Nice fix, thanks! 1646524 8 397827 pnormand 2020-04-28 09:34:39 -0700 Comment on attachment 397827 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397827&action=review > LayoutTests/media/track/track-load-error-readyState.html:15 > + function setup() > + { > + if (window.internals) > + run("internals.setCaptionDisplayMode('Automatic')"); > + } > + Truitt, the test would need a similar setup function. I wonder why the EWS didn't fail on that test? 1646531 9 tsavell 2020-04-28 09:44:48 -0700 (In reply to Philippe Normand from comment #8) > Comment on attachment 397827 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397827&action=review > > > LayoutTests/media/track/track-load-error-readyState.html:15 > > + function setup() > > + { > > + if (window.internals) > > + run("internals.setCaptionDisplayMode('Automatic')"); > > + } > > + > > Truitt, the test would need a similar setup function. I wonder why the EWS > didn't fail on that test? Looks like our test history doesn't show any failures for that test: https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack-load-error-readyState.html 1646545 10 397827 pnormand 2020-04-28 10:10:59 -0700 Comment on attachment 397827 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397827&action=review >>> LayoutTests/media/track/track-load-error-readyState.html:15 >>> + >> >> Truitt, the test would need a similar setup function. I wonder why the EWS didn't fail on that test? > > Looks like our test history doesn't show any failures for that test: https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack-load-error-readyState.html I meant for the test now failing after this patch landed... Anyway, please review #211133 :) 1647066 11 tsavell 2020-04-29 10:48:45 -0700 I just found this test is also failing after r260822 media/track/track-cue-missing.html History: https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack-cue-missing.html Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/media/track/track-cue-missing-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/media/track/track-cue-missing-actual.txt @@ -5,6 +5,6 @@ EVENT(loadeddata) Created 121 cues. EVENT(ended) -EXPECTED (missedCueCount < '50') OK +EXPECTED (missedCueCount < '50'), OBSERVED '56' FAIL END OF TEST 1647068 12 pnormand 2020-04-29 10:52:08 -0700 Another test flagged as failing in GTK... I'm checking it now. Thanks Truitt. 1647155 13 tsavell 2020-04-29 14:19:33 -0700 (In reply to Truitt Savell from comment #11) > I just found this test is also failing after r260822 > > media/track/track-cue-missing.html > > History: > https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Ftrack- > cue-missing.html > > Diff: > --- > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/media/ > track/track-cue-missing-expected.txt > +++ > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/media/ > track/track-cue-missing-actual.txt > @@ -5,6 +5,6 @@ > EVENT(loadeddata) > Created 121 cues. > EVENT(ended) > -EXPECTED (missedCueCount < '50') OK > +EXPECTED (missedCueCount < '50'), OBSERVED '56' FAIL > END OF TEST I was able to reproduce it using command: run-webkit-tests media/track/track-cue-missing.html --iterations 2000 --exit-after-n-failures 1 -f --debug on a build of r260823 I cannot reproduce this on a build of r260820 sense r260823 is a test gardening change that leaves r260822 and r260821 as where this regressed 397820 2020-04-28 01:38:18 -0700 2020-04-28 03:29:38 -0700 Patch bug-210976-20200428093817.patch text/plain 1591 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU0Y2U3ZWJhOTQzMzc5 MGE3NTAxOWVhMmM4NDkzOTM2YmI4Mjc2Mi4uNDg0NDljNjk0ODNiMDUzZmFiZmJiODllMWRmOGM3 YzE4NDY1NzQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA0LTI4ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBtZWRpYS90cmFj ay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUuaHRtbCBwYXNzZXMgb25seSB3aGVuIGFjY29t cGFuaWVkIGJ5IHNvbWUgb3RoZXIgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlKTogUmVzZXQgY2FwdGlvbgor ICAgICAgICBkaXNwbGF5IG1vZGUsIHdoaWNoIG1pZ2h0IGhhdmUgYmVlbiBvdmVycmlkZW4gYnkg YSBwcmV2aW91cyB0ZXN0LgorCiAyMDIwLTA0LTI3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIERvIGNvcnJlY3QgY2xpcHBpbmcgb2YgY29tcG9zaXRl ZCByZXBsYWNlZCBlbGVtZW50cyB3aXRoIGJvcmRlci1yYWRpdXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3Rpbmcv SW50ZXJuYWxzLmNwcAppbmRleCA0ZTAxMzNmMTAxMDUwOGM1MzVhNDc3NjgxZTRjMGZjYzcwZGZl MjA1Li5mMzhmZDJjNGM1Y2VhNjVhOWJlMTdhZTI5M2Y5NTA2NTYyODZiOWVhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCkBAIC01MTMsNiArNTEzLDcgQEAgdm9pZCBJbnRlcm5h bHM6OnJlc2V0VG9Db25zaXN0ZW50U3RhdGUoUGFnZSYgcGFnZSkKICAgICBXZWJDb3JlOjpEZXBy ZWNhdGVkR2xvYmFsU2V0dGluZ3M6OnNldFVzZXNNb2NrU2Nyb2xsQW5pbWF0b3IoZmFsc2UpOwog I2lmIEVOQUJMRShWSURFT19UUkFDSykKICAgICBwYWdlLmdyb3VwKCkuY2FwdGlvblByZWZlcmVu Y2VzKCkuc2V0VGVzdGluZ01vZGUodHJ1ZSk7CisgICAgcGFnZS5ncm91cCgpLmNhcHRpb25QcmVm ZXJlbmNlcygpLnNldENhcHRpb25EaXNwbGF5TW9kZShDYXB0aW9uVXNlclByZWZlcmVuY2VzOjpB dXRvbWF0aWMpOwogICAgIHBhZ2UuZ3JvdXAoKS5jYXB0aW9uUHJlZmVyZW5jZXMoKS5zZXRDYXB0 aW9uc1N0eWxlU2hlZXRPdmVycmlkZShlbXB0eVN0cmluZygpKTsKICAgICBwYWdlLmdyb3VwKCku Y2FwdGlvblByZWZlcmVuY2VzKCkuc2V0VGVzdGluZ01vZGUoZmFsc2UpOwogI2VuZGlmCg== 397824 2020-04-28 03:29:42 -0700 2020-04-28 04:27:49 -0700 Patch bug-210976-20200428112941.patch text/plain 4086 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRmMWYzZmExNzNlNWJi OGQ1YTE2YzI4NTI2OGE3OGE5NWFkMTNkMC4uZWViZjg2MGEzZDc1ODk4MGJiNWE4ZTZiODAyOTFl YjE3NjA3ODFlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA0LTI4ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBtZWRpYS90cmFj ay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUuaHRtbCBwYXNzZXMgb25seSB3aGVuIGFjY29t cGFuaWVkIGJ5IHNvbWUgb3RoZXIgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlKTogUmVzZXQgY2FwdGlvbgor ICAgICAgICBkaXNwbGF5IG1vZGUsIHdoaWNoIG1pZ2h0IGhhdmUgYmVlbiBvdmVycmlkZW4gYnkg YSBwcmV2aW91cyB0ZXN0LgorCiAyMDIwLTA0LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBSVENQZWVyQ29ubmVjdGlvbiBzaG91bGQgbm90IHJlbW92ZSBp dHMgY3JlYXRlZCByZW1vdGUgTWVkaWFTdHJlYW0gb2JqZWN0cyB1bnRpbCBnZXR0aW5nIGNsb3Nl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggNGUwMTMzZjEwMTA1MDhjNTM1 YTQ3NzY4MWU0YzBmY2M3MGRmZTIwNS4uMGY4YmVjOTExNjI3MzI4NmI0ZmM1MjYzYjIwMWI3NDE3 MTY0NmU0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtNTEzLDYgKzUx Myw3IEBAIHZvaWQgSW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlKFBhZ2UmIHBhZ2Up CiAgICAgV2ViQ29yZTo6RGVwcmVjYXRlZEdsb2JhbFNldHRpbmdzOjpzZXRVc2VzTW9ja1Njcm9s bEFuaW1hdG9yKGZhbHNlKTsKICNpZiBFTkFCTEUoVklERU9fVFJBQ0spCiAgICAgcGFnZS5ncm91 cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpLnNldFRlc3RpbmdNb2RlKHRydWUpOworICAgIHBhZ2Uu Z3JvdXAoKS5jYXB0aW9uUHJlZmVyZW5jZXMoKS5zZXRDYXB0aW9uRGlzcGxheU1vZGUoQ2FwdGlv blVzZXJQcmVmZXJlbmNlczo6Rm9yY2VkT25seSk7CiAgICAgcGFnZS5ncm91cCgpLmNhcHRpb25Q cmVmZXJlbmNlcygpLnNldENhcHRpb25zU3R5bGVTaGVldE92ZXJyaWRlKGVtcHR5U3RyaW5nKCkp OwogICAgIHBhZ2UuZ3JvdXAoKS5jYXB0aW9uUHJlZmVyZW5jZXMoKS5zZXRUZXN0aW5nTW9kZShm YWxzZSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMTg3MjBhOGM0NTdmOGEwNDk1NzBmOTI5MmUxMTVjYzRm YzExYTg4Li5hZTkzOTg0YmUxYTk0YWE0YmY2ODZjNzA1NmE3YjgwMDM5ZWY0YjVjIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMjggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCisgICAgICAgIG1lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlT dGF0ZS5odG1sIHBhc3NlcyBvbmx5IHdoZW4gYWNjb21wYW5pZWQgYnkgc29tZSBvdGhlciB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwOTc2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRp YS90cmFjay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIG1lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlTdGF0ZS5odG1sOiBFbnN1cmUg dGhlIGNhcHRpb24KKyAgICAgICAgZGlzcGxheSBtb2RlIGlzIHNldCB0byBhdXRvbWF0aWMsIHRo aXMgaXMgYSByZXF1aXJlbWVudCBmb3IgdGhlCisgICAgICAgIHRlc3QuCisKIDIwMjAtMDQtMjgg IFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJUQ1BlZXJDb25u ZWN0aW9uIHNob3VsZCBub3QgcmVtb3ZlIGl0cyBjcmVhdGVkIHJlbW90ZSBNZWRpYVN0cmVhbSBv YmplY3RzIHVudGlsIGdldHRpbmcgY2xvc2UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlh L3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlTdGF0ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9tZWRpYS90cmFjay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUtZXhwZWN0ZWQudHh0 CmluZGV4IGQ1YWRmMzE0Y2Y1OTBkMjgzMmVjOGU0NWM1YTE5MDc5NGI0MDBiZDUuLmMwOTVkNDdl MWJlNjBiNWE1MDBhMTZkZmNiZjNkNTVjNDRhNmMzNjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L21lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlTdGF0ZS1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stbG9hZC1lcnJvci1yZWFkeVN0YXRlLWV4 cGVjdGVkLnR4dApAQCAtMSw2ICsxLDcgQEAKIFRlc3RzIHRoZSBlcnJvciBldmVudCBvbiBIVE1M VHJhY2tFbGVtZW50IGFuZCBFUlJPUiByZWFkeVN0YXRlIG9uIFRleHRUcmFjay4KIAogCitSVU4o aW50ZXJuYWxzLnNldENhcHRpb25EaXNwbGF5TW9kZSgnQXV0b21hdGljJykpCiBFVkVOVChlcnJv cikKIEVYUEVDVEVEICh0cmFjay5yZWFkeVN0YXRlID09ICczJykgT0sKIEVORCBPRiBURVNUCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1sb2FkLWVycm9yLXJlYWR5 U3RhdGUuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVh ZHlTdGF0ZS5odG1sCmluZGV4IDMyNmJhN2M1ZDAzZWQ2ZmExMzJiOTVkZGJmMThkN2I2NTY4Mjc3 NTkuLjRiOTI3MDg2YTU2ZjdkYjdhN2JiYjkyMjlmMTdmZGRkMDY2ZDg1OGMgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlTdGF0ZS5odG1s CisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlTdGF0 ZS5odG1sCkBAIC03LDYgKzcsMTIgQEAKICAgICAgICAgPHNjcmlwdCBzcmM9Li4vdmlkZW8tdGVz dC5qcz48L3NjcmlwdD4KICAgICAgICAgPHNjcmlwdD4KIAorICAgICAgICAgICAgZnVuY3Rpb24g c2V0dXAoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJu YWxzKQorICAgICAgICAgICAgICAgICAgICBydW4oImludGVybmFscy5zZXRDYXB0aW9uRGlzcGxh eU1vZGUoJ0F1dG9tYXRpYycpIik7CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgIGZ1bmN0 aW9uIHRyYWNrRXJyb3IoKQogICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIGNvbnNvbGVX cml0ZSgiRVZFTlQoZXJyb3IpIik7CkBAIC0xNyw3ICsyMyw3IEBACiAKICAgICAgICAgPC9zY3Jp cHQ+CiAgICAgPC9oZWFkPgotICAgIDxib2R5PgorICAgIDxib2R5IG9ubG9hZD0ic2V0dXAoKSI+ CiAgICAgICAgIDxwPlRlc3RzIHRoZSBlcnJvciBldmVudCBvbiBIVE1MVHJhY2tFbGVtZW50IGFu ZCBFUlJPUiByZWFkeVN0YXRlIG9uIFRleHRUcmFjay48L3A+CiAgICAgICAgIDx2aWRlbyBpZD0i dmlkZW90ZXN0cyI+CiAgICAgICAgICAgICA8dHJhY2sgaWQ9InRlc3RUcmFja0Vycm9yIiBzcmM9 Imp1bmsiIG9uZXJyb3I9InRyYWNrRXJyb3IoKSIgZGVmYXVsdD4K 397827 2020-04-28 04:27:53 -0700 2020-04-28 07:12:31 -0700 Patch bug-210976-20200428122752.patch text/plain 5547 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRmMWYzZmExNzNlNWJi OGQ1YTE2YzI4NTI2OGE3OGE5NWFkMTNkMC4uZWViZjg2MGEzZDc1ODk4MGJiNWE4ZTZiODAyOTFl YjE3NjA3ODFlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA0LTI4ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBtZWRpYS90cmFj ay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUuaHRtbCBwYXNzZXMgb25seSB3aGVuIGFjY29t cGFuaWVkIGJ5IHNvbWUgb3RoZXIgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDk3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlKTogUmVzZXQgY2FwdGlvbgor ICAgICAgICBkaXNwbGF5IG1vZGUsIHdoaWNoIG1pZ2h0IGhhdmUgYmVlbiBvdmVycmlkZW4gYnkg YSBwcmV2aW91cyB0ZXN0LgorCiAyMDIwLTA0LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBSVENQZWVyQ29ubmVjdGlvbiBzaG91bGQgbm90IHJlbW92ZSBp dHMgY3JlYXRlZCByZW1vdGUgTWVkaWFTdHJlYW0gb2JqZWN0cyB1bnRpbCBnZXR0aW5nIGNsb3Nl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggNGUwMTMzZjEwMTA1MDhjNTM1 YTQ3NzY4MWU0YzBmY2M3MGRmZTIwNS4uMGY4YmVjOTExNjI3MzI4NmI0ZmM1MjYzYjIwMWI3NDE3 MTY0NmU0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtNTEzLDYgKzUx Myw3IEBAIHZvaWQgSW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlKFBhZ2UmIHBhZ2Up CiAgICAgV2ViQ29yZTo6RGVwcmVjYXRlZEdsb2JhbFNldHRpbmdzOjpzZXRVc2VzTW9ja1Njcm9s bEFuaW1hdG9yKGZhbHNlKTsKICNpZiBFTkFCTEUoVklERU9fVFJBQ0spCiAgICAgcGFnZS5ncm91 cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpLnNldFRlc3RpbmdNb2RlKHRydWUpOworICAgIHBhZ2Uu Z3JvdXAoKS5jYXB0aW9uUHJlZmVyZW5jZXMoKS5zZXRDYXB0aW9uRGlzcGxheU1vZGUoQ2FwdGlv blVzZXJQcmVmZXJlbmNlczo6Rm9yY2VkT25seSk7CiAgICAgcGFnZS5ncm91cCgpLmNhcHRpb25Q cmVmZXJlbmNlcygpLnNldENhcHRpb25zU3R5bGVTaGVldE92ZXJyaWRlKGVtcHR5U3RyaW5nKCkp OwogICAgIHBhZ2UuZ3JvdXAoKS5jYXB0aW9uUHJlZmVyZW5jZXMoKS5zZXRUZXN0aW5nTW9kZShm YWxzZSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMTg3MjBhOGM0NTdmOGEwNDk1NzBmOTI5MmUxMTVjYzRm YzExYTg4Li4xMjAxYjNiMzk5Yjg4OGIyYjE2MTk1YTFlNGZmYjA4ODFkMTI5NjM4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMjAtMDQtMjggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCisgICAgICAgIG1lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlT dGF0ZS5odG1sIHBhc3NlcyBvbmx5IHdoZW4gYWNjb21wYW5pZWQgYnkgc29tZSBvdGhlciB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwOTc2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRp YS90cmFjay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIG1lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlTdGF0ZS5odG1sOiBFbnN1cmUg dGhlIGNhcHRpb24KKyAgICAgICAgZGlzcGxheSBtb2RlIGlzIHNldCB0byBhdXRvbWF0aWMsIHRo aXMgaXMgYSByZXF1aXJlbWVudCBmb3IgdGhlCisgICAgICAgIHRlc3QuCisgICAgICAgICogbWVk aWEvdHJhY2svdHJhY2stbW9kZS1ub3QtY2hhbmdlZC1ieS1uZXctdHJhY2stZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIG1lZGlhL3RyYWNrL3RyYWNrLW1vZGUtbm90LWNoYW5nZWQtYnktbmV3LXRy YWNrLmh0bWw6IERpdHRvLgorCiAyMDIwLTA0LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBSVENQZWVyQ29ubmVjdGlvbiBzaG91bGQgbm90IHJlbW92ZSBp dHMgY3JlYXRlZCByZW1vdGUgTWVkaWFTdHJlYW0gb2JqZWN0cyB1bnRpbCBnZXR0aW5nIGNsb3Nl CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1sb2FkLWVycm9yLXJl YWR5U3RhdGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stbG9h ZC1lcnJvci1yZWFkeVN0YXRlLWV4cGVjdGVkLnR4dAppbmRleCBkNWFkZjMxNGNmNTkwZDI4MzJl YzhlNDVjNWExOTA3OTRiNDAwYmQ1Li5jMDk1ZDQ3ZTFiZTYwYjVhNTAwYTE2ZGZjYmYzZDU1YzQ0 YTZjMzYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1sb2FkLWVy cm9yLXJlYWR5U3RhdGUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNr L3RyYWNrLWxvYWQtZXJyb3ItcmVhZHlTdGF0ZS1leHBlY3RlZC50eHQKQEAgLTEsNiArMSw3IEBA CiBUZXN0cyB0aGUgZXJyb3IgZXZlbnQgb24gSFRNTFRyYWNrRWxlbWVudCBhbmQgRVJST1IgcmVh ZHlTdGF0ZSBvbiBUZXh0VHJhY2suCiAKIAorUlVOKGludGVybmFscy5zZXRDYXB0aW9uRGlzcGxh eU1vZGUoJ0F1dG9tYXRpYycpKQogRVZFTlQoZXJyb3IpCiBFWFBFQ1RFRCAodHJhY2sucmVhZHlT dGF0ZSA9PSAnMycpIE9LCiBFTkQgT0YgVEVTVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvdHJhY2svdHJhY2stbG9hZC1lcnJvci1yZWFkeVN0YXRlLmh0bWwgYi9MYXlvdXRUZXN0cy9t ZWRpYS90cmFjay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUuaHRtbAppbmRleCAzMjZiYTdj NWQwM2VkNmZhMTMyYjk1ZGRiZjE4ZDdiNjU2ODI3NzU5Li40YjkyNzA4NmE1NmY3ZGI3YTdiYmI5 MjI5ZjE3ZmRkZDA2NmQ4NThjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90 cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS90 cmFjay90cmFjay1sb2FkLWVycm9yLXJlYWR5U3RhdGUuaHRtbApAQCAtNyw2ICs3LDEyIEBACiAg ICAgICAgIDxzY3JpcHQgc3JjPS4uL3ZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CiAgICAgICAgIDxz Y3JpcHQ+CiAKKyAgICAgICAgICAgIGZ1bmN0aW9uIHNldHVwKCkKKyAgICAgICAgICAgIHsKKyAg ICAgICAgICAgICAgICBpZiAod2luZG93LmludGVybmFscykKKyAgICAgICAgICAgICAgICAgICAg cnVuKCJpbnRlcm5hbHMuc2V0Q2FwdGlvbkRpc3BsYXlNb2RlKCdBdXRvbWF0aWMnKSIpOworICAg ICAgICAgICAgfQorCiAgICAgICAgICAgICBmdW5jdGlvbiB0cmFja0Vycm9yKCkKICAgICAgICAg ICAgIHsKICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIkVWRU5UKGVycm9yKSIpOwpAQCAt MTcsNyArMjMsNyBAQAogCiAgICAgICAgIDwvc2NyaXB0PgogICAgIDwvaGVhZD4KLSAgICA8Ym9k eT4KKyAgICA8Ym9keSBvbmxvYWQ9InNldHVwKCkiPgogICAgICAgICA8cD5UZXN0cyB0aGUgZXJy b3IgZXZlbnQgb24gSFRNTFRyYWNrRWxlbWVudCBhbmQgRVJST1IgcmVhZHlTdGF0ZSBvbiBUZXh0 VHJhY2suPC9wPgogICAgICAgICA8dmlkZW8gaWQ9InZpZGVvdGVzdHMiPgogICAgICAgICAgICAg PHRyYWNrIGlkPSJ0ZXN0VHJhY2tFcnJvciIgc3JjPSJqdW5rIiBvbmVycm9yPSJ0cmFja0Vycm9y KCkiIGRlZmF1bHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1t b2RlLW5vdC1jaGFuZ2VkLWJ5LW5ldy10cmFjay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9t ZWRpYS90cmFjay90cmFjay1tb2RlLW5vdC1jaGFuZ2VkLWJ5LW5ldy10cmFjay1leHBlY3RlZC50 eHQKaW5kZXggZjU0NTRjNzY2YjczOWU5YzFjM2U4ZDZhNTU4NTk5NjgxZjUxNGVjNi4uMGVjYTBl MTkwM2U0N2ViNDk3Mzg2NWU3ZGQ3OTNkZTg0NDgxZjE2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvbWVkaWEvdHJhY2svdHJhY2stbW9kZS1ub3QtY2hhbmdlZC1ieS1uZXctdHJhY2stZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLW1vZGUtbm90LWNoYW5n ZWQtYnktbmV3LXRyYWNrLWV4cGVjdGVkLnR4dApAQCAtMSw2ICsxLDcgQEAKIFRlc3RzIHRoYXQg YSB0cmFjayBhcHBlbmRlZCBhZnRlciB0aGUgaW5pdGlhbCB0cmFjayBjb25maWd1cmF0aW9uIGRv ZXMgbm90IGNoYW5nZSBvdGhlciB0cmFja3MuCiAKIAorUlVOKGludGVybmFscy5zZXRDYXB0aW9u RGlzcGxheU1vZGUoJ0F1dG9tYXRpYycpKQogCiBFVkVOVChsb2FkKSAtLSA8Ym9keT4KIEVYUEVD VEVEICh0cmFjazEucmVhZHlTdGF0ZSA9PSAnMCcpIE9LCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9tZWRpYS90cmFjay90cmFjay1tb2RlLW5vdC1jaGFuZ2VkLWJ5LW5ldy10cmFjay5odG1sIGIv TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stbW9kZS1ub3QtY2hhbmdlZC1ieS1uZXctdHJh Y2suaHRtbAppbmRleCBjOWZjZjYwMjMwYzJiMTg0MDdlZmNlMzNhNDg3Mzg5YmNiN2I5OWYyLi44 NDA0ZDUzOTIyNTZjNDM5Y2I2YTY4MjhlYzA2YmEwZGY4ZmViMWM2IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1tb2RlLW5vdC1jaGFuZ2VkLWJ5LW5ldy10cmFjay5o dG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLW1vZGUtbm90LWNoYW5nZWQt YnktbmV3LXRyYWNrLmh0bWwKQEAgLTc4LDYgKzc4LDkgQEAKIAogICAgICAgICAgICAgZnVuY3Rp b24gc3RhcnQoKQogICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cuaW50 ZXJuYWxzKQorICAgICAgICAgICAgICAgICAgICBydW4oImludGVybmFscy5zZXRDYXB0aW9uRGlz cGxheU1vZGUoJ0F1dG9tYXRpYycpIik7CisKICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUo Ijxicj5FVkVOVChsb2FkKSAtLSAmbHQ7Ym9keSZndDsiKTsKICAgICAgICAgICAgICAgICBmaW5k TWVkaWFFbGVtZW50KCk7CiAK