210950 2020-04-23 18:03:39 -0700 Disable useKernTCSM=false for JSC stress tests to make EWS faster 2020-04-24 06:15:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199117 InRadar P2 Normal --- 1 ysuzuki ysuzuki aakash_jain ap jbedard mark.lam saam webkit-bug-importer oldest_to_newest 1645040 0 ysuzuki 2020-04-23 18:03:39 -0700 Disable useKernTCSM=false for JSC stress tests to make EWS faster 1645043 1 397410 ysuzuki 2020-04-23 18:07:23 -0700 Created attachment 397410 Patch 1645044 2 397410 ysuzuki 2020-04-23 18:08:16 -0700 Comment on attachment 397410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review > Tools/Scripts/run-javascriptcore-tests:-532 > -} I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. 1645058 3 ysuzuki 2020-04-23 19:09:59 -0700 EWS JSC stress bot finishes with 59:23, so this patch is effective. 1645059 4 397410 ysuzuki 2020-04-23 19:10:28 -0700 Comment on attachment 397410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review >> Tools/Scripts/run-javascriptcore-tests:-532 >> -} > > I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. I've ensured this works on EWS. 1645064 5 397410 mark.lam 2020-04-23 20:21:02 -0700 Comment on attachment 397410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review r=me >>> Tools/Scripts/run-javascriptcore-tests:-532 >>> -} >> >> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. > > I've ensured this works on EWS. Jonathan Bedard (cc'ed) added this change. I'm fine with removing it since we have evidence that it speeds up the EWS. 1645065 6 ews-feeder 2020-04-23 20:31:14 -0700 Committed r260617: <https://trac.webkit.org/changeset/260617> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397410. 1645066 7 webkit-bug-importer 2020-04-23 20:32:14 -0700 <rdar://problem/62278398> 1645165 8 397410 jbedard 2020-04-24 06:15:47 -0700 Comment on attachment 397410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review >>>> Tools/Scripts/run-javascriptcore-tests:-532 >>>> -} >>> >>> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. >> >> I've ensured this works on EWS. > > Jonathan Bedard (cc'ed) added this change. I'm fine with removing it since we have evidence that it speeds up the EWS. I would agree. I have evidence JSC_useKernTCSM=false speeds up layout tests, but never had evidence for JSC tests. 397410 2020-04-23 18:07:23 -0700 2020-04-23 20:31:15 -0700 Patch bug-210950-20200423180722.patch text/plain 1775 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2NiZDliZDA5MjMwYWI1Y2MwOGFmYTIzOTQ1NDFiMWVm NzIwYTFmOS4uMTIxZjRjMmZmOThjOTU4YmQ2YmVjYjZkYTVmNjhhMjg3YThmNjY5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTA0LTIzICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAg ICAgICAgRGlzYWJsZSB1c2VLZXJuVENTTT1mYWxzZSBmb3IgSlNDIHN0cmVzcyB0ZXN0cyB0byBt YWtlIEVXUyBmYXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMDk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyAiSlNDX3VzZUtlcm5UQ1NNPWZhbHNlIiBlbnZpcm9u bWVudCB2YXJpYWJsZSBpbiBKU0Mgc3RyZXNzIHRlc3RzLgorICAgICAgICBBbGV4ZXkgZm91bmQg dGhhdCB0aGlzIGNhdXNlcyBFV1MgSlNDIHN0cmVzcyB0ZXN0cyBzbG93IGRvd24gKGZyb20gcm91 Z2hseSA2MyBtaW5zIHRvIDgzIG1pbnMpLgorICAgICAgICBUaGlzIHNsb3cgZG93biBoYXBwZW5z IGluIE1hYyBQcm8gKHdoaWNoIGlzIHVzZWQgaW4gSlNDIEVXUyByaWdodCBub3cpLCBhbmQgdGhp cyBzbG93IGRvd24gZG9lcworICAgICAgICBub3QgaGFwcGVuIGluIE1hYyBtaW5pIChwb3N0LWNv bW1pdCBidWlsZGJvdCkgYW5kIHJhdGhlciBpbXByb3ZlcyBNYWMgTWluaSBleGVjdXRpb24gdGlt ZSBieSAxNSUsCisgICAgICAgIGJ1dCBrZWVwaW5nIEVXUyBmYXN0ZXIgaXMgbW9yZSBpbXBvcnRh bnQgdGhhbiBtYWtpbmcgcG9zdC1jb21taXQgYm90cyBmYXN0ZXIuCisKKyAgICAgICAgKiBTY3Jp cHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKwogMjAyMC0wNC0yMyAgWXVzdWtlIFN1enVr aSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgYC0tcmVwb3J0LWV4ZWN1 dGlvbi10aW1lYCB0byByZXBvcnQgZXhlY3V0aW9uIHRpbWUgZm9yIGVhY2ggSlNDIHN0cmVzcyB0 ZXN0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBi L1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCmluZGV4IDY0OWExMWY0OTQ2 MDYxMDZlMTMzNjZhZDBlOWRmMjkyOGVmMjg1M2EuLjJiMDU2MjM1YjQ2MGZhMTNjMGRjMmM5ODgy MTRlNjZiMTAwYjU5MDQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRj b3JlLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCkBA IC01MjcsMTAgKzUyNyw2IEBAIGlmICgkY292ZXJhZ2UpIHsKICAgICB9CiB9CiAKLWlmIChpc0Fw cGxlTWFjV2ViS2l0KCkpIHsKLSAgICAkZW52VmFycyAuPSAiIEpTQ191c2VLZXJuVENTTT1mYWxz ZSI7Ci19Ci0KIG15ICRwcm9kdWN0RGlyID0ganNjUHJvZHVjdERpcigpOwogJEVOVntEWUxEX0ZS QU1FV09SS19QQVRIfSA9ICRwcm9kdWN0RGlyOwogJEVOVntKU0NURVNUX3RpbWVvdXR9ID0gMTIw IHVubGVzcyAkRU5We0pTQ1RFU1RfdGltZW91dH07ICMgU2V0IGEgMTIwIHNlY29uZCB0aW1lb3V0 IG9uIGFsbCBqc2MgdGVzdHMgKGlmIGVudmlyb25tZW50IHZhcmlhYmxlIG5vdCBkZWZpbmVkIGFs cmVhZHkpLgo=