210931 2020-04-23 12:08:13 -0700 stress/ensure-crash.js shouldn't spew stuff onto my screen 2020-04-23 22:15:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo ysuzuki ap fpizlo ross.kirsling webkit-bug-importer oldest_to_newest 1644895 0 fpizlo 2020-04-23 12:08:13 -0700 JS tests should only spew things onto my screen if they succeed. ensure-crash appears to succeed but spews errors onto my screen. We should either skip it so it doesn't pollute a user's screen with errors that aren't errors or we should make it so that `crash!` or whatever makes the test not spew things unless it fails. run-jsc-stress-tests has the ability to log output and then only spew it if there was an actual error. We should use that. 1644896 1 fpizlo 2020-04-23 12:09:05 -0700 (In reply to Filip Pizlo from comment #0) > JS tests should only spew things onto my screen if they succeed. I mean if they fail. > > ensure-crash appears to succeed but spews errors onto my screen. > > We should either skip it so it doesn't pollute a user's screen with errors > that aren't errors or we should make it so that `crash!` or whatever makes > the test not spew things unless it fails. run-jsc-stress-tests has the > ability to log output and then only spew it if there was an actual error. > We should use that. 1645068 2 397418 ysuzuki 2020-04-23 20:49:08 -0700 Created attachment 397418 Patch 1645069 3 397419 ysuzuki 2020-04-23 20:52:40 -0700 Created attachment 397419 Patch 1645086 4 ews-feeder 2020-04-23 22:14:26 -0700 Committed r260620: <https://trac.webkit.org/changeset/260620> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397419. 1645087 5 webkit-bug-importer 2020-04-23 22:15:19 -0700 <rdar://problem/62281561> 397418 2020-04-23 20:49:08 -0700 2020-04-23 20:52:39 -0700 Patch bug-210931-20200423204906.patch text/plain 2406 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTUzZTY1NjU1YWMyNTMyNWNhNzJlODRhYTFlZTQ2YTZj MGY4YTAwNS4uOTdlOGNjMmQzY2QyMzFlZGE4MzkzYzMzOTRmMjg5OTJlZGU4M2QxZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA0LTIzICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAg ICAgICAgc3RyZXNzL2Vuc3VyZS1jcmFzaC5qcyBzaG91bGRuJ3Qgc3BldyBzdHVmZiBvbnRvIG15 IHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjEwOTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2V0IG5vaXN5T3V0cHV0SGFuZGxlciB3aGVuIGNyYXNoISBpcyBzcGVjaWZpZWQuIFdlIGFsc28g c3BlY2lmeSBub2lzeU91dHB1dEhhbmRsZXIgZm9yIHJ1bkNvbXBsZXhUZXN0LgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRydWJ5L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItZGVmYXVsdC5yYjoK KwogMjAyMC0wNC0yMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIERpc2FibGUgdXNlS2VyblRDU009ZmFsc2UgZm9yIEpTQyBzdHJlc3MgdGVzdHMgdG8gbWFr ZSBFV1MgZmFzdGVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRl c3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRleCA1ZDBkZmU4MzIx N2IwMDAxODcyNTg2Y2JlZWFiY2I0MGI2Njc5OGZkLi5jOTkwNTRhOGQ0ZDg2ZjdiNzRiZTEwYTMw ZDQ1YWQwZmIyNzJmMTJmIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNz LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKQEAgLTE0MzEs NyArMTQzMSw3IEBAIGRlZiBydW5Db21wbGV4VGVzdChiZWZvcmUsIGFmdGVyLCBhZGRpdGlvbmFs RW52LCAqb3B0aW9ucykKICAgICBwcmVwYXJlRXh0cmFSZWxhdGl2ZUZpbGVzKGJlZm9yZS5tYXB7 fHZ8IChQYXRobmFtZSgiLi4iKSArIHYpLnRvX3N9LCAkY29sbGVjdGlvbikKICAgICBwcmVwYXJl RXh0cmFSZWxhdGl2ZUZpbGVzKGFmdGVyLm1hcHt8dnwgKFBhdGhuYW1lKCIuLiIpICsgdikudG9f c30sICRjb2xsZWN0aW9uKQogICAgIGFyZ3MgPSBbcGF0aFRvVk0udG9fc10gKyBCQVNFX09QVElP TlMgKyAkdGVzdFNwZWNpZmljUmVxdWlyZWRPcHRpb25zICsgb3B0aW9ucyArIGJlZm9yZS5tYXB7 fHZ8IHYudG9fc30gKyBbJGJlbmNobWFyay50b19zXSArIGFmdGVyLm1hcHt8dnwgdi50b19zfQot ICAgIGFkZFJ1bkNvbW1hbmQoImNvbXBsZXgiLCBhcmdzLCBzaWxlbnRPdXRwdXRIYW5kbGVyLCBz aW1wbGVFcnJvckhhbmRsZXIsICphZGRpdGlvbmFsRW52KQorICAgIGFkZFJ1bkNvbW1hbmQoImNv bXBsZXgiLCBhcmdzLCBub2lzeU91dHB1dEhhbmRsZXIsIHNpbXBsZUVycm9ySGFuZGxlciwgKmFk ZGl0aW9uYWxFbnYpCiBlbmQKIAogZGVmIHJ1bk1vemlsbGFUZXN0KGtpbmQsIG1vZGUsIGV4dHJh RmlsZXMsICpvcHRpb25zKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRydWJ5L2pz Yy1zdHJlc3MtdGVzdC13cml0ZXItZGVmYXVsdC5yYiBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVi eS9qc2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLWRlZmF1bHQucmIKaW5kZXggYjA5NjNlN2M5YjVjMWFj YTM4NTc0NDVkZDZiNzRhOWNjM2JmMjk5Yy4uYmUyNTk2ZTUwNTk3NmU0YWVjMGY1MDI2OGJjMTZl NWU0NzQ2NTc5NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRydWJ5L2pzYy1zdHJl c3MtdGVzdC13cml0ZXItZGVmYXVsdC5yYgorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHJ1Ynkv anNjLXN0cmVzcy10ZXN0LXdyaXRlci1kZWZhdWx0LnJiCkBAIC0yMjcsNiArMjI3LDkgQEAgZGVm IGluaXRpYWxpemUoZGlyZWN0b3J5LCBhcmd1bWVudHMsIGZhbWlseSwgbmFtZSwgb3V0cHV0SGFu ZGxlciwgZXJyb3JIYW5kbGVyKQogICAgICAgICBAZXJyb3JIYW5kbGVyID0gZXJyb3JIYW5kbGVy CiAgICAgICAgIEBpc1Nsb3cgPSAhISRydW5Db21tYW5kT3B0aW9uc1s6aXNTbG93XQogICAgICAg ICBAc2hvdWxkQ3Jhc2ggPSAhISRydW5Db21tYW5kT3B0aW9uc1s6c2hvdWxkQ3Jhc2hdCisgICAg ICAgIGlmIEBzaG91bGRDcmFzaAorICAgICAgICAgICAgQG91dHB1dEhhbmRsZXIgPSBub2lzeU91 dHB1dEhhbmRsZXIKKyAgICAgICAgZW5kCiAgICAgICAgIEBhZGRpdGlvbmFsRW52ID0gW10KICAg ICBlbmQKICAgICAK 397419 2020-04-23 20:52:40 -0700 2020-04-23 22:14:26 -0700 Patch bug-210931-20200423205238.patch text/plain 4050 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNjE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTUzZTY1NjU1YWMyNTMyNWNhNzJlODRhYTFlZTQ2YTZj MGY4YTAwNS4uN2ZlOTJjOTM1NzRhZTVhNDQwNzI5ZTk3ODIxNGFkMWJkM2Q4Y2RhZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTA0LTIzICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAg ICAgICAgc3RyZXNzL2Vuc3VyZS1jcmFzaC5qcyBzaG91bGRuJ3Qgc3BldyBzdHVmZiBvbnRvIG15 IHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjEwOTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2V0IG5vaXN5T3V0cHV0SGFuZGxlciB3aGVuIGNyYXNoISBpcyBzcGVjaWZpZWQuIFdlIGFsc28g c3BlY2lmeSBub2lzeU91dHB1dEhhbmRsZXIgZm9yIHJ1bkNvbXBsZXhUZXN0LgorCisgICAgICAg ICogU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0czoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHJ1YnkvanNjLXN0cmVzcy10ZXN0LXdyaXRlci1kZWZhdWx0LnJiOgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cnVieS9qc2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLXBsYXlzdGF0aW9uLnJiOgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cnVieS9qc2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLXJ1YnkucmI6 CisKIDIwMjAtMDQtMjMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAg ICAgICBEaXNhYmxlIHVzZUtlcm5UQ1NNPWZhbHNlIGZvciBKU0Mgc3RyZXNzIHRlc3RzIHRvIG1h a2UgRVdTIGZhc3RlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10 ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKaW5kZXggNWQwZGZlODMy MTdiMDAwMTg3MjU4NmNiZWVhYmNiNDBiNjY3OThmZC4uYzk5MDU0YThkNGQ4NmY3Yjc0YmUxMGEz MGQ0NWFkMGZiMjcyZjEyZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVz cy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCkBAIC0xNDMx LDcgKzE0MzEsNyBAQCBkZWYgcnVuQ29tcGxleFRlc3QoYmVmb3JlLCBhZnRlciwgYWRkaXRpb25h bEVudiwgKm9wdGlvbnMpCiAgICAgcHJlcGFyZUV4dHJhUmVsYXRpdmVGaWxlcyhiZWZvcmUubWFw e3x2fCAoUGF0aG5hbWUoIi4uIikgKyB2KS50b19zfSwgJGNvbGxlY3Rpb24pCiAgICAgcHJlcGFy ZUV4dHJhUmVsYXRpdmVGaWxlcyhhZnRlci5tYXB7fHZ8IChQYXRobmFtZSgiLi4iKSArIHYpLnRv X3N9LCAkY29sbGVjdGlvbikKICAgICBhcmdzID0gW3BhdGhUb1ZNLnRvX3NdICsgQkFTRV9PUFRJ T05TICsgJHRlc3RTcGVjaWZpY1JlcXVpcmVkT3B0aW9ucyArIG9wdGlvbnMgKyBiZWZvcmUubWFw e3x2fCB2LnRvX3N9ICsgWyRiZW5jaG1hcmsudG9fc10gKyBhZnRlci5tYXB7fHZ8IHYudG9fc30K LSAgICBhZGRSdW5Db21tYW5kKCJjb21wbGV4IiwgYXJncywgc2lsZW50T3V0cHV0SGFuZGxlciwg c2ltcGxlRXJyb3JIYW5kbGVyLCAqYWRkaXRpb25hbEVudikKKyAgICBhZGRSdW5Db21tYW5kKCJj b21wbGV4IiwgYXJncywgbm9pc3lPdXRwdXRIYW5kbGVyLCBzaW1wbGVFcnJvckhhbmRsZXIsICph ZGRpdGlvbmFsRW52KQogZW5kCiAKIGRlZiBydW5Nb3ppbGxhVGVzdChraW5kLCBtb2RlLCBleHRy YUZpbGVzLCAqb3B0aW9ucykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVieS9q c2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLWRlZmF1bHQucmIgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHJ1 YnkvanNjLXN0cmVzcy10ZXN0LXdyaXRlci1kZWZhdWx0LnJiCmluZGV4IGIwOTYzZTdjOWI1YzFh Y2EzODU3NDQ1ZGQ2Yjc0YTljYzNiZjI5OWMuLmJlMjU5NmU1MDU5NzZlNGFlYzBmNTAyNjhiYzE2 ZTVlNDc0NjU3OTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVieS9qc2Mtc3Ry ZXNzLXRlc3Qtd3JpdGVyLWRlZmF1bHQucmIKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRydWJ5 L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItZGVmYXVsdC5yYgpAQCAtMjI3LDYgKzIyNyw5IEBAIGRl ZiBpbml0aWFsaXplKGRpcmVjdG9yeSwgYXJndW1lbnRzLCBmYW1pbHksIG5hbWUsIG91dHB1dEhh bmRsZXIsIGVycm9ySGFuZGxlcikKICAgICAgICAgQGVycm9ySGFuZGxlciA9IGVycm9ySGFuZGxl cgogICAgICAgICBAaXNTbG93ID0gISEkcnVuQ29tbWFuZE9wdGlvbnNbOmlzU2xvd10KICAgICAg ICAgQHNob3VsZENyYXNoID0gISEkcnVuQ29tbWFuZE9wdGlvbnNbOnNob3VsZENyYXNoXQorICAg ICAgICBpZiBAc2hvdWxkQ3Jhc2gKKyAgICAgICAgICAgIEBvdXRwdXRIYW5kbGVyID0gbm9pc3lP dXRwdXRIYW5kbGVyCisgICAgICAgIGVuZAogICAgICAgICBAYWRkaXRpb25hbEVudiA9IFtdCiAg ICAgZW5kCiAgICAgCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHJ1YnkvanNjLXN0 cmVzcy10ZXN0LXdyaXRlci1wbGF5c3RhdGlvbi5yYiBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVi eS9qc2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLXBsYXlzdGF0aW9uLnJiCmluZGV4IDg5NjI0ZTQ4ODUy ZmQ5ZjVjNzAxMDM0MWQ0MWQwY2VhMzU0ZjBjMTMuLmI2NGJmZWEwODA5MjdmYTk1Y2U5YjM0M2U5 OTk1NjExOTg5NGFjYzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVieS9qc2Mt c3RyZXNzLXRlc3Qtd3JpdGVyLXBsYXlzdGF0aW9uLnJiCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cnVieS9qc2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLXBsYXlzdGF0aW9uLnJiCkBAIC0yNzMsNiAr MjczLDkgQEAgZGVmIGluaXRpYWxpemUoZGlyZWN0b3J5LCBhcmd1bWVudHMsIGZhbWlseSwgbmFt ZSwgb3V0cHV0SGFuZGxlciwgZXJyb3JIYW5kbGVyKQogICAgICAgICBAZXJyb3JIYW5kbGVyID0g ZXJyb3JIYW5kbGVyCiAgICAgICAgIEBpc1Nsb3cgPSAhISRydW5Db21tYW5kT3B0aW9uc1s6aXNT bG93XQogICAgICAgICBAc2hvdWxkQ3Jhc2ggPSAhISRydW5Db21tYW5kT3B0aW9uc1s6c2hvdWxk Q3Jhc2hdCisgICAgICAgIGlmIEBzaG91bGRDcmFzaAorICAgICAgICAgICAgQG91dHB1dEhhbmRs ZXIgPSBub2lzeU91dHB1dEhhbmRsZXIKKyAgICAgICAgZW5kCiAgICAgICAgIEBhZGRpdGlvbmFs RW52ID0gW10KICAgICBlbmQKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRydWJ5 L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItcnVieS5yYiBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVi eS9qc2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLXJ1YnkucmIKaW5kZXggZTIxZTZiNGNiMTYxNmVkZDQ4 OGE2YWEwM2U3YmMzMWI5NmUyYWFlYi4uN2RiNjE5MDhlZjY0OWI5ZmFlNzQ1ZDEzOTRlMzY2YjA1 YWEwNGFlZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRydWJ5L2pzYy1zdHJlc3Mt dGVzdC13cml0ZXItcnVieS5yYgorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHJ1YnkvanNjLXN0 cmVzcy10ZXN0LXdyaXRlci1ydWJ5LnJiCkBAIC0yNzMsNiArMjczLDkgQEAgZGVmIGluaXRpYWxp emUoZGlyZWN0b3J5LCBhcmd1bWVudHMsIGZhbWlseSwgbmFtZSwgb3V0cHV0SGFuZGxlciwgZXJy b3JIYW5kbGVyKQogICAgICAgICBAZXJyb3JIYW5kbGVyID0gZXJyb3JIYW5kbGVyCiAgICAgICAg IEBpc1Nsb3cgPSAhISRydW5Db21tYW5kT3B0aW9uc1s6aXNTbG93XQogICAgICAgICBAc2hvdWxk Q3Jhc2ggPSAhISRydW5Db21tYW5kT3B0aW9uc1s6c2hvdWxkQ3Jhc2hdCisgICAgICAgIGlmIEBz aG91bGRDcmFzaAorICAgICAgICAgICAgQG91dHB1dEhhbmRsZXIgPSBub2lzeU91dHB1dEhhbmRs ZXIKKyAgICAgICAgZW5kCiAgICAgICAgIEBhZGRpdGlvbmFsRW52ID0gW10KICAgICBlbmQKICAg ICAK