210930 2020-04-23 12:03:48 -0700 Web Inspector: REGRESSION: Elements: Styles: color functions are missing swatches 2020-04-23 15:17:08 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1644892 0 hi 2020-04-23 12:03:48 -0700 # STEPS TO REPRODUCE 1. inspect any page with an `hsl`, `hsla`, `rgb`, `rgba`, or `color` function 2. view that style in the Styles panel of the details sidebar in the Elements Tab => no swatch :( 1644894 1 397372 hi 2020-04-23 12:06:09 -0700 Created attachment 397372 Patch 1644908 2 397372 bburg 2020-04-23 12:28:26 -0700 Comment on attachment 397372 Patch r=me 1644926 3 ews-feeder 2020-04-23 12:49:55 -0700 Committed r260590: <https://trac.webkit.org/changeset/260590> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397372. 1644980 4 webkit-bug-importer 2020-04-23 15:17:08 -0700 <rdar://problem/62265484> 1644981 5 webkit-bug-importer 2020-04-23 15:17:08 -0700 <rdar://problem/62265485> 397372 2020-04-23 12:06:09 -0700 2020-04-23 12:49:55 -0700 Patch bug-210930-20200423130608.patch text/plain 6479 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc3MzExN2Y1NDYyYzdmMmE1MDc0ZWVhNjRmYTE2 ODdiMGMwYTE0M2UuLmNjOWYxZjQ3YjUwZTk4YmEzMGIwNGI4ODQzZjg5Y2NkMDVkZWUwODAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA0LTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBFbGVtZW50czogU3R5bGVzOiBjb2xvciBmdW5jdGlvbnMgYXJlIG1pc3Npbmcg c3dhdGNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMDkzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkuanM6CisgICAg ICAgIChXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkucHJvdG90eXBlLl9yZXBsYWNlU3BlY2lh bFRva2Vucyk6CisgICAgICAgIChXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkucHJvdG90eXBl Ll9hZGRHcmFkaWVudFRva2Vucyk6CisgICAgICAgIChXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVy dHkucHJvdG90eXBlLl9hZGRDb2xvclRva2Vucyk6CisgICAgICAgIChXSS5TcHJlYWRzaGVldFN0 eWxlUHJvcGVydHkucHJvdG90eXBlLl9hZGRUaW1pbmdGdW5jdGlvblRva2Vucyk6CisgICAgICAg IChXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkucHJvdG90eXBlLl9hZGRCb3hTaGFkb3dUb2tl bnMpOgorICAgICAgICAoV0kuU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5LnByb3RvdHlwZS5fYWRk VmFyaWFibGVUb2tlbnMpOgorICAgICAgICBPbmx5IGF0dGVtcHQgdG8gYFdJLkNvbG9yLmZyb21T dHJpbmdgIHdoZW4gYXQgYSAiKSIgdGhhdCBpcyBub3QgcGFydCBvZiBhbm90aGVyIGZ1bmN0aW9u LgorICAgICAgICBEcml2ZS1ieTogYWRkIHZhcmlhYmxlIHRva2VucyBhZnRlciB2YXJpYWJsZSB0 ZXh0IGlzIHJlc29sdmVkLCBhcyBvdGhlcndpc2UgdGhlIHZhcmlhYmxlIGlzCisgICAgICAgICAg ICAgICAgICByZXBsYWNlZCB3aXRoIGEgYFdJLklubGluZVN3YXRjaGAsIHdoaWNoIHJlcGxhY2Vz IHRoZSBvcmlnaW5hbCB0ZXh0LCBwcmV2ZW50aW5nIGl0CisgICAgICAgICAgICAgICAgICBmcm9t IGJlaW5nIHVzZWQgZm9yIGxvb2tpbmcgdXAgdGhlIHZhcmlhYmxlIG5hbWUuCisKIDIwMjAtMDQt MjIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFN0b3JhZ2U6IHVuYWJsZSB0byBmaWx0ZXIgY29va2llcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRTdHlsZVBy b3BlcnR5LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3By ZWFkc2hlZXRTdHlsZVByb3BlcnR5LmpzCmluZGV4IDJhYWFjNGZlMDdjNjljOWIzZDkwMmZiNjky MThiZjE2MTdmZjM1YTYuLjY0NDBhY2ZhNmI5ZDQ2M2MyNmE0ODJjMjc3M2VhNDAxNTI0ZTE2Mjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Nw cmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkuanMKQEAgLTU1NSw4ICs1 NTUsNiBAQCBXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgPSBjbGFzcyBTcHJlYWRzaGVldFN0 eWxlUHJvcGVydHkgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgaWYgKHRoaXMuX3Byb3BlcnR5 Lm5hbWUgPT09ICJib3gtc2hhZG93IikKICAgICAgICAgICAgIHJldHVybiB0aGlzLl9hZGRCb3hT aGFkb3dUb2tlbnModG9rZW5zKTsKIAotICAgICAgICB0b2tlbnMgPSB0aGlzLl9hZGRWYXJpYWJs ZVRva2Vucyh0b2tlbnMpOwotCiAgICAgICAgIGlmICh0aGlzLl9wcm9wZXJ0eS5pc1ZhcmlhYmxl IHx8IFdJLkNTU0tleXdvcmRDb21wbGV0aW9ucy5pc0NvbG9yQXdhcmVQcm9wZXJ0eSh0aGlzLl9w cm9wZXJ0eS5uYW1lKSkgewogICAgICAgICAgICAgdG9rZW5zID0gdGhpcy5fYWRkR3JhZGllbnRU b2tlbnModG9rZW5zKTsKICAgICAgICAgICAgIHRva2VucyA9IHRoaXMuX2FkZENvbG9yVG9rZW5z KHRva2Vucyk7CkBAIC01NjcsNiArNTY1LDggQEAgV0kuU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5 ID0gY2xhc3MgU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAg ICAgICAgICB0b2tlbnMgPSB0aGlzLl9hZGRUaW1pbmdGdW5jdGlvblRva2Vucyh0b2tlbnMsICJz cHJpbmciKTsKICAgICAgICAgfQogCisgICAgICAgIHRva2VucyA9IHRoaXMuX2FkZFZhcmlhYmxl VG9rZW5zKHRva2Vucyk7CisKICAgICAgICAgcmV0dXJuIHRva2VuczsKICAgICB9CiAKQEAgLTU5 Miw3ICs1OTIsMTAgQEAgV0kuU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5ID0gY2xhc3MgU3ByZWFk c2hlZXRTdHlsZVByb3BlcnR5IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICAgICAgfQog CiAgICAgICAgICAgICAgICAgbGV0IHJhd1Rva2VucyA9IHRva2Vucy5zbGljZShncmFkaWVudFN0 YXJ0SW5kZXgsIGkgKyAxKTsKKwogICAgICAgICAgICAgICAgIGxldCB0ZXh0ID0gdGhpcy5fcmVz b2x2ZVZhcmlhYmxlcyhyYXdUb2tlbnMubWFwKCh0b2tlbikgPT4gdG9rZW4udmFsdWUpLmpvaW4o IiIpKTsKKyAgICAgICAgICAgICAgICByYXdUb2tlbnMgPSB0aGlzLl9hZGRWYXJpYWJsZVRva2Vu cyhyYXdUb2tlbnMpOworCiAgICAgICAgICAgICAgICAgbGV0IGdyYWRpZW50ID0gV0kuR3JhZGll bnQuZnJvbVN0cmluZyh0ZXh0KTsKICAgICAgICAgICAgICAgICBpZiAoZ3JhZGllbnQpCiAgICAg ICAgICAgICAgICAgICAgIG5ld1Rva2Vucy5wdXNoKHRoaXMuX2NyZWF0ZUlubGluZVN3YXRjaChX SS5JbmxpbmVTd2F0Y2guVHlwZS5HcmFkaWVudCwgcmF3VG9rZW5zLCBncmFkaWVudCkpOwpAQCAt NjM5LDE2ICs2NDIsMTcgQEAgV0kuU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5ID0gY2xhc3MgU3By ZWFkc2hlZXRTdHlsZVByb3BlcnR5IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgICAgIGlmICh0 b2tlbi52YWx1ZSA9PT0gIikiKSB7Ci0gICAgICAgICAgICAgICAgICAgIC0tb3BlblBhcmVudGhl c2VzOwotICAgICAgICAgICAgICAgICAgICBpZiAob3BlblBhcmVudGhlc2VzKQotICAgICAgICAg ICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAgfQorICAgICAgICAgICAg ICAgIGlmICh0b2tlbi52YWx1ZSAhPT0gIikiKQorICAgICAgICAgICAgICAgICAgICBjb250aW51 ZTsKIAotICAgICAgICAgICAgICAgIC8vIENvbG9yIEZ1bmN0aW9uIGVuZAorICAgICAgICAgICAg ICAgIGlmICgtLW9wZW5QYXJlbnRoZXNlcykKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7 CiAKICAgICAgICAgICAgICAgICBsZXQgcmF3VG9rZW5zID0gdG9rZW5zLnNsaWNlKGNvbG9yRnVu Y3Rpb25TdGFydEluZGV4LCBpICsgMSk7CisKICAgICAgICAgICAgICAgICBsZXQgdGV4dCA9IHRo aXMuX3Jlc29sdmVWYXJpYWJsZXMocmF3VG9rZW5zLm1hcCgodG9rZW4pID0+IHRva2VuLnZhbHVl KS5qb2luKCIiKSk7CisgICAgICAgICAgICAgICAgcmF3VG9rZW5zID0gdGhpcy5fYWRkVmFyaWFi bGVUb2tlbnMocmF3VG9rZW5zKTsKKwogICAgICAgICAgICAgICAgIHB1c2hQb3NzaWJsZUNvbG9y VG9rZW4odGV4dCwgLi4ucmF3VG9rZW5zKTsKICAgICAgICAgICAgICAgICBjb2xvckZ1bmN0aW9u U3RhcnRJbmRleCA9IE5hTjsKICAgICAgICAgICAgIH0gZWxzZQpAQCAtNjc4LDcgKzY4Miw5IEBA IFdJLlNwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eSA9IGNsYXNzIFNwcmVhZHNoZWV0U3R5bGVQcm9w ZXJ0eSBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKIAog ICAgICAgICAgICAgICAgIGxldCByYXdUb2tlbnMgPSB0b2tlbnMuc2xpY2Uoc3RhcnRJbmRleCwg aSArIDEpOworCiAgICAgICAgICAgICAgICAgbGV0IHRleHQgPSB0aGlzLl9yZXNvbHZlVmFyaWFi bGVzKHJhd1Rva2Vucy5tYXAoKHRva2VuKSA9PiB0b2tlbi52YWx1ZSkuam9pbigiIikpOworICAg ICAgICAgICAgICAgIHJhd1Rva2VucyA9IHRoaXMuX2FkZFZhcmlhYmxlVG9rZW5zKHJhd1Rva2Vu cyk7CiAKICAgICAgICAgICAgICAgICBsZXQgdmFsdWVPYmplY3Q7CiAgICAgICAgICAgICAgICAg bGV0IGlubGluZVN3YXRjaFR5cGU7CkBAIC03MzEsNiArNzM3LDggQEAgV0kuU3ByZWFkc2hlZXRT dHlsZVByb3BlcnR5ID0gY2xhc3MgU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5IGV4dGVuZHMgV0ku T2JqZWN0CiAgICAgICAgICAgICAgICAgbmV3VG9rZW5zLnB1c2hBbGwocmF3VG9rZW5zLnNsaWNl KDAsIGZpcnN0Tm9uV2hpdGVzcGFjZUluZGV4KSk7CiAKICAgICAgICAgICAgICAgICBsZXQgdGV4 dCA9IHRoaXMuX3Jlc29sdmVWYXJpYWJsZXMobm9uV2hpdGVzcGFjZVRva2Vucy5tYXAoKHJhd1Rv a2VuKSA9PiByYXdUb2tlbi52YWx1ZSkuam9pbigiIikpOworICAgICAgICAgICAgICAgIG5vbldo aXRlc3BhY2VUb2tlbnMgPSB0aGlzLl9hZGRWYXJpYWJsZVRva2Vucyhub25XaGl0ZXNwYWNlVG9r ZW5zKTsKKwogICAgICAgICAgICAgICAgIGxldCBib3hTaGFkb3cgPSBXSS5Cb3hTaGFkb3cuZnJv bVN0cmluZyh0ZXh0KTsKICAgICAgICAgICAgICAgICBpZiAoYm94U2hhZG93KQogICAgICAgICAg ICAgICAgICAgICBuZXdUb2tlbnMucHVzaCh0aGlzLl9jcmVhdGVJbmxpbmVTd2F0Y2goV0kuSW5s aW5lU3dhdGNoLlR5cGUuQm94U2hhZG93LCBub25XaGl0ZXNwYWNlVG9rZW5zLCBib3hTaGFkb3cp KTsKQEAgLTgwMyw3ICs4MTEsMTUgQEAgV0kuU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5ID0gY2xh c3MgU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAg ICAgICAgICAgIGxldCBmYWxsYmFja1N0YXJ0SW5kZXggPSByYXdUb2tlbnMuZmluZEluZGV4KCh2 YWx1ZSwgaSkgPT4gaSA+IHZhcmlhYmxlTmFtZUluZGV4ICsgMSAmJiAvXGJtLWNzc1xiLy50ZXN0 KHZhbHVlLnR5cGUpKTsKICAgICAgICAgICAgICAgICAgICAgaWYgKGZhbGxiYWNrU3RhcnRJbmRl eCAhPT0gLTEpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRlbnRzLnB1c2hBbGwocmF3 VG9rZW5zLnNsaWNlKHZhcmlhYmxlTmFtZUluZGV4ICsgMSwgZmFsbGJhY2tTdGFydEluZGV4KSk7 Ci0gICAgICAgICAgICAgICAgICAgICAgICBjb250ZW50cy5wdXNoQWxsKHRoaXMuX3JlcGxhY2VT cGVjaWFsVG9rZW5zKHJhd1Rva2Vucy5zbGljZShmYWxsYmFja1N0YXJ0SW5kZXgsIGkpKSk7CisK KyAgICAgICAgICAgICAgICAgICAgICAgIGxldCBmYWxsYmFja1Rva2VucyA9IHJhd1Rva2Vucy5z bGljZShmYWxsYmFja1N0YXJ0SW5kZXgsIGkpOworICAgICAgICAgICAgICAgICAgICAgICAgZmFs bGJhY2tUb2tlbnMgPSB0aGlzLl9hZGRCb3hTaGFkb3dUb2tlbnMoZmFsbGJhY2tUb2tlbnMpOwor ICAgICAgICAgICAgICAgICAgICAgICAgZmFsbGJhY2tUb2tlbnMgPSB0aGlzLl9hZGRHcmFkaWVu dFRva2VucyhmYWxsYmFja1Rva2Vucyk7CisgICAgICAgICAgICAgICAgICAgICAgICBmYWxsYmFj a1Rva2VucyA9IHRoaXMuX2FkZENvbG9yVG9rZW5zKGZhbGxiYWNrVG9rZW5zKTsKKyAgICAgICAg ICAgICAgICAgICAgICAgIGZhbGxiYWNrVG9rZW5zID0gdGhpcy5fYWRkVGltaW5nRnVuY3Rpb25U b2tlbnMoZmFsbGJhY2tUb2tlbnMsICJjdWJpYy1iZXppZXIiKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGZhbGxiYWNrVG9rZW5zID0gdGhpcy5fYWRkVGltaW5nRnVuY3Rpb25Ub2tlbnMoZmFs bGJhY2tUb2tlbnMsICJzcHJpbmciKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGZhbGxiYWNr VG9rZW5zID0gdGhpcy5fYWRkVmFyaWFibGVUb2tlbnMoZmFsbGJhY2tUb2tlbnMpOworICAgICAg ICAgICAgICAgICAgICAgICAgY29udGVudHMucHVzaEFsbChmYWxsYmFja1Rva2Vucyk7CiAgICAg ICAgICAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAgICAgICAgICAgY29udGVudHMu cHVzaEFsbChyYXdUb2tlbnMuc2xpY2UodmFyaWFibGVOYW1lSW5kZXggKyAxLCBpKSk7CiAgICAg ICAgICAgICAgICAgICAgIGNvbnRlbnRzLnB1c2godG9rZW4pOwo=