210914 2020-04-23 08:26:12 -0700 Correction for patch 397001. 2020-04-23 10:47:58 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1644774 0 andresg_22 2020-04-23 08:26:12 -0700 Correction for patch 397001. 1644778 1 397344 andresg_22 2020-04-23 08:35:01 -0700 Created attachment 397344 Patch 1644791 2 ews-feeder 2020-04-23 09:12:09 -0700 Committed r260573: <https://trac.webkit.org/changeset/260573> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397344. 1644792 3 webkit-bug-importer 2020-04-23 09:13:16 -0700 <rdar://problem/62248776> 1644851 4 397344 darin 2020-04-23 10:47:58 -0700 Comment on attachment 397344 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397344&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2289 > + AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attributeName)); makeString is more efficient than making two String objects and then calling +; allocates 1 String instead 3 > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3872 > + AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attribute)); Ditto. > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4477 > + AXTRACE(String("WebAccessibilityObjectWrapper accessibilityArrayAttributeValue:") + String(attribute)); Ditto. 397344 2020-04-23 08:35:01 -0700 2020-04-23 09:12:09 -0700 Patch bug-210914-20200423113500.patch text/plain 4017 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ2Y2NkOWJmNTYzMDBj YjkzZDk2NWI4NDg0ODA1MDQ1ZTcyY2E0ZS4uZmU3YWYxMTc2YzEwNjc1MDdiY2EzYWJlYTFmNDZh MjZmNTM4NTEwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA0LTIzICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBDb3JyZWN0aW9u IGZvciBwYXRjaCAzOTcwMDEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTA5MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAtIE5vIG5lZWQgdG8gY2hlY2sgZm9yIGlzRW1wdHkgd2hlbiByZXRyaWV2aW5n IHRoZSBwcmltYXJ5IHNjcmVlbiBzaXplLAorICAgICAgICBhcyBwb2ludGVkIG91dCBieSBEYXJp biBBZGxlciBpbiBidWcgMjEwNzYwLCBwYXRjaCAzOTcwMDEuCisgICAgICAgIC0gQWRkZWQgc29t ZSBoZWxwZnVsIEFYTE9HaW5nLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNj ZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyIHByaW1hcnlTY3JlZW5IZWlnaHRdKToKKyAgICAgICAgKC1bV2ViQWNj ZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOl0pOgor ICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhY2Nlc3NpYmlsaXR5QXR0 cmlidXRlVmFsdWU6Zm9yUGFyYW1ldGVyOl0pOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlciBhY2Nlc3NpYmlsaXR5QXJyYXlBdHRyaWJ1dGVWYWx1ZXM6aW5kZXg6bWF4 Q291bnQ6XSk6CisKIDIwMjAtMDQtMjMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIGdldERpc3BsYXlNZWRpYSBpcyBub3QgcmVzcGVjdGluZyBhc3BlY3QgcmF0 aW8gd2l0aCBtYXggY29uc3RyYWludHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJN YWMubW0KaW5kZXggYzdiNjVkMTYwODlhNWVlMjUzNmFiNDlmMjY4OGZiYzc2MDZhYjAwYS4uZjFi OGFkYjRhYWFjZjE4YmFhZjFhYTliNmQ3NGFiOTViYWNmZWYwMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJN YWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJp bGl0eU9iamVjdFdyYXBwZXJNYWMubW0KQEAgLTMxLDYgKzMxLDcgQEAKIAogI2lmIEVOQUJMRShB Q0NFU1NJQklMSVRZKSAmJiBQTEFURk9STShNQUMpCiAKKyNpbXBvcnQgIkFYTG9nZ2VyLmgiCiAj aW1wb3J0ICJBWE9iamVjdENhY2hlLmgiCiAjaW1wb3J0ICJBY2Nlc3NpYmlsaXR5QVJJQUdyaWRS b3cuaCIKICNpbXBvcnQgIkFjY2Vzc2liaWxpdHlMYWJlbC5oIgpAQCAtMTk0NCwxMiArMTk0NSw5 IEBAIHN0YXRpYyB2b2lkIFdlYlRyYW5zZm9ybUNHUGF0aFRvTlNCZXppZXJQYXRoKHZvaWQqIGlu Zm8sIGNvbnN0IENHUGF0aEVsZW1lbnQgKmVsCiB7CiAgICAgLy8gVGhlIHJlY3QgZm9yIHByaW1h cnkgc2NyZWVuIHNob3VsZCBub3QgY2hhbmdlIGluIG5vcm1hbCB1c2UuIFNvIGNhY2hlIGl0CiAg ICAgLy8gaGVyZSB0byBhdm9pZCBoaXR0aW5nIHRoZSBtYWluIHRocmVhZCByZXBlYXRlZGx5Lgot ICAgIHN0YXRpYyBGbG9hdFJlY3Qgc2NyZWVuUmVjdDsKLSAgICBpZiAoc2NyZWVuUmVjdC5pc0Vt cHR5KCkpIHsKLSAgICAgICAgc2NyZWVuUmVjdCA9IEFjY2Vzc2liaWxpdHk6OnJldHJpZXZlVmFs dWVGcm9tTWFpblRocmVhZDxGbG9hdFJlY3Q+KFtdICgpIC0+IEZsb2F0UmVjdCB7Ci0gICAgICAg ICAgICByZXR1cm4gc2NyZWVuUmVjdEZvclByaW1hcnlTY3JlZW4oKTsKLSAgICAgICAgfSk7Ci0g ICAgfQorICAgIHN0YXRpYyBGbG9hdFJlY3Qgc2NyZWVuUmVjdCA9IEFjY2Vzc2liaWxpdHk6OnJl dHJpZXZlVmFsdWVGcm9tTWFpblRocmVhZDxGbG9hdFJlY3Q+KFtdICgpIC0+IEZsb2F0UmVjdCB7 CisgICAgICAgIHJldHVybiBzY3JlZW5SZWN0Rm9yUHJpbWFyeVNjcmVlbigpOworICAgIH0pOwog ICAgIHJldHVybiBbTlNOdW1iZXIgbnVtYmVyV2l0aEZsb2F0OnNjcmVlblJlY3QuaGVpZ2h0KCld OwogfQogCkBAIC0yMjg4LDEyICsyMjg2LDE4IEBAIEFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5U QVRJT05TX0JFR0lOCiAtIChpZClhY2Nlc3NpYmlsaXR5QXR0cmlidXRlVmFsdWU6KE5TU3RyaW5n KilhdHRyaWJ1dGVOYW1lCiBBTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKIHsK KyAgICBBWFRSQUNFKFN0cmluZygiV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNz aWJpbGl0eUF0dHJpYnV0ZVZhbHVlOiIpICsgU3RyaW5nKGF0dHJpYnV0ZU5hbWUpKTsKICAgICBh dXRvKiBiYWNraW5nT2JqZWN0ID0gc2VsZi51cGRhdGVPYmplY3RCYWNraW5nU3RvcmU7Ci0gICAg aWYgKCFiYWNraW5nT2JqZWN0KQorICAgIGlmICghYmFja2luZ09iamVjdCkgeworICAgICAgICBB WExPRygiTm8gYmFja2luZ09iamVjdCEhISIpOwogICAgICAgICByZXR1cm4gbmlsOworICAgIH0K KyAgICBBWExPRygqYmFja2luZ09iamVjdCk7CiAKLSAgICBpZiAoYmFja2luZ09iamVjdC0+aXNE ZXRhY2hlZEZyb21QYXJlbnQoKSkKKyAgICBpZiAoYmFja2luZ09iamVjdC0+aXNEZXRhY2hlZEZy b21QYXJlbnQoKSkgeworICAgICAgICBBWExPRygiYmFja2luZ09iamVjdCBpcyBkZXRhY2hlZCBm cm9tIHBhcmVudCEhISIpOwogICAgICAgICByZXR1cm4gbmlsOworICAgIH0KIAogICAgIGlmIChb YXR0cmlidXRlTmFtZSBpc0VxdWFsVG9TdHJpbmc6IE5TQWNjZXNzaWJpbGl0eVJvbGVBdHRyaWJ1 dGVdKQogICAgICAgICByZXR1cm4gW3NlbGYgcm9sZV07CkBAIC0zODY1LDYgKzM4NjksNyBAQCBB TExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19CRUdJTgogLSAoaWQpYWNjZXNzaWJpbGl0 eUF0dHJpYnV0ZVZhbHVlOihOU1N0cmluZyopYXR0cmlidXRlIGZvclBhcmFtZXRlcjooaWQpcGFy YW1ldGVyCiBBTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKIHsKKyAgICBBWFRS QUNFKFN0cmluZygiV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eUF0 dHJpYnV0ZVZhbHVlOiIpICsgU3RyaW5nKGF0dHJpYnV0ZSkpOwogICAgIGF1dG8qIGJhY2tpbmdP YmplY3QgPSBzZWxmLnVwZGF0ZU9iamVjdEJhY2tpbmdTdG9yZTsKICAgICBpZiAoIWJhY2tpbmdP YmplY3QpCiAgICAgICAgIHJldHVybiBuaWw7CkBAIC00NDY5LDYgKzQ0NzQsNyBAQCBBTExPV19E RVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKIAogLSAoTlNBcnJheSAqKWFjY2Vzc2liaWxpdHlB cnJheUF0dHJpYnV0ZVZhbHVlczooTlNTdHJpbmcgKilhdHRyaWJ1dGUgaW5kZXg6KE5TVUludGVn ZXIpaW5kZXggbWF4Q291bnQ6KE5TVUludGVnZXIpbWF4Q291bnQKIHsKKyAgICBBWFRSQUNFKFN0 cmluZygiV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eUFycmF5QXR0 cmlidXRlVmFsdWU6IikgKyBTdHJpbmcoYXR0cmlidXRlKSk7CiAgICAgYXV0byogYmFja2luZ09i amVjdCA9IHNlbGYudXBkYXRlT2JqZWN0QmFja2luZ1N0b3JlOwogICAgIGlmICghYmFja2luZ09i amVjdCkKICAgICAgICAgcmV0dXJuIG5pbDsK