210911 2020-04-23 06:21:06 -0700 Nullptr crash in objc_msgSend under WebCore::genericFamily 2020-04-24 23:55:36 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned andersca darin ggaren mmaxfield oldest_to_newest 1644748 0 koivisto 2020-04-23 06:21:06 -0700 Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x0000000000000018) [ 0] 0x00007fff6fffbc1d libobjc.A.dylib`objc_msgSend + 29 0x00007fff6fffbc0a: jne 0x5c83 ; <+131> 0x00007fff6fffbc0d: movabsq $0x7ffffffffff8, %r10 0x00007fff6fffbc17: andq (%rdi), %r10 0x00007fff6fffbc1a: movq %rsi, %r11 -> 0x00007fff6fffbc1d: andl 0x18(%r10), %r11d 0x00007fff6fffbc21: shlq $0x4, %r11 0x00007fff6fffbc25: addq 0x10(%r10), %r11 0x00007fff6fffbc29: cmpq (%r11), %rsi 0x00007fff6fffbc2c: jne 0x5c38 ; <+56> [ 1] 0x00007fff2f697d01 JavaScriptCore`WTF::String::String(__CFString const*) + 49 at StringCF.cpp:36:20 32 { 33 if (!str) 34 return; 35 -> 36 CFIndex size = CFStringGetLength(str); 37 if (size == 0) 38 m_impl = StringImpl::empty(); 39 else { 40 Vector<LChar, 1024> lcharBuffer(size); [ 2] 0x00007fff3cc506e3 WebCore`WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*) [inlined] void WTF::GenericHashTraits<WTF::String>::assignToEmpty<WTF::String, __CFString const*>(WTF::String&, __CFString const*&&) + 7 at HashTraits.h:72:22 [ 2] 0x00007fff3cc506dc WebCore`WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*) [inlined] void WTF::HashMapEnsureTranslator<WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::StringHash>::translate<WTF::KeyValuePair<WTF::String, WTF::String>, WTF::String const&, WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3>(WTF::KeyValuePair<WTF::String, WTF::String>&, WTF::String const&, WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3&&) + 144 at HashMap.h:220 [ 2] 0x00007fff3cc5064c WebCore`WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*) [inlined] WTF::HashTableAddResult<WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, WTF::String>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, WTF::String> >, WTF::StringHash, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> > > WTF::HashTable<WTF::String, WTF::KeyValuePair<WTF::String, WTF::String>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, WTF::String> >, WTF::StringHash, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> >::add<WTF::HashMapEnsureTranslator<WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::StringHash>, WTF::String const&, WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3>(WTF::String const&, WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3&&) + 268 at HashTable.h:994 [ 2] 0x00007fff3cc50540 WebCore`WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*) [inlined] WTF::HashTableAddResult<WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, WTF::String>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, WTF::String> >, WTF::StringHash, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> > > WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::inlineEnsure<WTF::String const&, WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3>(WTF::String const&, WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3&&) at HashMap.h:367 [ 2] 0x00007fff3cc50540 WebCore`WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*) [inlined] WTF::HashTableAddResult<WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, WTF::String>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, WTF::String> >, WTF::StringHash, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::KeyValuePairTraits, WTF::HashTraits<WTF::String> > > WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::ensure<WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3>(WTF::String const&, WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*)::$_3&&) at HashMap.h:423 [ 2] 0x00007fff3cc50540 WebCore`WebCore::genericFamily(WTF::String const&, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >&, __CFString const*) + 32 at SystemFontDatabaseCoreText.cpp:251 [ 3] 0x00007fff3cc4da08 WebCore`WebCore::FontDescription::platformResolveGenericFamily(UScriptCode, WTF::AtomString const&, WTF::AtomString const&) + 408 at SystemFontDatabaseCoreText.cpp:0:12 [ 4] 0x00007fff3c414406 WebCore`WebCore::CSSFontSelector::fontRangesForFamily(WebCore::FontDescription const&, WTF::AtomString const&)::$_1::operator()() const [inlined] WebCore::resolveGenericFamily(WebCore::Document*, WebCore::FontDescription const&, WTF::AtomString const&) + 24 at CSSFontSelector.cpp:266:27 [ 4] 0x00007fff3c4143ee WebCore`WebCore::CSSFontSelector::fontRangesForFamily(WebCore::FontDescription const&, WTF::AtomString const&)::$_1::operator()() const + 46 at CSSFontSelector.cpp:306 [ 5] 0x00007fff3c414179 WebCore`WebCore::CSSFontSelector::fontRangesForFamily(WebCore::FontDescription const&, WTF::AtomString const&) + 281 at CSSFontSelector.cpp:322:9 [ 6] 0x00007fff3cbd1392 WebCore`WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) [inlined] WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0::operator()(WTF::AtomString const&) const + 62 at FontCascadeFonts.cpp:149:45 [ 6] 0x00007fff3cbd1354 WebCore`WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) [inlined] WTF::__multi_visitor_return_type<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const>::__type WTF::__visit_helper<0ul, WTF::__index_sequence<0l> >::__visit<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const>(WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>&, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&) at Variant.h:1903 [ 6] 0x00007fff3cbd1354 WebCore`WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) [inlined] WTF::__multi_visitor_return_type<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>::__type WTF::__visit_helper2<0l, 1ul>::__visit<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>(WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>&, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&) at Variant.h:1939 [ 6] 0x00007fff3cbd1354 WebCore`WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) [inlined] WTF::__multi_visitor_return_type<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>::__type WTF::__visit_helper2<1l, 1ul>::__visit<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>(WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>&, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&) at Variant.h:1940 [ 6] 0x00007fff3cbd1354 WebCore`WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) [inlined] WTF::__multi_visitor_return_type<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>::__type WTF::__visit_helper<1ul, WTF::__index_sequence<> >::__visit<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>(WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>&, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&) at Variant.h:1977 [ 6] 0x00007fff3cbd1354 WebCore`WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) [inlined] WTF::__multi_visitor_return_type<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>&, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>::__type WTF::visit<WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>&, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&>(WTF::Visitor<WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_0, WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)::$_1>&, WTF::Variant<WTF::AtomString, WebCore::FontFamilySpecificationCoreText> const&) at Variant.h:1989 [ 6] 0x00007fff3cbd1354 WebCore`WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) + 180 at FontCascadeFonts.cpp:160 [ 7] 0x00007fff3cbd0d8c WebCore`WebCore::FontCascadeFonts::realizeFallbackRangesAt(WebCore::FontCascadeDescription const&, unsigned int) + 668 at FontCascadeFonts.cpp:186:22 [ 8] 0x00007fff3b5420cf WebCore`WebCore::FontCascadeFonts::primaryFont(WebCore::FontCascadeDescription const&) + 47 at FontCascadeFonts.h:130:31 [ 9] 0x00007fff3c436dd3 WebCore`WebCore::CSSPrimitiveValue::equalForLengthResolution(WebCore::RenderStyle const&, WebCore::RenderStyle const&) [inlined] WebCore::FontCascade::primaryFont() const + 4 at FontCascade.h:339:21 [ 9] 0x00007fff3c436dcf WebCore`WebCore::CSSPrimitiveValue::equalForLengthResolution(WebCore::RenderStyle const&, WebCore::RenderStyle const&) [inlined] WebCore::FontCascade::fontMetrics() const at FontCascade.h:151 1644749 1 koivisto 2020-04-23 06:21:20 -0700 <rdar://problem/61510208> 1644750 2 397335 koivisto 2020-04-23 06:28:04 -0700 Created attachment 397335 patch 1644976 3 397335 andersca 2020-04-23 14:53:22 -0700 Comment on attachment 397335 patch View in context: https://bugs.webkit.org/attachment.cgi?id=397335&action=review > Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:253 > + auto value = adoptCF(CTFontDescriptorCopyAttribute(descriptor.get(), kCTFontFamilyNameAttribute)); Can use dynamic_cf_cast here. https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/cf/TypeCastsCF.h 1645017 4 397335 darin 2020-04-23 17:04:05 -0700 Comment on attachment 397335 patch View in context: https://bugs.webkit.org/attachment.cgi?id=397335&action=review >> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:253 >> + auto value = adoptCF(CTFontDescriptorCopyAttribute(descriptor.get(), kCTFontFamilyNameAttribute)); > > Can use dynamic_cf_cast here. > > https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/cf/TypeCastsCF.h Or checked_cf_cast, since we know what the type is supposed to be 1645032 5 andersca 2020-04-23 17:50:47 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 397335 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397335&action=review > > >> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:253 > >> + auto value = adoptCF(CTFontDescriptorCopyAttribute(descriptor.get(), kCTFontFamilyNameAttribute)); > > > > Can use dynamic_cf_cast here. > > > > https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/cf/TypeCastsCF.h > > Or checked_cf_cast, since we know what the type is supposed to be Wouldn't that just cause a different crash though? 1645052 6 397335 darin 2020-04-23 18:34:42 -0700 Comment on attachment 397335 patch View in context: https://bugs.webkit.org/attachment.cgi?id=397335&action=review >>>> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:253 >>>> + auto value = adoptCF(CTFontDescriptorCopyAttribute(descriptor.get(), kCTFontFamilyNameAttribute)); >>> >>> Can use dynamic_cf_cast here. >>> >>> https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/cf/TypeCastsCF.h >> >> Or checked_cf_cast, since we know what the type is supposed to be > > Wouldn't that just cause a different crash though? I’m puzzled about which is correct; if it’s a programming error to have the wrong type, then checked_cf_cast seems with. If it’s not a programming mistake then dynamic_cf_cast is the right thing to use, but asserting is wrong. This patch does ASSERT_NOT_REACHED, so it’s like a third "half bad" case. 1645080 7 397424 koivisto 2020-04-23 21:55:29 -0700 Created attachment 397424 patch 1645200 8 andersca 2020-04-24 08:12:59 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 397335 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397335&action=review > > >>>> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:253 > >>>> + auto value = adoptCF(CTFontDescriptorCopyAttribute(descriptor.get(), kCTFontFamilyNameAttribute)); > >>> > >>> Can use dynamic_cf_cast here. > >>> > >>> https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/cf/TypeCastsCF.h > >> > >> Or checked_cf_cast, since we know what the type is supposed to be > > > > Wouldn't that just cause a different crash though? > > I’m puzzled about which is correct; if it’s a programming error to have the > wrong type, then checked_cf_cast seems with. If it’s not a programming > mistake then dynamic_cf_cast is the right thing to use, but asserting is > wrong. This patch does ASSERT_NOT_REACHED, so it’s like a third "half bad" > case. Good point, I missed the ASSERT_NOT_REACHED in the original patch. 1645202 9 koivisto 2020-04-24 08:30:34 -0700 dynamic_cf_cast does have debug assert so it seems equivalent to my original patch: ASSERT_WITH_SECURITY_IMPLICATION(CFGetTypeID(object) == CFTypeTrait<T>::typeID()); if (CFGetTypeID(object) != CFTypeTrait<T>::typeID()) return nullptr; 1645208 10 397424 ggaren 2020-04-24 09:03:15 -0700 Comment on attachment 397424 patch r=me You could declare the lambda "[&]() -> String" to maintain the existing one-liner return. Not sure if we like being that fancy or not. 1645209 11 koivisto 2020-04-24 09:10:27 -0700 I had that when there were multiple returns but went back for simplicity. 1645211 12 ews-feeder 2020-04-24 09:20:39 -0700 Committed r260646: <https://trac.webkit.org/changeset/260646> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397424. 1645235 13 darin 2020-04-24 10:02:02 -0700 (In reply to Antti Koivisto from comment #9) > dynamic_cf_cast does have debug assert so it seems equivalent to my > original patch: > > ASSERT_WITH_SECURITY_IMPLICATION(CFGetTypeID(object) == > CFTypeTrait<T>::typeID()); > if (CFGetTypeID(object) != CFTypeTrait<T>::typeID()) > return nullptr; Don’t get me started, though. dynamic_cf_cast is the wrong name for a function if it asserts, because dynamic_cast and dyanmic_objc_cast don’t! 1645545 14 koivisto 2020-04-24 23:55:36 -0700 Agreed, I was just confused with the claim that I had invented some third way of doing things. 397335 2020-04-23 06:28:04 -0700 2020-04-23 21:55:29 -0700 patch generic-family-crash.patch text/plain 2033 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNDZjY2Q5YmY1Ni4uNGMwNTVmYTdhZTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wNC0yMyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgTnVsbHB0ciBjcmFzaCBpbiBvYmpjX21zZ1NlbmQgdW5kZXIgV2ViQ29yZTo6 Z2VuZXJpY0ZhbWlseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEwOTExCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTUxMDIwOD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjdWxhdGl2ZSBmaXgu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9TeXN0ZW1Gb250RGF0YWJhc2VD b3JlVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZW5lcmljRmFtaWx5KToKKworICAgICAg ICBUZXN0IHRoYXQgQ1RGb250RGVzY3JpcHRvckNvcHlBdHRyaWJ1dGUgaXMgcmVhbGx5IHJldHVy bmluZyBDRlN0cmluZ1JlZi4KKwogMjAyMC0wNC0yMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgZ2V0RGlzcGxheU1lZGlhIGlzIG5vdCByZXNwZWN0aW5nIGFz cGVjdCByYXRpbyB3aXRoIG1heCBjb25zdHJhaW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVtRm9udERhdGFiYXNlQ29yZVRleHQuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVtRm9udERhdGFi YXNlQ29yZVRleHQuY3BwCmluZGV4IDdlNTYzZThmNTRmLi5mOTBmM2JlMjZkYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVtRm9udERhdGFi YXNlQ29yZVRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nv Y29hL1N5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0LmNwcApAQCAtMjQ4LDkgKzI0OCwxNiBAQCBW ZWN0b3I8UmV0YWluUHRyPENURm9udERlc2NyaXB0b3JSZWY+PiBTeXN0ZW1Gb250RGF0YWJhc2VD b3JlVGV4dDo6Y2FzY2FkZUxpc3QoYwogCiBzdGF0aWMgU3RyaW5nIGdlbmVyaWNGYW1pbHkoY29u c3QgU3RyaW5nJiBsb2NhbGUsIEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+JiBtYXAsIENGU3RyaW5n UmVmIGN0S2V5KQogewotICAgIHJldHVybiBtYXAuZW5zdXJlKGxvY2FsZSwgWyZdIHsKKyAgICBy ZXR1cm4gbWFwLmVuc3VyZShsb2NhbGUsIFsmXSgpIC0+IFN0cmluZyB7CiAgICAgICAgIGF1dG8g ZGVzY3JpcHRvciA9IGFkb3B0Q0YoQ1RGb250RGVzY3JpcHRvckNyZWF0ZUZvckNTU0ZhbWlseShj dEtleSwgbG9jYWxlLmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCkpKTsKLSAgICAgICAgcmV0dXJuIGFk b3B0Q0Yoc3RhdGljX2Nhc3Q8Q0ZTdHJpbmdSZWY+KENURm9udERlc2NyaXB0b3JDb3B5QXR0cmli dXRlKGRlc2NyaXB0b3IuZ2V0KCksIGtDVEZvbnRGYW1pbHlOYW1lQXR0cmlidXRlKSkpLmdldCgp OworICAgICAgICBhdXRvIHZhbHVlID0gYWRvcHRDRihDVEZvbnREZXNjcmlwdG9yQ29weUF0dHJp YnV0ZShkZXNjcmlwdG9yLmdldCgpLCBrQ1RGb250RmFtaWx5TmFtZUF0dHJpYnV0ZSkpOworICAg ICAgICBpZiAoIXZhbHVlKQorICAgICAgICAgICAgcmV0dXJuIHsgfTsKKyAgICAgICAgaWYgKENG R2V0VHlwZUlEKHZhbHVlLmdldCgpKSAhPSBDRlN0cmluZ0dldFR5cGVJRCgpKSB7CisgICAgICAg ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIHJldHVybiB7IH07CisgICAg ICAgIH0KKyAgICAgICAgcmV0dXJuIHsgc3RhdGljX2Nhc3Q8Q0ZTdHJpbmdSZWY+KHZhbHVlLmdl dCgpKSB9OwogICAgIH0pLml0ZXJhdG9yLT52YWx1ZTsKIH0KIAo= 397424 2020-04-23 21:55:29 -0700 2020-04-24 09:20:39 -0700 patch generic-family-crash-2.patch text/plain 1954 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNDZjY2Q5YmY1Ni4uNTQ5MmNhZGQzMTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMC0wNC0yMyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgTnVsbHB0ciBjcmFzaCBpbiBvYmpjX21zZ1NlbmQgdW5kZXIgV2ViQ29yZTo6 Z2VuZXJpY0ZhbWlseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEwOTExCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTUxMDIwOD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjdWxhdGl2ZSBmaXgu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9TeXN0ZW1Gb250RGF0YWJhc2VD b3JlVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZW5lcmljRmFtaWx5KToKKworICAgICAg ICBUZXN0IHRoYXQgQ1RGb250RGVzY3JpcHRvckNvcHlBdHRyaWJ1dGUgaXMgcmVhbGx5IHJldHVy bmluZyBDRlN0cmluZ1JlZi4KKyAgICAgICAgQWxzbyBleHBsaWNpdGx5IHJldHVybiBTdHJpbmcg ZnJvbSBsYW1iZGEgdG8gY2xhcmlmeSBsaWZldGltZXMuCisKIDIwMjAtMDQtMjMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIGdldERpc3BsYXlNZWRpYSBpcyBu b3QgcmVzcGVjdGluZyBhc3BlY3QgcmF0aW8gd2l0aCBtYXggY29uc3RyYWludHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1N5c3RlbUZvbnREYXRh YmFzZUNvcmVUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29h L1N5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0LmNwcAppbmRleCA3ZTU2M2U4ZjU0Zi4uY2M0ZTJi YzQ0NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29h L1N5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jb2NvYS9TeXN0ZW1Gb250RGF0YWJhc2VDb3JlVGV4dC5jcHAKQEAgLTI4 LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgIkZvbnRDYWNoZS5oIgogI2luY2x1ZGUgIkZvbnRDYXNj YWRlRGVzY3JpcHRpb24uaCIKKyNpbmNsdWRlIDx3dGYvY2YvVHlwZUNhc3RzQ0YuaD4KIAogI2lm IFBMQVRGT1JNKElPU19GQU1JTFkpCiAjaW5jbHVkZSAiUmVuZGVyVGhlbWVJT1MuaCIKQEAgLTI1 MCw3ICsyNTEsOCBAQCBzdGF0aWMgU3RyaW5nIGdlbmVyaWNGYW1pbHkoY29uc3QgU3RyaW5nJiBs b2NhbGUsIEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+JiBtYXAsCiB7CiAgICAgcmV0dXJuIG1hcC5l bnN1cmUobG9jYWxlLCBbJl0gewogICAgICAgICBhdXRvIGRlc2NyaXB0b3IgPSBhZG9wdENGKENU Rm9udERlc2NyaXB0b3JDcmVhdGVGb3JDU1NGYW1pbHkoY3RLZXksIGxvY2FsZS5jcmVhdGVDRlN0 cmluZygpLmdldCgpKSk7Ci0gICAgICAgIHJldHVybiBhZG9wdENGKHN0YXRpY19jYXN0PENGU3Ry aW5nUmVmPihDVEZvbnREZXNjcmlwdG9yQ29weUF0dHJpYnV0ZShkZXNjcmlwdG9yLmdldCgpLCBr Q1RGb250RmFtaWx5TmFtZUF0dHJpYnV0ZSkpKS5nZXQoKTsKKyAgICAgICAgYXV0byB2YWx1ZSA9 IGFkb3B0Q0YoZHluYW1pY19jZl9jYXN0PENGU3RyaW5nUmVmPihDVEZvbnREZXNjcmlwdG9yQ29w eUF0dHJpYnV0ZShkZXNjcmlwdG9yLmdldCgpLCBrQ1RGb250RmFtaWx5TmFtZUF0dHJpYnV0ZSkp KTsKKyAgICAgICAgcmV0dXJuIFN0cmluZyB7IHZhbHVlLmdldCgpIH07CiAgICAgfSkuaXRlcmF0 b3ItPnZhbHVlOwogfQogCg==