21091 2008-09-25 00:23:23 -0700 Regression: querySelector matches tag names case sensitively 2008-09-25 09:49:28 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://dscoder.com/qsaidtest.html P1 Normal --- 1 catfish.man catfish.man oldest_to_newest 92678 0 catfish.man 2008-09-25 00:23:23 -0700 It should be case insensitive in HTML documents. Patch tomorrow; too tired to wait for the world to rebuild right now. This regressed in http://trac.webkit.org/changeset/35282 because parseSelector doesn't create the dummy stylesheet with a Document, so the CSSParser can't check whether the Document is an HTML one. 92683 1 23784 catfish.man 2008-09-25 01:18:10 -0700 Created attachment 23784 Fix 92685 2 23784 eric 2008-09-25 01:21:59 -0700 Comment on attachment 23784 Fix The change looks fine. I'd like to see an xhtml test as well (or maybe that's already covered?) That could also be done in a follow-up patch. 92690 3 catfish.man 2008-09-25 01:57:59 -0700 Landed with an xhtml test in r36890 92739 4 23784 darin 2008-09-25 09:49:28 -0700 Comment on attachment 23784 Fix + std::auto_ptr<CSSSelector> parseSelector(const String&, Document* doc = 0); The parameter should not be named here. +std::auto_ptr<CSSSelector> CSSParser::parseSelector(const String& string, Document* doc) +{ + RefPtr<CSSStyleSheet> dummyStyleSheet = CSSStyleSheet::create(doc); I strongly prefer "document" over "doc", but that's just my personal taste. 23784 2008-09-25 01:18:10 -0700 2008-09-25 01:21:59 -0700 Fix qsatagcasesensitivity.txt text/plain 5183 catfish.man SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjg4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDgtMDktMjUgIERhdmlkIFNtaXRoICA8Y2F0ZmlzaC5tYW5AZ21h aWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgZml4IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA5 MQorICAgICAgICBSZWdyZXNzaW9uOiBxdWVyeVNlbGVjdG9yIG1hdGNoZXMgdGFnIG5hbWVzIGNh c2Ugc2Vuc2l0aXZlbHkKKyAgICAgICAgCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL1NlbGVjdG9y QVBJL2Nhc2VUYWcuaHRtbAorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlU2VsZWN0b3IpOiBBZGQgYSBEb2N1bWVudCBhcmd1 bWVudCwgc2luY2UgdGFnIGNhc2Ugc2Vuc2l0aXZpdHkgaXMgZGlmZmVyZW50IGZvciBIVE1MIGRv Y3VtZW50cworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuaDoKKyAgICAgICAgKiBkb20vTm9kZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpxdWVyeVNlbGVjdG9yKToKKyAgICAgICAgKFdl YkNvcmU6Ok5vZGU6OnF1ZXJ5U2VsZWN0b3JBbGwpOgorCiAyMDA4LTA5LTI0ICBEYXZpZCBIeWF0 dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEwODQKSW5kZXg6IFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkocmV2aXNpb24gMzY4ODUpCisr KyBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDUsOSArMzA1 LDkgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlQ29sb3IoQ1NTTXV0YWJsZVN0eQogICAgIHJldHVy biAobV9udW1QYXJzZWRQcm9wZXJ0aWVzICYmIG1fcGFyc2VkUHJvcGVydGllc1swXS0+bV9pZCA9 PSBDU1NQcm9wZXJ0eUNvbG9yKTsKIH0KIAotc3RkOjphdXRvX3B0cjxDU1NTZWxlY3Rvcj4gQ1NT UGFyc2VyOjpwYXJzZVNlbGVjdG9yKGNvbnN0IFN0cmluZyYgc3RyaW5nKQotewotICAgIFJlZlB0 cjxDU1NTdHlsZVNoZWV0PiBkdW1teVN0eWxlU2hlZXQgPSBDU1NTdHlsZVNoZWV0OjpjcmVhdGUo KTsKK3N0ZDo6YXV0b19wdHI8Q1NTU2VsZWN0b3I+IENTU1BhcnNlcjo6cGFyc2VTZWxlY3Rvcihj b25zdCBTdHJpbmcmIHN0cmluZywgRG9jdW1lbnQqIGRvYykKK3sgICAgCisgICAgUmVmUHRyPENT U1N0eWxlU2hlZXQ+IGR1bW15U3R5bGVTaGVldCA9IENTU1N0eWxlU2hlZXQ6OmNyZWF0ZShkb2Mp OwogCiAgICAgbV9zdHlsZVNoZWV0ID0gZHVtbXlTdHlsZVNoZWV0LmdldCgpOwogCkluZGV4OiBX ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuaAkocmV2aXNpb24gMzY4ODUpCisrKyBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTE3LDcgKzExNyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAg Ym9vbCBwYXJzZUhTTFBhcmFtZXRlcnMoQ1NTUGFyc2VyVmFsdWUqLCBkb3VibGUqIGNvbG9yVmFs dWVzLCBib29sIHBhcnNlQWxwaGEpOwogICAgICAgICBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZh bHVlPiBwYXJzZUNvbG9yKENTU1BhcnNlclZhbHVlKiA9IDApOwogICAgICAgICBib29sIHBhcnNl Q29sb3JGcm9tVmFsdWUoQ1NTUGFyc2VyVmFsdWUqLCBSR0JBMzImLCBib29sID0gZmFsc2UpOwot ICAgICAgICBzdGQ6OmF1dG9fcHRyPENTU1NlbGVjdG9yPiBwYXJzZVNlbGVjdG9yKGNvbnN0IFN0 cmluZyYpOworICAgICAgICBzdGQ6OmF1dG9fcHRyPENTU1NlbGVjdG9yPiBwYXJzZVNlbGVjdG9y KGNvbnN0IFN0cmluZyYsIERvY3VtZW50KiBkb2MgPSAwKTsKIAogICAgICAgICBzdGF0aWMgYm9v bCBwYXJzZUNvbG9yKGNvbnN0IFN0cmluZyYsIFJHQkEzMiYgcmdiLCBib29sIHN0cmljdCk7CiAK SW5kZXg6IFdlYkNvcmUvZG9tL05vZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL05v ZGUuY3BwCShyZXZpc2lvbiAzNjg4NSkKKysrIFdlYkNvcmUvZG9tL05vZGUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMzQ1LDcgKzEzNDUsNyBAQCBQYXNzUmVmUHRyPEVsZW1lbnQ+IE5vZGU6OnF1 ZXJ5U2VsZWN0b3IoCiAgICAgICAgICAgICBwLm1fZGVmYXVsdE5hbWVzcGFjZSA9IGRlZmF1bHRO YW1lc3BhY2U7CiAgICAgfQogCi0gICAgc3RkOjphdXRvX3B0cjxDU1NTZWxlY3Rvcj4gcXVlcnlT ZWxlY3RvciA9IHAucGFyc2VTZWxlY3RvcihzZWxlY3RvcnMpOworICAgIHN0ZDo6YXV0b19wdHI8 Q1NTU2VsZWN0b3I+IHF1ZXJ5U2VsZWN0b3IgPSBwLnBhcnNlU2VsZWN0b3Ioc2VsZWN0b3JzLCBk b2N1bWVudCgpKTsKICAgICBpZiAoIXF1ZXJ5U2VsZWN0b3IuZ2V0KCkpIHsKICAgICAgICAgZWMg PSBTWU5UQVhfRVJSOwogICAgICAgICByZXR1cm4gMDsKQEAgLTE0MDUsNyArMTQwNSw3IEBAIFBh c3NSZWZQdHI8Tm9kZUxpc3Q+IE5vZGU6OnF1ZXJ5U2VsZWN0b3IKICAgICAgICAgICAgIHAubV9k ZWZhdWx0TmFtZXNwYWNlID0gZGVmYXVsdE5hbWVzcGFjZTsKICAgICB9CiAKLSAgICBzdGQ6OmF1 dG9fcHRyPENTU1NlbGVjdG9yPiBxdWVyeVNlbGVjdG9yID0gcC5wYXJzZVNlbGVjdG9yKHNlbGVj dG9ycyk7CisgICAgc3RkOjphdXRvX3B0cjxDU1NTZWxlY3Rvcj4gcXVlcnlTZWxlY3RvciA9IHAu cGFyc2VTZWxlY3RvcihzZWxlY3RvcnMsIGRvY3VtZW50KCkpOwogCiAgICAgaWYgKCFxdWVyeVNl bGVjdG9yLmdldCgpKSB7CiAgICAgICAgIGVjID0gU1lOVEFYX0VSUjsKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDM2ODg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMDgtMDktMjUgIERhdmlkIFNtaXRoICA8Y2F0ZmlzaC5tYW5AZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgVGVzdHMgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTA5MQorICAgICAgICBSZWdyZXNzaW9uOiBxdWVyeVNlbGVjdG9yIG1hdGNoZXMgdGFnIG5hbWVz IGNhc2Ugc2Vuc2l0aXZlbHkKKworICAgICAgICAqIGZhc3QvZG9tL1NlbGVjdG9yQVBJL2Nhc2VU YWctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9TZWxlY3RvckFQSS9j YXNlVGFnLmh0bWw6IEFkZGVkLgorCiAyMDA4LTA5LTI0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9TZWxlY3RvckFQSS9jYXNlVGFnLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9TZWxlY3RvckFQSS9jYXNlVGFnLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1NlbGVjdG9yQVBJL2Nhc2VU YWctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYgQEAKK1BBU1MgZG9jdW1l bnQucXVlcnlTZWxlY3RvcignZGl2IFNQQU4nKS50ZXh0Q29udGVudCBpcyAnbG93ZXInCitQQVNT IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2RpdiBwJykudGV4dENvbnRlbnQgaXMgJ1VQUEVSJwor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvZG9tL1NlbGVjdG9yQVBJL2Nhc2VUYWcuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9TZWxlY3RvckFQSS9jYXNlVGFnLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9TZWxlY3RvckFQSS9jYXNlVGFnLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjEgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9 InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorICAgIDxk aXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorICAgIDxkaXYgc3R5bGU9ImRpc3BsYXk6IG5vbmUiPgor ICAgIDxzcGFuIGlkPSJsb3dlcjEiPmxvd2VyPC9zcGFuPjxicj4KKyAgICA8UCBpZD0iVVBQRVIx Ij5VUFBFUjwvUD48YnI+CisgICAgPC9kaXY+CisgICAgPHNjcmlwdD4KKyAgICAgICAgc2hvdWxk QmUoImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2RpdiBTUEFOJykudGV4dENvbnRlbnQiLCAiJ2xv d2VyJyIpOworICAgICAgICBzaG91bGRCZSgiZG9jdW1lbnQucXVlcnlTZWxlY3RvcignZGl2IHAn KS50ZXh0Q29udGVudCIsICInVVBQRVInIik7CisKKyAgICAgICAgdmFyIHN1Y2Nlc3NmdWxseVBh cnNlZCA9IHRydWU7CisgICAgPC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jl c291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=