210889 2020-04-22 17:19:38 -0700 Jesus Calling app needs more WebSQL 2020-05-14 10:52:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211896 https://bugs.webkit.org/show_bug.cgi?id=211906 InRadar P2 Normal --- 204907 1 achristensen achristensen cdumez ggaren webkit-bug-importer oldest_to_newest 1644587 0 achristensen 2020-04-22 17:19:38 -0700 Jesus Calling app needs more WebSQL 1644588 1 397293 achristensen 2020-04-22 17:20:13 -0700 Created attachment 397293 Patch 1644589 2 achristensen 2020-04-22 17:20:16 -0700 <rdar://problem/61795507> 1644824 3 397293 cdumez 2020-04-23 10:15:17 -0700 Comment on attachment 397293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397293&action=review > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:615 > + static const bool needsWebSQL = IOSApplication::isJesusCalling() && applicationSDKVersion() <= DYLD_IOS_VERSION_12_2; Can we make RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled() return true in this case instead? This is not the only place where RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled() is queried so this fix is incomplete otherwise. There are plenty of places in generated bindings code that check RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled(). 1644943 4 397379 achristensen 2020-04-23 13:31:48 -0700 Created attachment 397379 Patch 1644946 5 397379 cdumez 2020-04-23 13:34:52 -0700 Comment on attachment 397379 Patch r=me 1644952 6 ews-feeder 2020-04-23 13:59:56 -0700 Committed r260597: <https://trac.webkit.org/changeset/260597> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397379. 397293 2020-04-22 17:20:13 -0700 2020-04-23 13:31:47 -0700 Patch bug-210889-20200422172012.patch text/plain 1952 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MDU0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTIyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSmVzdXMgQ2Fs bGluZyBhcHAgbmVlZHMgbW9yZSBXZWJTUUwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDg4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjE3OTU1 MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFu dWFsbHkgdmVyaWZpZWQgdGhpcyBmaXhlcyB0aGUgaXNzdWUgaW4gdGhlIHJhZGFyLgorCisgICAg ICAgICogYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6anNET01XaW5kb3dJbnN0YW5jZUZ1bmN0aW9uT3BlbkRhdGFiYXNlQm9keSk6CisKIDIwMjAt MDQtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hYyB3 azIgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL25vdGlmaWNhdGlvbnMvZXZlbnQt b25jbG9zZS5odG1sIGlzIGZsYWt5IGZhaWxpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCShyZXZpc2lvbiAyNjA1MzEpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTYxMSw3ICs2MTEsMTMgQEAgc3RhdGljIGlubGluZSBKU0M6OkVuY29kZWRK U1ZhbHVlIGpzRE9NVwogICAgIGF1dG8gZXN0aW1hdGVkU2l6ZSA9IGNvbnZlcnQ8SURMVW5zaWdu ZWRMb25nPigqbGV4aWNhbEdsb2JhbE9iamVjdCwgY2FsbEZyYW1lLT51bmNoZWNrZWRBcmd1bWVu dCgzKSk7CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTih0aHJvd1Njb3BlLCBlbmNvZGVkSlNWYWx1 ZSgpKTsKIAotICAgIGlmICghUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMo KS53ZWJTUUxFbmFibGVkKCkpIHsKKyNpZiBQTEFURk9STShJT1MpCisgICAgc3RhdGljIGNvbnN0 IGJvb2wgbmVlZHNXZWJTUUwgPSBJT1NBcHBsaWNhdGlvbjo6aXNKZXN1c0NhbGxpbmcoKSAmJiBh cHBsaWNhdGlvblNES1ZlcnNpb24oKSA8PSBEWUxEX0lPU19WRVJTSU9OXzEyXzI7CisjZWxzZQor ICAgIGNvbnN0ZXhwciBib29sIG5lZWRzV2ViU1FMID0gZmFsc2U7CisjZW5kaWYKKworICAgIGlm ICghUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS53ZWJTUUxFbmFibGVk KCkgJiYgIW5lZWRzV2ViU1FMKSB7CiAgICAgICAgIGlmIChuYW1lICE9ICJudWxsIiB8fCB2ZXJz aW9uICE9ICJudWxsIiB8fCBkaXNwbGF5TmFtZSAhPSAibnVsbCIgfHwgZXN0aW1hdGVkU2l6ZSkK ICAgICAgICAgICAgIHByb3BhZ2F0ZUV4Y2VwdGlvbigqbGV4aWNhbEdsb2JhbE9iamVjdCwgdGhy b3dTY29wZSwgRXhjZXB0aW9uKFVua25vd25FcnJvciwgIldlYiBTUUwgaXMgZGVwcmVjYXRlZCJf cykpOwogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGNvbnN0cnVjdEVtcHR5T2JqZWN0 KGxleGljYWxHbG9iYWxPYmplY3QsIGNhc3RlZFRoaXMtPmdsb2JhbE9iamVjdCgpLT5vYmplY3RQ cm90b3R5cGUoKSkpOwo= 397379 2020-04-23 13:31:48 -0700 2020-04-23 13:59:57 -0700 Patch bug-210889-20200423133148.patch text/plain 5204 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MDU0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTIyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSmVzdXMgQ2Fs bGluZyBhcHAgbmVlZHMgbW9yZSBXZWJTUUwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDg4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjE3OTU1 MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFu dWFsbHkgdmVyaWZpZWQgdGhpcyBmaXhlcyB0aGUgaXNzdWUgaW4gdGhlIHJhZGFyLgorCisgICAg ICAgICogYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6anNET01XaW5kb3dJbnN0YW5jZUZ1bmN0aW9uT3BlbkRhdGFiYXNlQm9keSk6CisKIDIwMjAt MDQtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hYyB3 azIgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL25vdGlmaWNhdGlvbnMvZXZlbnQt b25jbG9zZS5odG1sIGlzIGZsYWt5IGZhaWxpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCShyZXZpc2lvbiAyNjA1MzEpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTU5LDExICs1OSw2IEBACiAjaW5jbHVkZSAiSlNXZWJLaXROYW1lc3BhY2Uu aCIKICNlbmRpZgogCi0jaWYgUExBVEZPUk0oSU9TKQotI2luY2x1ZGUgIlJ1bnRpbWVBcHBsaWNh dGlvbkNoZWNrcy5oIgotI2luY2x1ZGUgPHd0Zi9jb2NvYS9SdW50aW1lQXBwbGljYXRpb25DaGVj a3NDb2NvYS5oPgotI2VuZGlmCi0KIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHVzaW5nIG5hbWVzcGFj ZSBKU0M7CiAKQEAgLTYzNiwxNSArNjMxLDkgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBqc0RPTVdpbmRvdwogCiBKU1ZhbHVlIEpTRE9NV2luZG93OjpvcGVuRGF0YWJhc2UoSlNDOjpK U0dsb2JhbE9iamVjdCYgbGV4aWNhbEdsb2JhbE9iamVjdCkgY29uc3QKIHsKLSNpZiBQTEFURk9S TShJT1MpCi0gICAgc3RhdGljIGNvbnN0IGJvb2wgb3BlbkRhdGFiYXNlU2hvdWxkQmVEZWZpbmVk RXZlbldoZW5EaXNhYmxlZCA9IElPU0FwcGxpY2F0aW9uOjppc0plc3VzQ2FsbGluZygpICYmIGFw cGxpY2F0aW9uU0RLVmVyc2lvbigpIDw9IERZTERfSU9TX1ZFUlNJT05fMTJfMjsKLSNlbHNlCi0g ICAgY29uc3RleHByIGJvb2wgb3BlbkRhdGFiYXNlU2hvdWxkQmVEZWZpbmVkRXZlbldoZW5EaXNh YmxlZCA9IGZhbHNlOwotI2VuZGlmCi0KICAgICBWTSYgdm0gPSBsZXhpY2FsR2xvYmFsT2JqZWN0 LnZtKCk7CiAgICAgU3RyaW5nSW1wbCogbmFtZSA9IFByb3BlcnR5TmFtZShzdGF0aWNfY2FzdDxK U1ZNQ2xpZW50RGF0YSo+KHZtLmNsaWVudERhdGEpLT5idWlsdGluTmFtZXMoKS5vcGVuRGF0YWJh c2VQdWJsaWNOYW1lKCkpLnB1YmxpY05hbWUoKTsKLSAgICBpZiAoUnVudGltZUVuYWJsZWRGZWF0 dXJlczo6c2hhcmVkRmVhdHVyZXMoKS53ZWJTUUxFbmFibGVkKCkgfHwgb3BlbkRhdGFiYXNlU2hv dWxkQmVEZWZpbmVkRXZlbldoZW5EaXNhYmxlZCkKKyAgICBpZiAoUnVudGltZUVuYWJsZWRGZWF0 dXJlczo6c2hhcmVkRmVhdHVyZXMoKS53ZWJTUUxFbmFibGVkKCkpCiAgICAgICAgIHJldHVybiBK U0Z1bmN0aW9uOjpjcmVhdGUodm0sICZsZXhpY2FsR2xvYmFsT2JqZWN0LCA0LCBuYW1lLCBqc0RP TVdpbmRvd0luc3RhbmNlRnVuY3Rpb25PcGVuRGF0YWJhc2UsIE5vSW50cmluc2ljKTsKIAogICAg IHJldHVybiBKU0Z1bmN0aW9uOjpjcmVhdGVGdW5jdGlvblRoYXRNYXNxdWVyYWRlc0FzVW5kZWZp bmVkKHZtLCAmbGV4aWNhbEdsb2JhbE9iamVjdCwgNCwgbmFtZSwganNET01XaW5kb3dJbnN0YW5j ZUZ1bmN0aW9uT3BlbkRhdGFiYXNlLCBOb0ludHJpbnNpYyk7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAkocmV2aXNpb24g MjYwNTMxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hl Y2tzLmgJKHdvcmtpbmcgY29weSkKQEAgLTg2LDcgKzg2LDcgQEAgV0VCQ09SRV9FWFBPUlQgYm9v bCBpc1dlYkJvb2ttYXJrc0QoKTsKIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNEdW1wUmVuZGVyVHJl ZSgpOwogV0VCQ09SRV9FWFBPUlQgYm9vbCBpc01pbmlCcm93c2VyKCk7CiBib29sIGlzTW9iaWxl U3RvcmUoKTsKLWJvb2wgaXNKZXN1c0NhbGxpbmcoKTsKK1dFQkNPUkVfRVhQT1JUIGJvb2wgaXNK ZXN1c0NhbGxpbmcoKTsKIGJvb2wgaXNTcHJpbmdCb2FyZCgpOwogV0VCQ09SRV9FWFBPUlQgYm9v bCBpc1dlYlByb2Nlc3MoKTsKIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNJQm9va3MoKTsKSW5kZXg6 IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MDU5NSkKKysrIFNvdXJjZS9X ZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA0LTIzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgSmVzdXMgQ2FsbGluZyBhcHAgbmVlZHMgbW9yZSBXZWJTUUwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDg4OQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNjE3OTU1MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tOgorICAgICAgICAo K1tXZWJQcmVmZXJlbmNlcyBpbml0aWFsaXplXSk6CisKIDIwMjAtMDQtMjIgIERhcmluIEFkbGVy ICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gQnVpbGQgd2l0aCBVQ2hhciBh cyBjaGFyMTZfdCBldmVuIGluIGJ1aWxkcyB0aGF0IHVzZSBBcHBsZSdzIGludGVybmFsIFNESwpJ bmRleDogU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlByZWZlcmVu Y2VzLm1tCShyZXZpc2lvbiAyNjA1MzEpCisrKyBTb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJW aWV3L1dlYlByZWZlcmVuY2VzLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MCw2ICs1MCw3IEBACiAj aW1wb3J0IDx3dGYvTWFpblRocmVhZC5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogI2lt cG9ydCA8d3RmL1J1bkxvb3AuaD4KKyNpbXBvcnQgPHd0Zi9jb2NvYS9SdW50aW1lQXBwbGljYXRp b25DaGVja3NDb2NvYS5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIApAQCAtMzg5LDEx ICszOTAsMTMgQEAgKyAodm9pZClpbml0aWFsaXplCiAgICAgSlNDOjppbml0aWFsaXplVGhyZWFk aW5nKCk7CiAgICAgUnVuTG9vcDo6aW5pdGlhbGl6ZU1haW5SdW5Mb29wKCk7CiAgICAgYm9vbCBh dHRhY2htZW50RWxlbWVudEVuYWJsZWQgPSBNYWNBcHBsaWNhdGlvbjo6aXNBcHBsZU1haWwoKTsK KyAgICBib29sIHdlYlNRTEVuYWJsZWQgPSBmYWxzZTsKICNlbHNlCiAgICAgYm9vbCBhbGxvd3NJ bmxpbmVNZWRpYVBsYXliYWNrID0gV2ViQ29yZTo6ZGV2aWNlQ2xhc3MoKSA9PSBNR0RldmljZUNs YXNzaVBhZDsKICAgICBib29sIGFsbG93c0lubGluZU1lZGlhUGxheWJhY2tBZnRlckZ1bGxzY3Jl ZW4gPSBXZWJDb3JlOjpkZXZpY2VDbGFzcygpICE9IE1HRGV2aWNlQ2xhc3NpUGFkOwogICAgIGJv b2wgcmVxdWlyZXNQbGF5c0lubGluZUF0dHJpYnV0ZSA9ICFhbGxvd3NJbmxpbmVNZWRpYVBsYXli YWNrOwogICAgIGJvb2wgYXR0YWNobWVudEVsZW1lbnRFbmFibGVkID0gSU9TQXBwbGljYXRpb246 OmlzTW9iaWxlTWFpbCgpOworICAgIGJvb2wgd2ViU1FMRW5hYmxlZCA9IElPU0FwcGxpY2F0aW9u Ojppc0plc3VzQ2FsbGluZygpICYmIGFwcGxpY2F0aW9uU0RLVmVyc2lvbigpIDw9IERZTERfSU9T X1ZFUlNJT05fMTJfMjsKICNlbmRpZgogCiAgICAgTlNEaWN0aW9uYXJ5ICpkaWN0ID0gW05TRGlj dGlvbmFyeSBkaWN0aW9uYXJ5V2l0aE9iamVjdHNBbmRLZXlzOgpAQCAtNzExLDcgKzcxNCw3IEBA ICsgKHZvaWQpaW5pdGlhbGl6ZQogICAgICAgICBAWUVTLCBXZWJLaXRDU1NTaGFkb3dQYXJ0c0Vu YWJsZWRQcmVmZXJlbmNlS2V5LAogICAgICAgICBATk8sIFdlYktpdERlYnVnSW5BcHBCcm93c2Vy UHJpdmFjeUVuYWJsZWRQcmVmZXJlbmNlS2V5LAogICAgICAgICBATk8sIFdlYktpdEFzcGVjdFJh dGlvT2ZJbWdGcm9tV2lkdGhBbmRIZWlnaHRFbmFibGVkUHJlZmVyZW5jZUtleSwKLSAgICAgICAg QE5PLCBXZWJLaXRXZWJTUUxFbmFibGVkUHJlZmVyZW5jZUtleSwKKyAgICAgICAgQCh3ZWJTUUxF bmFibGVkKSwgV2ViS2l0V2ViU1FMRW5hYmxlZFByZWZlcmVuY2VLZXksCiAgICAgICAgIEBZRVMs IFdlYktpdERlYnVnTmVlZHNJbkFwcEJyb3dzZXJQcml2YWN5UXVpcmtzUHJlZmVyZW5jZUtleSwK ICAgICAgICAgbmlsXTsKIAo=