<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>210879</bug_id>
          
          <creation_ts>2020-04-22 14:58:30 -0700</creation_ts>
          <short_desc>AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet</short_desc>
          <delta_ts>2020-04-25 10:03:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="chris fleizach">cfleizach</reporter>
          <assigned_to name="chris fleizach">cfleizach</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>samuel_white</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1644518</commentid>
    <comment_count>0</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2020-04-22 14:58:30 -0700</bug_when>
    <thetext>Realized we could make use of WeakHashSet


&lt;rdar://problem/58383764&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1644519</commentid>
    <comment_count>1</comment_count>
      <attachid>397268</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2020-04-22 14:59:30 -0700</bug_when>
    <thetext>Created attachment 397268
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645547</commentid>
    <comment_count>2</comment_count>
      <attachid>397546</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2020-04-25 00:13:32 -0700</bug_when>
    <thetext>Created attachment 397546
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645548</commentid>
    <comment_count>3</comment_count>
      <attachid>397547</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2020-04-25 00:14:52 -0700</bug_when>
    <thetext>Created attachment 397547
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645598</commentid>
    <comment_count>4</comment_count>
      <attachid>397547</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2020-04-25 08:06:06 -0700</bug_when>
    <thetext>Comment on attachment 397547
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397547&amp;action=review

Patch looks good.

&gt; Source/WebCore/accessibility/AXObjectCache.h:490
&gt; +    WeakHashSet&lt;Element&gt; m_deferredRecomputeIsIgnoredList;

This is a behavior change: weak set is UNORDERED, but list set is ORDERED. Is this OK?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1645613</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-04-25 10:03:36 -0700</bug_when>
    <thetext>Committed r260706: &lt;https://trac.webkit.org/changeset/260706&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397547.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>397268</attachid>
            <date>2020-04-22 14:59:30 -0700</date>
            <delta_ts>2020-04-25 00:13:32 -0700</delta_ts>
            <desc>patch</desc>
            <filename>file_210879.txt</filename>
            <type>text/plain</type>
            <size>4660</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZw0KaW5kZXggNjkyNTUzNjAwNWYuLmFhOGIxZmJhNDEyIDEwMDY0NA0KLS0tIGEvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCkBA
IC0xLDMgKzEsMTcgQEANCisyMDIwLTA0LTIyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh
cHBsZS5jb20+DQorDQorICAgICAgICBBWDogSW1wcm92ZSB0cmFja2luZyBvZiBFbGVtZW50KiBw
b2ludGVycyBpbiBBWE9iamVjdENhY2hlIHdpdGggV2Vha0hhc2hTZXQNCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA4NzkNCisNCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FY
T2JqZWN0Q2FjaGUuY3BwOg0KKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnJlbW92
ZSk6DQorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6aGFuZGxlRm9jdXNlZFVJRWxl
bWVudENoYW5nZWQpOg0KKyAgICAgICAgKFdlYkNvcmU6OmZpbHRlckxpc3RGb3JSZW1vdmFsKToN
CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpwZXJmb3JtRGVmZXJyZWRDYWNoZVVw
ZGF0ZSk6DQorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oOg0KKw0KIDIw
MjAtMDQtMjIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+DQogDQogICAg
ICAgICBmYXN0L2V2ZW50cy9ldmVudC1oYW5kbGVyLWRldGFjaGVkLWRvY3VtZW50LWRpc3BhdGNo
RXZlbnQuaHRtbCBpcyBjcmFzaGluZw0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz
c2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5
L0FYT2JqZWN0Q2FjaGUuY3BwDQppbmRleCA2NDk1MmIzNTM1OS4uYmNjNDM3NmM4MjEgMTAwNjQ0
DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQor
KysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQpAQCAt
ODU5LDggKzg1OSw4IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6cmVtb3ZlKFJlbmRlck9iamVjdCog
cmVuZGVyZXIpDQogdm9pZCBBWE9iamVjdENhY2hlOjpyZW1vdmUoTm9kZSYgbm9kZSkNCiB7DQog
ICAgIGlmIChpczxFbGVtZW50Pihub2RlKSkgew0KLSAgICAgICAgbV9kZWZlcnJlZFJlY29tcHV0
ZUlzSWdub3JlZExpc3QucmVtb3ZlKGRvd25jYXN0PEVsZW1lbnQ+KCZub2RlKSk7DQotICAgICAg
ICBtX2RlZmVycmVkU2VsZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0LnJlbW92ZShkb3duY2FzdDxF
bGVtZW50Pigmbm9kZSkpOw0KKyAgICAgICAgbV9kZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExp
c3QucmVtb3ZlKGRvd25jYXN0PEVsZW1lbnQ+KG5vZGUpKTsNCisgICAgICAgIG1fZGVmZXJyZWRT
ZWxlY3RlZENoaWxkcmVkQ2hhbmdlZExpc3QucmVtb3ZlKGRvd25jYXN0PEVsZW1lbnQ+KG5vZGUp
KTsNCiAgICAgICAgIG1fZGVmZXJyZWRUZXh0Rm9ybUNvbnRyb2xWYWx1ZS5yZW1vdmUoZG93bmNh
c3Q8RWxlbWVudD4oJm5vZGUpKTsNCiAgICAgICAgIG1fZGVmZXJyZWRBdHRyaWJ1dGVDaGFuZ2Uu
cmVtb3ZlKGRvd25jYXN0PEVsZW1lbnQ+KCZub2RlKSk7DQogICAgIH0NCkBAIC0xMTY5LDYgKzEx
NjksMTQgQEAgdm9pZCBBWE9iamVjdENhY2hlOjpoYW5kbGVGb2N1c2VkVUlFbGVtZW50Q2hhbmdl
ZChOb2RlKiBvbGROb2RlLCBOb2RlKiBuZXdOb2RlKQ0KICAgICBzZXRJc29sYXRlZFRyZWVGb2N1
c2VkT2JqZWN0KG5ld05vZGUpOw0KICNlbmRpZg0KIA0KKyAgICAvLyBJZiBvdXIgbmV3IGZvY3Vz
ZWQgbm9kZSBpcyBpZ25vcmVkLCB0ZWxsIHRoZSBwYXJlbnQgdG8gdXBkYXRlIGl0J3MgY2hpbGRy
ZW4uDQorICAgIGlmIChhdXRvKiBheE9iamVjdCA9IGdldChuZXdOb2RlKSkgew0KKyAgICAgICAg
aWYgKGF1dG8qIHBhcmVudCA9IGF4T2JqZWN0LT5wYXJlbnRPYmplY3RVbmlnbm9yZWQoKSkgew0K
KyAgICAgICAgICAgIGlmICghcGFyZW50LT5jaGlsZHJlbigpLmNvbnRhaW5zKGF4T2JqZWN0KSkN
CisgICAgICAgICAgICAgICAgcGFyZW50LT5zZXROZWVkc1RvVXBkYXRlQ2hpbGRyZW4oKTsNCisg
ICAgICAgIH0NCisgICAgfQ0KKyAgICANCiAgICAgaGFuZGxlTWVudUl0ZW1TZWxlY3RlZChuZXdO
b2RlKTsNCiAgICAgcGxhdGZvcm1IYW5kbGVGb2N1c2VkVUlFbGVtZW50Q2hhbmdlZChvbGROb2Rl
LCBuZXdOb2RlKTsNCiB9DQpAQCAtMjk5Miw2ICszMDAwLDEzIEBAIHN0YXRpYyB2b2lkIGZpbHRl
ckxpc3RGb3JSZW1vdmFsKGNvbnN0IExpc3RIYXNoU2V0PFQ+JiBsaXN0LCBjb25zdCBEb2N1bWVu
dCYgZG9jDQogICAgICAgICBjb25kaXRpb25hbGx5QWRkTm9kZVRvRmlsdGVyTGlzdChub2RlLCBk
b2N1bWVudCwgbm9kZXNUb1JlbW92ZSk7DQogfQ0KIA0KK3RlbXBsYXRlPHR5cGVuYW1lIFQ+DQor
c3RhdGljIHZvaWQgZmlsdGVyTGlzdEZvclJlbW92YWwoY29uc3QgV2Vha0hhc2hTZXQ8VD4mIGxp
c3QsIGNvbnN0IERvY3VtZW50JiBkb2N1bWVudCwgSGFzaFNldDxOb2RlKj4mIG5vZGVzVG9SZW1v
dmUpDQorew0KKyAgICBmb3IgKGF1dG8mIG5vZGUgOiBsaXN0KQ0KKyAgICAgICAgY29uZGl0aW9u
YWxseUFkZE5vZGVUb0ZpbHRlckxpc3QoJm5vZGUsIGRvY3VtZW50LCBub2Rlc1RvUmVtb3ZlKTsN
Cit9DQorDQogdm9pZCBBWE9iamVjdENhY2hlOjpwcmVwYXJlRm9yRG9jdW1lbnREZXN0cnVjdGlv
bihjb25zdCBEb2N1bWVudCYgZG9jdW1lbnQpDQogew0KICAgICBIYXNoU2V0PE5vZGUqPiBub2Rl
c1RvUmVtb3ZlOw0KQEAgLTMwNDgsMTQgKzMwNjMsMTQgQEAgdm9pZCBBWE9iamVjdENhY2hlOjpw
ZXJmb3JtRGVmZXJyZWRDYWNoZVVwZGF0ZSgpDQogICAgICAgICB0ZXh0Q2hhbmdlZChub2RlKTsN
CiAgICAgbV9kZWZlcnJlZFRleHRDaGFuZ2VkTGlzdC5jbGVhcigpOw0KIA0KLSAgICBmb3IgKGF1
dG8qIGVsZW1lbnQgOiBtX2RlZmVycmVkUmVjb21wdXRlSXNJZ25vcmVkTGlzdCkgew0KLSAgICAg
ICAgaWYgKGF1dG8qIHJlbmRlcmVyID0gZWxlbWVudC0+cmVuZGVyZXIoKSkNCisgICAgZm9yIChh
dXRvJiBlbGVtZW50IDogbV9kZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExpc3QpIHsNCisgICAg
ICAgIGlmIChhdXRvKiByZW5kZXJlciA9IGVsZW1lbnQucmVuZGVyZXIoKSkNCiAgICAgICAgICAg
ICByZWNvbXB1dGVJc0lnbm9yZWQocmVuZGVyZXIpOw0KICAgICB9DQogICAgIG1fZGVmZXJyZWRS
ZWNvbXB1dGVJc0lnbm9yZWRMaXN0LmNsZWFyKCk7DQogICAgIA0KLSAgICBmb3IgKGF1dG8qIHNl
bGVjdEVsZW1lbnQgOiBtX2RlZmVycmVkU2VsZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0KQ0KLSAg
ICAgICAgc2VsZWN0ZWRDaGlsZHJlbkNoYW5nZWQoc2VsZWN0RWxlbWVudCk7DQorICAgIGZvciAo
YXV0byYgc2VsZWN0RWxlbWVudCA6IG1fZGVmZXJyZWRTZWxlY3RlZENoaWxkcmVkQ2hhbmdlZExp
c3QpDQorICAgICAgICBzZWxlY3RlZENoaWxkcmVuQ2hhbmdlZCgmc2VsZWN0RWxlbWVudCk7DQog
ICAgIG1fZGVmZXJyZWRTZWxlY3RlZENoaWxkcmVkQ2hhbmdlZExpc3QuY2xlYXIoKTsNCiANCiAg
ICAgZm9yIChhdXRvJiBkZWZlcnJlZEZvcm1Db250cm9sQ29udGV4dCA6IG1fZGVmZXJyZWRUZXh0
Rm9ybUNvbnRyb2xWYWx1ZSkgew0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li
aWxpdHkvQVhPYmplY3RDYWNoZS5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9i
amVjdENhY2hlLmgNCmluZGV4IGExNDExOTQzMmM1Li4xNDc0NmNiZGUwNSAxMDA2NDQNCi0tLSBh
L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oDQorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaA0KQEAgLTQ4Nyw5ICs0ODcs
OSBAQCBwcml2YXRlOg0KICAgICBUaW1lciBtX3BlcmZvcm1DYWNoZVVwZGF0ZVRpbWVyOw0KIA0K
ICAgICBBWFRleHRTdGF0ZUNoYW5nZUludGVudCBtX3RleHRTZWxlY3Rpb25JbnRlbnQ7DQotICAg
IExpc3RIYXNoU2V0PEVsZW1lbnQqPiBtX2RlZmVycmVkUmVjb21wdXRlSXNJZ25vcmVkTGlzdDsN
CisgICAgV2Vha0hhc2hTZXQ8RWxlbWVudD4gbV9kZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExp
c3Q7DQogICAgIExpc3RIYXNoU2V0PE5vZGUqPiBtX2RlZmVycmVkVGV4dENoYW5nZWRMaXN0Ow0K
LSAgICBMaXN0SGFzaFNldDxFbGVtZW50Kj4gbV9kZWZlcnJlZFNlbGVjdGVkQ2hpbGRyZWRDaGFu
Z2VkTGlzdDsNCisgICAgV2Vha0hhc2hTZXQ8RWxlbWVudD4gbV9kZWZlcnJlZFNlbGVjdGVkQ2hp
bGRyZWRDaGFuZ2VkTGlzdDsNCiAgICAgTGlzdEhhc2hTZXQ8UmVmUHRyPEFYQ29yZU9iamVjdD4+
IG1fZGVmZXJyZWRDaGlsZHJlbkNoYW5nZWRMaXN0Ow0KICAgICBMaXN0SGFzaFNldDxOb2RlKj4g
bV9kZWZlcnJlZENoaWxkcmVuQ2hhbmdlZE5vZGVMaXN0Ow0KICAgICBIYXNoTWFwPEVsZW1lbnQq
LCBTdHJpbmc+IG1fZGVmZXJyZWRUZXh0Rm9ybUNvbnRyb2xWYWx1ZTsNCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>397546</attachid>
            <date>2020-04-25 00:13:32 -0700</date>
            <delta_ts>2020-04-25 00:14:52 -0700</delta_ts>
            <desc>patch</desc>
            <filename>file_210879.txt</filename>
            <type>text/plain</type>
            <size>3902</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZw0KaW5kZXggNjkyNTUzNjAwNWYuLmFhOGIxZmJhNDEyIDEwMDY0NA0KLS0tIGEvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCkBA
IC0xLDMgKzEsMTcgQEANCisyMDIwLTA0LTIyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh
cHBsZS5jb20+DQorDQorICAgICAgICBBWDogSW1wcm92ZSB0cmFja2luZyBvZiBFbGVtZW50KiBw
b2ludGVycyBpbiBBWE9iamVjdENhY2hlIHdpdGggV2Vha0hhc2hTZXQNCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA4NzkNCisNCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FY
T2JqZWN0Q2FjaGUuY3BwOg0KKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnJlbW92
ZSk6DQorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6aGFuZGxlRm9jdXNlZFVJRWxl
bWVudENoYW5nZWQpOg0KKyAgICAgICAgKFdlYkNvcmU6OmZpbHRlckxpc3RGb3JSZW1vdmFsKToN
CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpwZXJmb3JtRGVmZXJyZWRDYWNoZVVw
ZGF0ZSk6DQorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oOg0KKw0KIDIw
MjAtMDQtMjIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+DQogDQogICAg
ICAgICBmYXN0L2V2ZW50cy9ldmVudC1oYW5kbGVyLWRldGFjaGVkLWRvY3VtZW50LWRpc3BhdGNo
RXZlbnQuaHRtbCBpcyBjcmFzaGluZw0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz
c2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5
L0FYT2JqZWN0Q2FjaGUuY3BwDQppbmRleCA2NDk1MmIzNTM1OS4uODYwYTdiNjJmZjQgMTAwNjQ0
DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQor
KysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQpAQCAt
ODU5LDggKzg1OSw2IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6cmVtb3ZlKFJlbmRlck9iamVjdCog
cmVuZGVyZXIpDQogdm9pZCBBWE9iamVjdENhY2hlOjpyZW1vdmUoTm9kZSYgbm9kZSkNCiB7DQog
ICAgIGlmIChpczxFbGVtZW50Pihub2RlKSkgew0KLSAgICAgICAgbV9kZWZlcnJlZFJlY29tcHV0
ZUlzSWdub3JlZExpc3QucmVtb3ZlKGRvd25jYXN0PEVsZW1lbnQ+KCZub2RlKSk7DQotICAgICAg
ICBtX2RlZmVycmVkU2VsZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0LnJlbW92ZShkb3duY2FzdDxF
bGVtZW50Pigmbm9kZSkpOw0KICAgICAgICAgbV9kZWZlcnJlZFRleHRGb3JtQ29udHJvbFZhbHVl
LnJlbW92ZShkb3duY2FzdDxFbGVtZW50Pigmbm9kZSkpOw0KICAgICAgICAgbV9kZWZlcnJlZEF0
dHJpYnV0ZUNoYW5nZS5yZW1vdmUoZG93bmNhc3Q8RWxlbWVudD4oJm5vZGUpKTsNCiAgICAgfQ0K
QEAgLTI5OTIsNiArMjk5MCwxMyBAQCBzdGF0aWMgdm9pZCBmaWx0ZXJMaXN0Rm9yUmVtb3ZhbChj
b25zdCBMaXN0SGFzaFNldDxUPiYgbGlzdCwgY29uc3QgRG9jdW1lbnQmIGRvYw0KICAgICAgICAg
Y29uZGl0aW9uYWxseUFkZE5vZGVUb0ZpbHRlckxpc3Qobm9kZSwgZG9jdW1lbnQsIG5vZGVzVG9S
ZW1vdmUpOw0KIH0NCiANCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPg0KK3N0YXRpYyB2b2lkIGZpbHRl
ckxpc3RGb3JSZW1vdmFsKGNvbnN0IFdlYWtIYXNoU2V0PFQ+JiBsaXN0LCBjb25zdCBEb2N1bWVu
dCYgZG9jdW1lbnQsIEhhc2hTZXQ8Tm9kZSo+JiBub2Rlc1RvUmVtb3ZlKQ0KK3sNCisgICAgZm9y
IChhdXRvJiBub2RlIDogbGlzdCkNCisgICAgICAgIGNvbmRpdGlvbmFsbHlBZGROb2RlVG9GaWx0
ZXJMaXN0KCZub2RlLCBkb2N1bWVudCwgbm9kZXNUb1JlbW92ZSk7DQorfQ0KKw0KIHZvaWQgQVhP
YmplY3RDYWNoZTo6cHJlcGFyZUZvckRvY3VtZW50RGVzdHJ1Y3Rpb24oY29uc3QgRG9jdW1lbnQm
IGRvY3VtZW50KQ0KIHsNCiAgICAgSGFzaFNldDxOb2RlKj4gbm9kZXNUb1JlbW92ZTsNCkBAIC0z
MDQ4LDE0ICszMDUzLDE0IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6cGVyZm9ybURlZmVycmVkQ2Fj
aGVVcGRhdGUoKQ0KICAgICAgICAgdGV4dENoYW5nZWQobm9kZSk7DQogICAgIG1fZGVmZXJyZWRU
ZXh0Q2hhbmdlZExpc3QuY2xlYXIoKTsNCiANCi0gICAgZm9yIChhdXRvKiBlbGVtZW50IDogbV9k
ZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExpc3QpIHsNCi0gICAgICAgIGlmIChhdXRvKiByZW5k
ZXJlciA9IGVsZW1lbnQtPnJlbmRlcmVyKCkpDQorICAgIGZvciAoYXV0byYgZWxlbWVudCA6IG1f
ZGVmZXJyZWRSZWNvbXB1dGVJc0lnbm9yZWRMaXN0KSB7DQorICAgICAgICBpZiAoYXV0byogcmVu
ZGVyZXIgPSBlbGVtZW50LnJlbmRlcmVyKCkpDQogICAgICAgICAgICAgcmVjb21wdXRlSXNJZ25v
cmVkKHJlbmRlcmVyKTsNCiAgICAgfQ0KICAgICBtX2RlZmVycmVkUmVjb21wdXRlSXNJZ25vcmVk
TGlzdC5jbGVhcigpOw0KICAgICANCi0gICAgZm9yIChhdXRvKiBzZWxlY3RFbGVtZW50IDogbV9k
ZWZlcnJlZFNlbGVjdGVkQ2hpbGRyZWRDaGFuZ2VkTGlzdCkNCi0gICAgICAgIHNlbGVjdGVkQ2hp
bGRyZW5DaGFuZ2VkKHNlbGVjdEVsZW1lbnQpOw0KKyAgICBmb3IgKGF1dG8mIHNlbGVjdEVsZW1l
bnQgOiBtX2RlZmVycmVkU2VsZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0KQ0KKyAgICAgICAgc2Vs
ZWN0ZWRDaGlsZHJlbkNoYW5nZWQoJnNlbGVjdEVsZW1lbnQpOw0KICAgICBtX2RlZmVycmVkU2Vs
ZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0LmNsZWFyKCk7DQogDQogICAgIGZvciAoYXV0byYgZGVm
ZXJyZWRGb3JtQ29udHJvbENvbnRleHQgOiBtX2RlZmVycmVkVGV4dEZvcm1Db250cm9sVmFsdWUp
IHsNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj
aGUuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oDQppbmRl
eCBhMTQxMTk0MzJjNS4uMTQ3NDZjYmRlMDUgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h
Y2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaA0KKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz
aWJpbGl0eS9BWE9iamVjdENhY2hlLmgNCkBAIC00ODcsOSArNDg3LDkgQEAgcHJpdmF0ZToNCiAg
ICAgVGltZXIgbV9wZXJmb3JtQ2FjaGVVcGRhdGVUaW1lcjsNCiANCiAgICAgQVhUZXh0U3RhdGVD
aGFuZ2VJbnRlbnQgbV90ZXh0U2VsZWN0aW9uSW50ZW50Ow0KLSAgICBMaXN0SGFzaFNldDxFbGVt
ZW50Kj4gbV9kZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExpc3Q7DQorICAgIFdlYWtIYXNoU2V0
PEVsZW1lbnQ+IG1fZGVmZXJyZWRSZWNvbXB1dGVJc0lnbm9yZWRMaXN0Ow0KICAgICBMaXN0SGFz
aFNldDxOb2RlKj4gbV9kZWZlcnJlZFRleHRDaGFuZ2VkTGlzdDsNCi0gICAgTGlzdEhhc2hTZXQ8
RWxlbWVudCo+IG1fZGVmZXJyZWRTZWxlY3RlZENoaWxkcmVkQ2hhbmdlZExpc3Q7DQorICAgIFdl
YWtIYXNoU2V0PEVsZW1lbnQ+IG1fZGVmZXJyZWRTZWxlY3RlZENoaWxkcmVkQ2hhbmdlZExpc3Q7
DQogICAgIExpc3RIYXNoU2V0PFJlZlB0cjxBWENvcmVPYmplY3Q+PiBtX2RlZmVycmVkQ2hpbGRy
ZW5DaGFuZ2VkTGlzdDsNCiAgICAgTGlzdEhhc2hTZXQ8Tm9kZSo+IG1fZGVmZXJyZWRDaGlsZHJl
bkNoYW5nZWROb2RlTGlzdDsNCiAgICAgSGFzaE1hcDxFbGVtZW50KiwgU3RyaW5nPiBtX2RlZmVy
cmVkVGV4dEZvcm1Db250cm9sVmFsdWU7DQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>397547</attachid>
            <date>2020-04-25 00:14:52 -0700</date>
            <delta_ts>2020-04-25 10:03:37 -0700</delta_ts>
            <desc>patch</desc>
            <filename>file_210879.txt</filename>
            <type>text/plain</type>
            <size>4124</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZw0KaW5kZXggNjkyNTUzNjAwNWYuLmFhOGIxZmJhNDEyIDEwMDY0NA0KLS0tIGEvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCkBA
IC0xLDMgKzEsMTcgQEANCisyMDIwLTA0LTIyICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh
cHBsZS5jb20+DQorDQorICAgICAgICBBWDogSW1wcm92ZSB0cmFja2luZyBvZiBFbGVtZW50KiBw
b2ludGVycyBpbiBBWE9iamVjdENhY2hlIHdpdGggV2Vha0hhc2hTZXQNCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA4NzkNCisNCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FY
T2JqZWN0Q2FjaGUuY3BwOg0KKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnJlbW92
ZSk6DQorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6aGFuZGxlRm9jdXNlZFVJRWxl
bWVudENoYW5nZWQpOg0KKyAgICAgICAgKFdlYkNvcmU6OmZpbHRlckxpc3RGb3JSZW1vdmFsKToN
CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpwZXJmb3JtRGVmZXJyZWRDYWNoZVVw
ZGF0ZSk6DQorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oOg0KKw0KIDIw
MjAtMDQtMjIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+DQogDQogICAg
ICAgICBmYXN0L2V2ZW50cy9ldmVudC1oYW5kbGVyLWRldGFjaGVkLWRvY3VtZW50LWRpc3BhdGNo
RXZlbnQuaHRtbCBpcyBjcmFzaGluZw0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz
c2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5
L0FYT2JqZWN0Q2FjaGUuY3BwDQppbmRleCA2NDk1MmIzNTM1OS4uMGZmYjVhMmQzZTIgMTAwNjQ0
DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQor
KysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQpAQCAt
ODU5LDggKzg1OSw2IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6cmVtb3ZlKFJlbmRlck9iamVjdCog
cmVuZGVyZXIpDQogdm9pZCBBWE9iamVjdENhY2hlOjpyZW1vdmUoTm9kZSYgbm9kZSkNCiB7DQog
ICAgIGlmIChpczxFbGVtZW50Pihub2RlKSkgew0KLSAgICAgICAgbV9kZWZlcnJlZFJlY29tcHV0
ZUlzSWdub3JlZExpc3QucmVtb3ZlKGRvd25jYXN0PEVsZW1lbnQ+KCZub2RlKSk7DQotICAgICAg
ICBtX2RlZmVycmVkU2VsZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0LnJlbW92ZShkb3duY2FzdDxF
bGVtZW50Pigmbm9kZSkpOw0KICAgICAgICAgbV9kZWZlcnJlZFRleHRGb3JtQ29udHJvbFZhbHVl
LnJlbW92ZShkb3duY2FzdDxFbGVtZW50Pigmbm9kZSkpOw0KICAgICAgICAgbV9kZWZlcnJlZEF0
dHJpYnV0ZUNoYW5nZS5yZW1vdmUoZG93bmNhc3Q8RWxlbWVudD4oJm5vZGUpKTsNCiAgICAgfQ0K
QEAgLTI5OTcsOSArMjk5NSw3IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6cHJlcGFyZUZvckRvY3Vt
ZW50RGVzdHJ1Y3Rpb24oY29uc3QgRG9jdW1lbnQmIGRvY3VtZW50KQ0KICAgICBIYXNoU2V0PE5v
ZGUqPiBub2Rlc1RvUmVtb3ZlOw0KICAgICBmaWx0ZXJMaXN0Rm9yUmVtb3ZhbChtX3RleHRNYXJr
ZXJOb2RlcywgZG9jdW1lbnQsIG5vZGVzVG9SZW1vdmUpOw0KICAgICBmaWx0ZXJMaXN0Rm9yUmVt
b3ZhbChtX21vZGFsTm9kZXNTZXQsIGRvY3VtZW50LCBub2Rlc1RvUmVtb3ZlKTsNCi0gICAgZmls
dGVyTGlzdEZvclJlbW92YWwobV9kZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExpc3QsIGRvY3Vt
ZW50LCBub2Rlc1RvUmVtb3ZlKTsNCiAgICAgZmlsdGVyTGlzdEZvclJlbW92YWwobV9kZWZlcnJl
ZFRleHRDaGFuZ2VkTGlzdCwgZG9jdW1lbnQsIG5vZGVzVG9SZW1vdmUpOw0KLSAgICBmaWx0ZXJM
aXN0Rm9yUmVtb3ZhbChtX2RlZmVycmVkU2VsZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0LCBkb2N1
bWVudCwgbm9kZXNUb1JlbW92ZSk7DQogICAgIGZpbHRlckxpc3RGb3JSZW1vdmFsKG1fZGVmZXJy
ZWRDaGlsZHJlbkNoYW5nZWROb2RlTGlzdCwgZG9jdW1lbnQsIG5vZGVzVG9SZW1vdmUpOw0KICAg
ICBmaWx0ZXJNYXBGb3JSZW1vdmFsKG1fZGVmZXJyZWRUZXh0Rm9ybUNvbnRyb2xWYWx1ZSwgZG9j
dW1lbnQsIG5vZGVzVG9SZW1vdmUpOw0KICAgICBmaWx0ZXJNYXBGb3JSZW1vdmFsKG1fZGVmZXJy
ZWRBdHRyaWJ1dGVDaGFuZ2UsIGRvY3VtZW50LCBub2Rlc1RvUmVtb3ZlKTsNCkBAIC0zMDQ4LDE0
ICszMDQ0LDE0IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6cGVyZm9ybURlZmVycmVkQ2FjaGVVcGRh
dGUoKQ0KICAgICAgICAgdGV4dENoYW5nZWQobm9kZSk7DQogICAgIG1fZGVmZXJyZWRUZXh0Q2hh
bmdlZExpc3QuY2xlYXIoKTsNCiANCi0gICAgZm9yIChhdXRvKiBlbGVtZW50IDogbV9kZWZlcnJl
ZFJlY29tcHV0ZUlzSWdub3JlZExpc3QpIHsNCi0gICAgICAgIGlmIChhdXRvKiByZW5kZXJlciA9
IGVsZW1lbnQtPnJlbmRlcmVyKCkpDQorICAgIGZvciAoYXV0byYgZWxlbWVudCA6IG1fZGVmZXJy
ZWRSZWNvbXB1dGVJc0lnbm9yZWRMaXN0KSB7DQorICAgICAgICBpZiAoYXV0byogcmVuZGVyZXIg
PSBlbGVtZW50LnJlbmRlcmVyKCkpDQogICAgICAgICAgICAgcmVjb21wdXRlSXNJZ25vcmVkKHJl
bmRlcmVyKTsNCiAgICAgfQ0KICAgICBtX2RlZmVycmVkUmVjb21wdXRlSXNJZ25vcmVkTGlzdC5j
bGVhcigpOw0KICAgICANCi0gICAgZm9yIChhdXRvKiBzZWxlY3RFbGVtZW50IDogbV9kZWZlcnJl
ZFNlbGVjdGVkQ2hpbGRyZWRDaGFuZ2VkTGlzdCkNCi0gICAgICAgIHNlbGVjdGVkQ2hpbGRyZW5D
aGFuZ2VkKHNlbGVjdEVsZW1lbnQpOw0KKyAgICBmb3IgKGF1dG8mIHNlbGVjdEVsZW1lbnQgOiBt
X2RlZmVycmVkU2VsZWN0ZWRDaGlsZHJlZENoYW5nZWRMaXN0KQ0KKyAgICAgICAgc2VsZWN0ZWRD
aGlsZHJlbkNoYW5nZWQoJnNlbGVjdEVsZW1lbnQpOw0KICAgICBtX2RlZmVycmVkU2VsZWN0ZWRD
aGlsZHJlZENoYW5nZWRMaXN0LmNsZWFyKCk7DQogDQogICAgIGZvciAoYXV0byYgZGVmZXJyZWRG
b3JtQ29udHJvbENvbnRleHQgOiBtX2RlZmVycmVkVGV4dEZvcm1Db250cm9sVmFsdWUpIHsNCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaCBi
L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oDQppbmRleCBhMTQx
MTk0MzJjNS4uMTQ3NDZjYmRlMDUgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np
YmlsaXR5L0FYT2JqZWN0Q2FjaGUuaA0KKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0
eS9BWE9iamVjdENhY2hlLmgNCkBAIC00ODcsOSArNDg3LDkgQEAgcHJpdmF0ZToNCiAgICAgVGlt
ZXIgbV9wZXJmb3JtQ2FjaGVVcGRhdGVUaW1lcjsNCiANCiAgICAgQVhUZXh0U3RhdGVDaGFuZ2VJ
bnRlbnQgbV90ZXh0U2VsZWN0aW9uSW50ZW50Ow0KLSAgICBMaXN0SGFzaFNldDxFbGVtZW50Kj4g
bV9kZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExpc3Q7DQorICAgIFdlYWtIYXNoU2V0PEVsZW1l
bnQ+IG1fZGVmZXJyZWRSZWNvbXB1dGVJc0lnbm9yZWRMaXN0Ow0KICAgICBMaXN0SGFzaFNldDxO
b2RlKj4gbV9kZWZlcnJlZFRleHRDaGFuZ2VkTGlzdDsNCi0gICAgTGlzdEhhc2hTZXQ8RWxlbWVu
dCo+IG1fZGVmZXJyZWRTZWxlY3RlZENoaWxkcmVkQ2hhbmdlZExpc3Q7DQorICAgIFdlYWtIYXNo
U2V0PEVsZW1lbnQ+IG1fZGVmZXJyZWRTZWxlY3RlZENoaWxkcmVkQ2hhbmdlZExpc3Q7DQogICAg
IExpc3RIYXNoU2V0PFJlZlB0cjxBWENvcmVPYmplY3Q+PiBtX2RlZmVycmVkQ2hpbGRyZW5DaGFu
Z2VkTGlzdDsNCiAgICAgTGlzdEhhc2hTZXQ8Tm9kZSo+IG1fZGVmZXJyZWRDaGlsZHJlbkNoYW5n
ZWROb2RlTGlzdDsNCiAgICAgSGFzaE1hcDxFbGVtZW50KiwgU3RyaW5nPiBtX2RlZmVycmVkVGV4
dEZvcm1Db250cm9sVmFsdWU7DQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>