210831 2020-04-21 17:27:26 -0700 Bindings-test should not require being in the checkout directory 2020-04-21 18:46:55 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 jlewis3 aakash_jain ap ews-watchlist glenn jbedard ryanhaddad slewis webkit-bug-importer oldest_to_newest 1644107 0 jlewis3 2020-04-21 17:27:26 -0700 Currently the bindings tests must be run from the checkout directory, they should be able to be run outside of the checkout directory. 1644111 1 jlewis3 2020-04-21 17:27:51 -0700 rdar://problem/62072298 1644112 2 webkit-bug-importer 2020-04-21 17:28:22 -0700 <rdar://problem/62140724> 1644123 3 397150 jlewis3 2020-04-21 17:40:28 -0700 Created attachment 397150 Patch 1644144 4 397150 jbedard 2020-04-21 18:31:16 -0700 Comment on attachment 397150 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397150&action=review > Tools/ChangeLog:3 > + Bindings-test should not require being in the checkout directory. Would say: Bindings-test should not depend on current working directory. 1644148 5 397157 jlewis3 2020-04-21 18:41:12 -0700 Created attachment 397157 Patch 1644149 6 jlewis3 2020-04-21 18:46:55 -0700 Committed r260484: <https://trac.webkit.org/changeset/260484> 397150 2020-04-21 17:40:28 -0700 2020-04-21 18:41:11 -0700 Patch bug-210831-20200421174027.patch text/plain 1254 jlewis3 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNDM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjgxYTY5MTVhYzdiYjM5MGVlNWFmY2Y2NTY1ZjllN2Mx MjJhMWYxNC4uYTYzNzFlZDdlMDQ2MzI5MjRjMTE2YWMwZmFhYjIxNDZkNWRmZWRjMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA0LTIxICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CisKKyAgICAg ICAgQmluZGluZ3MtdGVzdCBzaG91bGQgbm90IHJlcXVpcmUgYmVpbmcgaW4gdGhlIGNoZWNrb3V0 IGRpcmVjdG9yeS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMDgzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9iaW5kaW5ncy9tYWluLnB5OgorICAgICAgICAoQmluZGlu Z3NUZXN0cy5tYWluKToKKwogMjAyMC0wNC0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFw cGxlLmNvbT4KIAogICAgICAgICBDb3JyZWN0IHRoZSBwYXRoIHRvIGxpYmNsYW5nX3J0LmFzYW5f aW9zc2ltX2R5bmFtaWMuZHlsaWIgaW4gTENfUlBBVEgKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvYmluZGluZ3MvbWFpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmlu ZGluZ3MvbWFpbi5weQppbmRleCA3OWE0N2QxMjNiMjJiMTRiMWQyZWZiNGY0MzY4YTgxN2Q0NzM5 NTQ2Li45NzBmZDBhZDNhYWMxNjU2ODUzYjI0ZmNkNjMwZjIxNzhjZjE5NDlkIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9iaW5kaW5ncy9tYWluLnB5CkBAIC0xNzYsNyArMTc2LDcgQEAgY2xhc3Mg QmluZGluZ3NUZXN0czoKICAgICAgICAgcmV0dXJuIHBhc3NlZAogCiAgICAgZGVmIG1haW4oc2Vs Zik6Ci0gICAgICAgIGN1cnJlbnRfc2NtID0gZGV0ZWN0X3NjbV9zeXN0ZW0ob3MuY3VyZGlyKQor ICAgICAgICBjdXJyZW50X3NjbSA9IGRldGVjdF9zY21fc3lzdGVtKG9zLnBhdGguZGlybmFtZShf X2ZpbGVfXykpCiAgICAgICAgIG9zLmNoZGlyKG9zLnBhdGguam9pbihjdXJyZW50X3NjbS5jaGVj a291dF9yb290LCAnU291cmNlJykpCiAKICAgICAgICAgYWxsX3Rlc3RzX3Bhc3NlZCA9IFRydWUK 397157 2020-04-21 18:41:12 -0700 2020-04-21 18:45:45 -0700 Patch bug-210831-20200421184112.patch text/plain 1250 jlewis3 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNDM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjgxYTY5MTVhYzdiYjM5MGVlNWFmY2Y2NTY1ZjllN2Mx MjJhMWYxNC4uZjhjODJjN2UzMDEwMGFkMjhhMjFiZGUyOGQ4OTBmNDEyNjU4Njc3NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA0LTIxICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CisKKyAgICAg ICAgQmluZGluZ3MtdGVzdCBzaG91bGQgbm90IGRlcGVuZCBvbiBjdXJyZW50IHdvcmtpbmcgZGly ZWN0b3J5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjEwODMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHk6CisgICAgICAgIChCaW5kaW5nc1Rl c3RzLm1haW4pOgorCiAyMDIwLTA0LTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIENvcnJlY3QgdGhlIHBhdGggdG8gbGliY2xhbmdfcnQuYXNhbl9pb3Nz aW1fZHluYW1pYy5keWxpYiBpbiBMQ19SUEFUSApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9iaW5kaW5ncy9tYWluLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iaW5kaW5n cy9tYWluLnB5CmluZGV4IDc5YTQ3ZDEyM2IyMmIxNGIxZDJlZmI0ZjQzNjhhODE3ZDQ3Mzk1NDYu Ljk3MGZkMGFkM2FhYzE2NTY4NTNiMjRmY2Q2MzBmMjE3OGNmMTk0OWQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvYmluZGluZ3MvbWFpbi5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2JpbmRpbmdzL21haW4ucHkKQEAgLTE3Niw3ICsxNzYsNyBAQCBjbGFzcyBCaW5k aW5nc1Rlc3RzOgogICAgICAgICByZXR1cm4gcGFzc2VkCiAKICAgICBkZWYgbWFpbihzZWxmKToK LSAgICAgICAgY3VycmVudF9zY20gPSBkZXRlY3Rfc2NtX3N5c3RlbShvcy5jdXJkaXIpCisgICAg ICAgIGN1cnJlbnRfc2NtID0gZGV0ZWN0X3NjbV9zeXN0ZW0ob3MucGF0aC5kaXJuYW1lKF9fZmls ZV9fKSkKICAgICAgICAgb3MuY2hkaXIob3MucGF0aC5qb2luKGN1cnJlbnRfc2NtLmNoZWNrb3V0 X3Jvb3QsICdTb3VyY2UnKSkKIAogICAgICAgICBhbGxfdGVzdHNfcGFzc2VkID0gVHJ1ZQo=