210821 2020-04-21 16:04:09 -0700 makeValueRefForValue should be robust against the type encoding of a NSNumber backed by a boolean 2020-04-23 16:01:33 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ap darin mjs sam thorton webkit-bug-importer oldest_to_newest 1644069 0 saam 2020-04-21 16:04:09 -0700 ... 1644070 1 webkit-bug-importer 2020-04-21 16:04:18 -0700 <rdar://problem/62136598> 1644071 2 397136 saam 2020-04-21 16:09:40 -0700 Created attachment 397136 patch 1644338 3 ews-feeder 2020-04-22 09:22:43 -0700 Committed r260515: <https://trac.webkit.org/changeset/260515> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397136. 1644999 4 397136 darin 2020-04-23 16:01:33 -0700 Comment on attachment 397136 patch View in context: https://bugs.webkit.org/attachment.cgi?id=397136&action=review > Tools/ChangeLog:5 > + makeValueRefForValue should be robust against the type encoding of a NSNumber backed by a boolean > + https://bugs.webkit.org/show_bug.cgi?id=210821 > + <rdar://problem/62136598> Does anything like this affect JavaScript’s Objective-C API, beyond our testing tool? 397136 2020-04-21 16:09:40 -0700 2020-04-22 09:22:44 -0700 patch b-backup.diff text/plain 1488 saam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MDQ3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA0LTIxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor CisgICAgICAgIG1ha2VWYWx1ZVJlZkZvclZhbHVlIHNob3VsZCBiZSByb2J1c3QgYWdhaW5zdCB0 aGUgdHlwZSBlbmNvZGluZyBvZiBhIE5TTnVtYmVyIGJhY2tlZCBieSBhIGJvb2xlYW4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDgyMQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNjIxMzY1OTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eU5v dGlmaWNhdGlvbkhhbmRsZXIubW06CisgICAgICAgIChtYWtlVmFsdWVSZWZGb3JWYWx1ZSk6CisK IDIwMjAtMDQtMjEgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg IEF0dGVtcHQgdG8gZml4IHRoZSBidWlsZCBhZnRlciByMjYwNDQ5CkluZGV4OiBUb29scy9EdW1w UmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbkhhbmRsZXIubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlOb3RpZmljYXRp b25IYW5kbGVyLm1tCShyZXZpc2lvbiAyNjA0MzUpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9t YWMvQWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbkhhbmRsZXIubW0JKHdvcmtpbmcgY29weSkKQEAg LTEwNiw3ICsxMDYsNyBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBtYWtlVmFsdWVSZWZGb3JWYWx1ZShK CiAgICAgaWYgKFt2YWx1ZSBpc0tpbmRPZkNsYXNzOltOU1N0cmluZyBjbGFzc11dKQogICAgICAg ICByZXR1cm4gSlNWYWx1ZU1ha2VTdHJpbmcoY29udGV4dCwgW3ZhbHVlIGNyZWF0ZUpTU3RyaW5n UmVmXS5nZXQoKSk7CiAgICAgaWYgKFt2YWx1ZSBpc0tpbmRPZkNsYXNzOltOU051bWJlciBjbGFz c11dKSB7Ci0gICAgICAgIGlmICghc3RyY21wKFt2YWx1ZSBvYmpDVHlwZV0sIEBlbmNvZGUoQk9P TCkpKQorICAgICAgICBpZiAoIXN0cmNtcChbdmFsdWUgb2JqQ1R5cGVdLCBAZW5jb2RlKEJPT0wp KSB8fCAhc3RyY21wKFt2YWx1ZSBvYmpDVHlwZV0sICJjIikpCiAgICAgICAgICAgICByZXR1cm4g SlNWYWx1ZU1ha2VCb29sZWFuKGNvbnRleHQsIFt2YWx1ZSBib29sVmFsdWVdKTsKICAgICAgICAg cmV0dXJuIEpTVmFsdWVNYWtlTnVtYmVyKGNvbnRleHQsIFt2YWx1ZSBkb3VibGVWYWx1ZV0pOwog ICAgIH0K