210819 2020-04-21 15:41:35 -0700 [Cocoa] Don't bother compiling UpdateInfo since it's not used 2020-04-21 16:20:12 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham cdumez darin ddkilzer webkit-bug-importer oldest_to_newest 1644048 0 bfulgham 2020-04-21 15:41:35 -0700 We don't use the UpdateInfo class in Cocoa-based builds, so let's not bother building it! 1644050 1 397132 bfulgham 2020-04-21 15:43:28 -0700 Created attachment 397132 Patch 1644053 2 397132 darin 2020-04-21 15:46:17 -0700 Comment on attachment 397132 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397132&action=review > Source/WebKit/UIProcess/DrawingAreaProxy.h:55 > +#if USE(COORDINATED_GRAPHICS) || USE(TEXTURE_MAPPER) > +class UpdateInfo; > +#endif Seems overkill to make the forward declaration conditional. OK, but maybe not necessary to be so careful. 1644072 3 ews-feeder 2020-04-21 16:12:33 -0700 Committed r260473: <https://trac.webkit.org/changeset/260473> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397132. 1644074 4 webkit-bug-importer 2020-04-21 16:13:15 -0700 <rdar://problem/62137073> 1644082 5 bfulgham 2020-04-21 16:20:12 -0700 This was actually <rdar://problem/61774766>. 397132 2020-04-21 15:43:28 -0700 2020-04-21 16:12:34 -0700 Patch bug-210819-20200421154327.patch text/plain 2959 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFlNTljNDc5MDg5ZDc3Mjk4 Y2I4ZTYwYmMzZGVhM2RjYTRkN2E1OTYuLmY1N2RkOWM4MjZhMmJkNmEzOTk0ZjhiZDc0MTk0OGEw MGIyMmI2MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDQtMjEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBEb24ndCBib3Ro ZXIgY29tcGlsaW5nIFVwZGF0ZUluZm8gc2luY2UgaXQncyBub3QgdXNlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwODE5CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS82MTc3NDc2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW5jZSB3ZSBkb24ndCB1c2UgdGhlIFVwZGF0ZUluZm8gY2xhc3MgaW4g Q29jb2EgYnVpbGRzLCBsZXQncyBub3QKKyAgICAgICAgYm90aGVyIGJ1aWxkaW5nIGl0LgorCisg ICAgICAgICogU2hhcmVkL1VwZGF0ZUluZm8uY3BwOgorICAgICAgICAqIFNoYXJlZC9VcGRhdGVJ bmZvLmg6CisgICAgICAgICogVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaDoKKwogMjAyMC0w NC0yMSAgVGltb3RoeSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAg ICAgT25lIG1vcmUgYnVpbGQgZml4IGFmdGVyIHIyNjA0MDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL1VwZGF0ZUluZm8uY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvVXBkYXRl SW5mby5jcHAKaW5kZXggNDUwMmNlMTdhZDhjMjkwYjUxY2JlYTFlMjQ0YzdmYTM0ZjEwOTAxOS4u ZDNhMDA0NGVkNjE2ODg4ZDk4ZmQxYzM0MGZkMmNkMzZjYWNjZmY0YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9TaGFyZWQvVXBkYXRlSW5mby5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFy ZWQvVXBkYXRlSW5mby5jcHAKQEAgLTI2LDYgKzI2LDggQEAKICNpbmNsdWRlICJjb25maWcuaCIK ICNpbmNsdWRlICJVcGRhdGVJbmZvLmgiCiAKKyNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1Mp IHx8IFVTRShURVhUVVJFX01BUFBFUikKKwogI2luY2x1ZGUgIldlYkNvcmVBcmd1bWVudENvZGVy cy5oIgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAgLTY4LDMgKzcwLDUgQEAgYm9vbCBVcGRhdGVJ bmZvOjpkZWNvZGUoSVBDOjpEZWNvZGVyJiBkZWNvZGVyLCBVcGRhdGVJbmZvJiByZXN1bHQpCiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAorCisjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL1VwZGF0ZUluZm8uaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1VwZGF0ZUlu Zm8uaAppbmRleCA2MDExYzgwYjdlZDM1ZmU3OWUwNzkxYjYxY2RiNDU1YTYxOTA2ODI0Li5kYmIx YmUyODM0OGMxMWIxZmVhMDg5N2EzNjZiODRlNThhZDIzNDY0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9VcGRhdGVJbmZvLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvVXBk YXRlSW5mby5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMSBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEtMjAyMCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKQEAgLTIzLDggKzIzLDkgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KICAqLwogCi0jaWZuZGVmIFVwZGF0ZUluZm9faAotI2RlZmluZSBVcGRhdGVJbmZvX2gKKyNw cmFnbWEgb25jZQorCisjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKSB8fCBVU0UoVEVYVFVS RV9NQVBQRVIpCiAKICNpbmNsdWRlICJTaGFyZWFibGVCaXRtYXAuaCIKICNpbmNsdWRlIDxXZWJD b3JlL0ludFJlY3QuaD4KQEAgLTc1LDQgKzc2LDQgQEAgcHVibGljOgogCiB9IC8vIG5hbWVzcGFj ZSBXZWJLaXQKIAotI2VuZGlmIC8vIFVwZGF0ZUluZm9faAorI2VuZGlmCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmgKaW5kZXggMmIxZTU4ZjcwNDMwNjYwY2Y5ZTNh NDVlNWFjMDIwZTdhODEyYmJiZS4uYjBhODU3MTY3OWQ2NmJiZGUxZjM4MGExMTQ3OTdiODhhYjFm NDRmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94 eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuaApAQCAt NDcsMTAgKzQ3LDEzIEBAIGNsYXNzIE1hY2hTZW5kUmlnaHQ7CiBuYW1lc3BhY2UgV2ViS2l0IHsK IAogY2xhc3MgTGF5ZXJUcmVlQ29udGV4dDsKLWNsYXNzIFVwZGF0ZUluZm87CiBjbGFzcyBXZWJQ YWdlUHJveHk7CiBjbGFzcyBXZWJQcm9jZXNzUHJveHk7CiAKKyNpZiBVU0UoQ09PUkRJTkFURURf R1JBUEhJQ1MpIHx8IFVTRShURVhUVVJFX01BUFBFUikKK2NsYXNzIFVwZGF0ZUluZm87CisjZW5k aWYKKwogY2xhc3MgRHJhd2luZ0FyZWFQcm94eSA6IHB1YmxpYyBJUEM6Ok1lc3NhZ2VSZWNlaXZl ciwgcHJvdGVjdGVkIElQQzo6TWVzc2FnZVNlbmRlciB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExP Q0FURUQ7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRHJhd2luZ0FyZWFQcm94eSk7Cg==