210812 2020-04-21 13:03:31 -0700 WTF API test for StringConcatenate failing for internal Apple builds 2020-04-22 14:00:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210845 https://bugs.webkit.org/show_bug.cgi?id=209694 InRadar P2 Normal --- 1 darin darin ap bfulgham oldest_to_newest 1643975 0 darin 2020-04-21 13:03:31 -0700 WTF API test for StringConcatenate failing for internal Apple builds 1643976 1 397107 darin 2020-04-21 13:05:50 -0700 Created attachment 397107 Patch 1643977 2 darin 2020-04-21 13:06:17 -0700 <rdar://problem/62117460> 1644000 3 397107 bfulgham 2020-04-21 13:41:37 -0700 Comment on attachment 397107 Patch Thank you for the fix! 1644006 4 ews-feeder 2020-04-21 13:52:58 -0700 Committed r260452: <https://trac.webkit.org/changeset/260452> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397107. 1644160 5 397107 ap 2020-04-21 19:16:53 -0700 Comment on attachment 397107 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397107&action=review Looks like a pretty bad handgun to have such code behave differently between build configurations. > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86 > + // FIXME: Remove this if statement once we have UChar as char16_t in all configurations. Is there a bug to follow to know when this happens? 1644205 6 darin 2020-04-21 21:55:53 -0700 (In reply to Alexey Proskuryakov from comment #5) > Looks like a pretty bad handgun to have such code behave differently between > build configurations. Agreed. > > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86 > > + // FIXME: Remove this if statement once we have UChar as char16_t in all configurations. > > Is there a bug to follow to know when this happens? Bug 210845. 1644483 7 ap 2020-04-22 14:00:40 -0700 FOOTgun :) 397107 2020-04-21 13:05:50 -0700 2020-04-21 13:52:59 -0700 Patch bug-210812-20200421130549.patch text/plain 2150 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNDQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTFhMmYxNDk4ZTY4YzBhMDg2MGY2ZWE2YTI2MTM1NTcz NWUwYzIxNS4uM2M3ODc4Y2E5N2NkYTA1MWUxMWM5YjM1ZjZjZGE4NDYyZjM3MmJjMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA0LTIxICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAg ICBXVEYgQVBJIHRlc3QgZm9yIFN0cmluZ0NvbmNhdGVuYXRlIGZhaWxpbmcgZm9yIGludGVybmFs IEFwcGxlIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEwODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdDb25jYXRlbmF0ZS5jcHA6Cisg ICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKTogQWRkIGJhY2sgYSBjYXNlIGZvciB3aGVuIFVD aGFyIGlzIHVpbnQxNl90LgorCiAyMDIwLTA0LTIxICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5 QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXNldCBtX3VzZXJTY3JpcHRzTm90aWZpZWQgd2hlbiB3 ZWIgcHJvY2VzcyBjcmFzaGVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XVEYvU3RyaW5nQ29uY2F0ZW5hdGUuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X VEYvU3RyaW5nQ29uY2F0ZW5hdGUuY3BwCmluZGV4IDczOTE1OGU5Mjg2ZWRlYWRkNDJmZjBhYzVj NDIxYjUzMTY1OGI5ZDIuLmRhMDhmNGZkZjRjMDJmZjNhN2RiMzVjZWY0MGNkYzA3ZjRjODMzMjAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1N0cmluZ0NvbmNhdGVu YXRlLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdDb25jYXRl bmF0ZS5jcHAKQEAgLTgzLDcgKzgzLDExIEBAIFRFU1QoV1RGLCBTdHJpbmdDb25jYXRlbmF0ZV9V bnNpZ25lZCkKICAgICBFWFBFQ1RfU1RSRVEoImhlbGxvIDAgd29ybGQiLCBtYWtlU3RyaW5nKCJo ZWxsbyAiLCAwdSAsICIgd29ybGQiKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIEVYUEVDVF9TVFJF USgiaGVsbG8gNDIgd29ybGQiLCBtYWtlU3RyaW5nKCJoZWxsbyAiLCBzdGF0aWNfY2FzdDx1bnNp Z25lZCBjaGFyPig0MikgLCAiIHdvcmxkIikudXRmOCgpLmRhdGEoKSk7Ci0gICAgRVhQRUNUX1NU UkVRKCJoZWxsbyA0MiB3b3JsZCIsIG1ha2VTdHJpbmcoImhlbGxvICIsIHN0YXRpY19jYXN0PHVu c2lnbmVkIHNob3J0Pig0MikgLCAiIHdvcmxkIikudXRmOCgpLmRhdGEoKSk7CisgICAgLy8gRklY TUU6IFJlbW92ZSB0aGlzIGlmIHN0YXRlbWVudCBvbmNlIHdlIGhhdmUgVUNoYXIgYXMgY2hhcjE2 X3QgaW4gYWxsIGNvbmZpZ3VyYXRpb25zLgorICAgIGlmIGNvbnN0ZXhwciAoc3RkOjppc19zYW1l X3Y8VUNoYXIsIHVpbnQxNl90PikKKyAgICAgICAgRVhQRUNUX1NUUkVRKCJoZWxsbyAqIHdvcmxk IiwgbWFrZVN0cmluZygiaGVsbG8gIiwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgc2hvcnQ+KDQyKSAs ICIgd29ybGQiKS51dGY4KCkuZGF0YSgpKTsKKyAgICBlbHNlCisgICAgICAgIEVYUEVDVF9TVFJF USgiaGVsbG8gNDIgd29ybGQiLCBtYWtlU3RyaW5nKCJoZWxsbyAiLCBzdGF0aWNfY2FzdDx1bnNp Z25lZCBzaG9ydD4oNDIpICwgIiB3b3JsZCIpLnV0ZjgoKS5kYXRhKCkpOwogICAgIEVYUEVDVF9T VFJFUSgiaGVsbG8gNCB3b3JsZCIsIG1ha2VTdHJpbmcoImhlbGxvICIsIHNpemVvZihpbnQpICwg IiB3b3JsZCIpLnV0ZjgoKS5kYXRhKCkpOyAvLyBzaXplX3QKICAgICBFWFBFQ1RfU1RSRVEoImhl bGxvIDQgd29ybGQiLCBtYWtlU3RyaW5nKCJoZWxsbyAiLCBvZmZzZXRvZihTLCBpKSAsICIgd29y bGQiKS51dGY4KCkuZGF0YSgpKTsgLy8gc2l6ZV90CiAgICAgRVhQRUNUX1NUUkVRKCJoZWxsbyAz MjM1ODM5NzQyIHdvcmxkIiwgbWFrZVN0cmluZygiaGVsbG8gIiwgc3RhdGljX2Nhc3Q8c2l6ZV90 PigweGMwZGVmZWZlKSwgIiB3b3JsZCIpLnV0ZjgoKS5kYXRhKCkpOwo=