210811 2020-04-21 12:13:58 -0700 Move WebKit.WebViewCategory test to InAppBrowserPrivacy.mm 2020-04-21 13:49:37 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney aestes ap bfulgham wilander oldest_to_newest 1643958 0 katherine_cheney 2020-04-21 12:13:58 -0700 This test was added before InAppBrowserPrivacy.mm existed. It should be moved here so it has access to all setup/cleanup needed by these tests 1643959 1 katherine_cheney 2020-04-21 12:14:17 -0700 <rdar://problem/60972505> 1643960 2 397104 katherine_cheney 2020-04-21 12:16:07 -0700 Created attachment 397104 Patch 1643990 3 397104 ap 2020-04-21 13:23:25 -0700 Comment on attachment 397104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397104&action=review rs=me > Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-65 > - auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]); > - EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryAppBoundDomain); Can you add an explanation to ChangeLog about why this failed? Naively, I would expect the state of an object that was just init'ed to always the the same, and not require "initializeInAppBrowserPrivacyTestSettings()". > Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-71 > - [configuration _setWebViewCategory:_WKWebViewCategoryInAppBrowser]; > - EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryInAppBrowser); > - > - [configuration _setWebViewCategory:_WKWebViewCategoryWebBrowser]; > - EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryWebBrowser); Seems OK to move everything, but it may be even better to keep tests for other categories here. 1644003 4 ews-feeder 2020-04-21 13:49:36 -0700 Committed r260451: <https://trac.webkit.org/changeset/260451> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397104. 397104 2020-04-21 12:16:07 -0700 2020-04-21 13:49:37 -0700 Patch bug-210811-20200421121607.patch text/plain 3409 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNDQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTFhMmYxNDk4ZTY4YzBhMDg2MGY2ZWE2YTI2MTM1NTcz NWUwYzIxNS4uMjdjMjdiMmMyYWZiYjZkZjVkMWRiOGJhN2I2MTRjNTNjMzZlZTViMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTA0LTIxICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29t PgorCisgICAgICAgIE1vdmUgV2ViS2l0LldlYlZpZXdDYXRlZ29yeSB0ZXN0IHRvIEluQXBwQnJv d3NlclByaXZhY3kubW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMDgxMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjA5NzI1MDU+IAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdGVzdCB3YXMg YWRkZWQgYmVmb3JlIEluQXBwQnJvd3NlclByaXZhY3kubW0gZXhpc3RlZC4gSXQgc2hvdWxkCisg ICAgICAgIGJlIG1vdmVkIGhlcmUgc28gaXQgaGFzIGFjY2VzcyB0byBhbGwgc2V0dXAvY2xlYW51 cCBuZWVkZWQgYnkgdGhlc2UKKyAgICAgICAgdGVzdHMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL0NvbmZpZ3VyYXRpb24ubW06CisgICAgICAgICogVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9JbkFwcEJyb3dzZXJQcml2YWN5Lm1tOgorCiAyMDIw LTA0LTIxICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXNldCBtX3VzZXJTY3JpcHRzTm90aWZpZWQgd2hlbiB3ZWIgcHJvY2VzcyBjcmFzaGVzLgpkaWZm IC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Db25maWd1cmF0 aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Db25maWd1cmF0 aW9uLm1tCmluZGV4IGJkN2RkY2E1ZTFmYzUxMWU3YzAxNzUzOTliODBjY2Y4YmIzZGYwYTkuLmY3 MzM3YTZjMDg1YjM1YWE4YWYxNTRjODEzNjAyY2Q5NmRjNWQ4MzcgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvQ29uZmlndXJhdGlvbi5tbQorKysgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0NvbmZpZ3VyYXRpb24ubW0KQEAg LTU5LDE5ICs1OSw0IEBAIFRFU1QoV2ViS2l0LCBDb25maWd1cmF0aW9uRHJhd3NCYWNrZ3JvdW5k KQogICAgIEVYUEVDVF9FUShbY29uZmlnZWRXZWJWaWV3IF9kcmF3c0JhY2tncm91bmRdLCBOTyk7 CiB9CiAKLVRFU1QoV2ViS2l0LCBXZWJWaWV3Q2F0ZWdvcnkpCi17Ci0gICAgYXV0byBjb25maWd1 cmF0aW9uID0gYWRvcHROUyhbW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gYWxsb2NdIGluaXRdKTsK LSAgICBFWFBFQ1RfRVEoW2NvbmZpZ3VyYXRpb24gX3dlYlZpZXdDYXRlZ29yeV0sIF9XS1dlYlZp ZXdDYXRlZ29yeUFwcEJvdW5kRG9tYWluKTsKLQotICAgIFtjb25maWd1cmF0aW9uIF9zZXRXZWJW aWV3Q2F0ZWdvcnk6X1dLV2ViVmlld0NhdGVnb3J5SW5BcHBCcm93c2VyXTsKLSAgICBFWFBFQ1Rf RVEoW2NvbmZpZ3VyYXRpb24gX3dlYlZpZXdDYXRlZ29yeV0sIF9XS1dlYlZpZXdDYXRlZ29yeUlu QXBwQnJvd3Nlcik7Ci0KLSAgICBbY29uZmlndXJhdGlvbiBfc2V0V2ViVmlld0NhdGVnb3J5Ol9X S1dlYlZpZXdDYXRlZ29yeVdlYkJyb3dzZXJdOwotICAgIEVYUEVDVF9FUShbY29uZmlndXJhdGlv biBfd2ViVmlld0NhdGVnb3J5XSwgX1dLV2ViVmlld0NhdGVnb3J5V2ViQnJvd3Nlcik7Ci0KLSAg ICBbY29uZmlndXJhdGlvbiBfc2V0V2ViVmlld0NhdGVnb3J5Ol9XS1dlYlZpZXdDYXRlZ29yeUFw cEJvdW5kRG9tYWluXTsKLSAgICBFWFBFQ1RfRVEoW2NvbmZpZ3VyYXRpb24gX3dlYlZpZXdDYXRl Z29yeV0sIF9XS1dlYlZpZXdDYXRlZ29yeUFwcEJvdW5kRG9tYWluKTsKLX0KLQogI2VuZGlmCmRp ZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0luQXBwQnJv d3NlclByaXZhY3kubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0lu QXBwQnJvd3NlclByaXZhY3kubW0KaW5kZXggM2E4MmFmYWVkMzM0NWE1MDE5ZTNjMjQ4OGUxZDQ2 NTgyY2U1Y2Q1OC4uZGJmNTgzMmE2Yzg2MTQyYTM1MzQwNGIyYzM4NDZiODE2ODVmNGI0MyAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9JbkFwcEJyb3dz ZXJQcml2YWN5Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev SW5BcHBCcm93c2VyUHJpdmFjeS5tbQpAQCAtMTAyOCw2ICsxMDI4LDI1IEBAIFRFU1QoSW5BcHBC cm93c2VyUHJpdmFjeSwgV2ViVmlld0Nhbm5vdFVwZGF0ZUFwcEJvdW5kRmxhZ09uY2VTZXQpCiAg ICAgY2xlYW5VcEluQXBwQnJvd3NlclByaXZhY3lUZXN0U2V0dGluZ3MoKTsKIH0KIAorVEVTVChJ bkFwcEJyb3dzZXJQcml2YWN5LCBXZWJWaWV3Q2F0ZWdvcnkpCit7CisgICAgaW5pdGlhbGl6ZUlu QXBwQnJvd3NlclByaXZhY3lUZXN0U2V0dGluZ3MoKTsKKworICAgIGF1dG8gY29uZmlndXJhdGlv biA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0aW9uIGFsbG9jXSBpbml0XSk7CisgICAg RVhQRUNUX0VRKFtjb25maWd1cmF0aW9uIF93ZWJWaWV3Q2F0ZWdvcnldLCBfV0tXZWJWaWV3Q2F0 ZWdvcnlBcHBCb3VuZERvbWFpbik7CisKKyAgICBbY29uZmlndXJhdGlvbiBfc2V0V2ViVmlld0Nh dGVnb3J5Ol9XS1dlYlZpZXdDYXRlZ29yeUluQXBwQnJvd3Nlcl07CisgICAgRVhQRUNUX0VRKFtj b25maWd1cmF0aW9uIF93ZWJWaWV3Q2F0ZWdvcnldLCBfV0tXZWJWaWV3Q2F0ZWdvcnlJbkFwcEJy b3dzZXIpOworCisgICAgW2NvbmZpZ3VyYXRpb24gX3NldFdlYlZpZXdDYXRlZ29yeTpfV0tXZWJW aWV3Q2F0ZWdvcnlXZWJCcm93c2VyXTsKKyAgICBFWFBFQ1RfRVEoW2NvbmZpZ3VyYXRpb24gX3dl YlZpZXdDYXRlZ29yeV0sIF9XS1dlYlZpZXdDYXRlZ29yeVdlYkJyb3dzZXIpOworCisgICAgW2Nv bmZpZ3VyYXRpb24gX3NldFdlYlZpZXdDYXRlZ29yeTpfV0tXZWJWaWV3Q2F0ZWdvcnlBcHBCb3Vu ZERvbWFpbl07CisgICAgRVhQRUNUX0VRKFtjb25maWd1cmF0aW9uIF93ZWJWaWV3Q2F0ZWdvcnld LCBfV0tXZWJWaWV3Q2F0ZWdvcnlBcHBCb3VuZERvbWFpbik7CisKKyAgICBjbGVhblVwSW5BcHBC cm93c2VyUHJpdmFjeVRlc3RTZXR0aW5ncygpOworfQorCiAjZW5kaWYgLy8gVVNFKEFQUExFX0lO VEVSTkFMX1NESykKIAogI2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1JTFkpCg==