210804 2020-04-21 10:42:39 -0700 [Flatpak SDK] Regenerate toolchains only if new updates were downloaded 2020-04-27 03:01:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand dpino webkit-bug-importer zan oldest_to_newest 1643921 0 pnormand 2020-04-21 10:42:39 -0700 Currently we unconditionally regenerate toolchains. We should be smarter there. 1644388 1 397223 pnormand 2020-04-22 10:41:57 -0700 Created attachment 397223 Patch 1645943 2 ews-feeder 2020-04-27 03:00:29 -0700 Committed r260747: <https://trac.webkit.org/changeset/260747> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397223. 1645944 3 webkit-bug-importer 2020-04-27 03:01:15 -0700 <rdar://problem/62439671> 397223 2020-04-22 10:41:57 -0700 2020-04-27 03:00:30 -0700 Patch bug-210804-20200422184156.patch text/plain 5665 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNTA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOThiMjY1ZmM4MzUwYjFmMmM3NzBjNmYzOWFkZWM4YTQ1 ZGJkY2FmMy4uOTNmNzJlM2NhNTY3MjNmMWMzOTE3NmZkODZlYTBiYjU1ZjczMjYxNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTA0LTIyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbRmxhdHBhayBTREtdIFJlZ2VuZXJhdGUgdG9vbGNoYWlucyBvbmx5IGlmIG5l dyB1cGRhdGVzIHdlcmUgZG93bmxvYWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEwODA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIFNESyB0b29sY2hhaW4gYXJjaGl2ZXMgYXJlIG5vdyByZWdl bmVyYXRlZCBvbmx5IGlmIGFuIGFjdHVhbAorICAgICAgICB1cGRhdGUgd2FzIGRvd25sb2FkZWQg ZnJvbSB0aGUgRmxhdHBhayByZXBvc2l0b3J5LiBTb21lIHJlZHVuZGFudAorICAgICAgICBmbGF0 cGFrIGNhbGxzIHdlcmUgcmVtb3ZlZCBhcyB3ZWxsLCBzdWNoIGFzIHRoZSBHTCBleHRlbnNpb24g YW5kCisgICAgICAgIERlYnVnIHJlaW5zdGFsbHMgdGhhdCB3ZXJlIGhhcHBlbmluZyBkdXJpbmcg d2Via2l0LWZsYXRwYWsKKyAgICAgICAgdXBkYXRlcy4KKworICAgICAgICAqIGZsYXRwYWsvZmxh dHBha3V0aWxzLnB5OgorICAgICAgICAoRmxhdHBha09iamVjdC5mbGF0cGFrKToKKyAgICAgICAg KEZsYXRwYWtSZXBvLl9faW5pdF9fKToKKyAgICAgICAgKFdlYmtpdEZsYXRwYWsubWFpbik6Cisg ICAgICAgIChXZWJraXRGbGF0cGFrLnNldHVwX2Rldl9lbnYpOgorCiAyMDIwLTA0LTIxICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJl dmVydGluZyByMjYwNDEwLgpkaWZmIC0tZ2l0IGEvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMu cHkgYi9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQppbmRleCBiNjM0ZDg3ZTE2NzhjZWE0 OWI0ZDViYWIxZjFmZTI0YzAxNTM4NDk4Li45NWRjNDExMzQwMmUwMDNjMTZiM2M0OWU5NWZhYjYx ZDJlMWNiMWVkIDEwMDY0NAotLS0gYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQorKysg Yi9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQpAQCAtMTU2LDIyICsxNTYsMzEgQEAgY2xh c3MgRmxhdHBha09iamVjdDoKICAgICBkZWYgZmxhdHBhayhzZWxmLCBjb21tYW5kLCAqYXJncywg Kiprd2FyZ3MpOgogICAgICAgICBzaG93X291dHB1dCA9IGt3YXJncy5wb3AoInNob3dfb3V0cHV0 IiwgRmFsc2UpCiAgICAgICAgIGNvbW1lbnQgPSBrd2FyZ3MucG9wKCJjb21tZW50IiwgTm9uZSkK KyAgICAgICAgZ2F0aGVyX291dHB1dCA9IGt3YXJncy5nZXQoImdhdGhlcl9vdXRwdXQiLCBGYWxz ZSkKICAgICAgICAgaWYgY29tbWVudDoKICAgICAgICAgICAgIENvbnNvbGUubWVzc2FnZShjb21t ZW50KQogCiAgICAgICAgIGNvbW1hbmQgPSBbImZsYXRwYWsiLCBjb21tYW5kXQotICAgICAgICBy ZXMgPSBzdWJwcm9jZXNzLmNoZWNrX291dHB1dChjb21tYW5kICsgWyItLWhlbHAiXSkuZGVjb2Rl KCJ1dGYtOCIpCi0gICAgICAgIGlmIHNlbGYudXNlciBhbmQgIi0tdXNlciIgaW4gcmVzOgorICAg ICAgICBoZWxwX291dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KGNvbW1hbmQgKyBbIi0t aGVscCJdKS5kZWNvZGUoInV0Zi04IikKKyAgICAgICAgaWYgc2VsZi51c2VyIGFuZCAiLS11c2Vy IiBpbiBoZWxwX291dHB1dDoKICAgICAgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLXVzZXIiKQot ICAgICAgICBpZiAiLS1hc3N1bWV5ZXMiIGluIHJlczoKKyAgICAgICAgaWYgIi0tYXNzdW1leWVz IiBpbiBoZWxwX291dHB1dDoKICAgICAgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLWFzc3VtZXll cyIpCisgICAgICAgIGlmICItLW5vbmludGVyYWN0aXZlIiBhbmQgZ2F0aGVyX291dHB1dDoKKyAg ICAgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLW5vbmludGVyYWN0aXZlIikKKwogICAgICAgICBj b21tYW5kLmV4dGVuZChhcmdzKQogCiAgICAgICAgIF9sb2cuZGVidWcoIkV4ZWN1dGluZyAlcyIg JSAnICcuam9pbihjb21tYW5kKSkKICAgICAgICAgaWYgbm90IHNob3dfb3V0cHV0OgogICAgICAg ICAgICAgcmV0dXJuIHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KGNvbW1hbmQpLmRlY29kZSgidXRm LTgiKQogCi0gICAgICAgIHJldHVybiBzdWJwcm9jZXNzLmNoZWNrX2NhbGwoY29tbWFuZCkKKyAg ICAgICAgaWYgbm90IGdhdGhlcl9vdXRwdXQ6CisgICAgICAgICAgICByZXR1cm4gc3VicHJvY2Vz cy5jaGVja19jYWxsKGNvbW1hbmQpCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBwID0gc3Vi cHJvY2Vzcy5Qb3Blbihjb21tYW5kLCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFKQorICAgICAgICAg ICAgb3V0cHV0ID0gcC5jb21tdW5pY2F0ZSgpCisgICAgICAgICAgICByZXR1cm4gb3V0cHV0CiAK IAogY2xhc3MgRmxhdHBha1BhY2thZ2VzKEZsYXRwYWtPYmplY3QpOgpAQCAtMjcyLDExICsyODEs OSBAQCBjbGFzcyBGbGF0cGFrUmVwbyhGbGF0cGFrT2JqZWN0KToKICAgICAgICAgICAgIGFzc2Vy dCB1cmwKIAogICAgICAgICBzZWxmLl9hcHBfcmVnaXN0cnkgPSB7fQotICAgICAgICBvdXRwdXQg PSBzZWxmLmZsYXRwYWsoImxpc3QiLCAiLS1jb2x1bW5zPWFwcGxpY2F0aW9uLGJyYW5jaCxvcmln aW4iKQorICAgICAgICBvdXRwdXQgPSBzZWxmLmZsYXRwYWsoImxpc3QiLCAiLS1jb2x1bW5zPWFw cGxpY2F0aW9uLGJyYW5jaCIsICItYSIpCiAgICAgICAgIGZvciBsaW5lIGluIG91dHB1dC5zcGxp dGxpbmVzKCk6Ci0gICAgICAgICAgICBuYW1lLCBicmFuY2gsIG9yaWdpbiA9IGxpbmUuc3BsaXQo Ilx0IikKLSAgICAgICAgICAgIGlmIG9yaWdpbiAhPSBzZWxmLm5hbWU6Ci0gICAgICAgICAgICAg ICAgY29udGludWUKKyAgICAgICAgICAgIG5hbWUsIGJyYW5jaCA9IGxpbmUuc3BsaXQoIlx0IikK ICAgICAgICAgICAgIHNlbGYuX2FwcF9yZWdpc3RyeVtuYW1lXSA9IGJyYW5jaAogCiAgICAgZGVm IGlzX2FwcF9pbnN0YWxsZWQoc2VsZiwgbmFtZSwgYnJhbmNoPU5vbmUpOgpAQCAtNzYxLDE2ICs3 NjgsMjggQEAgY2xhc3MgV2Via2l0RmxhdHBhazoKIAogICAgICAgICBpZiBzZWxmLnVwZGF0ZToK ICAgICAgICAgICAgIHJlcG8gPSBzZWxmLnNka19yZXBvCi0gICAgICAgICAgICByZXBvLmZsYXRw YWsoInVwZGF0ZSIsIHNob3dfb3V0cHV0PVRydWUsIGNvbW1lbnQ9IlVwZGF0aW5nIEZsYXRwYWsg JXMgZW52aXJvbm1lbnQiICUgc2VsZi5idWlsZF90eXBlKQorICAgICAgICAgICAgdXBkYXRlX291 dHB1dCA9IHJlcG8uZmxhdHBhaygidXBkYXRlIiwgZ2F0aGVyX291dHB1dD1UcnVlLCBjb21tZW50 PSJVcGRhdGluZyBGbGF0cGFrICVzIGVudmlyb25tZW50IiAlIHNlbGYuYnVpbGRfdHlwZSkKKyAg ICAgICAgICAgIHJlZ2VuZXJhdGVfdG9vbGNoYWlucyA9IHVwZGF0ZV9vdXRwdXQuZmluZCgiTm90 aGluZyB0byBkbyIpID09IC0xCisKICAgICAgICAgICAgIGZvciBwYWNrYWdlIGluIHNlbGYuX2dl dF9wYWNrYWdlcygpOgogICAgICAgICAgICAgICAgIGlmIHBhY2thZ2UubmFtZS5zdGFydHN3aXRo KCJvcmcud2Via2l0IikgYW5kIHJlcG8uaXNfYXBwX2luc3RhbGxlZChwYWNrYWdlLm5hbWUpIFwK ICAgICAgICAgICAgICAgICAgICBhbmQgbm90IHJlcG8uaXNfYXBwX2luc3RhbGxlZChwYWNrYWdl Lm5hbWUsIGJyYW5jaD1zZWxmLnNka19icmFuY2gpOgogICAgICAgICAgICAgICAgICAgICBDb25z b2xlLm1lc3NhZ2UoIk5ldyBTREsgdmVyc2lvbiBhdmFpbGFibGUsIHJlbW92aW5nIGxvY2FsIFVz ZXJGbGF0cGFrIGRpcmVjdG9yeSBiZWZvcmUgc3dpdGNoaW5nIHRvIG5ldyB2ZXJzaW9uIikKICAg ICAgICAgICAgICAgICAgICAgc2h1dGlsLnJtdHJlZShzZWxmLmZsYXRwYWtfYnVpbGRfcGF0aCkK ICAgICAgICAgICAgICAgICAgICAgc2VsZi5fcmVzZXRfcmVwb3NpdG9yeSgpCisgICAgICAgICAg ICAgICAgICAgIHJlZ2VuZXJhdGVfdG9vbGNoYWlucyA9IFRydWUKICAgICAgICAgICAgICAgICAg ICAgYnJlYWsKICAgICAgICAgICAgICAgICBlbGlmIG5vdCByZXBvLmlzX2FwcF9pbnN0YWxsZWQo cGFja2FnZS5uYW1lKToKICAgICAgICAgICAgICAgICAgICAgcGFja2FnZS5pbnN0YWxsKCkKKyAg ICAgICAgICAgICAgICAgICAgcmVnZW5lcmF0ZV90b29sY2hhaW5zID0gVHJ1ZQorICAgICAgICBl bHNlOgorICAgICAgICAgICAgcmVnZW5lcmF0ZV90b29sY2hhaW5zID0gc2VsZi5yZWdlbmVyYXRl X3Rvb2xjaGFpbnMKKworICAgICAgICBpZiByZWdlbmVyYXRlX3Rvb2xjaGFpbnM6CisgICAgICAg ICAgICBzZWxmLmljY192ZXJzaW9uID0ge30KKyAgICAgICAgICAgIHNlbGYuc2V0dXBfaWNlY2Mo ImdjYyIpCisgICAgICAgICAgICBzZWxmLnNldHVwX2ljZWNjKCJjbGFuZyIpCisgICAgICAgICAg ICBzZWxmLnNhdmVfY29uZmlnKCkKIAogICAgICAgICByZXR1cm4gc2VsZi5zZXR1cF9kZXZfZW52 KCkKIApAQCAtODA5LDE1ICs4MjgsNiBAQCBjbGFzcyBXZWJraXRGbGF0cGFrOgogICAgIGRlZiBz ZXR1cF9kZXZfZW52KHNlbGYpOgogICAgICAgICBpZiBub3Qgb3MucGF0aC5leGlzdHMob3MucGF0 aC5qb2luKHNlbGYuZmxhdHBha19idWlsZF9wYXRoLCAicnVudGltZSIsICJvcmcud2Via2l0LlNk ayIpKSBvciBzZWxmLnVwZGF0ZToKICAgICAgICAgICAgIHNlbGYuaW5zdGFsbF9hbGwoKQotICAg ICAgICAgICAgcmVnZW5lcmF0ZV90b29sY2hhaW5zID0gVHJ1ZQotICAgICAgICBlbHNlOgotICAg ICAgICAgICAgcmVnZW5lcmF0ZV90b29sY2hhaW5zID0gc2VsZi5yZWdlbmVyYXRlX3Rvb2xjaGFp bnMKLQotICAgICAgICBpZiByZWdlbmVyYXRlX3Rvb2xjaGFpbnM6Ci0gICAgICAgICAgICBzZWxm LmljY192ZXJzaW9uID0ge30KLSAgICAgICAgICAgIHNlbGYuc2V0dXBfaWNlY2MoImdjYyIpCi0g ICAgICAgICAgICBzZWxmLnNldHVwX2ljZWNjKCJjbGFuZyIpCi0gICAgICAgICAgICBzZWxmLnNh dmVfY29uZmlnKCkKIAogICAgICAgICBpZiBub3Qgc2VsZi51cGRhdGU6CiAgICAgICAgICAgICBm b3IgcGFja2FnZSBpbiBzZWxmLl9nZXRfcGFja2FnZXMoKToKQEAgLTgzMyw3ICs4NDMsNyBAQCBj bGFzcyBXZWJraXRGbGF0cGFrOgogICAgICAgICAgICAgICAgIHNlbGYudXNlcl9jb21tYW5kLmFw cGVuZCgiLS1jbWFrZWFyZ3M9JXMiICUgc2VsZi5jbWFrZWFyZ3MpCiAKICAgICAgICAgICAgIHJl dHVybiBzZWxmLnJ1bl9pbl9zYW5kYm94KCpzZWxmLnVzZXJfY29tbWFuZCkKLSAgICAgICAgZWxp ZiBub3Qgc2VsZi51cGRhdGUgYW5kIG5vdCBzZWxmLmJ1aWxkX2dzdDoKKyAgICAgICAgZWxpZiBu b3Qgc2VsZi51cGRhdGUgYW5kIG5vdCBzZWxmLmJ1aWxkX2dzdCBhbmQgbm90IHNlbGYucmVnZW5l cmF0ZV90b29sY2hhaW5zOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYucnVuX2luX3NhbmRib3go KQogCiAgICAgICAgIHJldHVybiAwCg==