210803 2020-04-21 10:40:40 -0700 [ews] Display error message when submit for EWS analysis button doesn't work 2020-07-15 13:22:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214372 InRadar P2 Normal --- 1 aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1643920 0 aakash_jain 2020-04-21 10:40:40 -0700 Currently the 'submit for EWS analysis' button doesn't work for security bugs which doesn't have any r? patch. However, worst part is that it silently fails, there is no error message or no clear indication that the button didn't work. Because of that users get confused (whether it is taking time, or not working, or why isn't it working, what should they do to fix it etc). EWS should display an error message when 'submit for EWS analysis' button doesn't work. 1643922 1 397094 aakash_jain 2020-04-21 10:43:05 -0700 Created attachment 397094 Patch 1643923 2 aakash_jain 2020-04-21 10:43:40 -0700 Sample runs: https://ews.webkit-uat.org/status-bubble/397091/ https://ews.webkit-uat.org/status-bubble/326588/ 1643934 3 ews-feeder 2020-04-21 11:13:40 -0700 Committed r260444: <https://trac.webkit.org/changeset/260444> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397094. 1643935 4 webkit-bug-importer 2020-04-21 11:14:13 -0700 <rdar://problem/62120159> 1643937 5 aakash_jain 2020-04-21 11:21:44 -0700 > Committed r260444: <https://trac.webkit.org/changeset/260444> Deployed on the server. 397094 2020-04-21 10:43:05 -0700 2020-04-21 11:13:40 -0700 Patch bug-210803-20200421134304.patch text/plain 4953 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MDQ0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTA0LTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBEaXNwbGF5IGVycm9yIG1lc3NhZ2Ugd2hlbiBzdWJtaXQgZm9y IEVXUyBhbmFseXNpcyBidXR0b24gZG9lc24ndCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA4MDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdz L3ZpZXdzL3N1Ym1pdHRvZXdzLnB5OgorICAgICAgICAoU3VibWl0VG9FV1MucG9zdCk6IERpc3Bs YXkgcmVsZXZhbnQgZXJyb3IgbWVzc2FnZSBvbiBzdWJtaXQgZm9yIEVXUyBhbmFseXNpcyBidXR0 b24gZmFpbHVyZS4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9mZXRj aGVyLnB5OgorICAgICAgICAoQnVnemlsbGFQYXRjaEZldGNoZXIuZmV0Y2gpOgorICAgICAgICAo QnVnemlsbGFQYXRjaEZldGNoZXIuc2VuZF9wYXRjaGVzX3RvX2J1aWxkYm90KToKKyAgICAgICAg KiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb25maWcucHk6IEFkZCBmZXcgbW9yZSBl cnJvciBjb2Rlcy4KKwogMjAyMC0wNC0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBDb3JyZWN0IHRoZSBwYXRoIHRvIGxpYmNsYW5nX3J0LmFzYW5faW9z c2ltX2R5bmFtaWMuZHlsaWIgaW4gTENfUlBBVEgKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1hcHAvZXdzL2NvbmZpZy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYXBwL2V3cy9jb25maWcucHkJKHJldmlzaW9uIDI2MDQ0MCkKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbmZpZy5weQkod29ya2luZyBjb3B5KQpA QCAtNDIsMyArNDIsNSBAQCBFUlJfVU5FWFBFQ1RFRCA9IC0xCiBFUlJfRVhJU1RJTkdfUEFUQ0gg PSAtMgogRVJSX05PTl9FWElTVElOR19QQVRDSCA9IC0zCiBFUlJfSU5WQUxJRF9QQVRDSF9JRCA9 IC00CitFUlJfT0JTT0xFVEVfUEFUQ0ggPSAtNQorRVJSX1VOQUJMRV9UT19GRVRDSF9QQVRDSCA9 IC02CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9mZXRjaGVyLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2ZldGNo ZXIucHkJKHJldmlzaW9uIDI2MDQ0MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1h cHAvZXdzL2ZldGNoZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTI4LDYgKzI4LDcgQEAgaW1wb3J0 IHRpbWUKIAogZnJvbSBld3MuY29tbW9uLmJ1Z3ppbGxhIGltcG9ydCBCdWd6aWxsYQogZnJvbSBl d3MuY29tbW9uLmJ1aWxkYm90IGltcG9ydCBCdWlsZGJvdAorZnJvbSBld3MuY29uZmlnIGltcG9y dCBFUlJfT0JTT0xFVEVfUEFUQ0gsIEVSUl9VTkFCTEVfVE9fRkVUQ0hfUEFUQ0gKIGZyb20gZXdz Lm1vZGVscy5wYXRjaCBpbXBvcnQgUGF0Y2gKIGZyb20gZXdzLnZpZXdzLnN0YXR1c2J1YmJsZSBp bXBvcnQgU3RhdHVzQnViYmxlCiAKQEAgLTY2LDcgKzY3LDcgQEAgY2xhc3MgQnVnemlsbGFQYXRj aEZldGNoZXIoKToKICAgICAgICAgUGF0Y2guc2F2ZV9wYXRjaGVzKHBhdGNoX2lkcykKICAgICAg ICAgcGF0Y2hlc190b19zZW5kID0gc2VsZi5wYXRjaGVzX3RvX3NlbmRfdG9fYnVpbGRib3QocGF0 Y2hfaWRzKQogICAgICAgICBfbG9nLmluZm8oJ3t9IHI/IHBhdGNoZXMsIHt9IHBhdGNoZXMgbmVl ZCB0byBiZSBzZW50IHRvIEJ1aWxkYm90OiB7fScuZm9ybWF0KGxlbihwYXRjaF9pZHMpLCBsZW4o cGF0Y2hlc190b19zZW5kKSwgcGF0Y2hlc190b19zZW5kKSkKLSAgICAgICAgc2VsZi5zZW5kX3Bh dGNoZXNfdG9fYnVpbGRib3QocGF0Y2hlc190b19zZW5kKQorICAgICAgICByZXR1cm4gc2VsZi5z ZW5kX3BhdGNoZXNfdG9fYnVpbGRib3QocGF0Y2hlc190b19zZW5kKQogCiAgICAgZGVmIGZldGNo X2NvbW1pdF9xdWV1ZV9wYXRjaGVzKHNlbGYpOgogICAgICAgICBwYXRjaF9pZHNfY29tbWl0X3F1 ZXVlID0gQnVnemlsbGEuZ2V0X2xpc3Rfb2ZfcGF0Y2hlc19mb3JfY29tbWl0X3F1ZXVlKCkKQEAg LTg0LDEwICs4NSwxNCBAQCBjbGFzcyBCdWd6aWxsYVBhdGNoRmV0Y2hlcigpOgogICAgICAgICAg ICAgYnpfcGF0Y2ggPSBCdWd6aWxsYS5yZXRyaWV2ZV9hdHRhY2htZW50KHBhdGNoX2lkKQogICAg ICAgICAgICAgaWYgbm90IGJ6X3BhdGNoIG9yIGJ6X3BhdGNoWydpZCddICE9IHBhdGNoX2lkOgog ICAgICAgICAgICAgICAgIF9sb2cuZXJyb3IoJ1VuYWJsZSB0byByZXRyaXZlIHBhdGNoICJ7fSIn LmZvcm1hdChwYXRjaF9pZCkpCisgICAgICAgICAgICAgICAgaWYgbGVuKHBhdGNoZXNfdG9fc2Vu ZCkgPT0gMToKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEVSUl9VTkFCTEVfVE9fRkVUQ0hf UEFUQ0gKICAgICAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAgaWYgYnpfcGF0Y2gu Z2V0KCdpc19vYnNvbGV0ZScpOgogICAgICAgICAgICAgICAgIF9sb2cud2FybignUGF0Y2ggaXMg b2Jzb2xldGUsIHNraXBwaW5nJykKICAgICAgICAgICAgICAgICBQYXRjaC5zZXRfb2Jzb2xldGUo cGF0Y2hfaWQpCisgICAgICAgICAgICAgICAgaWYgbGVuKHBhdGNoZXNfdG9fc2VuZCkgPT0gMToK KyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEVSUl9PQlNPTEVURV9QQVRDSAogICAgICAgICAg ICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICBpZiBub3Qgc2VuZF90b19jb21taXRfcXVldWUg YW5kIFBhdGNoLmlzX3BhdGNoX3NlbnRfdG9fYnVpbGRib3QocGF0Y2hfaWQpOgogICAgICAgICAg ICAgICAgIF9sb2cuZXJyb3IoJ1BhdGNoIHt9IGlzIGFscmVhZHkgc2VudCB0byBidWlsZGJvdC4n LmZvcm1hdChwYXRjaF9pZCkpCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy92aWV3cy9zdWJtaXR0b2V3cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdWJtaXR0b2V3cy5weQkocmV2aXNpb24gMjYwNDQw KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3VibWl0dG9l d3MucHkJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi0jIENvcHlyaWdodCAoQykgMjAx OSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAxOS0y MDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucwpAQCAtMzAsNiArMzAsNyBAQCBmcm9tIGRqYW5nby5zaG9ydGN1dHMgaW1wb3J0IHJl ZGlyZWN0LCByCiBmcm9tIGRqYW5nby52aWV3cyBpbXBvcnQgVmlldwogZnJvbSBkamFuZ28udmll d3MuZGVjb3JhdG9ycy5jbGlja2phY2tpbmcgaW1wb3J0IHhmcmFtZV9vcHRpb25zX2V4ZW1wdAog Citmcm9tIGV3cy5jb25maWcgaW1wb3J0IEVSUl9PQlNPTEVURV9QQVRDSCwgRVJSX1VOQUJMRV9U T19GRVRDSF9QQVRDSAogZnJvbSBld3MuZmV0Y2hlciBpbXBvcnQgQnVnemlsbGFQYXRjaEZldGNo ZXIKIGZyb20gZXdzLm1vZGVscy5wYXRjaCBpbXBvcnQgUGF0Y2gKIApAQCAtNTUsNyArNTYsMTEg QEAgY2xhc3MgU3VibWl0VG9FV1MoVmlldyk6CiAgICAgICAgICAgICAgICAgcmV0dXJuIHJlZGly ZWN0KCcvc3RhdHVzLWJ1YmJsZS97fScuZm9ybWF0KHBhdGNoX2lkKSkKICAgICAgICAgICAgIHJl dHVybiBIdHRwUmVzcG9uc2UoIlBhdGNoIHt9IGFscmVhZHkgc3VibWl0dGVkLiBQbGVhc2Ugd2Fp dCBmb3Igc3RhdHVzLWJ1YmJsZXMuIi5mb3JtYXQocGF0Y2hfaWQpKQogCi0gICAgICAgIEJ1Z3pp bGxhUGF0Y2hGZXRjaGVyKCkuZmV0Y2goW3BhdGNoX2lkXSkKKyAgICAgICAgcmMgPSBCdWd6aWxs YVBhdGNoRmV0Y2hlcigpLmZldGNoKFtwYXRjaF9pZF0pCisgICAgICAgIGlmIHJjID09IEVSUl9V TkFCTEVfVE9fRkVUQ0hfUEFUQ0g6CisgICAgICAgICAgICByZXR1cm4gSHR0cFJlc3BvbnNlKCdF V1MgaXMgdW5hYmxlIHRvIGFjY2VzcyBwYXRjaCB7fS4gUGxlYXNlIGVuc3VyZSB0aGF0IHRoaXMg cGF0Y2ggaXMgcHVibGljbHkgYWNjZXNzaWJsZSBvciBoYXMgcj8gc2V0LicuZm9ybWF0KHBhdGNo X2lkKSkKKyAgICAgICAgaWYgcmMgPT0gRVJSX09CU09MRVRFX1BBVENIOgorICAgICAgICAgICAg cmV0dXJuIEh0dHBSZXNwb25zZSgnUGF0Y2gge30gaXMgb2Jzb2xldGUsIG5vdCBzdWJtaXR0aW5n IHRvIEVXUy4nLmZvcm1hdChwYXRjaF9pZCkpCiAKICAgICAgICAgaWYgcmVxdWVzdC5QT1NULmdl dCgnbmV4dF9hY3Rpb24nKSA9PSAncmV0dXJuX3RvX2J1YmJsZXMnOgogICAgICAgICAgICAgcmV0 dXJuIHJlZGlyZWN0KCcvc3RhdHVzLWJ1YmJsZS97fScuZm9ybWF0KHBhdGNoX2lkKSkK