210787 2020-04-21 02:33:17 -0700 TextureMapper should skip clipping a content layer if it's not needed 2020-05-08 16:11:23 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210544 P2 Normal --- 1 tomoki.imai webkit-unassigned bugs-noreply cmarcelo don.olmstead eric.carlson ews-watchlist glenn jer.noble kondapallykalyan luiz noam philipj sergio zan oldest_to_newest 1643812 0 tomoki.imai 2020-04-21 02:33:17 -0700 Our internal review found that there is a chance to optimize bug 210544 patch. We don't need to clip a content layer if the clipping rect contains the content rect. This patch doesn't change the behavior but saves stencil indices. 1643813 1 397064 tomoki.imai 2020-04-21 02:42:29 -0700 Created attachment 397064 patch 1650549 2 398851 tomoki.imai 2020-05-08 03:15:55 -0700 Created attachment 398851 patch Also update the test expectation. https://bugs.webkit.org/show_bug.cgi?id=210544#c5 Although it's not enabled because of bug 163528 and bug 177536 1650820 3 ews-feeder 2020-05-08 16:11:21 -0700 Committed r261422: <https://trac.webkit.org/changeset/261422> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398851. 397064 2020-04-21 02:42:29 -0700 2020-05-08 03:15:55 -0700 patch optimize-clipping-1.patch text/plain 2344 tomoki.imai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMjZhNmQwODk3MDMuLmVhZGFhYjRkNDM0OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDIwLTA0LTIwICBUb21va2kgSW1haSAgPFRvbW9raS5JbWFpQHNvbnku Y29tPgorCisgICAgICAgIFRleHR1cmVNYXBwZXIgc2hvdWxkIHNraXAgY2xpcHBpbmcgYSBjb250 ZW50IGxheWVyIGlmIGl0J3Mgbm90IG5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmb2xsb3dzIHVwIHIyNjAxNzQuCisgICAg ICAgIFdlIGRvbid0IG5lZWQgdG8gY2xpcCBhIGNvbnRlbnQgbGF5ZXIgaWYgdGhlIGNsaXBwaW5n IHJlY3QgY29udGFpbnMgdGhlIGNvbnRlbnQgcmVjdC4KKyAgICAgICAgVGhpcyBwYXRjaCBkb2Vz bid0IGNoYW5nZSB0aGUgYmVoYXZpb3IgYnV0IHNhdmVzIHN0ZW5jaWwgaW5kaWNlcy4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckxheWVyOjpwYWludFNlbGYpOgorCiAyMDIw LTA0LTE5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11b VEZDXSBBZGQgY29sdW1uIHNwYW5uaW5nIHN1cHBvcnQgZm9yIGZsZXhpYmxlIHRhYmxlIHdpZHRo CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IDcxOWM2NzkyMzFhYS4uYWEyNTJhODA0 MTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv VGV4dHVyZU1hcHBlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcApAQCAtMTkwLDEwICsxOTAsMTYgQEAg dm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50U2VsZihjb25zdCBUZXh0dXJlTWFwcGVyUGFp bnRPcHRpb25zJiBvcHRpb25zKQogCiAgICAgQVNTRVJUKCFsYXllclJlY3QoKS5pc0VtcHR5KCkp OwogCi0gICAgLy8gRklYTUU6IFRleHR1cmVNYXBwZXI6OmJlZ2luQ2xpcCBkb2Vzbid0IHN1cHBv cnQgRmxvYXRSb3VuZGVkUmVjdCwgc28gd2UgbmVlZCB0byBjb252ZXJ0IG1fc3RhdGUuY29udGVu dHNDbGlwcGluZ1JlY3QgdG8gRmxvYXRSZWN0LgotICAgIG9wdGlvbnMudGV4dHVyZU1hcHBlci5i ZWdpbkNsaXAodHJhbnNmb3JtLCBtX3N0YXRlLmNvbnRlbnRzQ2xpcHBpbmdSZWN0LnJlY3QoKSk7 CisgICAgYm9vbCBzaG91bGRDbGlwID0gbV9zdGF0ZS5jb250ZW50c0NsaXBwaW5nUmVjdC5pc1Jv dW5kZWQoKSB8fCAhbV9zdGF0ZS5jb250ZW50c0NsaXBwaW5nUmVjdC5yZWN0KCkuY29udGFpbnMo bV9zdGF0ZS5jb250ZW50c1JlY3QpOworICAgIGlmIChzaG91bGRDbGlwKSB7CisgICAgICAgIC8v IEZJWE1FOiBUZXh0dXJlTWFwcGVyOjpiZWdpbkNsaXAgZG9lc24ndCBzdXBwb3J0IEZsb2F0Um91 bmRlZFJlY3QsIHNvIHdlIG5lZWQgdG8gY29udmVydCBtX3N0YXRlLmNvbnRlbnRzQ2xpcHBpbmdS ZWN0IHRvIEZsb2F0UmVjdC4KKyAgICAgICAgb3B0aW9ucy50ZXh0dXJlTWFwcGVyLmJlZ2luQ2xp cCh0cmFuc2Zvcm0sIG1fc3RhdGUuY29udGVudHNDbGlwcGluZ1JlY3QucmVjdCgpKTsKKyAgICB9 CisKICAgICBtX2NvbnRlbnRzTGF5ZXItPnBhaW50VG9UZXh0dXJlTWFwcGVyKG9wdGlvbnMudGV4 dHVyZU1hcHBlciwgbV9zdGF0ZS5jb250ZW50c1JlY3QsIHRyYW5zZm9ybSwgb3B0aW9ucy5vcGFj aXR5KTsKLSAgICBvcHRpb25zLnRleHR1cmVNYXBwZXIuZW5kQ2xpcCgpOworCisgICAgaWYgKHNo b3VsZENsaXApCisgICAgICAgIG9wdGlvbnMudGV4dHVyZU1hcHBlci5lbmRDbGlwKCk7CiAKICAg ICBpZiAobV9zdGF0ZS5zaG93RGVidWdCb3JkZXJzKQogICAgICAgICBtX2NvbnRlbnRzTGF5ZXIt PmRyYXdCb3JkZXIob3B0aW9ucy50ZXh0dXJlTWFwcGVyLCBtX3N0YXRlLmRlYnVnQm9yZGVyQ29s b3IsIG1fc3RhdGUuZGVidWdCb3JkZXJXaWR0aCwgbV9zdGF0ZS5jb250ZW50c1JlY3QsIHRyYW5z Zm9ybSk7Cg== 398851 2020-05-08 03:15:55 -0700 2020-05-08 16:11:22 -0700 patch skip-clipping-2.patch text/plain 4527 tomoki.imai ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MmMzNGUwMGNiZjIuLjZmZTk1YjcwNTFmMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA0LTIwICBUb21va2kgSW1haSAgPFRvbW9raS5JbWFpQHNvbnkuY29tPgorCisgICAg ICAgIFRleHR1cmVNYXBwZXIgc2hvdWxkIHNraXAgY2xpcHBpbmcgYSBjb250ZW50IGxheWVyIGlm IGl0J3Mgbm90IG5lZWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjEwNzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBwYXRjaCBmb2xsb3dzIHVwIHIyNjAxNzQgYnkgdXBkYXRpbmcgdGhlIHRl c3QgZXhwZWN0YXRpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvY29tcG9zaXRpbmcvdmlk ZW8vdmlkZW8tb2JqZWN0LWZpdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDIwLTA0LTE5ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bVEZDXSBBZGQg Y29sdW1uIHNwYW5uaW5nIHN1cHBvcnQgZm9yIGZsZXhpYmxlIHRhYmxlIHdpZHRoCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8tb2Jq ZWN0LWZpdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvY29tcG9zaXRp bmcvdmlkZW8vdmlkZW8tb2JqZWN0LWZpdC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwLi42NmFjNWFjNmY0NjIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8tb2JqZWN0LWZp dC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1MCBAQAorICAgICAgICAKKyhHcmFwaGljc0xheWVy CisgIChhbmNob3IgMC4wMCAwLjAwKQorICAoYm91bmRzIDc4NS4wMCA3NzUuMDApCisgIChjaGls ZHJlbiAxCisgICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgIChib3VuZHMgNzg1LjAwIDc3NS4wMCkK KyAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAgICAgKGNoaWxkcmVuIDYKKyAgICAgICAgKEdy YXBoaWNzTGF5ZXIKKyAgICAgICAgICAocG9zaXRpb24gMTMuMDAgMTMuMDApCisgICAgICAgICAg KGJvdW5kcyAxMjQuMDAgMjA0LjAwKQorICAgICAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAg ICAgICAgIChkcmF3c0NvbnRlbnQgMSkKKyAgICAgICAgKQorICAgICAgICAoR3JhcGhpY3NMYXll cgorICAgICAgICAgIChwb3NpdGlvbiAxNTEuMDAgMTMuMDApCisgICAgICAgICAgKGJvdW5kcyAx MjQuMDAgMjA0LjAwKQorICAgICAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAgICAgICAgIChk cmF3c0NvbnRlbnQgMSkKKyAgICAgICAgKQorICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAg ICAgIChwb3NpdGlvbiAyODkuMDAgMTMuMDApCisgICAgICAgICAgKGJvdW5kcyAxMjQuMDAgMjA0 LjAwKQorICAgICAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAgICAgICAgIChkcmF3c0NvbnRl bnQgMSkKKyAgICAgICAgKQorICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgIChwb3Np dGlvbiAxMy4wMCAyMzEuMDApCisgICAgICAgICAgKGJvdW5kcyAzNTQuMDAgMzA0LjAwKQorICAg ICAgICAgIChjb250ZW50c09wYXF1ZSAxKQorICAgICAgICAgIChkcmF3c0NvbnRlbnQgMSkKKyAg ICAgICAgKQorICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiAxMy4w MCA1NjkuMDApCisgICAgICAgICAgKGJvdW5kcyA0MDQuMDAgMTg0LjAwKQorICAgICAgICAgIChj b250ZW50c09wYXF1ZSAxKQorICAgICAgICAgIChkcmF3c0NvbnRlbnQgMSkKKyAgICAgICAgKQor ICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiA0MzEuMDAgNTQ5LjAw KQorICAgICAgICAgIChib3VuZHMgMTI0LjAwIDIwNC4wMCkKKyAgICAgICAgICAoY29udGVudHNP cGFxdWUgMSkKKyAgICAgICAgICAoZHJhd3NDb250ZW50IDEpCisgICAgICAgICkKKyAgICAgICkK KyAgICApCisgICkKKykKKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQyNmE2ZDA4OTcwMy4uZjAyNmYzNDhlOTIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDQtMjAgIFRvbW9raSBJbWFpICA8 VG9tb2tpLkltYWlAc29ueS5jb20+CisKKyAgICAgICAgVGV4dHVyZU1hcHBlciBzaG91bGQgc2tp cCBjbGlwcGluZyBhIGNvbnRlbnQgbGF5ZXIgaWYgaXQncyBub3QgbmVlZGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA3ODcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGZvbGxvd3Mg dXAgcjI2MDE3NC4KKyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBjbGlwIGEgY29udGVudCBsYXll ciBpZiB0aGUgY2xpcHBpbmcgcmVjdCBjb250YWlucyB0aGUgY29udGVudCByZWN0LgorICAgICAg ICBUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIHRoZSBiZWhhdmlvciBidXQgc2F2ZXMgc3RlbmNp bCBpbmRpY2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnBh aW50U2VsZik6CisKIDIwMjAtMDQtMTkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4K IAogICAgICAgICBbTEZDXVtURkNdIEFkZCBjb2x1bW4gc3Bhbm5pbmcgc3VwcG9ydCBmb3IgZmxl eGlibGUgdGFibGUgd2lkdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKaW5kZXggNzE5YzY3 OTIzMWFhLi5hYTI1MmE4MDQxNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkBAIC0x OTAsMTAgKzE5MCwxNiBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmKGNvbnN0 IFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9wdGlvbnMpCiAKICAgICBBU1NFUlQoIWxheWVy UmVjdCgpLmlzRW1wdHkoKSk7CiAKLSAgICAvLyBGSVhNRTogVGV4dHVyZU1hcHBlcjo6YmVnaW5D bGlwIGRvZXNuJ3Qgc3VwcG9ydCBGbG9hdFJvdW5kZWRSZWN0LCBzbyB3ZSBuZWVkIHRvIGNvbnZl cnQgbV9zdGF0ZS5jb250ZW50c0NsaXBwaW5nUmVjdCB0byBGbG9hdFJlY3QuCi0gICAgb3B0aW9u cy50ZXh0dXJlTWFwcGVyLmJlZ2luQ2xpcCh0cmFuc2Zvcm0sIG1fc3RhdGUuY29udGVudHNDbGlw cGluZ1JlY3QucmVjdCgpKTsKKyAgICBib29sIHNob3VsZENsaXAgPSBtX3N0YXRlLmNvbnRlbnRz Q2xpcHBpbmdSZWN0LmlzUm91bmRlZCgpIHx8ICFtX3N0YXRlLmNvbnRlbnRzQ2xpcHBpbmdSZWN0 LnJlY3QoKS5jb250YWlucyhtX3N0YXRlLmNvbnRlbnRzUmVjdCk7CisgICAgaWYgKHNob3VsZENs aXApIHsKKyAgICAgICAgLy8gRklYTUU6IFRleHR1cmVNYXBwZXI6OmJlZ2luQ2xpcCBkb2Vzbid0 IHN1cHBvcnQgRmxvYXRSb3VuZGVkUmVjdCwgc28gd2UgbmVlZCB0byBjb252ZXJ0IG1fc3RhdGUu Y29udGVudHNDbGlwcGluZ1JlY3QgdG8gRmxvYXRSZWN0LgorICAgICAgICBvcHRpb25zLnRleHR1 cmVNYXBwZXIuYmVnaW5DbGlwKHRyYW5zZm9ybSwgbV9zdGF0ZS5jb250ZW50c0NsaXBwaW5nUmVj dC5yZWN0KCkpOworICAgIH0KKwogICAgIG1fY29udGVudHNMYXllci0+cGFpbnRUb1RleHR1cmVN YXBwZXIob3B0aW9ucy50ZXh0dXJlTWFwcGVyLCBtX3N0YXRlLmNvbnRlbnRzUmVjdCwgdHJhbnNm b3JtLCBvcHRpb25zLm9wYWNpdHkpOwotICAgIG9wdGlvbnMudGV4dHVyZU1hcHBlci5lbmRDbGlw KCk7CisKKyAgICBpZiAoc2hvdWxkQ2xpcCkKKyAgICAgICAgb3B0aW9ucy50ZXh0dXJlTWFwcGVy LmVuZENsaXAoKTsKIAogICAgIGlmIChtX3N0YXRlLnNob3dEZWJ1Z0JvcmRlcnMpCiAgICAgICAg IG1fY29udGVudHNMYXllci0+ZHJhd0JvcmRlcihvcHRpb25zLnRleHR1cmVNYXBwZXIsIG1fc3Rh dGUuZGVidWdCb3JkZXJDb2xvciwgbV9zdGF0ZS5kZWJ1Z0JvcmRlcldpZHRoLCBtX3N0YXRlLmNv bnRlbnRzUmVjdCwgdHJhbnNmb3JtKTsK