210760 2020-04-20 12:21:33 -0700 The rect for the primary screen should be retrieved on the main thread. 2020-04-23 08:40:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1643578 0 andresg_22 2020-04-20 12:21:33 -0700 The rect for the primary screen should be retrieved on the main thread. 1643581 1 397001 andresg_22 2020-04-20 12:26:12 -0700 Created attachment 397001 Patch 1643608 2 ews-feeder 2020-04-20 13:11:15 -0700 Committed r260392: <https://trac.webkit.org/changeset/260392> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397001. 1643609 3 webkit-bug-importer 2020-04-20 13:12:15 -0700 <rdar://problem/62072352> 1643648 4 397001 darin 2020-04-20 14:49:18 -0700 Comment on attachment 397001 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397001&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1952 > + static FloatRect screenRect; > + if (screenRect.isEmpty()) { > + screenRect = Accessibility::retrieveValueFromMainThread<FloatRect>([] () -> FloatRect { > + return screenRectForPrimaryScreen(); > + }); > + } You don’t need to add the if statement: static FloatRect screenRect = Accessibility::retrieveValueFromMainThread<FloatRect>([] () -> FloatRect { return screenRectForPrimaryScreen(); }); 1644779 5 andresg_22 2020-04-23 08:40:07 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 397001 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397001&action=review > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1952 > > + static FloatRect screenRect; > > + if (screenRect.isEmpty()) { > > + screenRect = Accessibility::retrieveValueFromMainThread<FloatRect>([] () -> FloatRect { > > + return screenRectForPrimaryScreen(); > > + }); > > + } > > You don’t need to add the if statement: > > static FloatRect screenRect = > Accessibility::retrieveValueFromMainThread<FloatRect>([] () -> FloatRect { > return screenRectForPrimaryScreen(); > }); Fixed in https://bugs.webkit.org/show_bug.cgi?id=210914. Thanks! 397001 2020-04-20 12:26:12 -0700 2020-04-20 13:11:15 -0700 Patch bug-210760-20200420152611.patch text/plain 2007 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZmZGNhMDAzNzdmMjRl MTg4YWU1N2ZiNWU0ZjU0NzA2Zjk3ZGM4Yi4uMTU0Yjg0YjU4ZGU5MGI5ODg1OTc5YTczZDRjMzMx NDFlOGI1NDllMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTIwICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBUaGUgcmVjdCBm b3IgdGhlIHByaW1hcnkgc2NyZWVuIHNob3VsZCBiZSByZXRyaWV2ZWQgb24gdGhlIG1haW4gdGhy ZWFkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEw NzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBD YWxsIHRvIHNjcmVlblJlY3RGb3JQcmltYXJ5U2NyZWVuIGlzIGRpc3BhdGNoZWQgdG8gbWFpbiB0 aHJlYWQuCisgICAgICAgIC0gVGhpcyB2YWx1ZSBpcyBjYWNoZWQgc2luY2UgaXQgaXMgdmVyeSB1 bmxpa2VseSB0byBjaGFuZ2UgaW4gbm9ybWFsCisgICAgICAgIHVzYWdlIGFuZCB0aGlzIHdvdWxk IGF2b2lkIGhpdHRpbmcgdGhlIG1haW4gdGhyZWFkIHJlcGVhdGVkbHkuCisKKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbToKKyAg ICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgcHJpbWFyeVNjcmVlbkhlaWdo dF0pOgorCiAyMDIwLTA0LTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggR1N0cmVhbWVyIGJ1aWxkIHdhcm5pbmdzLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJp bGl0eU9iamVjdFdyYXBwZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21h Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQppbmRleCBkMWZlMjZjMTFkZGQ4 MmRhMmQ0YmM1ODcyYzBhNjFlNDFiZTBhODJjLi5lYWI1MjlhYjAxY2FiNTE4YmVkY2ZhZjljZjAx N2E1NmY4NjM0OTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21h Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQpA QCAtMTk0Miw3ICsxOTQyLDE0IEBAIHN0YXRpYyB2b2lkIFdlYlRyYW5zZm9ybUNHUGF0aFRvTlNC ZXppZXJQYXRoKHZvaWQqIGluZm8sIGNvbnN0IENHUGF0aEVsZW1lbnQgKmVsCiAKIC0gKE5TTnVt YmVyICopcHJpbWFyeVNjcmVlbkhlaWdodAogewotICAgIEZsb2F0UmVjdCBzY3JlZW5SZWN0ID0g c2NyZWVuUmVjdEZvclByaW1hcnlTY3JlZW4oKTsKKyAgICAvLyBUaGUgcmVjdCBmb3IgcHJpbWFy eSBzY3JlZW4gc2hvdWxkIG5vdCBjaGFuZ2UgaW4gbm9ybWFsIHVzZS4gU28gY2FjaGUgaXQKKyAg ICAvLyBoZXJlIHRvIGF2b2lkIGhpdHRpbmcgdGhlIG1haW4gdGhyZWFkIHJlcGVhdGVkbHkuCisg ICAgc3RhdGljIEZsb2F0UmVjdCBzY3JlZW5SZWN0OworICAgIGlmIChzY3JlZW5SZWN0LmlzRW1w dHkoKSkgeworICAgICAgICBzY3JlZW5SZWN0ID0gQWNjZXNzaWJpbGl0eTo6cmV0cmlldmVWYWx1 ZUZyb21NYWluVGhyZWFkPEZsb2F0UmVjdD4oW10gKCkgLT4gRmxvYXRSZWN0IHsKKyAgICAgICAg ICAgIHJldHVybiBzY3JlZW5SZWN0Rm9yUHJpbWFyeVNjcmVlbigpOworICAgICAgICB9KTsKKyAg ICB9CiAgICAgcmV0dXJuIFtOU051bWJlciBudW1iZXJXaXRoRmxvYXQ6c2NyZWVuUmVjdC5oZWln aHQoKV07CiB9CiAK