210759 2020-04-20 12:15:02 -0700 When SpeculativeLoadManager is destroyed, properly clean up its PendingFrameLoads 2020-05-08 13:05:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210768 InRadar P2 Normal --- 1 achristensen achristensen cdumez cgarcia darin ews-watchlist jacob_uphoff webkit-bug-importer oldest_to_newest 1643572 0 achristensen 2020-04-20 12:15:02 -0700 When SpeculativeLoadManager is destroyed, properly clean up its PendingFrameLoads 1643573 1 396999 achristensen 2020-04-20 12:21:06 -0700 Created attachment 396999 Patch 1643574 2 achristensen 2020-04-20 12:21:09 -0700 <rdar://problem/62056856> 1643583 3 396999 darin 2020-04-20 12:28:33 -0700 Comment on attachment 396999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396999&action=review > Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:274 > + Vector<RefPtr<PendingFrameLoad>> pendingFrameLoads; > + pendingFrameLoads.reserveInitialCapacity(m_pendingFrameLoads.size()); > + for (auto& pendingFrameLoad : m_pendingFrameLoads.values()) > + pendingFrameLoads.uncheckedAppend(pendingFrameLoad); > + for (auto& pendingFrameLoad : pendingFrameLoads) { You should be able to write this instead and get exactly the same effect: for (auto& pendingFrameLoad : copyToVector(m_pendingFrameLoads.values())) 1643584 4 397002 achristensen 2020-04-20 12:30:11 -0700 Created attachment 397002 Patch 1643586 5 397002 achristensen 2020-04-20 12:35:08 -0700 Comment on attachment 397002 Patch Aha! That's the idiom I was looking for. 1643605 6 ews-feeder 2020-04-20 13:04:54 -0700 Committed r260390: <https://trac.webkit.org/changeset/260390> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397002. 1643611 7 achristensen 2020-04-20 13:16:34 -0700 *** Bug 210744 has been marked as a duplicate of this bug. *** 1650727 8 achristensen 2020-05-08 13:05:43 -0700 Reverted in http://trac.webkit.org/r261405 396999 2020-04-20 12:21:06 -0700 2020-04-20 12:30:09 -0700 Patch bug-210759-20200420122105.patch text/plain 2997 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjAzODQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA0LTIwICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV2hlbiBTcGVjdWxh dGl2ZUxvYWRNYW5hZ2VyIGlzIGRlc3Ryb3llZCwgcHJvcGVybHkgY2xlYW4gdXAgaXRzIFBlbmRp bmdGcmFtZUxvYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTA3NTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYyMDU2ODU2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlY2VudCB3b3JrIG9uIHRo ZSByZXNvdXJjZUxvYWRTdGF0aXN0aWNzIGxheW91dCB0ZXN0cyBpbmNyZWFzZWQgdGhlIGFtb3Vu dCB3ZSBzd2FwIG91dCB0aGUgV2Vic2l0ZURhdGFTdG9yZS4KKyAgICAgICAgV2hlbiB0aGlzIGhh cHBlbnMsIHRoZSBOZXR3b3JrU2Vzc2lvbiBpcyBldmVudHVhbGx5IGRlc3Ryb3llZCBpbiB0aGUg TmV0d29ya1Byb2Nlc3MsIHNvbWV0aW1lcyB3aGVuIHJ1bm5pbmcgdGhlIG5leHQgdGVzdC4KKyAg ICAgICAgQW4gYXNzZXJ0aW9uIHdhcyBmaXJpbmcgaW4gdGhlIFBlbmRpbmdGcmFtZUxvYWQgZGVz dHJ1Y3RvciBiZWNhdXNlIGl0IGhhZG4ndCBiZWVuIG1hcmtlZCBhcyBjb21wbGV0ZSB3aGVuIGl0 IHdhcyBkZXN0cm95ZWQuCisgICAgICAgIFJhdGhlciB0aGFuIHJlbW92ZSB0aGUgYXNzZXJ0aW9u LCB3aGVuIHdlIGRlc3Ryb3kgdGhlIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXIgKHdoaWNoIG9ubHkg aGFwcGVucyB3aGVuIGEgV2Vic2l0ZURhdGFTdG9yZQorICAgICAgICBpcyBkZXN0cm95ZWQpIGR1 cmluZyBhIHNwZWN1bGF0aXZlIHBlbmRpbmcgZnJhbWUgbG9hZCwganVzdCBtYXJrIHRoZSBwZW5k aW5nIGZyYW1lIGxvYWQgYXMgY29tcGxldGUgYmVjYXVzZSBpdCBpcyBiZWluZyBjYW5jZWxsZWQu CisgICAgICAgIE1hcmtpbmcgdGhlIHBlbmRpbmcgZnJhbWUgbG9hZCBhcyBjb21wbGV0ZSBjYW4g dGVsbCB0aGUgU3BlY3VsYXRpdmVMb2FkTWFuYWdlciB0byBtdXRhdGUgbV9wZW5kaW5nRnJhbWVM b2Fkcywgd2hpY2ggd2UgZG9uJ3Qgd2FudAorICAgICAgICB0byBkbyB3aGlsZSBpdGVyYXRpbmcs IHNvIGNvcHkgdGhlIFJlZlB0cnMgaW50byBhIFZlY3RvciBmaXJzdCB0aGVuIGl0ZXJhdGUgdGhh dCB0byBnZXQgdGhlbSBhbGwuCisKKyAgICAgICAgVGhpcyBmaXhlcyBhbiBhc3NlcnRpb24gdGhh dCB3YXMgc29tZXRpbWVzIGhpdCBpbiBodHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3Mv c3RyaXAtcmVmZXJyZXItdG8tb3JpZ2luLWZvci1wcmV2YWxlbnQtc3VicmVzb3VyY2UtcmVkaXJl Y3RzLWRhdGFiYXNlLmh0bWwKKyAgICAgICAgYnV0IG9ubHkgYWZ0ZXIgcnVubmluZyBvdGhlciB0 ZXN0cyB0aGF0IGhhZCBpbml0aWF0ZWQgc3BlY3VsYXRpdmUgcGVuZGluZyBmcmFtZSBsb2Fkcy4g IFRoaXMgd2FzIG9zdGVuc2libHkgc3RhcnRlZCBieSByMjYwMzIyIGJ1dCBpcyBxdWl0ZSB1bnJl bGF0ZWQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVj dWxhdGl2ZUxvYWRNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpT cGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjp+U3BlY3VsYXRpdmVMb2FkTWFuYWdlcik6CisKIDIwMjAt MDQtMjAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTZW5kaW5n IGJlYWNvbnMgd2hlbiBGZXRjaCBLZWVwQWxpdmUgZmVhdHVyZSBpcyBkaXNhYmxlZCBjcmFzaGVz IHRoZSBXZWJQcm9jZXNzCkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVM b2FkTWFuYWdlci5jcHAJKHJldmlzaW9uIDI2MDM2NykKKysrIFNvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI2Nyw2ICsyNjcsMTQgQEAgU3BlY3VsYXRpdmVMb2FkTWFuYWdlcjo6 U3BlY3VsYXRpdmVMb2FkTQogCiBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjp+U3BlY3VsYXRpdmVM b2FkTWFuYWdlcigpCiB7CisgICAgVmVjdG9yPFJlZlB0cjxQZW5kaW5nRnJhbWVMb2FkPj4gcGVu ZGluZ0ZyYW1lTG9hZHM7CisgICAgcGVuZGluZ0ZyYW1lTG9hZHMucmVzZXJ2ZUluaXRpYWxDYXBh Y2l0eShtX3BlbmRpbmdGcmFtZUxvYWRzLnNpemUoKSk7CisgICAgZm9yIChhdXRvJiBwZW5kaW5n RnJhbWVMb2FkIDogbV9wZW5kaW5nRnJhbWVMb2Fkcy52YWx1ZXMoKSkKKyAgICAgICAgcGVuZGlu Z0ZyYW1lTG9hZHMudW5jaGVja2VkQXBwZW5kKHBlbmRpbmdGcmFtZUxvYWQpOworICAgIGZvciAo YXV0byYgcGVuZGluZ0ZyYW1lTG9hZCA6IHBlbmRpbmdGcmFtZUxvYWRzKSB7CisgICAgICAgIGlm IChwZW5kaW5nRnJhbWVMb2FkKQorICAgICAgICAgICAgcGVuZGluZ0ZyYW1lTG9hZC0+bWFya0xv YWRBc0NvbXBsZXRlZCgpOworICAgIH0KIH0KIAogYm9vbCBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2Vy OjpjYW5Vc2VQcmVsb2FkZWRFbnRyeShjb25zdCBQcmVsb2FkZWRFbnRyeSYgZW50cnksIGNvbnN0 IFJlc291cmNlUmVxdWVzdCYgYWN0dWFsUmVxdWVzdCkK 397002 2020-04-20 12:30:11 -0700 2020-04-20 13:04:54 -0700 Patch bug-210759-20200420123010.patch text/plain 2760 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjAzODQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA0LTIwICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV2hlbiBTcGVjdWxh dGl2ZUxvYWRNYW5hZ2VyIGlzIGRlc3Ryb3llZCwgcHJvcGVybHkgY2xlYW4gdXAgaXRzIFBlbmRp bmdGcmFtZUxvYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTA3NTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYyMDU2ODU2PgorCisgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIFJlY2VudCB3b3JrIG9uIHRoZSBy ZXNvdXJjZUxvYWRTdGF0aXN0aWNzIGxheW91dCB0ZXN0cyBpbmNyZWFzZWQgdGhlIGFtb3VudCB3 ZSBzd2FwIG91dCB0aGUgV2Vic2l0ZURhdGFTdG9yZS4KKyAgICAgICAgV2hlbiB0aGlzIGhhcHBl bnMsIHRoZSBOZXR3b3JrU2Vzc2lvbiBpcyBldmVudHVhbGx5IGRlc3Ryb3llZCBpbiB0aGUgTmV0 d29ya1Byb2Nlc3MsIHNvbWV0aW1lcyB3aGVuIHJ1bm5pbmcgdGhlIG5leHQgdGVzdC4KKyAgICAg ICAgQW4gYXNzZXJ0aW9uIHdhcyBmaXJpbmcgaW4gdGhlIFBlbmRpbmdGcmFtZUxvYWQgZGVzdHJ1 Y3RvciBiZWNhdXNlIGl0IGhhZG4ndCBiZWVuIG1hcmtlZCBhcyBjb21wbGV0ZSB3aGVuIGl0IHdh cyBkZXN0cm95ZWQuCisgICAgICAgIFJhdGhlciB0aGFuIHJlbW92ZSB0aGUgYXNzZXJ0aW9uLCB3 aGVuIHdlIGRlc3Ryb3kgdGhlIFNwZWN1bGF0aXZlTG9hZE1hbmFnZXIgKHdoaWNoIG9ubHkgaGFw cGVucyB3aGVuIGEgV2Vic2l0ZURhdGFTdG9yZQorICAgICAgICBpcyBkZXN0cm95ZWQpIGR1cmlu ZyBhIHNwZWN1bGF0aXZlIHBlbmRpbmcgZnJhbWUgbG9hZCwganVzdCBtYXJrIHRoZSBwZW5kaW5n IGZyYW1lIGxvYWQgYXMgY29tcGxldGUgYmVjYXVzZSBpdCBpcyBiZWluZyBjYW5jZWxsZWQuCisg ICAgICAgIE1hcmtpbmcgdGhlIHBlbmRpbmcgZnJhbWUgbG9hZCBhcyBjb21wbGV0ZSBjYW4gdGVs bCB0aGUgU3BlY3VsYXRpdmVMb2FkTWFuYWdlciB0byBtdXRhdGUgbV9wZW5kaW5nRnJhbWVMb2Fk cywgd2hpY2ggd2UgZG9uJ3Qgd2FudAorICAgICAgICB0byBkbyB3aGlsZSBpdGVyYXRpbmcsIHNv IGNvcHkgdGhlIFJlZlB0cnMgaW50byBhIFZlY3RvciBmaXJzdCB0aGVuIGl0ZXJhdGUgdGhhdCB0 byBnZXQgdGhlbSBhbGwuCisKKyAgICAgICAgVGhpcyBmaXhlcyBhbiBhc3NlcnRpb24gdGhhdCB3 YXMgc29tZXRpbWVzIGhpdCBpbiBodHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3Mvc3Ry aXAtcmVmZXJyZXItdG8tb3JpZ2luLWZvci1wcmV2YWxlbnQtc3VicmVzb3VyY2UtcmVkaXJlY3Rz LWRhdGFiYXNlLmh0bWwKKyAgICAgICAgYnV0IG9ubHkgYWZ0ZXIgcnVubmluZyBvdGhlciB0ZXN0 cyB0aGF0IGhhZCBpbml0aWF0ZWQgc3BlY3VsYXRpdmUgcGVuZGluZyBmcmFtZSBsb2Fkcy4gIFRo aXMgd2FzIG9zdGVuc2libHkgc3RhcnRlZCBieSByMjYwMzIyIGJ1dCBpcyBxdWl0ZSB1bnJlbGF0 ZWQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxh dGl2ZUxvYWRNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpTcGVj dWxhdGl2ZUxvYWRNYW5hZ2VyOjp+U3BlY3VsYXRpdmVMb2FkTWFuYWdlcik6CisKIDIwMjAtMDQt MjAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTZW5kaW5nIGJl YWNvbnMgd2hlbiBGZXRjaCBLZWVwQWxpdmUgZmVhdHVyZSBpcyBkaXNhYmxlZCBjcmFzaGVzIHRo ZSBXZWJQcm9jZXNzCkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05l dHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZE1hbmFnZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2Fk TWFuYWdlci5jcHAJKHJldmlzaW9uIDI2MDM2NykKKysrIFNvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkTWFuYWdlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI2Nyw2ICsyNjcsMTAgQEAgU3BlY3VsYXRpdmVMb2FkTWFuYWdlcjo6U3Bl Y3VsYXRpdmVMb2FkTQogCiBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjp+U3BlY3VsYXRpdmVMb2Fk TWFuYWdlcigpCiB7CisgICAgZm9yIChhdXRvJiBwZW5kaW5nRnJhbWVMb2FkIDogY29weVRvVmVj dG9yKG1fcGVuZGluZ0ZyYW1lTG9hZHMudmFsdWVzKCkpKSB7CisgICAgICAgIGlmIChwZW5kaW5n RnJhbWVMb2FkKQorICAgICAgICAgICAgcGVuZGluZ0ZyYW1lTG9hZC0+bWFya0xvYWRBc0NvbXBs ZXRlZCgpOworICAgIH0KIH0KIAogYm9vbCBTcGVjdWxhdGl2ZUxvYWRNYW5hZ2VyOjpjYW5Vc2VQ cmVsb2FkZWRFbnRyeShjb25zdCBQcmVsb2FkZWRFbnRyeSYgZW50cnksIGNvbnN0IFJlc291cmNl UmVxdWVzdCYgYWN0dWFsUmVxdWVzdCkK