210757 2020-04-20 11:56:38 -0700 Fix build when !ENABLE(RESOURCE_LOAD_STATISTICS) 2020-04-20 13:10:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned cgarcia don.olmstead ross.kirsling webkit-bug-importer zan oldest_to_newest 1643557 0 stephan.szabo 2020-04-20 11:56:38 -0700 r260356 appears to use functions of NetworkSession that appear to be declared in a ENABLE(RESOURCE_LOAD_STATISTICS) block with no guard. 1643558 1 396997 stephan.szabo 2020-04-20 12:00:02 -0700 Created attachment 396997 Patch 1643568 2 396997 ross.kirsling 2020-04-20 12:12:24 -0700 Comment on attachment 396997 Patch r=me, looks like this code was moved from a Cocoa-specific file that was making this assumption without issue. 1643606 3 ews-feeder 2020-04-20 13:09:51 -0700 Committed r260391: <https://trac.webkit.org/changeset/260391> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396997. 1643607 4 webkit-bug-importer 2020-04-20 13:10:15 -0700 <rdar://problem/62072250> 396997 2020-04-20 12:00:02 -0700 2020-04-20 13:09:51 -0700 Patch 210757.1.diff text/plain 1512 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYmZhMzllNTI4ZDUuLjlkMzhhMDhmNTViIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDIwLTA0LTIwICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNv bT4KKworICAgICAgICBGaXggYnVpbGQgd2hlbiAhRU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElT VElDUykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MDc1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1 aWxkIGZpeCwgbm8gbmV3IHRlc3RzCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr RGF0YVRhc2suY3BwOgorICAgICAgICBBZGQgRU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElTVElD UykgYXJvdW5kIGJsb2NrCisgICAgICAgIHVzaW5nIE5ldHdvcmtTZXNzaW9uIGZ1bmN0aW9ucyBv bmx5IGRlY2xhcmVkIHdoZW4KKyAgICAgICAgdGhhdCBpcyBlbmFibGVkLgorCiAyMDIwLTA0LTIw ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgI2ltcG9ydCBp bnN0ZWFkIG9mICNpbmNsdWRlIGluIE9iamVjdGl2ZS1DIGFuZCBkb24ndCB1c2UgI3ByYWdtYSBv bmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRh VGFzay5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFzay5j cHAKaW5kZXggZGJjZmNlNTc0OWEuLjNhYWYxNzU2ZGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFzay5jcHAKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suY3BwCkBAIC0xNzgsOCArMTc4LDEwIEBA IGJvb2wgTmV0d29ya0RhdGFUYXNrOjppc1RoaXJkUGFydHlSZXF1ZXN0KGNvbnN0IFdlYkNvcmU6 OlJlc291cmNlUmVxdWVzdCYgcmVxdWVzCiAKIHZvaWQgTmV0d29ya0RhdGFUYXNrOjpyZXN0cmlj dFJlcXVlc3RSZWZlcnJlclRvT3JpZ2luSWZOZWVkZWQoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0 JiByZXF1ZXN0KQogeworI2lmIEVOQUJMRShSRVNPVVJDRV9MT0FEX1NUQVRJU1RJQ1MpCiAgICAg aWYgKChtX3Nlc3Npb24tPnNlc3Npb25JRCgpLmlzRXBoZW1lcmFsKCkgfHwgbV9zZXNzaW9uLT5p c1Jlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKCkpICYmIG1fc2Vzc2lvbi0+c2hvdWxkRG93 bmdyYWRlUmVmZXJyZXIoKSAmJiBpc1RoaXJkUGFydHlSZXF1ZXN0KHJlcXVlc3QpKQogICAgICAg ICByZXF1ZXN0LnNldEV4aXN0aW5nSFRUUFJlZmVycmVyVG9PcmlnaW5TdHJpbmcoKTsKKyNlbmRp ZgogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK